[Wireshark-bugs] [Bug 13016] Buildbot crash output: fuzz-2016-10-14-17977.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13016

--- Comment #9 from Michael Mann  ---
*** Bug 13002 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13016] Buildbot crash output: fuzz-2016-10-14-17977.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13016

--- Comment #8 from Michael Mann  ---
*** Bug 13027 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13016] Buildbot crash output: fuzz-2016-10-14-17977.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13016

--- Comment #7 from Michael Mann  ---
*** Bug 13008 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13016] Buildbot crash output: fuzz-2016-10-14-17977.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13016

--- Comment #6 from Gerrit Code Review  ---
Change 18273 merged by Michael Mann:
Ensure http_tcp_range gets initialized through preference callback.

https://code.wireshark.org/review/18273

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13016] Buildbot crash output: fuzz-2016-10-14-17977.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13016

Gerrit Code Review  changed:

   What|Removed |Added

 Status|IN_PROGRESS |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13016] Buildbot crash output: fuzz-2016-10-14-17977.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13016

--- Comment #5 from Gerrit Code Review  ---
Change 18273 had a related patch set uploaded by Michael Mann:
Ensure http_tcp_range gets initialized through preference callback.

https://code.wireshark.org/review/18273

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13016] Buildbot crash output: fuzz-2016-10-14-17977.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13016

Michael Mann  changed:

   What|Removed |Added

 Status|CONFIRMED   |IN_PROGRESS

--- Comment #4 from Michael Mann  ---
Working on it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13016] Buildbot crash output: fuzz-2016-10-14-17977.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13016

Pascal Quantin  changed:

   What|Removed |Added

 CC||pascal.quan...@gmail.com

--- Comment #3 from Pascal Quantin  ---
Presumably this is the same kind of issue as the Kafka one I reported in
https://code.wireshark.org/review/17724.

But here (contrary to Kafka dissector) I do not even see code ensuring that
http_tcp_range is not NULL, and initialized when the prefs are loaded. So more
code seems to be missing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13016] Buildbot crash output: fuzz-2016-10-14-17977.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13016

Peter Wu  changed:

   What|Removed |Added

 CC||mman...@netscape.net

--- Comment #2 from Peter Wu  ---
Michael, can you have a look?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13016] Buildbot crash output: fuzz-2016-10-14-17977.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13016

Peter Wu  changed:

   What|Removed |Added

 CC||pe...@lekensteyn.nl

--- Comment #1 from Peter Wu  ---
bisected to:

268841f3e00b7cf0f16c81dd2b3b952172130b8b is the first bad commit
commit 268841f3e00b7cf0f16c81dd2b3b952172130b8b
Author: Michael Mann 
Date:   Fri Oct 7 16:25:01 2016 -0400

Combine Decode As and port preferences for tcp.port dissector table.

This patch introduces new APIs to allow dissectors to have a preference for
a (TCP) port, but the underlying data is actually part of Decode As
functionality.
For now the APIs are intentionally separate from the regular APIs that
register a
dissector within a dissector table.  It may be possible to eventually
combine the
two so that all dissectors that register with a dissector table have an
opportunity
to "automatically" have a preference to adjust the "table value" through
the
preferences dialog.

The tcp.port dissector table was used as the guinea pig.  This will
eventually be
expanded to other dissector tables as well (most notably UDP ports).  Some
dissectors that "shared" a TCP/UDP port preference were also converted. It
also
removed the need for some preference callback functions (mostly when the
callback
function was the proto_reg_handoff function) so there is cleanup around
that.

Dissectors that has a port preference whose default was 0 were switched to
using
the dissector_add_for_decode_as_with_preference API rather than
dissector_add_uint_with_preference

Also added comments for TCP ports used that aren't IANA registered.

Change-Id: I99604f95d426ad345f4b494598d94178b886eb67
Reviewed-on: https://code.wireshark.org/review/17724
Reviewed-by: Michael Mann 

The stack trace looks like:
...
#422 0x7faa9c26d7a9 in http_payload_subdissector (tvb=0x6070003258e0,
tree=0x604000140790, pinfo=0x6140e858, conv_data=0x60854c20,
data=0x7ffcc4dfff00) at epan/dissectors/packet-http.c:2179
#423 0x7faa9c272153 in dissect_http_tcp (tvb=0x6070003258e0,
pinfo=0x6140e858, tree=0x604000140790, data=0x7ffcc4dfff00) at
epan/dissectors/packet-http.c:3162
#424 0x7faa9d7123a7 in call_dissector_through_handle
(handle=0x60300020c860, tvb=0x6070003258e0, pinfo=0x6140e858,
tree=0x604000140790, data=0x7ffcc4dfff00) at epan/packet.c:650
#425 0x7faa9d712776 in call_dissector_work (handle=0x60300020c860,
tvb=0x6070003258e0, pinfo_arg=0x6140e858, tree=0x604000140790,
add_proto_name=1, data=0x7ffcc4dfff00) at epan/packet.c:725
#426 0x7faa9d714783 in dissector_try_uint_new
(sub_dissectors=0x60669e60, uint_val=80, tvb=0x6070003258e0,
pinfo=0x6140e858, tree=0x604000140790, add_proto_name=1,
data=0x7ffcc4dfff00) at epan/packet.c:1290
#427 0x7faa9caa6010 in decode_tcp_ports (tvb=0x607000325950, offset=0,
pinfo=0x6140e858, tree=0x604000140790, src_port=80, dst_port=1196,
tcpd=0x0, tcpinfo=0x7ffcc4dfff00) at epan/dissectors/packet-tcp.c:5191

#428 0x7faa9c26d7a9 in http_payload_subdissector (tvb=0x607000325950,
tree=0x604000140790, pinfo=0x6140e858, conv_data=0x60854c20,
data=0x7ffcc4dfff00) at epan/dissectors/packet-http.c:2179
#429 0x7faa9c272153 in dissect_http_tcp (tvb=0x607000325950,
pinfo=0x6140e858, tree=0x604000140790, data=0x7ffcc4dfff00) at
epan/dissectors/packet-http.c:3162
#430 0x7faa9d7123a7 in call_dissector_through_handle
(handle=0x60300020c860, tvb=0x607000325950, pinfo=0x6140e858,
tree=0x604000140790, data=0x7ffcc4dfff00) at epan/packet.c:650
#431 0x7faa9d712776 in call_dissector_work (handle=0x60300020c860,
tvb=0x607000325950, pinfo_arg=0x6140e858, tree=0x604000140790,
add_proto_name=1, data=0x7ffcc4dfff00) at epan/packet.c:725
#432 0x7faa9d714783 in dissector_try_uint_new
(sub_dissectors=0x60669e60, uint_val=80, tvb=0x607000325950,
pinfo=0x6140e858, tree=0x604000140790, add_proto_name=1,
data=0x7ffcc4dfff00) at epan/packet.c:1290
#433 0x7faa9caa6010 in decode_tcp_ports (tvb=0x607000325b10, offset=20,
pinfo=0x6140e858, tree=0x604000140790, src_port=80, dst_port=1196,
tcpd=0x61213540, tcpinfo=0x7ffcc4dfff00) at
epan/dissectors/packet-tcp.c:5191

#434 0x7faa9caa6918 in process_tcp_payload (tvb=0x607000325b10, offset=20,
pinfo=0x6140e858, tree=0x604000140790, tcp_tree=0x604000158810,
src_port=80, dst_port=1196, seq=0, nxtseq=0, is_tcp_segment=0,
tcpd=0x61213540, tcpinfo=0x7ffcc4dfff00) at
epan/dissectors/packet-tcp.c:5260
#435 0x7faa9ca9aa48 in desegment_tcp (tvb=0x607000325b10,
pinfo=0x6140e858, offset=20, seq=20, nxtseq=453, sport=80, dport=1196,
tree=0x604000140790, tcp_tree=0x604000158810, tcpd=0x61213540,
tcpinfo=0x7ffcc4dfff00) at