subject:"\[Wireshark\-bugs\] \[Bug 14406\] Wireshark doesn't report EAP packet as malformed packet when EAP LENGTH field has wrong length value"

[Wireshark-bugs] [Bug 14406] Wireshark doesn't report EAP packet as malformed packet when EAP LENGTH field has wrong length value

2019-08-15 Thread bugzilla-daemon

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14406

Peter Wu  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|IN_PROGRESS |RESOLVED

--- Comment #10 from Peter Wu  ---
Fixed in v3.1.1rc0-143-g05dc3bf2ce

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14406] Wireshark doesn't report EAP packet as malformed packet when EAP LENGTH field has wrong length value

2019-08-14 Thread bugzilla-daemon

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14406

--- Comment #9 from Gerrit Code Review  ---
Change 34292 merged by Anders Broman:
EAP: show expert info for bad EAP lengths

https://code.wireshark.org/review/34292

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14406] Wireshark doesn't report EAP packet as malformed packet when EAP LENGTH field has wrong length value

2019-08-14 Thread bugzilla-daemon

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14406

Peter Wu  changed:

   What|Removed |Added

 Status|CONFIRMED   |IN_PROGRESS
 CC||pe...@lekensteyn.nl

--- Comment #8 from Peter Wu  ---
Proposed a patch for expert info based on
https://tools.ietf.org/html/rfc3748#page-21

  The Length field is two octets and indicates the length, in
  octets, of the EAP packet including the Code, Identifier, Length,
  and Data fields.  Octets outside the range of the Length field
  should be treated as Data Link Layer padding and MUST be ignored
  upon reception.  A message with the Length field set to a value
  larger than the number of received octets MUST be silently
  discarded.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14406] Wireshark doesn't report EAP packet as malformed packet when EAP LENGTH field has wrong length value

2019-08-14 Thread bugzilla-daemon

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14406

--- Comment #7 from Gerrit Code Review  ---
Change 34292 had a related patch set uploaded by Peter Wu:
EAP: show expert info for bad EAP lengths

https://code.wireshark.org/review/34292

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14406] Wireshark doesn't report EAP packet as malformed packet when EAP LENGTH field has wrong length value

2018-02-20 Thread bugzilla-daemon

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14406

Jaap Keuter  changed:

   What|Removed |Added

   Severity|Normal  |Enhancement
 Status|INCOMPLETE  |CONFIRMED

--- Comment #6 from Jaap Keuter  ---
(In reply to Alexis La Goutte from comment #4)
> There is no often (never ?) a really check of length (only if it is need for
> decode payload)
> 
> and it is too complicated to add a check for each value for say it is
> correct or not...

It may be possible to add expert items for certain cases. 
Leaving open as possible enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14406] Wireshark doesn't report EAP packet as malformed packet when EAP LENGTH field has wrong length value

2018-02-15 Thread bugzilla-daemon

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14406

--- Comment #5 from Trotters  ---
(In reply to Alexis La Goutte from comment #4)
> There is no often (never ?) a really check of length (only if it is need for
> decode payload)
> 
> and it is too complicated to add a check for each value for say it is
> correct or not...

I totally agree on the first, and can understand the latter. I simply wanted to
report this, but if there won't be implemented any code for this, I won't make
a big deal about it. Wireshark is an excellent tool, and free, so I'll take
what I get none the less.

With this note, this bug / ticket may be closed. Is there anything I need to do
to close it?

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14406] Wireshark doesn't report EAP packet as malformed packet when EAP LENGTH field has wrong length value

2018-02-13 Thread bugzilla-daemon

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14406

--- Comment #4 from Alexis La Goutte  ---
There is no often (never ?) a really check of length (only if it is need for
decode payload)

and it is too complicated to add a check for each value for say it is correct
or not...

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14406] Wireshark doesn't report EAP packet as malformed packet when EAP LENGTH field has wrong length value

2018-02-13 Thread bugzilla-daemon

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14406

--- Comment #3 from Trotters  ---
(In reply to Trotters from comment #2)
> Created attachment 16131 [details]
> A correct EAP SUCCESS packet

For clarification:

AFAIK there are three mandatory fields (EAP CODE, EAP ID, EAP LENGTH), and one
optional (EAP DATA) in an EAP packet.

As a result, the shortest EAP LENGTH possible = 4 bytes.
(1 byte EAP CODE + 1 byte EAP ID + 2 bytes EAP LENGTH + 0 or more bytes EAP
DATA)

The contents of EAP DATA depends on the EAP CODE. For a code 3 (EAP SUCCESS)
there is no EAP DATA, so EAP LENGTH for EAP SUCCESS should always be 4 bytes.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14406] Wireshark doesn't report EAP packet as malformed packet when EAP LENGTH field has wrong length value

2018-02-13 Thread bugzilla-daemon

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14406

--- Comment #2 from Trotters  ---
Created attachment 16131
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=16131=edit
A correct EAP SUCCESS packet

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14406] Wireshark doesn't report EAP packet as malformed packet when EAP LENGTH field has wrong length value

2018-02-09 Thread bugzilla-daemon

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14406

Alexis La Goutte  changed:

   What|Removed |Added

 CC||alexis.lagou...@gmail.com
 Status|UNCONFIRMED |INCOMPLETE
 Ever confirmed|0   |1

--- Comment #1 from Alexis La Goutte  ---
Hi,

Wireshark only display what it is see (and on this case a EAP Length = 0 and
don't try to decode rest of data...

Do you have a correct packet for compare ?

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14406] Wireshark doesn't report EAP packet as malformed packet when EAP LENGTH field has wrong length value

[Wireshark-bugs] [Bug 14406] Wireshark doesn't report EAP packet as malformed packet when EAP LENGTH field has wrong length value

[Wireshark-bugs] [Bug 14406] Wireshark doesn't report EAP packet as malformed packet when EAP LENGTH field has wrong length value

[Wireshark-bugs] [Bug 14406] Wireshark doesn't report EAP packet as malformed packet when EAP LENGTH field has wrong length value

[Wireshark-bugs] [Bug 14406] Wireshark doesn't report EAP packet as malformed packet when EAP LENGTH field has wrong length value

[Wireshark-bugs] [Bug 14406] Wireshark doesn't report EAP packet as malformed packet when EAP LENGTH field has wrong length value

[Wireshark-bugs] [Bug 14406] Wireshark doesn't report EAP packet as malformed packet when EAP LENGTH field has wrong length value

[Wireshark-bugs] [Bug 14406] Wireshark doesn't report EAP packet as malformed packet when EAP LENGTH field has wrong length value

[Wireshark-bugs] [Bug 14406] Wireshark doesn't report EAP packet as malformed packet when EAP LENGTH field has wrong length value

[Wireshark-bugs] [Bug 14406] Wireshark doesn't report EAP packet as malformed packet when EAP LENGTH field has wrong length value

10 matches

Site Navigation

Mail list logo

Footer information