[Wireshark-bugs] [Bug 13363] "Do you want to save the captured packets...?" [Continue without saving]

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13363

--- Comment #12 from Alexander Petrossian (PAF)  ---
(In reply to Guy Harris from comment #7)
> (In reply to Alexander Petrossian (PAF) from comment #0)
> > * Spacebar -- accept non-default button, in [Continue without saving]
> No, that's
> * Spacebar -- accept the button that has the input focus (at least with
> TextEdit on Snow Leopard)

Yes, when the button was manually focused.
BUT
until then it used to be differently.
Now I can't reproduce it on High Sierra with Microsoft Word/TextEdit.

They've removed that tricky reaction to Spacebar.

OK then. Consistent behaviour is best.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13363] "Do you want to save the captured packets...?" [Continue without saving]

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13363

--- Comment #11 from Guy Harris  ---
In I214dd2870a9720ea705d8db39adc5b6af2003fb1 I made it disable auto-default for
*all* buttons on macOS.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13363] "Do you want to save the captured packets...?" [Continue without saving]

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13363

--- Comment #10 from Guy Harris  ---
(In reply to Guy Harris from comment #9)
> (In reply to Alexander Petrossian (PAF) from comment #1)
> > Created attachment 15210 [details]
> > example of "traditional" dialog, when non-default button is blue-framed and
> > can be pressed with Spacebar shortcut
> > 
> > In Windows in similar dialog windows keyboard shortcuts are traditionally
> > different:
> > * Escape = cancel
> > * Enter+Space = accept default button
> 
> That appears to be the KDE 5 and GNOME 3 behavior as well.
> 
> So what we want is to somehow arrange that:
> 
> we have notions of "the default button", "the button that initially gets
> the input focus", and "the button that has the input focus", with the
> default button being the button with the input focus on non-macOS systems
> and being assigned at dialog creation time on macOS and unaffected by input
> focus changes;
> 
> Enter activates the default button, with the above definitions;
> 
> Space activates the button with the input focus.
> 
> I'm not sure whether Qt actually supports that, at least in QMessageBox

So:

on macOS, we have *no* buttons with autoDefault set, set the desired
default button to have default set, and set the desired initial button to have
focus;

on other OSes, we make all the buttons autoDefault, set the desired default
button to have focus, and maybe not set default on any button.

See

http://doc.qt.io/qt-5/qpushbutton.html#default-prop

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13363] "Do you want to save the captured packets...?" [Continue without saving]

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13363

--- Comment #9 from Guy Harris  ---
(In reply to Alexander Petrossian (PAF) from comment #1)
> Created attachment 15210 [details]
> example of "traditional" dialog, when non-default button is blue-framed and
> can be pressed with Spacebar shortcut
> 
> In Windows in similar dialog windows keyboard shortcuts are traditionally
> different:
> * Escape = cancel
> * Enter+Space = accept default button

That appears to be the KDE 5 and GNOME 3 behavior as well.

So what we want is to somehow arrange that:

we have notions of "the default button", "the button that initially gets
the input focus", and "the button that has the input focus", with the default
button being the button with the input focus on non-macOS systems and being
assigned at dialog creation time on macOS and unaffected by input focus
changes;

Enter activates the default button, with the above definitions;

Space activates the button with the input focus.

I'm not sure whether Qt actually supports that, at least in QMessageBox

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13363] "Do you want to save the captured packets...?" [Continue without saving]

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13363

--- Comment #8 from Guy Harris  ---
(In reply to Alexander Petrossian (PAF) from comment #1)
> Created attachment 15210 [details]
> example of "traditional" dialog, when non-default button is blue-framed and
> can be pressed with Spacebar shortcut
> 
> In Windows in similar dialog windows keyboard shortcuts are traditionally
> different:
> * Escape = cancel
> * Enter+Space = accept default button

Microsoft's documentation:

   
https://msdn.microsoft.com/en-us/library/windows/desktop/dn742465(v=vs.85).aspx

is a bit complicated, as it says

Default buttons. Windows with command buttons and command links have a
single default button indicated by a highlighted border, which is the button
that is clicked when the Enter key is pressed. There is a single default
command button or command link assigned by default. However, the default button
moves when the user tabs to another command button or command link.
Consequently, any command button or command link with input focus is also
always the default button.

[OK]  [Cancel]

The OK button is normally the default button, as indicated by its
highlighted border. However, if the user were to tab to the Cancel button, it
would become the default button and would be activated with the Enter key.

Spacebar, Enter, and Esc keys. The spacebar activates the control with
input focus, whereas the Enter key activates the default button. Pressing the
Esc key cancels or closes the window.

So, presumably, space and Enter do the same thing if a button has the input
focus, but if some control *other* than a command button or command link has
the input focus, space activates *that* control, but Enter activates the
"default button", whatever that might be in this situation - the last button
that *did* have the input focus, perhaps?

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13363] "Do you want to save the captured packets...?" [Continue without saving]

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13363

--- Comment #7 from Guy Harris  ---
(In reply to Alexander Petrossian (PAF) from comment #0)
> In MacOS tradition of UI there are two keyboard shortcuts:
> * Escape -- cancel the action
> * Enter -- accept default button, in this case [Save] 
> * Spacebar -- accept non-default button, in [Continue without saving]

No, that's

* Spacebar -- accept the button that has the input focus (at least with
TextEdit on Snow Leopard)

If, for example, you try to quit TextEdit when you have unsaved edits (that's
why I did this on Snow Leopard, to avoid the Shiny New Document Model with no
unsaved edits - Wireshark doesn't implement the new model), the dialog that
pops up has "don't save" on the left, "cancel" in the middle, and "save" on the
right, with the *leftmost* button, "don't save" having the input focus, and the
*rightmost* button, "Save", being the default.  If you tab from "don't save" to
"cancel", and hit the spacebar, it cancels the dialog.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13363] "Do you want to save the captured packets...?" [Continue without saving]

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13363

--- Comment #6 from Gerrit Code Review  ---
Change 20485 merged by Stig Bjørlykke:
Qt: Give discard button focus (but not as default)

https://code.wireshark.org/review/20485

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13363] "Do you want to save the captured packets...?" [Continue without saving]

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13363

Gerrit Code Review  changed:

   What|Removed |Added

 Status|IN_PROGRESS |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13363] "Do you want to save the captured packets...?" [Continue without saving]

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13363

--- Comment #5 from Stig Bjørlykke  ---
Created attachment 15326
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=15326=edit
Wanted wireshark dialog view

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13363] "Do you want to save the captured packets...?" [Continue without saving]

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13363

--- Comment #4 from Gerrit Code Review  ---
Change 20485 had a related patch set uploaded by Stig Bjørlykke:
Qt: Give discard button focus (but not as default)

https://code.wireshark.org/review/20485

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13363] "Do you want to save the captured packets...?" [Continue without saving]

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13363

Stig Bjørlykke  changed:

   What|Removed |Added

 Status|UNCONFIRMED |IN_PROGRESS
 CC||s...@bjorlykke.org
 Ever confirmed|0   |1

--- Comment #3 from Stig Bjørlykke  ---
I which other dialogs do you think this is useful?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13363] "Do you want to save the captured packets...?" [Continue without saving]

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13363

--- Comment #2 from Alexis La Goutte  ---
I think, it is a Qt option..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13363] "Do you want to save the captured packets...?" [Continue without saving]

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13363

Alexis La Goutte  changed:

   What|Removed |Added

 CC||alexis.lagou...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13363] "Do you want to save the captured packets...?" [Continue without saving]

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13363

--- Comment #1 from Alexander Petrossian (PAF)  ---
Created attachment 15210
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=15210=edit
example of "traditional" dialog, when non-default button is blue-framed and can
be pressed with Spacebar shortcut

In Windows in similar dialog windows keyboard shortcuts are traditionally
different:
* Escape = cancel
* Enter+Space = accept default button

And this is why MacOS is better ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe