[Wireshark-bugs] [Bug 13366] Double "Full Screen" menu item on macOS

2018-04-09 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13366

--- Comment #9 from Gerrit Code Review  ---
Change 26828 merged by Roland Knall:
Qt: Fix MacOSX menu entries

https://code.wireshark.org/review/26828

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13366] Double "Full Screen" menu item on macOS

2018-04-09 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13366

--- Comment #8 from Gerrit Code Review  ---
Change 26829 merged by Roland Knall:
Qt: Fix MacOSX menu entries

https://code.wireshark.org/review/26829

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13366] Double "Full Screen" menu item on macOS

2018-04-09 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13366

Roland Knall  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13366] Double "Full Screen" menu item on macOS

2018-04-09 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13366

--- Comment #7 from Gerrit Code Review  ---
Change 26829 had a related patch set uploaded by Roland Knall:
Qt: Fix MacOSX menu entries

https://code.wireshark.org/review/26829

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13366] Double "Full Screen" menu item on macOS

2018-04-09 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13366

--- Comment #6 from Gerrit Code Review  ---
Change 26828 had a related patch set uploaded by Roland Knall:
Qt: Fix MacOSX menu entries

https://code.wireshark.org/review/26828

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13366] Double "Full Screen" menu item on macOS

2018-04-09 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13366

--- Comment #5 from Gerrit Code Review  ---
Change 26823 merged by Roland Knall:
Qt: Fix MacOSX menu entries

https://code.wireshark.org/review/26823

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13366] Double "Full Screen" menu item on macOS

2018-04-09 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13366

--- Comment #4 from Roland Knall  ---
(In reply to Roland Knall from comment #3)
> (In reply to Stig Bjørlykke from comment #2)
> > (In reply to Alexis La Goutte from comment #1)
> > > If i remenber, it is a bug/known issue with Qt on macOS...
> > 
> > Qt (or macOS itself?) is adding the default "Enter Full Screen" at the
> > default (bottom) position, while we are manually adding the "Full Screen"
> > entry and grabbing the default shortcut.  This sounds wrong to me.
> 
> I've uploaded a patch, and it should fix both issues. I've opted to remove
> the automatic added one, as this is easier, than to attach to the action
> item.

It gets weirder and weirder, apparently there are also two new entries for
"Edit/Start dictation" and "Edit/Emoji & Symbols". Gone now

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13366] Double "Full Screen" menu item on macOS

2018-04-09 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13366

--- Comment #3 from Roland Knall  ---
(In reply to Stig Bjørlykke from comment #2)
> (In reply to Alexis La Goutte from comment #1)
> > If i remenber, it is a bug/known issue with Qt on macOS...
> 
> Qt (or macOS itself?) is adding the default "Enter Full Screen" at the
> default (bottom) position, while we are manually adding the "Full Screen"
> entry and grabbing the default shortcut.  This sounds wrong to me.

I've uploaded a patch, and it should fix both issues. I've opted to remove the
automatic added one, as this is easier, than to attach to the action item.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13366] Double "Full Screen" menu item on macOS

2017-01-28 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13366

Stig Bjørlykke  changed:

   What|Removed |Added

Summary|Double "Enter Fullscreen"   |Double "Full Screen" menu
   |menu item on macOS  |item on macOS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe