[Wireshark-bugs] [Bug 13494] Bug Fix 4204 Wrong Enumerations for DEPI Sublayer Types L2TPv3

2018-05-16 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13494

Anders Broman  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |NOTOURBUG

--- Comment #7 from Anders Broman  ---
No progress for a year. Wee stick with the IANA definitions.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13494] Bug Fix 4204 Wrong Enumerations for DEPI Sublayer Types L2TPv3

2017-03-21 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13494

Michael Mann  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1
   Severity|Major   |Enhancement

--- Comment #6 from Michael Mann  ---
(In reply to Bob Holtorf from comment #5)
> I discovered through assistance from the people developing the DEPI
> specification that IANA does have "MPT" Specific sublayer assigned to the
> value "3".  With IANA governing these enumerations it seems to me that a
> change does need to occur.  The question is what happens to "LAPD" ?? I know
> I cannot break anyone else here so I don't know what to submit for a patch
> here

Wireshark will usually defer to IANA definitions when they exist.  The LAPD
stuff has been in there for many years, but there isn't much to it.  I'm okay
with dumping the LAPD dissection (it's a single field), at worst make it a
preference (defaulting to MPT).
Do you have a sample capture with MPT sublayer data so that we can add a patch
to support/test its dissection?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13494] Bug Fix 4204 Wrong Enumerations for DEPI Sublayer Types L2TPv3

2017-03-20 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13494

Bob Holtorf  changed:

   What|Removed |Added

 CC||bob.holt...@newwavedv.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13494] Bug Fix 4204 Wrong Enumerations for DEPI Sublayer Types L2TPv3

2017-03-20 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13494

--- Comment #5 from Bob Holtorf  ---
I discovered through assistance from the people developing the DEPI
specification that IANA does have "MPT" Specific sublayer assigned to the value
"3".  With IANA governing these enumerations it seems to me that a change does
need to occur.  The question is what happens to "LAPD" ?? I know I cannot break
anyone else here so I don't know what to submit for a patch here

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13494] Bug Fix 4204 Wrong Enumerations for DEPI Sublayer Types L2TPv3

2017-03-17 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13494

--- Comment #4 from Michael Mann  ---
(In reply to Bob Holtorf from comment #3)
> I Apologize Michael ... this code shows precisely what you typed in your
> response (i.e. 3 & 4 are defined but value "5" is not).  The code I
> submitted when I opened the bug was a patch for bug 4204  which
> evidentally hasn't found it's way to a trunk anywhere.

The patch from bug 4204 was submitted to the trunk over 7 years ago (in the SVN
days).  Because Wireshark migrated from SVN to git, I'm not quite sure how to
link to it directly, but the patch wasn't taken "as is" apparently (see
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4204#c4).  And the value
"5" was never included to the trunk.
I don't see a patch attached here (or in Gerrit where it should be).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13494] Bug Fix 4204 Wrong Enumerations for DEPI Sublayer Types L2TPv3

2017-03-17 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13494

--- Comment #3 from Bob Holtorf  ---
I Apologize Michael ... this code shows precisely what you typed in your
response (i.e. 3 & 4 are defined but value "5" is not).  The code I submitted
when I opened the bug was a patch for bug 4204  which evidentally hasn't
found it's way to a trunk anywhere.  However, a conflict still exists.  DEPI
now defined sublayer type "PSP" as "4" and the code defines "MPT" as "4".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13494] Bug Fix 4204 Wrong Enumerations for DEPI Sublayer Types L2TPv3

2017-03-17 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13494

--- Comment #2 from Bob Holtorf  ---
This is version 2.3.0 from the website:
https://www.wireshark.org/download/automated/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13494] Bug Fix 4204 Wrong Enumerations for DEPI Sublayer Types L2TPv3

2017-03-16 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13494

Michael Mann  changed:

   What|Removed |Added

 CC||mman...@netscape.net

--- Comment #1 from Michael Mann  ---
I'm not sure where you're seeing this but I can't find a supported branch (2.0,
2.2 or master) branch that has these values.  All have

#define L2TPv3_L2_SPECIFIC_LAPD 3 
#define L2TPv3_L2_SPECIFIC_DOCSIS_DMPT  4

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe