[Wireshark-bugs] [Bug 13655] After loading a capture file, Wireshark crashes upon exiting.

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13655

--- Comment #13 from Christopher Maynard  ---
(In reply to Christopher Maynard from comment #12)
> (In reply to Guy Harris from comment #10)
> > Evan, should this check be done in wmem_list_foreach() instead?
> 
> ... as well as in wmem_destroy_list()?

... and others, such as wmem_list_remove(), wmem_list_remove_frame(),
wmem_list_find(), ... ?

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13655] After loading a capture file, Wireshark crashes upon exiting.

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13655

--- Comment #12 from Christopher Maynard  ---
(In reply to Guy Harris from comment #10)
> Evan, should this check be done in wmem_list_foreach() instead?

... as well as in wmem_destroy_list()?

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13655] After loading a capture file, Wireshark crashes upon exiting.

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13655

--- Comment #11 from Stig Bjørlykke  ---
*** Bug 13660 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13655] After loading a capture file, Wireshark crashes upon exiting.

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13655

--- Comment #10 from Guy Harris  ---
Evan, should this check be done in wmem_list_foreach() instead?

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13655] After loading a capture file, Wireshark crashes upon exiting.

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13655

Guy Harris  changed:

   What|Removed |Added

 CC||eapa...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13655] After loading a capture file, Wireshark crashes upon exiting.

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13655

Guy Harris  changed:

   What|Removed |Added

 Status|IN_PROGRESS |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13655] After loading a capture file, Wireshark crashes upon exiting.

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13655

--- Comment #9 from Gerrit Code Review  ---
Change 21329 merged by Guy Harris:
Don't crash if we have no BOOTP option preferences.

https://code.wireshark.org/review/21329

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13655] After loading a capture file, Wireshark crashes upon exiting.

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13655

--- Comment #8 from Gerrit Code Review  ---
Change 21329 had a related patch set uploaded by Guy Harris:
Don't crash if we have no BOOTP option preferences.

https://code.wireshark.org/review/21329

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13655] After loading a capture file, Wireshark crashes upon exiting.

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13655

Guy Harris  changed:

   What|Removed |Added

 Status|CONFIRMED   |IN_PROGRESS

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13655] After loading a capture file, Wireshark crashes upon exiting.

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13655

--- Comment #7 from Guy Harris  ---
That sure looks like a null pointer dereference (and the crash report from
macOS would probably have indicated that as well, if I'd bothered to look at
the failing address).

wmem_list_foreach() assumes it is *not* passed a null pointer, but if you have
no options specified in the options UAT, it will be null, so that whole step
should be skipped if saved_uat_opts is null.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13655] After loading a capture file, Wireshark crashes upon exiting.

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13655

--- Comment #6 from Pascal Quantin  ---
*** Bug 13659 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13655] After loading a capture file, Wireshark crashes upon exiting.

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13655

--- Comment #5 from Guy Harris  ---
(In reply to Guy Harris from comment #2)
> I'll look at trying with an ASAN build.

Mr. ASAN says:

ASAN:DEADLYSIGNAL
=
==16594==ERROR: AddressSanitizer: SEGV on unknown address 0x0008 (pc
0x0001061e3f9e bp 0x7fff5d9c3500 sp 0x7fff5d9c34e0 T0)
==16594==The signal is caused by a READ memory access.
==16594==Hint: address points to the zero page.
#0 0x1061e3f9d in wmem_list_foreach wmem_list.c:267
#1 0x104e11068 in bootp_cleanup_protocol packet-bootp.c:6343
#2 0x103e9649c in g_slist_foreach gslist.c:896
#3 0x104ba1fdd in cleanup_dissection packet.c:343
#4 0x104b87b52 in epan_free epan.c:337
#5 0x102255dca in cf_close file.c:477
#6 0x1026fb2ad in MainWindow::testCaptureFileClose(QString,
MainWindow::FileCloseContext) main_window.cpp:1914

...

==16594==Register values:
rax = 0x1001  rbx = 0x6150cb40  rcx = 0x61d00076b860 
rdx = 0x  
rdi = 0x0008  rsi = 0x000104e1be40  rbp = 0x7fff5d9c3500 
rsp = 0x7fff5d9c34e0  
 r8 = 0x61d1bc80   r9 = 0x0001  r10 = 0x0005 
r11 = 0x  
r12 = 0x1000  r13 = 0x1000  r14 = 0x 
r15 = 0x000104e1be40  
AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: SEGV wmem_list.c:267 in wmem_list_foreach

which doesn't add much - in particular, for what it's worth, it's not reporting
any out-of-bounds stores *before* the list is freed.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13655] After loading a capture file, Wireshark crashes upon exiting.

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13655

--- Comment #4 from Pascal Quantin  ---
*** Bug 13658 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13655] After loading a capture file, Wireshark crashes upon exiting.

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13655

Pascal Quantin  changed:

   What|Removed |Added

 CC||buildbot-do-not-reply@wires
   ||hark.org

--- Comment #3 from Pascal Quantin  ---
*** Bug 13654 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13655] After loading a capture file, Wireshark crashes upon exiting.

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13655

Alexis La Goutte  changed:

   What|Removed |Added

 CC||alexis.lagou...@gmail.com,
   ||mman...@netscape.net

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13655] After loading a capture file, Wireshark crashes upon exiting.

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13655

--- Comment #2 from Guy Harris  ---
(In reply to Guy Harris from comment #1)
> Possibly a result of If52c00bbc23d89386ba3e777600f665609856de0.

Backing that change out seems to prevent the crash.

I'll look at trying with an ASAN build.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13655] After loading a capture file, Wireshark crashes upon exiting.

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13655

Guy Harris  changed:

   What|Removed |Added

   Hardware|x86-64  |All
 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1
 OS|Windows 10  |All

--- Comment #1 from Guy Harris  ---
Confirmed on macOS with tip of master branch and a small capture with DHCP
traffic.  The stack trace is

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   libwireshark.0.dylib0x00010aa24b40 wmem_list_foreach +
16 (wmem_list.c:267)
1   libwireshark.0.dylib0x000109e563f9
bootp_cleanup_protocol + 25 (packet-bootp.c:6345)
2   libglib-2.0.0.dylib 0x00010f44c49d g_slist_foreach + 45
(gslist.c:893)
3   libwireshark.0.dylib0x000109d1bbce cleanup_dissection +
30 (packet.c:346)
4   libwireshark.0.dylib0x000109d11253 epan_free + 19
(epan.c:339)
5   wireshark   0x00010937e113 cf_close + 451
(file.c:478)
6

...

Possibly a result of If52c00bbc23d89386ba3e777600f665609856de0.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13655] After loading a capture file, Wireshark crashes upon exiting.

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13655

Christopher Maynard  changed:

   What|Removed |Added

   Priority|Low |High

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe