[Wireshark-bugs] [Bug 13698] SIP packets with SDP marked as malformed

2017-05-20 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13698

Jaap Keuter  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13698] SIP packets with SDP marked as malformed

2017-05-20 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13698

--- Comment #10 from Gerrit Code Review  ---
Change 21715 merged by Anders Broman:
SDP: Handle incomplete media attributes

https://code.wireshark.org/review/21715

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13698] SIP packets with SDP marked as malformed

2017-05-19 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13698

--- Comment #9 from Gerrit Code Review  ---
Change 21715 had a related patch set uploaded by Jaap Keuter:
SDP: Handle incomplete media attributes

https://code.wireshark.org/review/21715

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13698] SIP packets with SDP marked as malformed

2017-05-19 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13698

--- Comment #8 from Gerrit Code Review  ---
Change 21699 merged by Anders Broman:
SDP: Handle incomplete media attributes

https://code.wireshark.org/review/21699

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13698] SIP packets with SDP marked as malformed

2017-05-18 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13698

--- Comment #6 from Jan  ---
Hi Anders,

I do agree that this would be the best option. I do use "display SIP as raw
text" and this is not seen because of the "malformed packet". So I do agree
that best would be to display the SIP as it is and add "expert info".

thanks,
Jan

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13698] SIP packets with SDP marked as malformed

2017-05-18 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13698

--- Comment #5 from Anders Broman  ---
(In reply to Jan from comment #4)
> ok, I see, so the colon should not be present..
> 
> apparently quite a lot of ntw devices to accept it with the : and no issues
> reported (by the sip / sdp parser). I will report this to the product owner,
> but would it be possible to allow also the a=rtcp-xr: with colon and not
> mark as malformed?

We should probably have an expert item saying that it is wrongly formated but
continue dissection, I don't think we should silently accept it.
Just my 2 cents.
Anders

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13698] SIP packets with SDP marked as malformed

2017-05-18 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13698

Jaap Keuter  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13698] SIP packets with SDP marked as malformed

2017-05-18 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13698

--- Comment #4 from Jan  ---
ok, I see, so the colon should not be present..

apparently quite a lot of ntw devices to accept it with the : and no issues
reported (by the sip / sdp parser). I will report this to the product owner,
but would it be possible to allow also the a=rtcp-xr: with colon and not mark
as malformed?

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13698] SIP packets with SDP marked as malformed

2017-05-12 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13698

--- Comment #3 from Jaap Keuter  ---
But check RFC 3611 Errata ID 3795:

Status: Verified
Type: Technical

Reported By: Stephen James
Date Reported: 2013-11-11
Verifier Name: Ben Campbell
Date Verified: 2015-07-22

Section 5.1 says:

rtcp-xr-attrib = "a=" "rtcp-xr" ":" [xr-format *(SP xr-format)] CRLF

It should say:

rtcp-xr-attrib = "a=" "rtcp-xr" [ ":" xr-format *(SP xr-format)] CRLF

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13698] SIP packets with SDP marked as malformed

2017-05-12 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13698

--- Comment #2 from Jan  ---
not sure if it's a problem.. as per RFC 7243:
rtcp-xr-attrib = "a=" "rtcp-xr" ":" [xr-format *(SP xr-format)]
CRLF   ; defined in [RFC3611]

and in 3611:
 rtcp-xr-attrib = "a=" "rtcp-xr" ":" [xr-format *(SP xr-format)] CRLF

The "rtcp-xr" attribute contains zero, one, or more XR block related
   parameters.
..
The "rtcp-xr" attributes parameter list MAY be empty. 
..

so from that I do assume that empty even with colon is expected

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13698] SIP packets with SDP marked as malformed

2017-05-12 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13698

--- Comment #1 from Jaap Keuter  ---
What's with the colon while no parameter value follows?

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe