[Wireshark-bugs] [Bug 14113] AMQP 0.9 dissector confused when first packet contains several frames

2017-10-28 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14113

Michael Mann  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14113] AMQP 0.9 dissector confused when first packet contains several frames

2017-10-28 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14113

--- Comment #5 from Gerrit Code Review  ---
Change 24109 merged by Michael Mann:
AMQP: Add dissector table for versions so they can be dissected with Decode As

https://code.wireshark.org/review/24109

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14113] AMQP 0.9 dissector confused when first packet contains several frames

2017-10-27 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14113

--- Comment #4 from Gerrit Code Review  ---
Change 24108 merged by Michael Mann:
Autodetect more AMQP 0-9 captures

https://code.wireshark.org/review/24108

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14113] AMQP 0.9 dissector confused when first packet contains several frames

2017-10-27 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14113

--- Comment #3 from Magnus Henoch  ---
I pushed two commits with possible solutions for this.  The first one changes
the autodetection to consider the possibility of a 0-9 packet containing two
frames. The second one adds a preference for forcing a certain protocol
version.

I'm not sure if it would be appropriate to use either of them or both.  The
first commit introduces a small possibility of misdetecting 0-10 or 1.0
traffic, though I think it should be very small.  The second commit offers a
way of overriding this if the autodetection code gets it wrong - or a way of
getting the behaviour I want for 0-9 traffic.  Any feedback is welcome.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14113] AMQP 0.9 dissector confused when first packet contains several frames

2017-10-27 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14113

--- Comment #1 from Gerrit Code Review  ---
Change 24108 had a related patch set uploaded by Magnus Henoch:
Autodetect more AMQP 0-9 captures

https://code.wireshark.org/review/24108

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14113] AMQP 0.9 dissector confused when first packet contains several frames

2017-10-27 Thread bugzilla-daemon 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14113

--- Comment #2 from Gerrit Code Review  ---
Change 24109 had a related patch set uploaded by Magnus Henoch:
Add preference for AMQP version detection

https://code.wireshark.org/review/24109

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe