[Wireshark-bugs] [Bug 14258] CMake should install the Wireshark User Guide to $docdir
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14258 Michael Mann changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 14258] CMake should install the Wireshark User Guide to $docdir
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14258 --- Comment #4 from Gerrit Code Review --- Change 25737 merged by Anders Broman: CMake: Install the HTML guides. https://code.wireshark.org/review/25737 -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 14258] CMake should install the Wireshark User Guide to $docdir
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14258 --- Comment #3 from Gerrit Code Review --- Change 25737 had a related patch set uploaded by Gerald Combs: CMake: Install the HTML guides. https://code.wireshark.org/review/25737 -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 14258] CMake should install the Wireshark User Guide to $docdir
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14258
João Valverde changed:
What|Removed |Added
Ever confirmed|0 |1
Status|UNCONFIRMED |CONFIRMED
--- Comment #2 from João Valverde ---
(In reply to Gerald Combs from comment #1)
> The top-level CMakeLists.txt currently calls
>
> set(DOC_DIR "$ENV{docdir}")
>
> at line 1422, then installs the PDF guides into ${DOC_DIR} at line 3146. We
> should probably:
>
> - Use CMAKE_INSTALL_FULL_DOCDIR (which is defined by GNUInstallDirs) instead
> of DOC_DIR
> - Move the doc installation stanza to a target (install_guides?) in
> docbook/CMakeLists.txt.
> - Install ws[ud]g_html_chunked instead of or in addition to the PDFs.
Sounds good. Should be easier after change 25668 is merged. The autotools code
installs the guide using "make install" but personally I prefer having a
separate build/install step for that (like you started doing in 25668).
--
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 14258] CMake should install the Wireshark User Guide to $docdir
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14258
--- Comment #1 from Gerald Combs ---
The top-level CMakeLists.txt currently calls
set(DOC_DIR "$ENV{docdir}")
at line 1422, then installs the PDF guides into ${DOC_DIR} at line 3146. We
should probably:
- Use CMAKE_INSTALL_FULL_DOCDIR (which is defined by GNUInstallDirs) instead of
DOC_DIR
- Move the doc installation stanza to a target (install_guides?) in
docbook/CMakeLists.txt.
- Install ws[ud]g_html_chunked instead of or in addition to the PDFs.
--
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
