[Wireshark-bugs] [Bug 14340] Subtree expand/collapse tracking only works for top-level items in the packet details pane

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14340

--- Comment #12 from Gerald Combs  ---
(In reply to Thomas Wiens from comment #10)
> There is still an issue with this.
> 
> The subtree is now opened correctly, but only if you have selected a
> tree element under the root tree.
> 
> For the sample capture examlpe to reproduce it within tcp tree:
> 
> Select #1, expand tcp, expand tcp.flags
> Select #2, tcp is expanded down to tcp.flags as expected
> 
> Select the ip root node without expanding / collapsing anything
> Select #1, tcp is collapsed now

This should be fixed in change 25328. It also fixes:

Select #1, expand tcp, expand tcp.flags, collapse tcp
Select the ip root node without expanding / collapsing anything
Select #2, expand tcp. tcp.flags should be expanded.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14340] Subtree expand/collapse tracking only works for top-level items in the packet details pane

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14340

--- Comment #11 from Gerrit Code Review  ---
Change 25328 had a related patch set uploaded by Gerald Combs:
ProtoTree behavior fixes.

https://code.wireshark.org/review/25328

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14340] Subtree expand/collapse tracking only works for top-level items in the packet details pane

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14340

--- Comment #10 from Thomas Wiens  ---
There is still an issue with this.

The subtree is now opened correctly, but only if you have selected a
tree element under the root tree.

For the sample capture examlpe to reproduce it within tcp tree:

Select #1, expand tcp, expand tcp.flags
Select #2, tcp is expanded down to tcp.flags as expected

Select the ip root node without expanding / collapsing anything
Select #1, tcp is collapsed now

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14340] Subtree expand/collapse tracking only works for top-level items in the packet details pane

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14340

Michael Mann  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14340] Subtree expand/collapse tracking only works for top-level items in the packet details pane

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14340

--- Comment #9 from Gerrit Code Review  ---
Change 25316 merged by Roland Knall:
Qt: Expand subtrees when a packet is selected.

https://code.wireshark.org/review/25316

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14340] Subtree expand/collapse tracking only works for top-level items in the packet details pane

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14340

--- Comment #8 from Gerrit Code Review  ---
Change 25316 had a related patch set uploaded by Gerald Combs:
Qt: Expand subtrees when a packet is selected.

https://code.wireshark.org/review/25316

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14340] Subtree expand/collapse tracking only works for top-level items in the packet details pane

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14340

--- Comment #7 from Roland Knall  ---
(In reply to Guy Harris from comment #6)
> OK, so I'm not sure where ProtoNode fits in the Qt class hierarchy, but its
> isExpanded method is only being called for the top-level nodes, *even
> though, when it returns true, there are other nodes underneath it, so the
> TreeView needs to know whether those nodes are expanded as well*.
> 
> This is not the proper behavior.  I don't know whether Qt is just being
> stupid here or whether we haven't put the proper classes in the proper
> places.

I'll try to take a run at it. It is hard getting Qt and our own proprietary
stuff of doing things acting together. But this should be a rather simple fix.
It's not so much the proper classes, but rather emitting the right signals.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14340] Subtree expand/collapse tracking only works for top-level items in the packet details pane

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14340

--- Comment #6 from Guy Harris  ---
OK, so I'm not sure where ProtoNode fits in the Qt class hierarchy, but its
isExpanded method is only being called for the top-level nodes, *even though,
when it returns true, there are other nodes underneath it, so the TreeView
needs to know whether those nodes are expanded as well*.

This is not the proper behavior.  I don't know whether Qt is just being stupid
here or whether we haven't put the proper classes in the proper places.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14340] Subtree expand/collapse tracking only works for top-level items in the packet details pane

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14340

Guy Harris  changed:

   What|Removed |Added

 CC||ger...@wireshark.org

--- Comment #5 from Guy Harris  ---
I think this is a side-effect of

commit bdb6baa7405d259fa2cd2f6f7d2fb21e13315885
Author: Gerald Combs 
Date:   Thu Dec 7 08:15:30 2017 -0800

Qt: Switch ProtoTree to a treeview+model.

Add a ProtoTreeModel and use it in ProtoTree. This should make the UI
more responsive when we have lots of items in the tree.

Change-Id: Id26e6bcff84663867a8da17fd9ae86ff639b633f
Reviewed-on: https://code.wireshark.org/review/24774
Reviewed-by: Gerald Combs 
Petri-Dish: Gerald Combs 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14340] Subtree expand/collapse tracking only works for top-level items in the packet details pane

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14340

Guy Harris  changed:

   What|Removed |Added

   Priority|Low |Medium

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14340] Subtree expand/collapse tracking only works for top-level items in the packet details pane

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14340

Guy Harris  changed:

   What|Removed |Added

Summary|Subtree expand/collapse |Subtree expand/collapse
   |tracking sometimes doesn't  |tracking only works for
   |work|top-level items in the
   ||packet details pane

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe