[Wireshark-bugs] [Bug 14494] Buildbot crash output: fuzz-2018-03-07-5447.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14494

Peter Wu  changed:

   What|Removed |Added

 CC||pe...@lekensteyn.nl
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #26 from Peter Wu  ---
The faulting function (process_mmdbr_stdout) was moved in
v2.9.0rc0-689-gc159d48420 and I cannot reproduce the issue, not even on
v2.6.4rc0-111-gb2bbd9fdf2. Assuming fixed.

If vectorization was suspect, note that --partial-loads-ok=yes option was made
by default in 3.11.0 which should reduce false positives:
http://valgrind.org/docs/manual/dist.news.html

The code before v2.5.1rc0-563-gaae6b8442c looks sane to me, "read_buf" up to
and including position "read_status" should have been fully initialized by the
"ws_read" (macro for "read") call.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14494] Buildbot crash output: fuzz-2018-03-07-5447.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14494

--- Comment #23 from Michael Mann  ---
*** Bug 14510 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14494] Buildbot crash output: fuzz-2018-03-07-5447.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14494

--- Comment #24 from Michael Mann  ---
*** Bug 14511 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14494] Buildbot crash output: fuzz-2018-03-07-5447.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14494

--- Comment #22 from Michael Mann  ---
*** Bug 14509 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14494] Buildbot crash output: fuzz-2018-03-07-5447.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14494

--- Comment #25 from Michael Mann  ---
*** Bug 14513 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14494] Buildbot crash output: fuzz-2018-03-07-5447.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14494

--- Comment #21 from Michael Mann  ---
*** Bug 14508 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14494] Buildbot crash output: fuzz-2018-03-07-5447.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14494

--- Comment #20 from Michael Mann  ---
*** Bug 14507 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14494] Buildbot crash output: fuzz-2018-03-07-5447.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14494

--- Comment #18 from Michael Mann  ---
*** Bug 14504 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14494] Buildbot crash output: fuzz-2018-03-07-5447.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14494

--- Comment #19 from Michael Mann  ---
*** Bug 14505 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14494] Buildbot crash output: fuzz-2018-03-07-5447.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14494

--- Comment #15 from Michael Mann  ---
*** Bug 14501 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14494] Buildbot crash output: fuzz-2018-03-07-5447.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14494

--- Comment #16 from Michael Mann  ---
*** Bug 14502 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14494] Buildbot crash output: fuzz-2018-03-07-5447.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14494

--- Comment #17 from Michael Mann  ---
*** Bug 14503 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14494] Buildbot crash output: fuzz-2018-03-07-5447.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14494

--- Comment #14 from Guy Harris  ---
(In reply to Gerald Combs from comment #12)
> (In reply to Guy Harris from comment #11)
> > (In reply to Gerald Combs from comment #10)
> > > I've disabled the Valgrind step for now.
> > 
> > Unfortunately, now it's trying to run a fuzz-menagerie step, but that's
> > failing:
> > 
> >
> > https://buildbot.wireshark.org/wireshark-master/builders/
> > Clang%20Code%20Analysis/builds/4660/steps/fuzz-menagerie/logs/stdio
> 
> If I build with ASAN enabled on Linux, tshark -V returns 141.

Yup, 141 = (0x80 | (SIGPIPE = 13)).

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14494] Buildbot crash output: fuzz-2018-03-07-5447.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14494

--- Comment #13 from Gerrit Code Review  ---
Change 26369 had a related patch set uploaded by Gerald Combs:
epan: Ignore SIGPIPE.

https://code.wireshark.org/review/26369

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14494] Buildbot crash output: fuzz-2018-03-07-5447.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14494

--- Comment #12 from Gerald Combs  ---
(In reply to Guy Harris from comment #11)
> (In reply to Gerald Combs from comment #10)
> > I've disabled the Valgrind step for now.
> 
> Unfortunately, now it's trying to run a fuzz-menagerie step, but that's
> failing:
> 
>
> https://buildbot.wireshark.org/wireshark-master/builders/
> Clang%20Code%20Analysis/builds/4660/steps/fuzz-menagerie/logs/stdio

If I build with ASAN enabled on Linux, tshark -V returns 141. We ignore SIGPIPE
in wireshark-qt.cpp and gtk_init does that for us in the GTK+ UI. We don't do
so in tshark.c.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14494] Buildbot crash output: fuzz-2018-03-07-5447.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14494

--- Comment #11 from Guy Harris  ---
(In reply to Gerald Combs from comment #10)
> I've disabled the Valgrind step for now.

Unfortunately, now it's trying to run a fuzz-menagerie step, but that's
failing:

   
https://buildbot.wireshark.org/wireshark-master/builders/Clang%20Code%20Analysis/builds/4660/steps/fuzz-menagerie/logs/stdio

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14494] Buildbot crash output: fuzz-2018-03-07-5447.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14494

--- Comment #10 from Gerald Combs  ---
I've disabled the Valgrind step for now.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14494] Buildbot crash output: fuzz-2018-03-07-5447.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14494

--- Comment #9 from Gerald Combs  ---
*** Bug 14497 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14494] Buildbot crash output: fuzz-2018-03-07-5447.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14494

--- Comment #8 from Guy Harris  ---
*** Bug 14500 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14494] Buildbot crash output: fuzz-2018-03-07-5447.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14494

--- Comment #7 from Guy Harris  ---
*** Bug 14499 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14494] Buildbot crash output: fuzz-2018-03-07-5447.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14494

--- Comment #6 from Guy Harris  ---
*** Bug 14498 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14494] Buildbot crash output: fuzz-2018-03-07-5447.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14494

--- Comment #5 from Gerald Combs  ---
It looks like we're ending up with an optimized strlen, for which Valgrind
doesn't care[1]. If I change the "read_buf[0] = '\0'" at line 126 to
"memset(read_buf, 0, 64)" Valgrind stops complaining. Passing "-fno-builtin" to
clang doesn't fix it unfortunately:

==25583== Conditional jump or move depends on uninitialised value(s)
==25583==at 0x4C32D08: strlen (in
/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==25583==by 0x751C832: process_mmdbr_stdout (maxmind_db.c:135)
==25583==by 0x7579828: uat_load (uat_load.l:372)
==25583==by 0x7569114: uat_load_all (uat.c:532)
==25583==by 0x752FE07: init_prefs (prefs.c:3961)
==25583==by 0x752FE07: read_prefs (prefs.c:4314)
==25583==by 0x75170EA: epan_load_settings (epan.c:283)
==25583==by 0x119CC9: main (tshark.c:1016)


[1]https://bugs.kde.org/show_bug.cgi?id=264936 (It's for gcc, but I'm assuming
that the same applies for clang).

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14494] Buildbot crash output: fuzz-2018-03-07-5447.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14494

--- Comment #4 from Guy Harris  ---
*** Bug 14496 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14494] Buildbot crash output: fuzz-2018-03-07-5447.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14494

--- Comment #3 from Guy Harris  ---
*** Bug 14495 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14494] Buildbot crash output: fuzz-2018-03-07-5447.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14494

--- Comment #2 from Guy Harris  ---
*** Bug 14493 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14494] Buildbot crash output: fuzz-2018-03-07-5447.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14494

Guy Harris  changed:

   What|Removed |Added

 CC||ger...@wireshark.org

--- Comment #1 from Guy Harris  ---
Gerald?  This appears to be in the new MaxMind DB code.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe