[Wireshark-bugs] [Bug 14596] SSL reassembly results in multiple "Reassembled SSL segments" items and duplicate dissections
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14596 Peter Wu changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED --- Comment #6 from Peter Wu --- Fix will be part of 2.6 -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 14596] SSL reassembly results in multiple "Reassembled SSL segments" items and duplicate dissections
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14596 --- Comment #5 from Gerrit Code Review --- Change 26971 merged by Peter Wu: ssl: fix duplicate dissections with multiple PDUs in a stream https://code.wireshark.org/review/26971 -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 14596] SSL reassembly results in multiple "Reassembled SSL segments" items and duplicate dissections
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14596 --- Comment #4 from Gerrit Code Review --- Change 26971 had a related patch set uploaded by Peter Wu: ssl: fix duplicate dissections with multiple PDUs in a stream https://code.wireshark.org/review/26971 -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 14596] SSL reassembly results in multiple "Reassembled SSL segments" items and duplicate dissections
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14596 --- Comment #3 from Gerrit Code Review --- Change 26935 merged by Anders Broman: ssl: fix duplicate dissections with multiple PDUs in a stream https://code.wireshark.org/review/26935 -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 14596] SSL reassembly results in multiple "Reassembled SSL segments" items and duplicate dissections
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14596 --- Comment #2 from Gerrit Code Review --- Change 26935 had a related patch set uploaded by Peter Wu: ssl: fix duplicate dissections with multiple PDUs in a stream https://code.wireshark.org/review/26935 -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 14596] SSL reassembly results in multiple "Reassembled SSL segments" items and duplicate dissections
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14596
--- Comment #1 from Peter Wu ---
Probable problem cause:
"seq" and "nxtseq" (in desegment_ssl) are the absolute offsets of decrypted
data within a SSL stream, starting from the very first application data record
(not sure if this is reset during renegotiation).
"ipfd_head->datalen" on the other hand is just the size of of reassembled data
(which may contain a partial (head) or full PDU).
In case of a single TCP stream with multiple PDUs, the condition "nxtseq <
ipfd_head->datalen" will therefore unlikely prevent multiple fragment trees
from being added after the first PDU. Unlikely here means: subsequent PDUs are
probably not sized as large as the sum of all previous PDU sizes.
Debug print after "if (ipfd_head) {":
g_print("seq=%d nxtseq=%d fraglen=%d datalen=%d\n", seq, nxtseq, fraglen,
ipfd_head->datalen);
Frame 7
seq=4 nxtseq=8 fraglen=4 datalen=8
Frame 8
seq=8 nxtseq=12 fraglen=4 datalen=12
seq=12 nxtseq=16 fraglen=4 datalen=16
seq=16 nxtseq=20 fraglen=4 datalen=20
seq=20 nxtseq=24 fraglen=4 datalen=24
seq=24 nxtseq=28 fraglen=4 datalen=28
seq=28 nxtseq=32 fraglen=4 datalen=32
seq=32 nxtseq=36 fraglen=4 datalen=36
seq=36 nxtseq=40 fraglen=4 datalen=40
seq=40 nxtseq=44 fraglen=4 datalen=6
seq=44 nxtseq=48 fraglen=4 datalen=10
seq=48 nxtseq=52 fraglen=4 datalen=14
seq=52 nxtseq=56 fraglen=4 datalen=18
seq=56 nxtseq=60 fraglen=4 datalen=22
seq=60 nxtseq=64 fraglen=4 datalen=26
seq=64 nxtseq=68 fraglen=4 datalen=30
seq=68 nxtseq=72 fraglen=4 datalen=34
seq=72 nxtseq=76 fraglen=4 datalen=38
Frame 9
seq=76 nxtseq=80 fraglen=4 datalen=42
seq=80 nxtseq=84 fraglen=4 datalen=46
seq=84 nxtseq=86 fraglen=2 datalen=48
--
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
