[Wireshark-bugs] [Bug 15301] CMake install target is broken on Windows
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15301 --- Comment #25 from João Valverde --- (In reply to João Valverde from comment #24) > (In reply to Jaap Keuter from comment #23) > > Might as well close this, since it's not really applicable on Windows to > > have this. > > There were three separate goals to this bug, which should probably be called > an enhancement: > > 1. Improve CMake code. Make it less fragile and platform dependent and > remove some bad smells like using CMAKE_CFG_INTDIR. > > 2. Lay the ground work for CPack. > > 3. Make it possible to have a build environment on Windows for plugins (out > of tree). Peter makes a good point about using an SDK instead. I should have said "using an SDK instead of bundling everything with the NSIS installer". -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:[email protected]?subject=unsubscribe
[Wireshark-bugs] [Bug 15301] CMake install target is broken on Windows
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15301 --- Comment #24 from João Valverde --- (In reply to Jaap Keuter from comment #23) > Might as well close this, since it's not really applicable on Windows to > have this. There were three separate goals to this bug, which should probably be called an enhancement: 1. Improve CMake code. Make it less fragile and platform dependent and remove some bad smells like using CMAKE_CFG_INTDIR. 2. Lay the ground work for CPack. 3. Make it possible to have a build environment on Windows for plugins (out of tree). Peter makes a good point about using an SDK instead. But I don't see myself investing more time on this, I don't use the platform, and nobody else seems to want it, so closing doesn't bother me. -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:[email protected]?subject=unsubscribe
[Wireshark-bugs] [Bug 15301] CMake install target is broken on Windows
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15301 Jaap Keuter changed: What|Removed |Added Resolution|--- |WONTFIX Status|CONFIRMED |RESOLVED --- Comment #23 from Jaap Keuter --- Might as well close this, since it's not really applicable on Windows to have this. -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:[email protected]?subject=unsubscribe
[Wireshark-bugs] [Bug 15301] CMake install target is broken on Windows
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15301 João Valverde changed: What|Removed |Added Status|RESOLVED|CONFIRMED Resolution|FIXED |--- Ever confirmed|0 |1 --- Comment #22 from João Valverde --- Reopening with commit f7def1d07f39c8b90245a20d09a4b56ae23de077. -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:[email protected]?subject=unsubscribe
[Wireshark-bugs] [Bug 15301] CMake install target is broken on Windows
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15301 João Valverde changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED --- Comment #21 from João Valverde --- The issue is resolved for the most part but without testing or change 30853 (pending) I believe it will regress. -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:[email protected]?subject=unsubscribe
[Wireshark-bugs] [Bug 15301] CMake install target is broken on Windows
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15301 --- Comment #20 from Gerrit Code Review --- Change 30879 had a related patch set uploaded by João Valverde: CMake: Add Windows help install target https://code.wireshark.org/review/30879 -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:[email protected]?subject=unsubscribe
[Wireshark-bugs] [Bug 15301] CMake install target is broken on Windows
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15301 --- Comment #19 from Gerrit Code Review --- Change 30853 had a related patch set uploaded by João Valverde: [WIP] CMake: Refactor the staging dir code. https://code.wireshark.org/review/30853 -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:[email protected]?subject=unsubscribe
[Wireshark-bugs] [Bug 15301] CMake install target is broken on Windows
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15301 --- Comment #18 from João Valverde --- Created attachment 16767 --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=16767&action=edit patch wireshark zlib source -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:[email protected]?subject=unsubscribe
[Wireshark-bugs] [Bug 15301] CMake install target is broken on Windows
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15301 --- Comment #17 from João Valverde --- With the latest patch I'm at least able to run Wireshark after installation (without any glaring issues). -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:[email protected]?subject=unsubscribe
[Wireshark-bugs] [Bug 15301] CMake install target is broken on Windows
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15301 --- Comment #16 from Gerrit Code Review --- Change 30819 had a related patch set uploaded by João Valverde: CMake: Change some install() paths to match NSIS package https://code.wireshark.org/review/30819 -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:[email protected]?subject=unsubscribe
[Wireshark-bugs] [Bug 15301] CMake install target is broken on Windows
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15301 --- Comment #15 from Gerrit Code Review --- Change 30818 had a related patch set uploaded by João Valverde: CMake: Enable install target on Windows (missing DLLs) https://code.wireshark.org/review/30818 -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:[email protected]?subject=unsubscribe
[Wireshark-bugs] [Bug 15301] CMake install target is broken on Windows
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15301 --- Comment #14 from João Valverde --- (In reply to Graham Bloice from comment #12) > We've never supported the idea of install on Windows as: > > 1. Only a few folks have ever asked for it (a simpler plug-in dev env) and > as you've found it's not easy and no-one else has stepped up. > 1. We'd have to create and maintain an SDK for all the 3rd party and > Wireshark link libraries required. > > Theoretically the vcpackage (https://github.com/Microsoft/vcpkg) project > could help here, which is CMake based, but that's a long way down on my todo > list. Thanks for that context. Point 2 is a bummer but even if it only provides a working installation without NSIS, that's a win. But if it's too difficult I will probably give up on this. -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:[email protected]?subject=unsubscribe
[Wireshark-bugs] [Bug 15301] CMake install target is broken on Windows
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15301
--- Comment #13 from João Valverde ---
(In reply to Peter Wu from comment #11)
> > (In reply to Peter Wu from comment #9)
> > Problem:
> > msbuild ... INSTALL.vcxproj fails.
> >
> > Expected:
> > msbuild ... INSTALL.vcxproj should create a working wireshark installation
> > to CMAKE_INSTALL_PREFIX/PROJECT_NAME.
> >
> > Does that clarify the issue?
>
> Is anything installed at all? Any error messages?
> (According to CMAKE_INSTALL_PREFIX, it defaults to c:/Program
> Files/${PROJECT_NAME} on Windows by the way.)
After change 30784 at least it runs. The rest of the work to fix it to a
working state is ongoing.
> While plugin development is one use case that could be enabled by a proper
> CMake configuration, a portable Wireshark version (unzip and run) seems a
> more appealing use case.
I agree, there other use cases and even more benefits down the road. If your
opinion is that we shouldn't include optional development files with the
installer, that's fine, we can have that discussion later. I probably wouldn't
want either at the current size and an SDK doesn't seem appealing right now.
Right now there is a broken installation target on Windows and as faras I can
tell there is no reason, technical or otherwise, to keep it that way.
--
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
mailto:[email protected]?subject=unsubscribe
[Wireshark-bugs] [Bug 15301] CMake install target is broken on Windows
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15301 --- Comment #12 from Graham Bloice --- We've never supported the idea of install on Windows as: 1. Only a few folks have ever asked for it (a simpler plug-in dev env) and as you've found it's not easy and no-one else has stepped up. 1. We'd have to create and maintain an SDK for all the 3rd party and Wireshark link libraries required. Theoretically the vcpackage (https://github.com/Microsoft/vcpkg) project could help here, which is CMake based, but that's a long way down on my todo list. -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:[email protected]?subject=unsubscribe
[Wireshark-bugs] [Bug 15301] CMake install target is broken on Windows
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15301
--- Comment #11 from Peter Wu ---
> (In reply to Peter Wu from comment #9)
> Problem:
> msbuild ... INSTALL.vcxproj fails.
>
> Expected:
> msbuild ... INSTALL.vcxproj should create a working wireshark installation to
> CMAKE_INSTALL_PREFIX/PROJECT_NAME.
>
> Does that clarify the issue?
Is anything installed at all? Any error messages?
(According to CMAKE_INSTALL_PREFIX, it defaults to c:/Program
Files/${PROJECT_NAME} on Windows by the way.)
While plugin development is one use case that could be enabled by a proper
CMake configuration, a portable Wireshark version (unzip and run) seems a more
appealing use case.
--
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
mailto:[email protected]?subject=unsubscribe
[Wireshark-bugs] [Bug 15301] CMake install target is broken on Windows
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15301 --- Comment #10 from João Valverde --- (In reply to Peter Wu from comment #9) > > The end goal was also to add an option to the installer to install > > development files (they should come down in size though). > > I would not bother, I expect that the majority of the users won't need it. > For those who do, a SDK could be provided, but I am not sure who would use > it. (You still need a proper build environment as created by > tools/win-setup.ps1.) > > I've tried to give this bug a more specific title, but failed. Can you > clarify it with steps to reproduce/expected behavior/actual behavior? Problem: msbuild ... INSTALL.vcxproj fails. Expected: msbuild ... INSTALL.vcxproj should create a working wireshark installation to CMAKE_INSTALL_PREFIX/PROJECT_NAME. Does that clarify the issue? -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:[email protected]?subject=unsubscribe
[Wireshark-bugs] [Bug 15301] CMake install target is broken on Windows
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15301 Peter Wu changed: What|Removed |Added Summary|Wireshark can't be |CMake install target is |installed on Windows|broken on Windows |(CMake) | --- Comment #9 from Peter Wu --- > The end goal was also to add an option to the installer to install > development files (they should come down in size though). I would not bother, I expect that the majority of the users won't need it. For those who do, a SDK could be provided, but I am not sure who would use it. (You still need a proper build environment as created by tools/win-setup.ps1.) I've tried to give this bug a more specific title, but failed. Can you clarify it with steps to reproduce/expected behavior/actual behavior? -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:[email protected]?subject=unsubscribe
