[Wireshark-bugs] [Bug 16136] AMQP: Boolean values are not correctly displayed

2019-10-16 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16136

linahirsch...@gmail.com changed:

   What|Removed |Added

 Resolution|--- |NOTABUG
 Status|INCOMPLETE  |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16136] AMQP: Boolean values are not correctly displayed

2019-10-16 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16136

--- Comment #3 from linahirsch...@gmail.com ---
Hi again,

The problem is resolved.
Indeed, we should have encoded true as 0x56 0x01 and false as 0x56 0x00.
My observations with the other independent AMQP client were also wrong.

This bug can be closed, as it was an error on our side.
Sorry and thank you anyways!

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16136] AMQP: Boolean values are not correctly displayed

2019-10-16 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16136

--- Comment #2 from linahirsch...@gmail.com ---
Hello,
thank you for the quick comment.
I think I understand your point.
I tried sending the message with a different (independent) AMQP client to check
whether our encoding is indeed different or wrong.
However, I see the same behaviour, true is encoded to 0x56 0x42 and false to
0x56 0x42.
Let's see what the AMQP experts say.

Thank you and friendly regards

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16136] AMQP: Boolean values are not correctly displayed

2019-10-16 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16136

Pascal Quantin  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |INCOMPLETE
 CC||pas...@wireshark.org

--- Comment #1 from Pascal Quantin  ---
Hi,

I do not know AMQP, but when I read your specification it says that for
encoding code 0x56 (what you are using according to your screenshot) false
should be 0x00 and true 0x01. But here you send 0x41 and 0x42 (as if you were
using the code specific to a boolean being always true or always false if I
understood the spec properly).
According to the Wireshark source code, to get false you should send 0x56 0x00
and not 0x56 0x42 (and it matches your spec). Here Wireshark does not flag 0x42
as invalid: it's either 0x00 (false) or anything else (true). A future
evolution could add an expert info whan the value is neither true (0x01) or
false (0x00).
I will let someone else knowing AMQP comment on your report, but at first
glance your encoding seems wrong.

Best regards,
Pascal.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe