[Wireshark-bugs] [Bug 16338] Amqp requeue param is incorrectly dissects and displayed .
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16338 Jaap Keuter changed: What|Removed |Added Resolution|--- |FIXED Status|IN_PROGRESS |RESOLVED -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:[email protected]?subject=unsubscribe
[Wireshark-bugs] [Bug 16338] Amqp requeue param is incorrectly dissects and displayed .
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16338 --- Comment #12 from Gerrit Code Review --- Change 35906 merged by Anders Broman: amqp: fix wrong bitmask (v2) https://code.wireshark.org/review/35906 -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:[email protected]?subject=unsubscribe
[Wireshark-bugs] [Bug 16338] Amqp requeue param is incorrectly dissects and displayed .
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16338 --- Comment #11 from Gerrit Code Review --- Change 35906 had a related patch set uploaded by Alexis La Goutte: amqp: fix wrong bitmask (v2) https://code.wireshark.org/review/35906 -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:[email protected]?subject=unsubscribe
[Wireshark-bugs] [Bug 16338] Amqp requeue param is incorrectly dissects and displayed .
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16338 --- Comment #10 from Christopher Maynard --- (In reply to Jaap Keuter from comment #5) > (Now with Alexis on CC) > > Is the fix correct? If so Alexis, can you close the bug? Otherwise can you > > fix it? Judging by the capture files and comments I've read, this looks like the wrong fix to me. basic.nack is described here: https://www.rabbitmq.com/nack.html, but I'm unfamiliar with the AMQP sources, so maybe someone could provide a direct link to source code at https://github.com/rabbitmq (presumably) where it's unambiguous as to which bit is which. Also, bit fields seem to be added to the protocol tree in right-to-left order instead of what I would consider the more natural left-to-right order. That is, bit fields are currently being added least-significant bit first rather than most-significant bit first. Do AMQP users like this right-to-left ordering? If not, then the requeue field should be added before the multiple field, and other changes in bit field order should be made as well, such as with the order of: hf_amqp_method_queue_delete_if_unused, hf_amqp_method_queue_delete_if_empty, and hf_amqp_method_queue_delete_nowait, etc. Reordering of the bits, if desired, is probably better as a separate enhancement request though. -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:[email protected]?subject=unsubscribe
[Wireshark-bugs] [Bug 16338] Amqp requeue param is incorrectly dissects and displayed .
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16338 Christopher Maynard changed: What|Removed |Added Attachment #17574|0 |1 is obsolete|| --- Comment #9 from Christopher Maynard --- Created attachment 17580 --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=17580&action=edit Capture file with requeue bit set to false, but Wireshark showing it as true because the multiple bit is true and Wireshark is using the wrong bitmask. Extracted all info.zip contents so capture files can be harvested, and image files are easier to preview. -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:[email protected]?subject=unsubscribe
[Wireshark-bugs] [Bug 16338] Amqp requeue param is incorrectly dissects and displayed .
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16338 --- Comment #8 from Christopher Maynard --- Created attachment 17579 --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=17579&action=edit Capture file with requeue bit set to true, but Wireshark showing the wrong bit. -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:[email protected]?subject=unsubscribe
[Wireshark-bugs] [Bug 16338] Amqp requeue param is incorrectly dissects and displayed .
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16338 --- Comment #7 from Christopher Maynard --- Created attachment 17578 --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=17578&action=edit Image with requeue bit set to false, but Wireshark showing it as true because the multiple bit is true and Wireshark is using the wrong bitmask.. -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:[email protected]?subject=unsubscribe
[Wireshark-bugs] [Bug 16338] Amqp requeue param is incorrectly dissects and displayed .
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16338 --- Comment #6 from Christopher Maynard --- Created attachment 17577 --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=17577&action=edit Image with requeue bit set to true, but Wireshark showing the wrong bit. -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:[email protected]?subject=unsubscribe
[Wireshark-bugs] [Bug 16338] Amqp requeue param is incorrectly dissects and displayed .
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16338 Jaap Keuter changed: What|Removed |Added CC||[email protected] --- Comment #5 from Jaap Keuter --- (Now with Alexis on CC) > Is the fix correct? If so Alexis, can you close the bug? Otherwise can you > fix it? -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:[email protected]?subject=unsubscribe
[Wireshark-bugs] [Bug 16338] Amqp requeue param is incorrectly dissects and displayed .
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16338 Dario Lombardo changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |IN_PROGRESS CC||[email protected] --- Comment #4 from Dario Lombardo --- Is the fix correct? If so Alexis, can you close the bug? Otherwise can you fix it? -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:[email protected]?subject=unsubscribe
[Wireshark-bugs] [Bug 16338] Amqp requeue param is incorrectly dissects and displayed .
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16338 --- Comment #3 from Gerrit Code Review --- Change 35846 merged by Anders Broman: amqp: wrong bitmask for amqp.method.arguments.multiple https://code.wireshark.org/review/35846 -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:[email protected]?subject=unsubscribe
[Wireshark-bugs] [Bug 16338] Amqp requeue param is incorrectly dissects and displayed .
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16338 --- Comment #2 from caowb <[email protected]> --- (In reply to Gerrit Code Review from comment #1) > Change 35846 had a related patch set uploaded by Alexis La Goutte: > amqp: wrong bitmask for amqp.method.arguments.multiple > > https://code.wireshark.org/review/35846 I'm not sure you fixed it correctly. Shouldn't it be `wrong bitmask for amqp.method.arguments.rerqueue`? -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:[email protected]?subject=unsubscribe
[Wireshark-bugs] [Bug 16338] Amqp requeue param is incorrectly dissects and displayed .
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16338 --- Comment #1 from Gerrit Code Review --- Change 35846 had a related patch set uploaded by Alexis La Goutte: amqp: wrong bitmask for amqp.method.arguments.multiple https://code.wireshark.org/review/35846 -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:[email protected]?subject=unsubscribe
