[Wireshark-bugs] [Bug 16388] LACP dissector consumes all octets to the end of the TVB and eth trailer dissector does not get called

2020-02-27 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16388

Jason Cohen  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16388] LACP dissector consumes all octets to the end of the TVB and eth trailer dissector does not get called

2020-02-25 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16388

Gerald Combs  changed:

   What|Removed |Added

Summary|lacp dissector consumes all |LACP dissector consumes all
   |octets to the end of the|octets to the end of the
   |TVB and eth trailer |TVB and eth trailer
   |dissector does not get  |dissector does not get
   |called  |called

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16388] lacp dissector consumes all octets to the end of the TVB and eth trailer dissector does not get called

2020-02-23 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16388

--- Comment #8 from Gerrit Code Review  ---
Change 36141 merged by Anders Broman:
packet-lacp: Report only the consumed octets

https://code.wireshark.org/review/36141

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16388] lacp dissector consumes all octets to the end of the TVB and eth trailer dissector does not get called

2020-02-23 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16388

--- Comment #7 from Gerrit Code Review  ---
Change 36142 merged by Anders Broman:
packet-lacp: Report only the consumed octets

https://code.wireshark.org/review/36142

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16388] lacp dissector consumes all octets to the end of the TVB and eth trailer dissector does not get called

2020-02-20 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16388

--- Comment #6 from Gerrit Code Review  ---
Change 36142 had a related patch set uploaded by Alexis La Goutte:
packet-lacp: Report only the consumed octets

https://code.wireshark.org/review/36142

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16388] lacp dissector consumes all octets to the end of the TVB and eth trailer dissector does not get called

2020-02-20 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16388

--- Comment #5 from Gerrit Code Review  ---
Change 36141 had a related patch set uploaded by Alexis La Goutte:
packet-lacp: Report only the consumed octets

https://code.wireshark.org/review/36141

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16388] lacp dissector consumes all octets to the end of the TVB and eth trailer dissector does not get called

2020-02-15 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16388

Jason Cohen  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16388] lacp dissector consumes all octets to the end of the TVB and eth trailer dissector does not get called

2020-02-15 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16388

--- Comment #4 from Jason Cohen  ---
Confirmed the same issue applies to 3.0 and 3.2.  The patch applies cleanly to
resolve.

Could this be pulled back to master-3.0 and master-3.2?

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16388] lacp dissector consumes all octets to the end of the TVB and eth trailer dissector does not get called

2020-02-15 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16388

--- Comment #3 from Gerrit Code Review  ---
Change 36096 merged by Anders Broman:
packet-lacp: Report only the consumed octets

https://code.wireshark.org/review/36096

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16388] lacp dissector consumes all octets to the end of the TVB and eth trailer dissector does not get called

2020-02-13 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16388

--- Comment #2 from Jason Cohen  ---
Now the same frame properly renders the ethernet trailer:

$ .tshark -r d1.pcap -Y "frame.number eq 151" -xO slow,lacp,f5ethtrailer
Frame 151: 254 bytes on wire (2032 bits), 254 bytes captured (2032 bits)
Ethernet II, Src: Cisco_11:71:da (8c:60:4f:11:71:da), Dst: Slow-Protocols
(01:80:c2:00:00:02)
802.1Q Virtual LAN, PRI: 0, DEI: 0, ID: 4094
Slow Protocols
Slow Protocols subtype: LACP (0x01)
Link Aggregation Control Protocol
LACP Version: 0x01
TLV Type: Actor Information (0x01)
TLV Length: 0x14
Actor System Priority: 1
Actor System ID: Cisco_ee:be:1a (00:23:04:ee:be:1a)
Actor Key: 32798
Actor Port Priority: 32768
Actor Port: 515
Actor State: 0x3d, LACP Activity, Aggregation, Synchronization, Collecting,
Distributing
 ...1 = LACP Activity: Active
 ..0. = LACP Timeout: Long Timeout
 .1.. = Aggregation: Aggregatable
 1... = Synchronization: In Sync
...1  = Collecting: Enabled
..1.  = Distributing: Enabled
.0..  = Defaulted: No
0...  = Expired: No
[Actor State Flags: **DCSG*A]
Reserved: 00
TLV Type: Partner Information (0x02)
TLV Length: 0x14
Partner System Priority: 3200
Partner System: F5Networ_50:0c:80 (f4:15:63:50:0c:80)
Partner Key: 2
Partner Port Priority: 10240
Partner Port: 10240
Partner State: 0x3c, Aggregation, Synchronization, Collecting, Distributing
 ...0 = LACP Activity: Passive
 ..0. = LACP Timeout: Long Timeout
 .1.. = Aggregation: Aggregatable
 1... = Synchronization: In Sync
...1  = Collecting: Enabled
..1.  = Distributing: Enabled
.0..  = Defaulted: No
0...  = Expired: No
[Partner State Flags: **DCSG**]
Reserved: 00
TLV Type: Collector Information (0x03)
TLV Length: 0x10
Collector Max Delay: 0
Reserved: 
TLV Type: Terminator (0x00)
TLV Length: 0x00
Pad:
…
F5 Ethernet Trailer Protocol
F5 Trailer Header - Version: 1
Magic: 0xf5deb0f5
Length: 126
Version: 1
Low Details
F5 Trailer Header, Provider: 1, Type: 1
Provider: 1
Type: 1
Trailer length: 31
Version: 2
Ingress: True (IN)
Slot (1-based): 1
TMM (0-based): 2
VIP name length: 19
VIP: :5.0:external_trunk
Medium Details
F5 Trailer Header, Provider: 1, Type: 2
Provider: 1
Type: 2
Trailer length: 40
Version: 4
Flow ID: 0x
Peer ID: 0x
Connflow Flags High Bits: 0x
Connflow Flags: 0x
Flow Type: 0x00
HA Unit: 0x00
Ingress Slot: 2
Ingress Port: 0
Priority: 0
High Details
F5 Trailer Header, Provider: 1, Type: 3
Provider: 1
Type: 3
Trailer length: 47
Version: 1
No peer connection information

  01 80 c2 00 00 02 8c 60 4f 11 71 da 81 00 0f fe   ...`O.q.
0010  88 09 01 01 01 14 00 01 00 23 04 ee be 1a 80 1e   .#..
0020  80 00 02 03 3d 00 00 00 02 14 0c 80 f4 15 63 50   =.cP
0030  0c 80 00 02 28 00 28 00 3c 00 00 00 03 10 00 00   (.(.<...
0040  00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00   
0050  00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00   
0060  00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00   
0070  00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00   
0080  f5 de b0 f5 00 7e 00 01 00 01 00 01 00 1f 00 02   .~..
0090  01 00 02 13 3a 35 2e 30 3a 65 78 74 65 72 6e 61   :5.0:externa
00a0  6c 5f 74 72 75 6e 6b 00 01 00 02 00 28 00 04 00   l_trunk.(...
00b0  00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00   
00c0  00 00 00 00 00 00 00 00 00 00 02 00 00 00 00 00   
00d0  01 00 03 00 2f 00 01 00 00 00 00 00 00 00 00 00   /...
00e0  00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00   
00f0  00 00 00 00 00 00 00 00 00 00 00 00 00 00 ..

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16388] lacp dissector consumes all octets to the end of the TVB and eth trailer dissector does not get called

2020-02-13 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16388

--- Comment #1 from Gerrit Code Review  ---
Change 36096 had a related patch set uploaded by Jason Cohen:
packet-lacp: Report only the consumed octets

https://code.wireshark.org/review/36096

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16388] lacp dissector consumes all octets to the end of the TVB and eth trailer dissector does not get called

2020-02-13 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16388

Jason Cohen  changed:

   What|Removed |Added

   Assignee|bugzilla-ad...@wireshark.or |kryojen...@gmail.com
   |g   |

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe