[Wireshark-bugs] [Bug 16780] Wireshark crashes while opening a capture

2020-08-15 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16780

--- Comment #10 from Iqbal Ahmad  ---
Great. Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:[email protected]?subject=unsubscribe

[Wireshark-bugs] [Bug 16780] Wireshark crashes while opening a capture

2020-08-15 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16780

--- Comment #9 from Pascal Quantin  ---
The fix is present in master and master-3.2 branches, and will be part of the
next official release.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:[email protected]?subject=unsubscribe

[Wireshark-bugs] [Bug 16780] Wireshark crashes while opening a capture

2020-08-15 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16780

--- Comment #8 from Iqbal Ahmad  ---
Ah...sorry, I did not understand it before. How can get I the latest fix? Is it
available in next release?

I can build it from source on CentOS-7. Please let me know from where I can get
the latest source along with your fix. Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:[email protected]?subject=unsubscribe

[Wireshark-bugs] [Bug 16780] Wireshark crashes while opening a capture

2020-08-15 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16780

--- Comment #7 from Pascal Quantin  ---
(In reply to Iqbal Ahmad from comment #6)
> I understand that the JSON is invalid. But I would expect Wireshark not to
> crash at any point. It can throw the packet as Malformed.

Which is why I fixed the crash. I simply gave the technical analysis before
pushing the fix, nothing more.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:[email protected]?subject=unsubscribe

[Wireshark-bugs] [Bug 16780] Wireshark crashes while opening a capture

2020-08-15 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16780

--- Comment #6 from Iqbal Ahmad  ---
I understand that the JSON is invalid. But I would expect Wireshark not to
crash at any point. It can throw the packet as Malformed.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:[email protected]?subject=unsubscribe

[Wireshark-bugs] [Bug 16780] Wireshark crashes while opening a capture

2020-08-14 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16780

Pascal Quantin  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|IN_PROGRESS |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:[email protected]?subject=unsubscribe

[Wireshark-bugs] [Bug 16780] Wireshark crashes while opening a capture

2020-08-14 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16780

--- Comment #3 from Gerrit Code Review  ---
Change 38160 merged by Pascal Quantin:
Check that at least one token exists to consider the JSON as valid

https://code.wireshark.org/review/38160

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:[email protected]?subject=unsubscribe

[Wireshark-bugs] [Bug 16780] Wireshark crashes while opening a capture

2020-08-14 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16780

--- Comment #4 from Gerrit Code Review  ---
Change 38161 had a related patch set uploaded by Pascal Quantin:
Check that at least one token exists to consider the JSON as valid

https://code.wireshark.org/review/38161

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:[email protected]?subject=unsubscribe

[Wireshark-bugs] [Bug 16780] Wireshark crashes while opening a capture

2020-08-14 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16780

--- Comment #5 from Gerrit Code Review  ---
Change 38161 merged by Pascal Quantin:
Check that at least one token exists to consider the JSON as valid

https://code.wireshark.org/review/38161

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:[email protected]?subject=unsubscribe

[Wireshark-bugs] [Bug 16780] Wireshark crashes while opening a capture

2020-08-14 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16780

--- Comment #2 from Gerrit Code Review  ---
Change 38160 had a related patch set uploaded by Pascal Quantin:
Check that at least one token exists to consider the JSON as valid

https://code.wireshark.org/review/38160

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:[email protected]?subject=unsubscribe

[Wireshark-bugs] [Bug 16780] Wireshark crashes while opening a capture

2020-08-14 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16780

--- Comment #1 from Pascal Quantin  ---
The crash is due to a malformed JSON content sent by the AMF in packet 31, taht
is actually rejected by the SMF in packet 32.
Wireshark also parses the JSON content to be able to decode the embedded 5GS
NAS PDU, NGAP paylaod, etc... but the parser does not report an error for a
JSON string containing only "}". We need to verify that at least one token
exists.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:[email protected]?subject=unsubscribe

[Wireshark-bugs] [Bug 16780] Wireshark crashes while opening a capture

2020-08-14 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16780

Pascal Quantin  changed:

   What|Removed |Added

 CC||[email protected]
 Ever confirmed|0   |1
 Status|UNCONFIRMED |IN_PROGRESS

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:[email protected]?subject=unsubscribe