[Wireshark-commits] master-3.2 f3cb256: camins: make sure the presence flags are set.

2020-05-01 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f3cb256e5df0d9896da1590fa6d03666df94e152 Submitter: "Guy Harris " Changed: branch: master-3.2 Repository: wireshark Commits: f3cb256 by Guy Harris (g...@alum.mit.edu): camins: make sure the presence flags are set.

[Wireshark-commits] master f0db074: camins: make sure the presence flags are set.

2020-05-01 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f0db07421f20b50f0630198cb249f37368b89186 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: f0db074 by Guy Harris (g...@alum.mit.edu): camins: make sure the presence flags are set.

[Wireshark-commits] master-3.0 5064830: camins: make sure the presence flags are set.

2020-05-01 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5064830e422109bb53fcaccc8837874652e25772 Submitter: "Guy Harris " Changed: branch: master-3.0 Repository: wireshark Commits: 5064830 by Guy Harris (g...@alum.mit.edu): camins: make sure the presence flags are set.

[Wireshark-commits] master 582ad24: Remove some single-SHB assumptions.

2020-05-01 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=582ad24c38713722695177fabafbd3d47ecb1d7d Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: 582ad24 by Guy Harris (g...@alum.mit.edu): Remove some single-SHB assumptions. Make wtap

[Wireshark-commits] master 3a32757: CMake: Fix FindGLIB2 for saner output

2020-05-01 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3a32757313e85368e88fdd9dbb82f839514569f5 Submitter: "Peter Wu " Changed: branch: master Repository: wireshark Commits: 3a32757 by João Valverde (joao.valve...@tecnico.ulisboa.pt): CMake: Fix FindGLIB2 for saner output

[Wireshark-commits] master 6b4c158: UFTP4: fix for tree display of uftp4.complete.reserved

2020-05-01 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6b4c158f003fe32900085ce5ec303467bcd99733 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 6b4c158 by Dennis Bush (b...@tcnj.edu): UFTP4: fix for tree display of uftp4.complete.reserved

[Wireshark-commits] master 3bb7d00: pcapng: have per-section interface tables rather than per-file.

2020-04-30 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3bb7d00d41e25f6832343ce54f3e554d392f2927 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: 3bb7d00 by Guy Harris (g...@alum.mit.edu): pcapng: have per-section interface tables rather than

[Wireshark-commits] master adb8fee: Qt: Allow renaming personal profile

2020-04-30 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=adb8feee6d505e36ef85bdd5b9fae6f9a7a07237 Submitter: "Roland Knall " Changed: branch: master Repository: wireshark Commits: adb8fee by Roland Knall (rkn...@gmail.com): Qt: Allow renaming personal profile If a p

[Wireshark-commits] master 07576e9: pcapng: clean up handling of current vs. new section.

2020-04-30 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=07576e9f3be231e5b53b0bd35357941266823354 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: 07576e9 by Guy Harris (g...@alum.mit.edu): pcapng: clean up handling of current vs. new section.

[Wireshark-commits] master ada193f: ieee80211: fix typo naqp => anqp

2020-04-30 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ada193f6adc58b85919aa9704cf5b26356ed7b5b Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: ada193f by Alexis La Goutte (alexis.lagou...@gmail.com): ieee80211: fix typo naqp => anqp

[Wireshark-commits] master 67f6809: pcapng: free up the section table when closing the file.

2020-04-30 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=67f6809d8b287a17c533dc2dc156c81b9f177817 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: 67f6809 by Guy Harris (g...@alum.mit.edu): pcapng: free up the section table when closing the fil

[Wireshark-commits] master 1e80803: Support reading mixed-byte-order pcapng files.

2020-04-30 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1e80803aa13bdcc6fde86e7f3a25dcd8c6d25fa9 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: 1e80803 by Guy Harris (g...@alum.mit.edu): Support reading mixed-byte-order pcapng files.

[Wireshark-commits] master 61d923d: bison/flex: comment why we ignore deprecated directive warning.

2020-04-30 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=61d923da39d46b45ccd55cd36aa739657be4369b Submitter: "Pascal Quantin " Changed: branch: master Repository: wireshark Commits: 61d923d by Anders Broman (anders.bro...@ericsson.com): bison/flex: comment why we ignore depr

[Wireshark-commits] master faa4399: pcapng: give a structure member an appropriate name.

2020-04-29 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=faa43991842ca770d7111fa4792863c99ac4dfa8 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: faa4399 by Guy Harris (g...@alum.mit.edu): pcapng: give a structure member an appropriate name.

[Wireshark-commits] master-3.0 8c667d8: pcapng: give a structure member an appropriate name.

2020-04-29 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8c667d846c3ff2e16a5cc84ff7297bb9e898dcb6 Submitter: "Guy Harris " Changed: branch: master-3.0 Repository: wireshark Commits: 8c667d8 by Guy Harris (g...@alum.mit.edu): pcapng: give a structure member an appropriate nam

[Wireshark-commits] master-2.6 09f354b: pcapng: give a structure member an appropriate name.

2020-04-29 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=09f354b820167ff7f2841543bbfa2a59273c9e21 Submitter: "Guy Harris " Changed: branch: master-2.6 Repository: wireshark Commits: 09f354b by Guy Harris (g...@alum.mit.edu): pcapng: give a structure member an appropriate nam

[Wireshark-commits] master-3.2 b7c31f7: pcapng: give a structure member an appropriate name.

2020-04-29 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b7c31f77f28d6432b158af48074ba2cd71ecadb3 Submitter: "Guy Harris " Changed: branch: master-3.2 Repository: wireshark Commits: b7c31f7 by Guy Harris (g...@alum.mit.edu): pcapng: give a structure member an appropriate nam

[Wireshark-commits] master-2.6 8d6ab4e: capinfos: fix absolute and relative time display.

2020-04-29 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8d6ab4ebe3130ad7ae2bc7d91db58f295619ca74 Submitter: "Guy Harris " Changed: branch: master-2.6 Repository: wireshark Commits: 8d6ab4e by Guy Harris (g...@alum.mit.edu): capinfos: fix absolute and relative time display.

[Wireshark-commits] master-3.0 49dace5: capinfos: fix absolute and relative time display.

2020-04-29 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=49dace5ec9949ea1f55746b90feb2171c89d4c51 Submitter: "Guy Harris " Changed: branch: master-3.0 Repository: wireshark Commits: 49dace5 by Guy Harris (g...@alum.mit.edu): capinfos: fix absolute and relative time display.

[Wireshark-commits] master-3.2 e7e52e9: DTLS: try harder to decrypt broken traces with double CCS

2020-04-29 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e7e52e9b0d35e9d7eb7eddfa3bc027ace0dfece6 Submitter: "Peter Wu " Changed: branch: master-3.2 Repository: wireshark Commits: e7e52e9 by Peter Wu (pe...@lekensteyn.nl): DTLS: try harder to decrypt broken traces with doubl

[Wireshark-commits] master-3.2 d863846: capinfos: fix absolute and relative time display.

2020-04-29 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d8638463819bedf221ffcb8a15131efce0faf1b4 Submitter: "Guy Harris " Changed: branch: master-3.2 Repository: wireshark Commits: d863846 by Guy Harris (g...@alum.mit.edu): capinfos: fix absolute and relative time display.

[Wireshark-commits] master 928bbf5: capinfos: fix absolute and relative time display.

2020-04-29 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=928bbf5984ee8b81e960c3d53c1d8d2e1bc2bdbf Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: 928bbf5 by Guy Harris (g...@alum.mit.edu): capinfos: fix absolute and relative time display.

[Wireshark-commits] master 0eb92d7: Document unit string and true false string helper functions

2020-04-29 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0eb92d7aa0fca23cafb675f6140861206ba48101 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 0eb92d7 by Jaap Keuter (jaap.keu...@xs4all.nl): Document unit string and true false string hel

[Wireshark-commits] master 7bd3f8a: LteMacStatisticsDialog: fix memory leaks

2020-04-28 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7bd3f8a58f8512232288c5390ed3ca367d6ed7c7 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 7bd3f8a by Martin Kaiser (wiresh...@kaiser.cx): LteMacStatisticsDialog: fix memory leaks

[Wireshark-commits] master 8025250: WlanStatisticsDialog: fix memory leaks

2020-04-28 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=80252503132e93d3cb615e667a74e20854f78f20 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 8025250 by Martin Kaiser (wiresh...@kaiser.cx): WlanStatisticsDialog: fix memory leaks

[Wireshark-commits] master b7ea495: CMake: Increase our AsciidoctrJ JVM memory limits.

2020-04-28 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b7ea495e2e583ba11aa1f156c659f5503cd03465 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: b7ea495 by Gerald Combs (ger...@wireshark.org): CMake: Increase our AsciidoctrJ JVM memory lim

[Wireshark-commits] master 76a69be: If possible use proto_tree_add_item(), not proto_tree_add_bytes_item().

2020-04-28 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=76a69be324fd109bec2c4693e4ab57b9bc140c58 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: 76a69be by Guy Harris (g...@alum.mit.edu): If possible use proto_tree_add_item(), not proto_tree_

[Wireshark-commits] master 50806f2: Qt: workaround a C4138 warning generated by MSVC2019

2020-04-28 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=50806f2f1be9f7c3a6e37f29a8f5a8bcf83f0c28 Submitter: "Gerald Combs " Changed: branch: master Repository: wireshark Commits: 50806f2 by Pascal Quantin (pas...@wireshark.org): Qt: workaround a C4138 warning generated by M

[Wireshark-commits] master f867d12: Peekremote : modified the peekremote dissector to support 11ax

2020-04-28 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f867d127ecef383089ee11bd8c6d01fc1e5faccc Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: f867d12 by Nicolas Darchis (ndarc...@cisco.com): Peekremote : modified the peekremote dissecto

[Wireshark-commits] master c24286a: 3GPP: Update Geographical Area Description (GAD).

2020-04-28 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c24286a9caa4530de1be14eba3e95ce868b7837a Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: c24286a by Anders Broman (anders.bro...@ericsson.com): 3GPP: Update Geographical Area Descript

[Wireshark-commits] master 99ecab4: New dissector: Dynamic Link Exchange Protocol

2020-04-27 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=99ecab4122970d1d9f5591ab4dc1a7360123e0e9 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 99ecab4 by Uli Heilmeier (u...@heilmeier.eu): New dissector: Dynamic Link Exchange Protocol

[Wireshark-commits] master e4aeb1d: Clean up the encoding value definitions.

2020-04-27 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e4aeb1d2bb4a2f0559f6ee938de45b7f42d82fa3 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: e4aeb1d by Guy Harris (g...@alum.mit.edu): Clean up the encoding value definitions. Grou

[Wireshark-commits] master 5f80801: RTSP/SDP: Fix parsing error for H264:sprop-parameter-sets

2020-04-27 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5f80801adda1b59f714373cfc636893d7aea41f1 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 5f80801 by Sergey Bogdanov (sergey.bogda...@astrosoft.ru): RTSP/SDP: Fix parsing error for H26

[Wireshark-commits] master 9eaf9a5: proto(.h): fix parameter (it is pi not it) like on proto.c

2020-04-27 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9eaf9a5648adaef573c45ab9c4a2e31bb31f81df Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 9eaf9a5 by Alexis La Goutte (alexis.lagou...@gmail.com): proto(.h): fix parameter (it is pi no

[Wireshark-commits] master 56e9110: ICMPv6: Add PREF64 (RFC8781) Option

2020-04-27 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=56e9110e09d61c71fb193119d27bf074da4a8241 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 56e9110 by Alexis La Goutte (alexis.lagou...@gmail.com): ICMPv6: Add PREF64 (RFC8781) Option

[Wireshark-commits] master-3.2 d5399b7: Qt: Fix export of dissection

2020-04-27 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d5399b7279e38e61e75f7aa266ca7d1aaedbe3c0 Submitter: "Gerald Combs " Changed: branch: master-3.2 Repository: wireshark Commits: d5399b7 by Roland Knall (rkn...@gmail.com): Qt: Fix export of dissection Exporting

[Wireshark-commits] master 7fcac9c: Qt: Fix export of dissection

2020-04-27 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7fcac9c955af94f0d046e985278ea41936a3b1a2 Submitter: "Gerald Combs " Changed: branch: master Repository: wireshark Commits: 7fcac9c by Roland Knall (rkn...@gmail.com): Qt: Fix export of dissection Exporting dis

[Wireshark-commits] master ca4cc6a: proto(.h): fix -Wdocumentation

2020-04-27 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ca4cc6a34fe23b9b7c01573c2e87bf2d5ff15d44 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: ca4cc6a by Alexis La Goutte (alexis.lagou...@gmail.com): proto(.h): fix -Wdocumentation

[Wireshark-commits] master 6d0863e: dissectors: add ScyllaDB dissector

2020-04-27 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6d0863eecbde53b4898ab42908a6f75a4dc65191 Submitter: "Martin Mathieson " Changed: branch: master Repository: wireshark Commits: 6d0863e by Piotr Sarna (sa...@scylladb.com): dissectors: add ScyllaDB dissector Th

[Wireshark-commits] master 1aba122: openflow_v6: OFPMP_FLOW_DESC multipart req rep has an array of ofp_flow_desc.

2020-04-27 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1aba12265eacf5b9a4942f3a7ecdd893f5157a88 Submitter: "Alexis La Goutte " Changed: branch: master Repository: wireshark Commits: 1aba122 by Lichen Liu (llc1234...@gmail.com): openflow_v6: OFPMP_FLOW_DESC multipart req re

[Wireshark-commits] master 524baee: Add string encoding values for various BCD encodings, and use them.

2020-04-26 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=524baee94fd8fab0ce4ba212ef35f39e81a386c0 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: 524baee by Guy Harris (g...@alum.mit.edu): Add string encoding values for various BCD encodings,

[Wireshark-commits] master 94556ca: doc: document another character encoding.

2020-04-26 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=94556ca7a2502f820e2884550b153d06997b9384 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: 94556ca by Guy Harris (g...@alum.mit.edu): doc: document another character encoding. Cha

[Wireshark-commits] master bf7aa77: doc: Add some new character encodings.

2020-04-26 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bf7aa7710c348e4b4d79a77c58e4774fac2596ff Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: bf7aa77 by Guy Harris (g...@alum.mit.edu): doc: Add some new character encodings. They w

[Wireshark-commits] master-2.6 56bef3f: Docs+help: Remove "-m".

2020-04-26 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=56bef3f9be635b18f5f31a0b775346bfdad23eab Submitter: "Gerald Combs " Changed: branch: master-2.6 Repository: wireshark Commits: 56bef3f by Gerald Combs (ger...@wireshark.org): Docs+help: Remove "-m". Support fo

[Wireshark-commits] master 7fcc19a: tls: Add EC J-PAKE Key Exchange Params

2020-04-26 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7fcc19a373b61eadf4d4c8fd506713c42a66b8ab Submitter: "Stig Bjørlykke " Changed: branch: master Repository: wireshark Commits: 7fcc19a by Stig Bjørlykke (s...@bjorlykke.org): tls: Add EC J-PAKE Key Exchange Params

[Wireshark-commits] master-3.0 06d9c48: Docs+help: Remove "-m".

2020-04-26 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=06d9c48f93eb26b8a50016b68b4087c1e2f85c29 Submitter: "Guy Harris " Changed: branch: master-3.0 Repository: wireshark Commits: 06d9c48 by Gerald Combs (ger...@wireshark.org): Docs+help: Remove "-m". Support for

[Wireshark-commits] master-2.6 29bf08c: [Automatic update for 2020-04-26]

2020-04-26 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=29bf08c16566bb1a98c906edc4645811ec0979b7 Submitter: "Gerald Combs " Changed: branch: master-2.6 Repository: wireshark Commits: 29bf08c by Gerald Combs (ger...@wireshark.org): [Automatic update for 2020-04-26]

[Wireshark-commits] master-3.0 26df31a: [Automatic update for 2020-04-26]

2020-04-26 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=26df31a47be6cb3c4ad24ea5978a635c1f55c728 Submitter: "Gerald Combs " Changed: branch: master-3.0 Repository: wireshark Commits: 26df31a by Gerald Combs (ger...@wireshark.org): [Automatic update for 2020-04-26]

[Wireshark-commits] master-3.0 4d646e5: false isn't defined in this release; use FALSE instead.

2020-04-26 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4d646e5f259625ec96f82b3f491dc6f9f44df2bf Submitter: "Guy Harris " Changed: branch: master-3.0 Repository: wireshark Commits: 4d646e5 by Guy Harris (g...@alum.mit.edu): false isn't defined in this release; use FALSE ins

[Wireshark-commits] master-3.2 b901168: [Automatic update for 2020-04-26]

2020-04-26 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b9011680e52864eb78727b91b2889c8f6a0eef4a Submitter: "Gerald Combs " Changed: branch: master-3.2 Repository: wireshark Commits: b901168 by Gerald Combs (ger...@wireshark.org): [Automatic update for 2020-04-26]

[Wireshark-commits] master-2.6 b82c7ba: false isn't defined in this release; use FALSE instead.

2020-04-26 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b82c7ba32baa5c76e08c46dcfaca3b29cc00cf32 Submitter: "Guy Harris " Changed: branch: master-2.6 Repository: wireshark Commits: b82c7ba by Guy Harris (g...@alum.mit.edu): false isn't defined in this release; use FALSE ins

[Wireshark-commits] master 4149f3e: [Automatic update for 2020-04-26]

2020-04-26 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4149f3e5bd6f42e8cff488435855607680a92492 Submitter: "Gerald Combs " Changed: branch: master Repository: wireshark Commits: 4149f3e by Gerald Combs (ger...@wireshark.org): [Automatic update for 2020-04-26] Upda

[Wireshark-commits] master-2.6 88bdf25: nfs: Initialize the fs_cycle element of an nfs_name_snoop_t.

2020-04-26 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=88bdf254ce1ca56cb14511286f65216d23769e7f Submitter: "Guy Harris " Changed: branch: master-2.6 Repository: wireshark Commits: 88bdf25 by Guy Harris (g...@alum.mit.edu): nfs: Initialize the fs_cycle element of an nfs_nam

[Wireshark-commits] master-3.2 e3257d7: nfs: Initialize the fs_cycle element of an nfs_name_snoop_t.

2020-04-26 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e3257d7cd2a533ad8b68236b250ba892f7ae6e36 Submitter: "Guy Harris " Changed: branch: master-3.2 Repository: wireshark Commits: e3257d7 by Guy Harris (g...@alum.mit.edu): nfs: Initialize the fs_cycle element of an nfs_nam

[Wireshark-commits] master-3.0 dcb2760: nfs: Initialize the fs_cycle element of an nfs_name_snoop_t.

2020-04-26 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dcb2760553ff8c7ef776db4abe182eb16c300472 Submitter: "Guy Harris " Changed: branch: master-3.0 Repository: wireshark Commits: dcb2760 by Guy Harris (g...@alum.mit.edu): nfs: Initialize the fs_cycle element of an nfs_nam

[Wireshark-commits] master 3abdb96: nfs: Initialize the fs_cycle element of an nfs_name_snoop_t.

2020-04-26 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3abdb967aefc550de92f2ab0b5d3a49207b2ac58 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: 3abdb96 by Guy Harris (g...@alum.mit.edu): nfs: Initialize the fs_cycle element of an nfs_name_sn

[Wireshark-commits] master e38e2df: WSDG: Expand the zero window description.

2020-04-25 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e38e2df5a2b2bcc1c3fab83b9363049d2490d6f0 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: e38e2df by Gerald Combs (ger...@wireshark.org): WSDG: Expand the zero window description.

[Wireshark-commits] master a1266a6: MSRP: Support TCP defragmentation in MSRP

2020-04-25 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a1266a6363e6384fc93e67e0598c010e675fc611 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: a1266a6 by Kevin Hausman (kevin.haus...@sentaca.com): MSRP: Support TCP defragmentation in MS

[Wireshark-commits] master d8137cc: ProfileTreeView: fix a memory leak

2020-04-25 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d8137cc1be55f084b99332b967d1d1cab9324d5b Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: d8137cc by Martin Kaiser (wiresh...@kaiser.cx): ProfileTreeView: fix a memory leak In

[Wireshark-commits] master 64b6b68: TCPStreamDialog: prevent access to uninitialized memory

2020-04-25 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=64b6b68efa317802a8718b0b4ca227694594b1a3 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 64b6b68 by Martin Kaiser (wiresh...@kaiser.cx): TCPStreamDialog: prevent access to uninitializ

[Wireshark-commits] master 17298cc: DTLS: try harder to decrypt broken traces with double CCS

2020-04-25 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=17298cc0fbe1655ee07db54457f476f0799b8152 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 17298cc by Peter Wu (pe...@lekensteyn.nl): DTLS: try harder to decrypt broken traces with doub

[Wireshark-commits] master-3.2 3ba3dad: DIS: dissector fix for Articulated Part VP records.

2020-04-25 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3ba3dadfb2e430d66d2a3f632053944319060b8c Submitter: "Anders Broman " Changed: branch: master-3.2 Repository: wireshark Commits: 3ba3dad by Bert van Leeuwen (bert.vanleeu...@gmail.com): DIS: dissector fix for Articulate

[Wireshark-commits] master 3485ad6: travis: fix macOS build.

2020-04-25 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3485ad6d1c8417ec9c4501c0cb7badb07640d984 Submitter: "Dario Lombardo " Changed: branch: master Repository: wireshark Commits: 3485ad6 by Dario Lombardo (lom...@gmail.com): travis: fix macOS build. Use the toolc

[Wireshark-commits] master 5a854b8: DIS: dissector fix for Articulated Part VP records.

2020-04-25 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5a854b882fd90f97e20539568e8277f12a98c342 Submitter: "Jaap Keuter " Changed: branch: master Repository: wireshark Commits: 5a854b8 by Bert van Leeuwen (bert.vanleeu...@gmail.com): DIS: dissector fix for Articulated Part

[Wireshark-commits] master-3.2 1409d1f: Docs+help: Remove "-m".

2020-04-25 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1409d1f4f04c929852e333f9a546d1d707244f48 Submitter: "Gerald Combs " Changed: branch: master-3.2 Repository: wireshark Commits: 1409d1f by Gerald Combs (ger...@wireshark.org): Docs+help: Remove "-m". Support fo

[Wireshark-commits] master d2824f4: Fix display of header length and timestamps in UFTP4

2020-04-25 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d2824f4820f662ccddea08455ea903de69a87072 Submitter: "Jaap Keuter " Changed: branch: master Repository: wireshark Commits: d2824f4 by Dennis Bush (b...@tcnj.edu): Fix display of header length and timestamps in UFTP4

[Wireshark-commits] master 10be281: Docs: Switch from [float] to [discrete].

2020-04-25 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=10be2814fc267e463f42786510779c972c825cb0 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 10be281 by Gerald Combs (ger...@wireshark.org): Docs: Switch from [float] to [discrete].

[Wireshark-commits] master 7cbdab7: WSUG: Name resolution updates.

2020-04-25 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7cbdab776f97b64296886eb6cbbacb3b11777fda Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 7cbdab7 by Gerald Combs (ger...@wireshark.org): WSUG: Name resolution updates. Update

[Wireshark-commits] master dddb086: Docs+help: Remove "-m".

2020-04-25 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dddb086f58db0825b959e4e7b4c2ccea11dc4d0b Submitter: "Jaap Keuter " Changed: branch: master Repository: wireshark Commits: dddb086 by Gerald Combs (ger...@wireshark.org): Docs+help: Remove "-m". Support for the

[Wireshark-commits] master 6158e89: WSUG: Describe the advanced preferences.

2020-04-25 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6158e89f1989cec43629bb214fb884bc7724408a Submitter: "Jaap Keuter " Changed: branch: master Repository: wireshark Commits: 6158e89 by Gerald Combs (ger...@wireshark.org): WSUG: Describe the advanced preferences.

[Wireshark-commits] master 3460bd7: UDPCP: Use g_direct_hash() and g_direct_equal() for reassembly

2020-04-25 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3460bd70b532616b9900135b84d7e2dd68b0aacb Submitter: "Martin Mathieson " Changed: branch: master Repository: wireshark Commits: 3460bd7 by Martin Mathieson (martin.r.mathie...@googlemail.com): UDPCP: Use g_direct_hash()

[Wireshark-commits] master 9f03cde: Add a routine to get the representation of a protocol tree item and use it.

2020-04-24 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9f03cde5a55dd2f3ffba23935c1ccb8b02f0ffe6 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: 9f03cde by Guy Harris (g...@alum.mit.edu): Add a routine to get the representation of a protocol

[Wireshark-commits] master 9750d00: Introduce tfs_get_string helper

2020-04-24 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9750d00ff10bc344a2b1dcc69ee34d09a7ce76d0 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 9750d00 by Jaap Keuter (jaap.keu...@xs4all.nl): Introduce tfs_get_string helper true_

[Wireshark-commits] master c9295f1: isakmp: clean up EMERGENCY_CALL_NUMBER dissection.

2020-04-24 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c9295f161c4a6275faa98a77a3a81380e01b34d8 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: c9295f1 by Guy Harris (g...@alum.mit.edu): isakmp: clean up EMERGENCY_CALL_NUMBER dissection.

[Wireshark-commits] master-3.0 af1b4cc: Check the validator in ExtArgText::isValid().

2020-04-24 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=af1b4cc2e8acb172813719fabbf87d6e727bf471 Submitter: "Guy Harris " Changed: branch: master-3.0 Repository: wireshark Commits: af1b4cc by Guy Harris (g...@alum.mit.edu): Check the validator in ExtArgText::isValid().

[Wireshark-commits] master-3.2 3f4e014: Check the validator in ExtArgText::isValid().

2020-04-24 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3f4e014dc182f664d0268570258cd72968bc25f7 Submitter: "Guy Harris " Changed: branch: master-3.2 Repository: wireshark Commits: 3f4e014 by Guy Harris (g...@alum.mit.edu): Check the validator in ExtArgText::isValid().

[Wireshark-commits] master ba50c5a: Check the validator in ExtArgText::isValid().

2020-04-24 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ba50c5a5f6b0edb6b06496de9c3f9d5b18f6cd1e Submitter: "Roland Knall " Changed: branch: master Repository: wireshark Commits: ba50c5a by Guy Harris (g...@alum.mit.edu): Check the validator in ExtArgText::isValid().

[Wireshark-commits] master 48f87bc: unit_strings.c: Prepend space before dB related unit strings

2020-04-24 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=48f87bc3ee504f0bf9c9c2812d090ea3fca39566 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 48f87bc by Pau Espin Pedrol (pes...@sysmocom.de): unit_strings.c: Prepend space before dB rela

[Wireshark-commits] master a814b0c: OsmoTRX: Fix unused ei entry ei_otrxc_unknown_dir

2020-04-23 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a814b0c626ff24e229bca9cefe1bb313a1e7229e Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: a814b0c by Pau Espin Pedrol (pes...@sysmocom.de): OsmoTRX: Fix unused ei entry ei_otrxc_unknow

[Wireshark-commits] master 3631529: OsmoTRX: use unit_name_string_get_value() to print unit string

2020-04-23 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=363152916e288f3d75e8e7d0083ec6e428fdc69b Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 3631529 by Pau Espin Pedrol (pes...@sysmocom.de): OsmoTRX: use unit_name_string_get_value() to

[Wireshark-commits] master 4b503b1: Add a comment explaining why we treat OUI_HP_2 specially.

2020-04-23 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4b503b1f0e8984059f8541f62ec76e7a65443a37 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: 4b503b1 by Guy Harris (g...@alum.mit.edu): Add a comment explaining why we treat OUI_HP_2 special

[Wireshark-commits] master 485476d: OsmoTRX: Use units from unit_strings.{c, h}

2020-04-23 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=485476d0d2abaeca35473192011063572a7b9ecd Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 485476d by Pau Espin Pedrol (pes...@sysmocom.de): OsmoTRX: Use units from unit_strings.{c,h}

[Wireshark-commits] master 6bc1962: PFCP: Fix encoding of PFD Contents IE

2020-04-23 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6bc19621bc355ad9d3625ff5a4f9e2ba95b6eb19 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 6bc1962 by Yoshiyuki Kurauchi (ahochauwaa...@gmail.com): PFCP: Fix encoding of PFD Contents IE

[Wireshark-commits] master 30f4f1b: Qt: update import via GUI to match import features using text2pcap

2020-04-22 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=30f4f1b0560fbd67867a38bf5e418aac67abc3eb Submitter: "Peter Wu " Changed: branch: master Repository: wireshark Commits: 30f4f1b by Andre Luyer (an...@luyer.nl): Qt: update import via GUI to match import features using t

[Wireshark-commits] master dc4a5b5: LISP: add support for Distinguished Name AFI

2020-04-22 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dc4a5b5addcf990589f7a1afa6963d9de9a5f2b2 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: dc4a5b5 by Lorand Jakab (lja...@ac.upc.edu): LISP: add support for Distinguished Name AFI

[Wireshark-commits] master 569deb7: PFCP: Fix lengths of fields in Remote GTP-U Peer

2020-04-22 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=569deb7215937270e93361b42f549c6c1fbb6d60 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 569deb7 by Yoshiyuki Kurauchi (ahochauwaa...@gmail.com): PFCP: Fix lengths of fields in Remote

[Wireshark-commits] master 2a64d97: http2: Replace deprecated function.

2020-04-22 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2a64d97d8c5cbc22aa63fbe86e773564915b43b8 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 2a64d97 by Anders Broman (anders.bro...@ericsson.com): http2: Replace deprecated function.

[Wireshark-commits] master 9e4a704: WSDG: Edits to 'How Wireshark Works'

2020-04-22 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9e4a70411501a3bbca2403faa3428014ae085c23 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 9e4a704 by Moshe Kaplan (m...@moshekaplan.com): WSDG: Edits to 'How Wireshark Works'

[Wireshark-commits] master 3a42f53: JDWP dissector for TCP transport

2020-04-22 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3a42f536ed7dff6bf04cbb2b6fbf9c69f4267f59 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 3a42f53 by Eugene Adell (eugene.ad...@gmail.com): JDWP dissector for TCP transport Bu

[Wireshark-commits] master 9132feb: synphasor: refactor style and add some improvements

2020-04-22 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9132feb4a4da8453b490f863caaeb260bc31cb27 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 9132feb by Dmitriy Eliseev (elisee...@ntcees.ru): synphasor: refactor style and add some impro

[Wireshark-commits] master 9748e8a: IEC104: Add dissection of reset process command C_RP_NA_1

2020-04-22 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9748e8a315fbc59e5660ee0ff4ae0eb46828a967 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 9748e8a by Jiří Engelthaler (eng...@gmail.com): IEC104: Add dissection of reset process comman

[Wireshark-commits] master b1668e7: NFS: fix dissecting of READ_PLUS contents

2020-04-21 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b1668e77e48abbce9d82941ab0dde848b13791fa Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: b1668e7 by Jorge Mora (jmora1...@gmail.com): NFS: fix dissecting of READ_PLUS contents

[Wireshark-commits] master e74ce4e: Qt: Fix compilation error

2020-04-21 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e74ce4e1bc22c2be3e9f39c68fdd89d3fc8d0277 Submitter: "Roland Knall " Changed: branch: master Repository: wireshark Commits: e74ce4e by Roland Knall (rkn...@gmail.com): Qt: Fix compilation error and also remove

[Wireshark-commits] master 9c75c1d: Qt: Allow folders for filter buttons

2020-04-21 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9c75c1dc18199ea6b282177e21fe1d445af5bbb3 Submitter: "Roland Knall " Changed: branch: master Repository: wireshark Commits: 9c75c1d by Roland Knall (rkn...@gmail.com): Qt: Allow folders for filter buttons Filte

[Wireshark-commits] master d10817c: mac-lte: fix no previous prototype for function

2020-04-21 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d10817ce02c837765a050c006904765275d15e8d Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: d10817c by Alexis La Goutte (alexis.lagou...@gmail.com): mac-lte: fix no previous prototype fo

[Wireshark-commits] master 0c3729a: lwm2m: fix no previous prototype for function

2020-04-20 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0c3729a688f8dc4098652c0ae4ff85e9ded4a135 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 0c3729a by Alexis La Goutte (alexis.lagou...@gmail.com): lwm2m: fix no previous prototype for

[Wireshark-commits] master 6736b8f: Add a newline at the end of the file.

2020-04-20 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6736b8f281553a469e0d3aeae719b8d100d8c4dc Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: 6736b8f by Guy Harris (g...@alum.mit.edu): Add a newline at the end of the file. Change-

[Wireshark-commits] master 76b530e: eth: require padding to be zeros by default

2020-04-20 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=76b530eb6acb1efa4e28254325a8ab4dac6b7db3 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 76b530e by Jason Cohen (j.co...@f5.com): eth: require padding to be zeros by default

[Wireshark-commits] master 15b53b6: wireshark_zip_helper(Qt): fix no previous prototype for function

2020-04-20 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=15b53b6892076a4e19ca2b8f21771cd6ce0b2115 Submitter: "Gerald Combs " Changed: branch: master Repository: wireshark Commits: 15b53b6 by Alexis La Goutte (alexis.lagou...@gmail.com): wireshark_zip_helper(Qt): fix no previ

[Wireshark-commits] master c0069d9: http2: Use proto_tree_add_bitmask_with_flags_ret_uint64() to dis flags.

2020-04-20 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c0069d9676e71681d01ccb0da2f9caee5976c076 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: c0069d9 by Anders Broman (anders.bro...@ericsson.com): http2: Use proto_tree_add_bitmask_with_

<    7   8   9   10   11   12   13   14   15   16   >