[Wireshark-commits] master-2.0 5b9790d: One of the new routines is static; declare it.

2017-03-31 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5b9790d0bf004fe0acc543675a826be800da4d70 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master-2.0 Repository: wireshark Commits: 5b9790d by Guy Harris (g...@alum.mit.edu): One of the new routines is

[Wireshark-commits] buildbot failure in Wireshark 2.0 on Windows Server 2012 R2 x64

2017-03-31 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 while building wireshark. Full details are available at: http://buildbot.wireshark.org/wireshark-2.0/builders/Windows%20Server%202012%20R2%20x64/builds/573 Buildbot URL:

[Wireshark-commits] buildbot failure in Wireshark 2.2 on Windows 8.1 x86

2017-03-31 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder Windows 8.1 x86 while building wireshark. Full details are available at: http://buildbot.wireshark.org/wireshark-2.2/builders/Windows%208.1%20x86/builds/521 Buildbot URL: http://buildbot.wireshark.org/wireshark-2.2/ Buildslave for this

[Wireshark-commits] buildbot failure in Wireshark 2.0 on Windows 8.1 x86

2017-03-31 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder Windows 8.1 x86 while building wireshark. Full details are available at: http://buildbot.wireshark.org/wireshark-2.0/builders/Windows%208.1%20x86/builds/1219 Buildbot URL: http://buildbot.wireshark.org/wireshark-2.0/ Buildslave for this

[Wireshark-commits] buildbot failure in Wireshark 2.0 on OSX 10.7 x64

2017-03-31 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder OSX 10.7 x64 while building wireshark. Full details are available at: http://buildbot.wireshark.org/wireshark-2.0/builders/OSX%2010.7%20x64/builds/1233 Buildbot URL: http://buildbot.wireshark.org/wireshark-2.0/ Buildslave for this Build:

[Wireshark-commits] buildbot failure in Wireshark 2.2 on Ubuntu 16.04 x64

2017-03-31 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder Ubuntu 16.04 x64 while building wireshark. Full details are available at: http://buildbot.wireshark.org/wireshark-2.2/builders/Ubuntu%2016.04%20x64/builds/470 Buildbot URL: http://buildbot.wireshark.org/wireshark-2.2/ Buildslave for this

[Wireshark-commits] buildbot failure in Wireshark 2.0 on Ubuntu 16.04 x64

2017-03-31 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder Ubuntu 16.04 x64 while building wireshark. Full details are available at: http://buildbot.wireshark.org/wireshark-2.0/builders/Ubuntu%2016.04%20x64/builds/289 Buildbot URL: http://buildbot.wireshark.org/wireshark-2.0/ Buildslave for this

[Wireshark-commits] buildbot failure in Wireshark 2.2 on OSX 10.7 x64

2017-03-31 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder OSX 10.7 x64 while building wireshark. Full details are available at: http://buildbot.wireshark.org/wireshark-2.2/builders/OSX%2010.7%20x64/builds/518 Buildbot URL: http://buildbot.wireshark.org/wireshark-2.2/ Buildslave for this Build:

[Wireshark-commits] buildbot failure in Wireshark 2.0 on OSX 10.6 x86

2017-03-31 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder OSX 10.6 x86 while building wireshark. Full details are available at: http://buildbot.wireshark.org/wireshark-2.0/builders/OSX%2010.6%20x86/builds/1226 Buildbot URL: http://buildbot.wireshark.org/wireshark-2.0/ Buildslave for this Build:

[Wireshark-commits] master-2.0 5057c8f: Fix some dissection errors.

2017-03-31 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5057c8f31c654d3010c907a3b9dd174792a5dac4 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master-2.0 Repository: wireshark Commits: 5057c8f by Guy Harris (g...@alum.mit.edu): Fix some dissection errors.

[Wireshark-commits] master-2.2 545e648: Fix some dissection errors.

2017-03-31 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=545e6483dd0ca3125ee5fe620cfbe32415c7766d Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master-2.2 Repository: wireshark Commits: 545e648 by Guy Harris (g...@alum.mit.edu): Fix some dissection errors.

[Wireshark-commits] master-2.0 b4feea7: This is now an FT_STRING elsewhere, so make it one here.

2017-03-31 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b4feea73f26ba8510f570846f8a6bb50801cb927 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master-2.0 Repository: wireshark Commits: b4feea7 by Guy Harris (g...@alum.mit.edu): This is now an FT_STRING

[Wireshark-commits] master-2.2 879d976: You can't get a string value from an FT_NONE string.

2017-03-31 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=879d976b98111daf54fe3b35b23cf3fa5e69f49a Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master-2.2 Repository: wireshark Commits: 879d976 by Guy Harris (g...@alum.mit.edu): You can't get a string value

[Wireshark-commits] master aa82f52: You can't get a string value from an FT_NONE string.

2017-03-31 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=aa82f522c28134463b223bc1eaa5d1fd6cd9d9cd Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: aa82f52 by Guy Harris (g...@alum.mit.edu): You can't get a string value from an

[Wireshark-commits] buildbot failure in Wireshark 2.2 on Windows Server 2012 R2 x64

2017-03-31 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 while building wireshark. Full details are available at: http://buildbot.wireshark.org/wireshark-2.2/builders/Windows%20Server%202012%20R2%20x64/builds/536 Buildbot URL:

[Wireshark-commits] master-2.0 0a30922: Provide better error messages for field type mismatches.

2017-03-31 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0a309226153d8806cba8b18f476ce2bfb2eede84 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master-2.0 Repository: wireshark Commits: 0a30922 by Guy Harris (g...@alum.mit.edu): Provide better error messages

[Wireshark-commits] master-2.2 7fa6f59: Provide better error messages for field type mismatches.

2017-03-31 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7fa6f59f840b5dd6644205a3efba8b7a8a280233 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master-2.2 Repository: wireshark Commits: 7fa6f59 by Guy Harris (g...@alum.mit.edu): Provide better error messages

[Wireshark-commits] master 19bb1b1: Provide better error messages for field type mismatches.

2017-03-31 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=19bb1b128b0e8fdbff0959a00ea062a34fbadfb4 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: 19bb1b1 by Guy Harris (g...@alum.mit.edu): Provide better error messages for

[Wireshark-commits] master d967d71: FT_CHAR is an integral type, so list it in the diagnostic message.

2017-03-31 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d967d71d98f20dbd107594e7605b13ea28cfe982 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: d967d71 by Guy Harris (g...@alum.mit.edu): FT_CHAR is an integral type, so list

[Wireshark-commits] master 6a67209: ieee80211: Fix parsing of supported operating classes IE

2017-03-31 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6a67209bff51c6e75e959bee27b29c0ebdd7882b Submitter: Michael Mann (mman...@netscape.net) Changed: branch: master Repository: wireshark Commits: 6a67209 by Mikael Kanstrup (mikael.kanst...@gmail.com): ieee80211: Fix

[Wireshark-commits] master d57f03c: Add citrix mep dissectors

2017-03-31 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d57f03ce0f747f251dd34f2bbe70e45667aa8a09 Submitter: Michael Mann (mman...@netscape.net) Changed: branch: master Repository: wireshark Commits: d57f03c by Priyanka Mondal (priyanka02...@gmail.com): Add citrix mep

[Wireshark-commits] master-2.2 14f5f90: packet-ieee802154.c: Bugfix handling Auxilary Security Header for v2003

2017-03-31 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=14f5f90bb90eea6f0fda392c89c2bd79854f2282 Submitter: Michael Mann (mman...@netscape.net) Changed: branch: master-2.2 Repository: wireshark Commits: 14f5f90 by Michael Mann (mman...@netscape.net): packet-ieee802154.c:

[Wireshark-commits] master 7aed334: Don't add an FT_UINT32 with proto_tree_add_none_format().

2017-03-31 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7aed334856820b1a1676b81313076e086a893587 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: 7aed334 by Guy Harris (g...@alum.mit.edu): Don't add an FT_UINT32 with

[Wireshark-commits] master 01ec229: Don't use proto_tree_add_uint() to add an FT_BOOLEAN field.

2017-03-31 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=01ec22994affe82633bb673da6f78d87986411cd Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: 01ec229 by Guy Harris (g...@alum.mit.edu): Don't use proto_tree_add_uint() to

[Wireshark-commits] master 62d7819: Add packet capture support for Darwin USB

2017-03-31 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=62d78199eee5d239b826442c6edd95aeeef1540b Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: 62d7819 by Scott Deandrea (sdeand...@apple.com): Add packet capture support for

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64

2017-03-31 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 while building wireshark. Full details are available at: http://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202012%20R2%20x64/builds/3231 Buildbot URL:

[Wireshark-commits] master 02f74e4: Fix some dissection errors.

2017-03-31 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=02f74e47ed3e542f4aff9fc6a7a9c44e29be5c7b Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: 02f74e4 by Guy Harris (g...@alum.mit.edu): Fix some dissection errors.

[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 16.04 x64

2017-03-31 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder Ubuntu 16.04 x64 while building wireshark. Full details are available at: http://buildbot.wireshark.org/wireshark-master/builders/Ubuntu%2016.04%20x64/builds/1775 Buildbot URL: http://buildbot.wireshark.org/wireshark-master/ Buildslave for

[Wireshark-commits] master 7dc0653: Optimize frame_data layout.

2017-03-31 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7dc065397a5a18715dd1cf70dc4cfbccb550fa90 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: 7dc0653 by Jakub Zawadzki (darkjames...@darkjames.pl): Optimize frame_data

[Wireshark-commits] master-2.0 4732ebb: Fix endpoints statistics optional filter parsing

2017-03-31 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4732ebb48d9e06c1a1d411d266400aed0c76618b Submitter: Pascal Quantin (pascal.quan...@gmail.com) Changed: branch: master-2.0 Repository: wireshark Commits: 4732ebb by Pascal Quantin (pascal.quan...@gmail.com): Fix

[Wireshark-commits] master-2.2 2258a45: Fix endpoints statistics optional filter parsing

2017-03-31 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2258a4566c293234afbd77b0bc155b78d3b235cc Submitter: Pascal Quantin (pascal.quan...@gmail.com) Changed: branch: master-2.2 Repository: wireshark Commits: 2258a45 by Pascal Quantin (pascal.quan...@gmail.com): Fix

[Wireshark-commits] master a8ce98f: Fix endpoints statistics optional filter parsing

2017-03-31 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a8ce98fc255482938b70142707e8fd40b134595e Submitter: Pascal Quantin (pascal.quan...@gmail.com) Changed: branch: master Repository: wireshark Commits: a8ce98f by Pascal Quantin (pascal.quan...@gmail.com): Fix endpoints

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64

2017-03-31 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 while building wireshark. Full details are available at: http://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202012%20R2%20x64/builds/3228 Buildbot URL:

[Wireshark-commits] master c5d7183: Fix comments.

2017-03-31 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c5d7183a32d138004517ab3699caa3239623f1b5 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: c5d7183 by Guy Harris (g...@alum.mit.edu): Fix comments. Change-Id:

[Wireshark-commits] master-2.2 959bc4c: Fix the build when a different version of Qt is in PATH

2017-03-31 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=959bc4cf9a3da9dbcc9155fd72fbd5f189869025 Submitter: Graham Bloice (graham.blo...@trihedral.com) Changed: branch: master-2.2 Repository: wireshark Commits: 959bc4c by Роман Донченко (d...@corrigendum.ru): Fix the build

[Wireshark-commits] buildbot failure in Wireshark 2.2 on Windows Server 2012 R2 x64

2017-03-31 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 while building wireshark. Full details are available at: http://buildbot.wireshark.org/wireshark-2.2/builders/Windows%20Server%202012%20R2%20x64/builds/532 Buildbot URL:

[Wireshark-commits] master e767f42: AMQP: fix field amqp.value is not of type FT_NONE

2017-03-31 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e767f42a242fa640feaee7df70c668ee16114f2d Submitter: Michael Mann (mman...@netscape.net) Changed: branch: master Repository: wireshark Commits: e767f42 by Alexis La Goutte (alexis.lagou...@gmail.com): AMQP: fix field

[Wireshark-commits] master-2.2 6a05b59: Qt: do not expand collapsed trees when switching packets

2017-03-31 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6a05b597c0a8e1d5d5a05c6eb1293b63d338d4d0 Submitter: Peter Wu (pe...@lekensteyn.nl) Changed: branch: master-2.2 Repository: wireshark Commits: 6a05b59 by Peter Wu (pe...@lekensteyn.nl): Qt: do not expand collapsed

[Wireshark-commits] master fff930d: Qt: do not expand collapsed trees when switching packets

2017-03-31 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fff930d3939c21a1ed988ef9014c32f75739ea7c Submitter: Peter Wu (pe...@lekensteyn.nl) Changed: branch: master Repository: wireshark Commits: fff930d by Peter Wu (pe...@lekensteyn.nl): Qt: do not expand collapsed trees

[Wireshark-commits] master 641a48e: checkAPIs: improve trailing item suggestion for XXX_string

2017-03-31 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=641a48ec68778a5eaed82e436c09642e9ef1f911 Submitter: Peter Wu (pe...@lekensteyn.nl) Changed: branch: master Repository: wireshark Commits: 641a48e by Peter Wu (pe...@lekensteyn.nl): checkAPIs: improve trailing item

[Wireshark-commits] master-2.2 17a3730: dns: prevent repeatedly overwriting resolved entries

2017-03-31 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=17a3730146e56b7aee0f15dbcc6b6106a7bc4e82 Submitter: Peter Wu (pe...@lekensteyn.nl) Changed: branch: master-2.2 Repository: wireshark Commits: 17a3730 by Peter Wu (pe...@lekensteyn.nl): dns: prevent repeatedly

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64

2017-03-31 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 while building wireshark. Full details are available at: http://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202012%20R2%20x64/builds/3223 Buildbot URL:

[Wireshark-commits] master 0896352: Fix typo.

2017-03-31 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=08963526bc618cb827f7e1eddb547c3bea0d2017 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: 0896352 by Guy Harris (g...@alum.mit.edu): Fix typo. Change-Id:

[Wireshark-commits] master 9a3f177: Fix incorrect NSAP AFI values.

2017-03-31 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9a3f177c22cc9f02511913be51927aab5309ab11 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: 9a3f177 by Guy Harris (g...@alum.mit.edu): Fix incorrect NSAP AFI values.