[Wireshark-commits] master 1f95d39: rawshark(.c): fix parameter 'phdr' not found in the function declaration [-Wdocumentation]

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1f95d39b623a3127e493446f773a22289637e6f1
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

1f95d39 by Alexis La Goutte (alexis.lagou...@gmail.com):

rawshark(.c): fix parameter 'phdr' not found in the function declaration 
[-Wdocumentation]

Change-Id: If5c8fbb77acdf75ba273a6b77d7f338381c229f6
Reviewed-on: https://code.wireshark.org/review/25983
Petri-Dish: Alexis La Goutte 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  ba72f73   DIS: move modulation parameters to correct place in tree
adds  1f95d39   rawshark(.c): fix parameter 'phdr' not found in the 
function declaration [-Wdocumentation]


Summary of changes:
 rawshark.c | 1 -
 1 file changed, 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 818b58d: TDS: Improve dissection of TDS5 responses.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=818b58da97d55af5fe0a0d7de72518f865730f20
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

818b58d by Craig Jackson (cejackso...@gmail.com):

TDS: Improve dissection of TDS5 responses.

Add dissection of the TDS5 packets for transmitting column information
(ROWFMT, ROWFMT2) and extended error messages.

Change-Id: Ib85c91b7ea007ce8bdc602bf6b607ab7a5cf1be5
Reviewed-on: https://code.wireshark.org/review/25855
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  1f95d39   rawshark(.c): fix parameter 'phdr' not found in the 
function declaration [-Wdocumentation]
adds  818b58d   TDS: Improve dissection of TDS5 responses.


Summary of changes:
 epan/dissectors/packet-tds.c | 685 ---
 1 file changed, 581 insertions(+), 104 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master e510cee: Reenable ieee 802.3 encapsulation and small cleanups/updates

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e510ceed0563a5b37481339beb1a8cb61809d164
Submitter: Jörg Mayer (jma...@loplof.de)
Changed: branch: master
Repository: wireshark

Commits:

e510cee by Joerg Mayer (jma...@loplof.de):

Reenable ieee 802.3 encapsulation and small cleanups/updates

Change-Id: I6674140b79bb21121edbd3caa371b7d0f179811a
Reviewed-on: https://code.wireshark.org/review/25982
Reviewed-by: Anders Broman 
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot
Reviewed-by: Jörg Mayer 


Actions performed:

from  818b58d   TDS: Improve dissection of TDS5 responses.
adds  e510cee   Reenable ieee 802.3 encapsulation and small cleanups/updates


Summary of changes:
 epan/dissectors/packet-vntag.c | 60 --
 1 file changed, 35 insertions(+), 25 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master e57ecf4: IEEE 802.11: fix build with gcc7

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e57ecf4acd280e972449558e58d57307338bca86
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

e57ecf4 by Pascal Quantin (pascal.quan...@gmail.com):

IEEE 802.11: fix build with gcc7

Remove an unused hf entry.
Remove an unused true_false value string.
Fix an indentation so that the compiler does not think backets are missing.

Change-Id: Id6c0597b68674fd17f750379f941698d72b0cbba
Reviewed-on: https://code.wireshark.org/review/25986
Reviewed-by: Pascal Quantin 
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann 


Actions performed:

from  e510cee   Reenable ieee 802.3 encapsulation and small cleanups/updates
adds  e57ecf4   IEEE 802.11: fix build with gcc7


Summary of changes:
 epan/dissectors/packet-ieee80211.c | 13 +
 1 file changed, 1 insertion(+), 12 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.4 0315ee1: WCCP: Make sure our offset increases.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0315ee158be981d1b116640f4215ae8eefd21561
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master-2.4
Repository: wireshark

Commits:

0315ee1 by Gerald Combs (ger...@wireshark.org):

WCCP: Make sure our offset increases.

Make sure we advance our offset in various places. Clarify a macro name.

Bug: 14412
Change-Id: I9b2af4bb57d039febe16f0c6d74ebb12fa34693c
Reviewed-on: https://code.wireshark.org/review/25965
Reviewed-by: Gerald Combs 
Petri-Dish: Gerald Combs 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 
(cherry picked from commit 5d45b69b590cabc5127282d1ade3bca1598e5f5c)
Reviewed-on: https://code.wireshark.org/review/25996


Actions performed:

from  caa6318   Fix endianness.
adds  0315ee1   WCCP: Make sure our offset increases.


Summary of changes:
 epan/dissectors/packet-wccp.c | 41 +++--
 1 file changed, 23 insertions(+), 18 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 032cb4b: Catapult DCT2000: Update sscanf patterns, and avoid calling if possible

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=032cb4b79fdb207e18bf121140d7c7c66f9b5cf2
Submitter: Martin Mathieson (martin.r.mathie...@googlemail.com)
Changed: branch: master
Repository: wireshark

Commits:

032cb4b by Martin Mathieson (martin.r.mathie...@googlemail.com):

Catapult DCT2000: Update sscanf patterns, and avoid calling if possible

Change-Id: Iafb7d62ab4a0431a00eaa284d421ea38b568533f
Reviewed-on: https://code.wireshark.org/review/25990
Petri-Dish: Martin Mathieson 
Tested-by: Petri Dish Buildbot
Reviewed-by: Martin Mathieson 


Actions performed:

from  01e8f50   TWAMP: Fix packets changing type in wireshark GUI
adds  032cb4b   Catapult DCT2000: Update sscanf patterns, and avoid calling 
if possible


Summary of changes:
 epan/dissectors/packet-catapult-dct2000.c | 103 +++---
 1 file changed, 52 insertions(+), 51 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master ba58d62: Fix endianness.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ba58d62cd13b2dfe39d62022cc066687019685de
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

ba58d62 by Guy Harris (g...@alum.mit.edu):

Fix endianness.

Make the 1-byte fields little-endian (it doesn't matter, but it's more
consistent that way), and make the transmission attenuation fields
little-endian (where it *does* matter - making them big-endian was
probably a copy-and-pasteo).

Note that the OUI field being "big-endian" is correct, however.
(Radiotap specifies it as an array of 3 octets containing an OUI, and we
display OUIs as big-endian 24-bit quantities.)

Change-Id: I42d19f7ec0d066ce89dbef78d11dff900c0a6b60
Reviewed-on: https://code.wireshark.org/review/25998
Reviewed-by: Guy Harris 


Actions performed:

from  2112490   nettrace: remove wrong frees (found by clang).
adds  ba58d62   Fix endianness.


Summary of changes:
 epan/dissectors/packet-ieee80211-radiotap.c | 36 +
 1 file changed, 21 insertions(+), 15 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.4 caa6318: Fix endianness.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=caa63184a95bdc50fb5582f7f9f3eb4ccc0d9b77
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.4
Repository: wireshark

Commits:

caa6318 by Guy Harris (g...@alum.mit.edu):

Fix endianness.

Make the 1-byte fields little-endian (it doesn't matter, but it's more
consistent that way), and make the transmission attenuation fields
little-endian (where it *does* matter - making them big-endian was
probably a copy-and-pasteo).

Change-Id: I42d19f7ec0d066ce89dbef78d11dff900c0a6b60
Reviewed-on: https://code.wireshark.org/review/25998
Reviewed-by: Guy Harris 
(cherry picked from commit ba58d62cd13b2dfe39d62022cc066687019685de)
Reviewed-on: https://code.wireshark.org/review/25999


Actions performed:

from  31ef857   [GSM A RR] RXLEV-SUB-SERVING-CELL displayed with wrong 
bitmask.
adds  caa6318   Fix endianness.


Summary of changes:
 epan/dissectors/packet-ieee80211-radiotap.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 d89e7e5: Fix endianness.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d89e7e51c68f1be1051be9178937c30bda75c380
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

d89e7e5 by Guy Harris (g...@alum.mit.edu):

Fix endianness.

Make the 1-byte fields little-endian (it doesn't matter, but it's more
consistent that way), and make the transmission attenuation fields
little-endian (where it *does* matter - making them big-endian was
probably a copy-and-pasteo).

Change-Id: I42d19f7ec0d066ce89dbef78d11dff900c0a6b60
Reviewed-on: https://code.wireshark.org/review/25998
Reviewed-by: Guy Harris 
(cherry picked from commit ba58d62cd13b2dfe39d62022cc066687019685de)
Reviewed-on: https://code.wireshark.org/review/26000


Actions performed:

from  a2901dc   Airpdcap: Add length checks.
adds  d89e7e5   Fix endianness.


Summary of changes:
 epan/dissectors/packet-ieee80211-radiotap.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 2112490: nettrace: remove wrong frees (found by clang).

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=21124903d5c6ffbddfe54db9b9490c095428909e
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

2112490 by Dario Lombardo (lom...@gmail.com):

nettrace: remove wrong frees (found by clang).

Change-Id: I5d8c81a4ebb89dfc6b6e9103a407cf24f1aa34d0
Reviewed-on: https://code.wireshark.org/review/25995
Petri-Dish: Dario Lombardo 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  032cb4b   Catapult DCT2000: Update sscanf patterns, and avoid calling 
if possible
adds  2112490   nettrace: remove wrong frees (found by clang).


Summary of changes:
 wiretap/nettrace_3gpp_32_423.c | 3 ---
 1 file changed, 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 f993b0e: WCCP: Make sure our offset increases.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f993b0e1ddee5700b71662403a605d5e8b3a09bf
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master-2.2
Repository: wireshark

Commits:

f993b0e by Gerald Combs (ger...@wireshark.org):

WCCP: Make sure our offset increases.

Make sure we advance our offset in various places. Clarify a macro name.

Bug: 14412
Change-Id: I9b2af4bb57d039febe16f0c6d74ebb12fa34693c
Reviewed-on: https://code.wireshark.org/review/25965
Reviewed-by: Gerald Combs 
Petri-Dish: Gerald Combs 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 
(cherry picked from commit 5d45b69b590cabc5127282d1ade3bca1598e5f5c)
Reviewed-on: https://code.wireshark.org/review/25997


Actions performed:

from  d89e7e5   Fix endianness.
adds  f993b0e   WCCP: Make sure our offset increases.


Summary of changes:
 epan/dissectors/packet-wccp.c | 41 +++--
 1 file changed, 23 insertions(+), 18 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 6364b3b: Check for dependencies in all subdirectories of $pkglib and $pkgexec.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6364b3b0e381134104d21594ab459efe22d0dcfd
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

6364b3b by Guy Harris (g...@alum.mit.edu):

Check for dependencies in all subdirectories of $pkglib and $pkgexec.

Just use "find" to find plain files under $pkglib and $pkgexec; this
avoids trying to run otool on directories, which can cause it to stop
looking in $pkgexec/* past the extcap directory, and does try to run it
on the Qt frameworks in subdirectories under $pkglib.

Add a comment giving more details about the big command to find
dependencies.

Change-Id: Ife3c3a8493ca0b6ea28f1bb108f63714366abeed
Reviewed-on: https://code.wireshark.org/review/26003
Reviewed-by: Guy Harris 
(cherry picked from commit eb2b8dd98ae8c298c484e61ddc4ad1fcf632ad5b)
Reviewed-on: https://code.wireshark.org/review/26007


Actions performed:

from  8eacd00   SIGCOMP: Disable UDVM dissection and decompression.
adds  6364b3b   Check for dependencies in all subdirectories of $pkglib and 
$pkgexec.


Summary of changes:
 packaging/macosx/osx-app.sh | 32 +---
 1 file changed, 21 insertions(+), 11 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.4 407b238: Check for dependencies in all subdirectories of $pkglib and $pkgexec.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=407b23835c86ce7d231d023ca277f50fcbab6550
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.4
Repository: wireshark

Commits:

407b238 by Guy Harris (g...@alum.mit.edu):

Check for dependencies in all subdirectories of $pkglib and $pkgexec.

Just use "find" to find plain files under $pkglib and $pkgexec; this
avoids trying to run otool on directories, which can cause it to stop
looking in $pkgexec/* past the extcap directory, and does try to run it
on the Qt frameworks in subdirectories under $pkglib.

Add a comment giving more details about the big command to find
dependencies.

Change-Id: Ife3c3a8493ca0b6ea28f1bb108f63714366abeed
Reviewed-on: https://code.wireshark.org/review/26003
Reviewed-by: Guy Harris 
(cherry picked from commit eb2b8dd98ae8c298c484e61ddc4ad1fcf632ad5b)
Reviewed-on: https://code.wireshark.org/review/26006


Actions performed:

from  44a295d   SIGCOMP: Disable UDVM dissection and decompression.
adds  407b238   Check for dependencies in all subdirectories of $pkglib and 
$pkgexec.


Summary of changes:
 packaging/macosx/osx-app.sh | 32 +---
 1 file changed, 21 insertions(+), 11 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 05cd2b6: Update comments to reflect current reality.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=05cd2b6c1cc52aca95a822096f77aec203f34622
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

05cd2b6 by Guy Harris (g...@alum.mit.edu):

Update comments to reflect current reality.

Change-Id: Ie0fcc197ed8841b5f7098a5129b774507646f2de
Reviewed-on: https://code.wireshark.org/review/26001
Reviewed-by: Guy Harris 


Actions performed:

from  ba58d62   Fix endianness.
adds  05cd2b6   Update comments to reflect current reality.


Summary of changes:
 packaging/macosx/osx-app.sh.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.4 44a295d: SIGCOMP: Disable UDVM dissection and decompression.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=44a295d16c0a951bb80919dff3cdfad88c142591
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master-2.4
Repository: wireshark

Commits:

44a295d by Gerald Combs (ger...@wireshark.org):

SIGCOMP: Disable UDVM dissection and decompression.

This dissector has had multiple, severe issues over the years. Set the
display.udvm.code and decomp.msg preferences to FALSE by default. Add
warnings about re-enabling them.

Change-Id: Ib23ab1b2cd23b35f2377416c7d197730dedbd9e2
Reviewed-on: https://code.wireshark.org/review/26002
Reviewed-by: Gerald Combs 
(cherry picked from commit 2e139a15fab0206403e66abaf435456007cb5e1f)
Reviewed-on: https://code.wireshark.org/review/26004


Actions performed:

from  0315ee1   WCCP: Make sure our offset increases.
adds  44a295d   SIGCOMP: Disable UDVM dissection and decompression.


Summary of changes:
 epan/dissectors/packet-sigcomp.c | 8 ++--
 1 file changed, 6 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 2e139a1: SIGCOMP: Disable UDVM dissection and decompression.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2e139a15fab0206403e66abaf435456007cb5e1f
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master
Repository: wireshark

Commits:

2e139a1 by Gerald Combs (ger...@wireshark.org):

SIGCOMP: Disable UDVM dissection and decompression.

This dissector has had multiple, severe issues over the years. Set the
display.udvm.code and decomp.msg preferences to FALSE by default. Add
warnings about re-enabling them.

Change-Id: Ib23ab1b2cd23b35f2377416c7d197730dedbd9e2
Reviewed-on: https://code.wireshark.org/review/26002
Reviewed-by: Gerald Combs 


Actions performed:

from  05cd2b6   Update comments to reflect current reality.
adds  2e139a1   SIGCOMP: Disable UDVM dissection and decompression.


Summary of changes:
 epan/dissectors/packet-sigcomp.c | 8 ++--
 1 file changed, 6 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 8eacd00: SIGCOMP: Disable UDVM dissection and decompression.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8eacd00208528c35e1794a1b152d0d8d583d7380
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master-2.2
Repository: wireshark

Commits:

8eacd00 by Gerald Combs (ger...@wireshark.org):

SIGCOMP: Disable UDVM dissection and decompression.

This dissector has had multiple, severe issues over the years. Set the
display.udvm.code and decomp.msg preferences to FALSE by default. Add
warnings about re-enabling them.

Change-Id: Ib23ab1b2cd23b35f2377416c7d197730dedbd9e2
Reviewed-on: https://code.wireshark.org/review/26002
Reviewed-by: Gerald Combs 
(cherry picked from commit 2e139a15fab0206403e66abaf435456007cb5e1f)
Reviewed-on: https://code.wireshark.org/review/26005


Actions performed:

from  f993b0e   WCCP: Make sure our offset increases.
adds  8eacd00   SIGCOMP: Disable UDVM dissection and decompression.


Summary of changes:
 epan/dissectors/packet-sigcomp.c | 8 ++--
 1 file changed, 6 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 4c8c59c: csn1: fix indentation.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4c8c59ca7d1fd7be949e8dc32697ba67b3541e88
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

4c8c59c by Dario Lombardo (lom...@gmail.com):

csn1: fix indentation.

Change-Id: I7832cea4d1073df854852aa598c04bcab68bf94c
Reviewed-on: https://code.wireshark.org/review/25992
Reviewed-by: Anders Broman 


Actions performed:

from  eb2b8dd   Check for dependencies in all subdirectories of $pkglib and 
$pkgexec.
adds  4c8c59c   csn1: fix indentation.


Summary of changes:
 epan/dissectors/packet-csn1.c | 118 +-
 1 file changed, 58 insertions(+), 60 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master eb2b8dd: Check for dependencies in all subdirectories of $pkglib and $pkgexec.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=eb2b8dd98ae8c298c484e61ddc4ad1fcf632ad5b
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

eb2b8dd by Guy Harris (g...@alum.mit.edu):

Check for dependencies in all subdirectories of $pkglib and $pkgexec.

Just use "find" to find plain files under $pkglib and $pkgexec; this
avoids trying to run otool on directories, which can cause it to stop
looking in $pkgexec/* past the extcap directory, and does try to run it
on the Qt frameworks in subdirectories under $pkglib.

Add a comment giving more details about the big command to find
dependencies.

Change-Id: Ife3c3a8493ca0b6ea28f1bb108f63714366abeed
Reviewed-on: https://code.wireshark.org/review/26003
Reviewed-by: Guy Harris 


Actions performed:

from  2e139a1   SIGCOMP: Disable UDVM dissection and decompression.
adds  eb2b8dd   Check for dependencies in all subdirectories of $pkglib and 
$pkgexec.


Summary of changes:
 packaging/macosx/osx-app.sh.in | 32 +---
 1 file changed, 21 insertions(+), 11 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 380381c: TWAMP: Reassemble only the Server-Greeting message

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=380381ce72e00db3e845eb6507c55b61739d783a
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

380381c by Valentin Vidic (valentin.vi...@carnet.hr):

TWAMP: Reassemble only the Server-Greeting message

Recursion fix forces all the messages to reassemble into 64 byte
chunks breaking the dissector for later (smaller) messages.

Change-Id: I4ab8ab4259aac5d5fc5a19ce10c6cab2db5ae3e0
Reviewed-on: https://code.wireshark.org/review/25985
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  4c8c59c   csn1: fix indentation.
adds  380381c   TWAMP: Reassemble only the Server-Greeting message


Summary of changes:
 epan/dissectors/packet-twamp.c | 12 +++-
 1 file changed, 11 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.4 cb11168: IPMI: Disable bus command dissection.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cb11168ab024ac1da21d3b4cbed6c58c4992d626
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master-2.4
Repository: wireshark

Commits:

cb11168 by Gerald Combs (ger...@wireshark.org):

IPMI: Disable bus command dissection.

This dissector has had multiple, severe issues over the years. Disable
bus command dissection by default. Add a warning about re-enabling it.

Change-Id: I9f71fafe2961f349825e6eda1f351025e00be182
Reviewed-on: https://code.wireshark.org/review/26009
Reviewed-by: Anders Broman 


Actions performed:

from  407b238   Check for dependencies in all subdirectories of $pkglib and 
$pkgexec.
adds  cb11168   IPMI: Disable bus command dissection.


Summary of changes:
 epan/dissectors/packet-ipmi.c | 29 ++---
 1 file changed, 22 insertions(+), 7 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 727c815: IPMI: Disable bus command dissection.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=727c815ad2b22aeb183c40e8fa78c640cff56f99
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

727c815 by Gerald Combs (ger...@wireshark.org):

IPMI: Disable bus command dissection.

This dissector has had multiple, severe issues over the years. Disable
bus command dissection by default. Add a warning about re-enabling it.

Change-Id: I9f71fafe2961f349825e6eda1f351025e00be182
Reviewed-on: https://code.wireshark.org/review/26008
Reviewed-by: Gerald Combs 
Petri-Dish: Gerald Combs 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  f14f76d   dmp: Allow multiple SecurityCategories again
adds  727c815   IPMI: Disable bus command dissection.


Summary of changes:
 epan/dissectors/packet-ipmi.c | 29 ++---
 1 file changed, 22 insertions(+), 7 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 ed334fa: IPMI: Disable bus command dissection.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ed334fad66c70610c049caba6ee2294a1769ab42
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master-2.2
Repository: wireshark

Commits:

ed334fa by Gerald Combs (ger...@wireshark.org):

IPMI: Disable bus command dissection.

This dissector has had multiple, severe issues over the years. Disable
bus command dissection by default. Add a warning about re-enabling it.

Change-Id: I9f71fafe2961f349825e6eda1f351025e00be182
Reviewed-on: https://code.wireshark.org/review/26010
Reviewed-by: Anders Broman 


Actions performed:

from  6364b3b   Check for dependencies in all subdirectories of $pkglib and 
$pkgexec.
adds  ed334fa   IPMI: Disable bus command dissection.


Summary of changes:
 epan/dissectors/packet-ipmi.c | 29 ++---
 1 file changed, 22 insertions(+), 7 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 9dcded6: Code-sign extcap binaries.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9dcded61a1f5634861d9abfcddc45ab972fe30a3
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

9dcded6 by Guy Harris (g...@alum.mit.edu):

Code-sign extcap binaries.

Change-Id: Icfca94774b929767560a06f873fbf90c3d0bebef
Reviewed-on: https://code.wireshark.org/review/26024
Reviewed-by: Guy Harris 


Actions performed:

from  727c815   IPMI: Disable bus command dissection.
adds  9dcded6   Code-sign extcap binaries.


Summary of changes:
 packaging/macosx/osx-app.sh.in | 3 +++
 1 file changed, 3 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master f14f76d: dmp: Allow multiple SecurityCategories again

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f14f76d12a3107f0a89884f084640925ba033b28
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master
Repository: wireshark

Commits:

f14f76d by Stig Bjørlykke (s...@bjorlykke.org):

dmp: Allow multiple SecurityCategories again

A Security Classification in DMP may have multiple Security Categories
so don't restrict this to only one.  Add a arbitrary limit of 255 to
avoid a long dissector loop in malformed packets.

This fixes a bug introduced in g85bbda51.

Bug: 14408
Change-Id: I48e7a61a097c58dfcf21e9c9ed3147cf1573dae6
Reviewed-on: https://code.wireshark.org/review/26011
Petri-Dish: Stig Bjørlykke 
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs 


Actions performed:

from  380381c   TWAMP: Reassemble only the Server-Greeting message
adds  f14f76d   dmp: Allow multiple SecurityCategories again


Summary of changes:
 epan/dissectors/packet-dmp.c | 36 ++--
 1 file changed, 26 insertions(+), 10 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 b6048cc: Update the release notes for 2.2.13.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b6048cc2180d03d13d453d296930f85417ad16e1
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master-2.2
Repository: wireshark

Commits:

b6048cc by Gerald Combs (ger...@wireshark.org):

Update the release notes for 2.2.13.

Change-Id: I988e075312fe30b730c9b9ecd599fc503a6aa426
Reviewed-on: https://code.wireshark.org/review/26020
Reviewed-by: Gerald Combs 


Actions performed:

from  ed334fa   IPMI: Disable bus command dissection.
adds  b6048cc   Update the release notes for 2.2.13.


Summary of changes:
 docbook/release-notes.asciidoc | 141 ++---
 1 file changed, 131 insertions(+), 10 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.4 d0373aa: dmp: Allow multiple SecurityCategories again

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d0373aaa0d9d321b6fbbef21fc057eabdb08b5ad
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master-2.4
Repository: wireshark

Commits:

d0373aa by Stig Bjørlykke (s...@bjorlykke.org):

dmp: Allow multiple SecurityCategories again

A Security Classification in DMP may have multiple Security Categories
so don't restrict this to only one.  Add a arbitrary limit of 255 to
avoid a long dissector loop in malformed packets.

This fixes a bug introduced in g85bbda51.

Bug: 14408
Change-Id: I48e7a61a097c58dfcf21e9c9ed3147cf1573dae6
Reviewed-on: https://code.wireshark.org/review/26011
Petri-Dish: Stig Bjørlykke 
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs 
(cherry picked from commit f14f76d12a3107f0a89884f084640925ba033b28)
Reviewed-on: https://code.wireshark.org/review/26018
Petri-Dish: Gerald Combs 


Actions performed:

from  deaeaca   More 2.4.5 release note updates.
adds  d0373aa   dmp: Allow multiple SecurityCategories again


Summary of changes:
 epan/dissectors/packet-dmp.c | 36 ++--
 1 file changed, 26 insertions(+), 10 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.4 e30b6d7: Code-sign extcap binaries.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e30b6d71665c1c761789e6ee0f94369c55417ba9
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.4
Repository: wireshark

Commits:

e30b6d7 by Guy Harris (g...@alum.mit.edu):

Code-sign extcap binaries.

Change-Id: Icfca94774b929767560a06f873fbf90c3d0bebef
Reviewed-on: https://code.wireshark.org/review/26024
Reviewed-by: Guy Harris 
(cherry picked from commit 9dcded61a1f5634861d9abfcddc45ab972fe30a3)
Reviewed-on: https://code.wireshark.org/review/26025


Actions performed:

from  b13af2a   Update the release notes for 2.4.5.
adds  e30b6d7   Code-sign extcap binaries.


Summary of changes:
 packaging/macosx/osx-app.sh | 3 +++
 1 file changed, 3 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.4 b13af2a: Update the release notes for 2.4.5.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b13af2a4573cd64f9a65c9e1be10d91975d28b62
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master-2.4
Repository: wireshark

Commits:

b13af2a by Gerald Combs (ger...@wireshark.org):

Update the release notes for 2.4.5.

Change-Id: I0624ef607e9424f398fd0182dc4fe545fdd57e41
Reviewed-on: https://code.wireshark.org/review/26019
Reviewed-by: Gerald Combs 


Actions performed:

from  cb11168   IPMI: Disable bus command dissection.
adds  b13af2a   Update the release notes for 2.4.5.


Summary of changes:
 docbook/release-notes.asciidoc | 174 ++---
 1 file changed, 164 insertions(+), 10 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 7585207: Fix stripping of binaries.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=75852074c485dc5c2e4af67e03132151fa1d308f
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

7585207 by Guy Harris (g...@alum.mit.edu):

Fix stripping of binaries.

Instead of using the never-defined $binpath (undefined going back to at
least Wireshark 1.0.0 - is it a leftover from the Inkscape version?),
use $bundle_binary_list, to strip all the executables with strip -ur.

(Not that we want to strip anything - we don't even want the debugging
symbols stripped! - but for cleanliness.)

Change-Id: I9c3520ffb418bf9dc206d3ccb55d347c208f3be2
Reviewed-on: https://code.wireshark.org/review/26033
Reviewed-by: Guy Harris 
(cherry picked from commit 316b858d28092bb1c55ff50cfe68ae51f34425de)
Reviewed-on: https://code.wireshark.org/review/26035


Actions performed:

from  58e6809   Don't use find to find files to check for dependencies.
adds  7585207   Fix stripping of binaries.


Summary of changes:
 packaging/macosx/osx-app.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.4 268fae4: Get rid of the -sdkroot option; it doesn't affect anything.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=268fae48900c89b89ba7a03100f35e49f2c1b128
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.4
Repository: wireshark

Commits:

268fae4 by Guy Harris (g...@alum.mit.edu):

Get rid of the -sdkroot option; it doesn't affect anything.

Change-Id: I9797eea30594f5e48b21f1c2daede18777e690b1
Reviewed-on: https://code.wireshark.org/review/26036
Reviewed-by: Guy Harris 
(cherry picked from commit dfe22ab861e7f2b618bbe65b0fca32898433216d)
Reviewed-on: https://code.wireshark.org/review/26037


Actions performed:

from  5057322   Fix stripping of binaries.
adds  268fae4   Get rid of the -sdkroot option; it doesn't affect anything.


Summary of changes:
 packaging/macosx/osx-app.sh | 7 +--
 1 file changed, 1 insertion(+), 6 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 5e0e2b6: Get rid of the -sdkroot option; it doesn't affect anything.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5e0e2b69c58536a992284d72db3bcc2a0ee24018
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

5e0e2b6 by Guy Harris (g...@alum.mit.edu):

Get rid of the -sdkroot option; it doesn't affect anything.

Change-Id: I9797eea30594f5e48b21f1c2daede18777e690b1
Reviewed-on: https://code.wireshark.org/review/26036
Reviewed-by: Guy Harris 
(cherry picked from commit dfe22ab861e7f2b618bbe65b0fca32898433216d)
Reviewed-on: https://code.wireshark.org/review/26038


Actions performed:

from  7585207   Fix stripping of binaries.
adds  5e0e2b6   Get rid of the -sdkroot option; it doesn't affect anything.


Summary of changes:
 packaging/macosx/osx-app.sh | 7 +--
 1 file changed, 1 insertion(+), 6 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 017167f: Just use tvb_memeql() to check the signature.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=017167fb34220a17af361d50b2d239927acac7c1
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

017167f by Guy Harris (g...@alum.mit.edu):

Just use tvb_memeql() to check the signature.

That's one of the things it's intended to do - check the values of parts
of the packet that might not actually be there.  The comparison fails if
either 1) it's all there and doesn't match or 2) it's not all there.

Change-Id: I0f97ea5f75c2cada511e254ec096d294ea710f45
Reviewed-on: https://code.wireshark.org/review/26040
Reviewed-by: Guy Harris 


Actions performed:

from  86f329a   LTE MAC: check direction and lcid before looking up msg3 
table
adds  017167f   Just use tvb_memeql() to check the signature.


Summary of changes:
 epan/dissectors/packet-ns-rpc.c | 12 
 1 file changed, 4 insertions(+), 8 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.4 e0aba0d: Just use tvb_memeql() to check the signature.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e0aba0de8e9a67566ba164a057976bb8f4f8074b
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.4
Repository: wireshark

Commits:

e0aba0d by Guy Harris (g...@alum.mit.edu):

Just use tvb_memeql() to check the signature.

That's one of the things it's intended to do - check the values of parts
of the packet that might not actually be there.  The comparison fails if
either 1) it's all there and doesn't match or 2) it's not all there.

Change-Id: I0f97ea5f75c2cada511e254ec096d294ea710f45
Reviewed-on: https://code.wireshark.org/review/26040
Reviewed-by: Guy Harris 
(cherry picked from commit 017167fb34220a17af361d50b2d239927acac7c1)
Reviewed-on: https://code.wireshark.org/review/26041


Actions performed:

from  268fae4   Get rid of the -sdkroot option; it doesn't affect anything.
adds  e0aba0d   Just use tvb_memeql() to check the signature.


Summary of changes:
 epan/dissectors/packet-ns-rpc.c | 12 
 1 file changed, 4 insertions(+), 8 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.4 0e48d73: Don't use find to find files to check for dependencies.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0e48d73b295d2081c6ff066cc04d10df2d5ba141
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.4
Repository: wireshark

Commits:

0e48d73 by Guy Harris (g...@alum.mit.edu):

Don't use find to find files to check for dependencies.

It may find files that aren't Mach-O binary files.  Instead, rename
cs_binary_list to bundle_binary_list, and use it when checking for
dependencies as well as when code-signing binaries.

Change-Id: I9d17a4ba137e494fbd38db1b62f5cc7e4b620fc9
Reviewed-on: https://code.wireshark.org/review/26028
Reviewed-by: Guy Harris 
(cherry picked from commit 529bb0491043cc716c9e8e72e78492bed6dbb076)
Reviewed-on: https://code.wireshark.org/review/26029


Actions performed:

from  d0373aa   dmp: Allow multiple SecurityCategories again
adds  0e48d73   Don't use find to find files to check for dependencies.


Summary of changes:
 packaging/macosx/osx-app.sh | 29 ++---
 1 file changed, 18 insertions(+), 11 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 529bb04: Don't use find to find files to check for dependencies.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=529bb0491043cc716c9e8e72e78492bed6dbb076
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

529bb04 by Guy Harris (g...@alum.mit.edu):

Don't use find to find files to check for dependencies.

It may find files that aren't Mach-O binary files.  Instead, rename
cs_binary_list to bundle_binary_list, and use it when checking for
dependencies as well as when code-signing binaries.

Change-Id: I9d17a4ba137e494fbd38db1b62f5cc7e4b620fc9
Reviewed-on: https://code.wireshark.org/review/26028
Reviewed-by: Guy Harris 


Actions performed:

from  9dcded6   Code-sign extcap binaries.
adds  529bb04   Don't use find to find files to check for dependencies.


Summary of changes:
 packaging/macosx/osx-app.sh.in | 29 ++---
 1 file changed, 18 insertions(+), 11 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 58e6809: Don't use find to find files to check for dependencies.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=58e68099192008b2920b1380c7862843287a0b55
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

58e6809 by Guy Harris (g...@alum.mit.edu):

Don't use find to find files to check for dependencies.

It may find files that aren't Mach-O binary files.  Instead, rename
cs_binary_list to bundle_binary_list, and use it when checking for
dependencies as well as when code-signing binaries.

Change-Id: I9d17a4ba137e494fbd38db1b62f5cc7e4b620fc9
Reviewed-on: https://code.wireshark.org/review/26028
Reviewed-by: Guy Harris 
(cherry picked from commit 529bb0491043cc716c9e8e72e78492bed6dbb076)
Reviewed-on: https://code.wireshark.org/review/26031


Actions performed:

from  504018d   Code-sign extcap binaries.
adds  58e6809   Don't use find to find files to check for dependencies.


Summary of changes:
 packaging/macosx/osx-app.sh | 29 ++---
 1 file changed, 18 insertions(+), 11 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 504018d: Code-sign extcap binaries.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=504018d923441453f85594c2cd0185a0f84cf0a5
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

504018d by Guy Harris (g...@alum.mit.edu):

Code-sign extcap binaries.

Change-Id: Icfca94774b929767560a06f873fbf90c3d0bebef
Reviewed-on: https://code.wireshark.org/review/26024
Reviewed-by: Guy Harris 
(cherry picked from commit 9dcded61a1f5634861d9abfcddc45ab972fe30a3)
Reviewed-on: https://code.wireshark.org/review/26030


Actions performed:

from  26cec08   Qt: Another filter expression toolbar layout attempt.
adds  504018d   Code-sign extcap binaries.


Summary of changes:
 packaging/macosx/osx-app.sh | 3 +++
 1 file changed, 3 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 434d1c9: Remove a bunch of obsolete code.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=434d1c975979bd39f42a16622db4c94f04ab66ce
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

434d1c9 by Guy Harris (g...@alum.mit.edu):

Remove a bunch of obsolete code.

We no longer have the code to create a bundle, as we rely on CMake
having done so, at least to the extent of populating the bundle with all
the files we've generated.  Get rid of the code that used to support it,
and the command-line options that are no longer necessary now that we no
longer build code bundles.

Don't have explicit lists of CLI or extcap binaries; instead, just look
for all plain files in Wireshark.app/Contents/MacOS that have read and
execute permissions for owner/group/user.  That way, we don't have to
update the script if we add new binaries or new directories of binaries.

Change-Id: I047296a7889bea71165eebde10f34bec6ea96cc5
Reviewed-on: https://code.wireshark.org/review/26032
Reviewed-by: Guy Harris 


Actions performed:

from  529bb04   Don't use find to find files to check for dependencies.
adds  434d1c9   Remove a bunch of obsolete code.


Summary of changes:
 packaging/macosx/osx-app.sh.in | 123 +++--
 1 file changed, 7 insertions(+), 116 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 316b858: Fix stripping of binaries.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=316b858d28092bb1c55ff50cfe68ae51f34425de
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

316b858 by Guy Harris (g...@alum.mit.edu):

Fix stripping of binaries.

Instead of using the never-defined $binpath (undefined going back to at
least Wireshark 1.0.0 - is it a leftover from the Inkscape version?),
use $bundle_binary_list, to strip all the executables with strip -ur.

(Not that we want to strip anything - we don't even want the debugging
symbols stripped! - but for cleanliness.)

Change-Id: I9c3520ffb418bf9dc206d3ccb55d347c208f3be2
Reviewed-on: https://code.wireshark.org/review/26033
Reviewed-by: Guy Harris 


Actions performed:

from  434d1c9   Remove a bunch of obsolete code.
adds  316b858   Fix stripping of binaries.


Summary of changes:
 packaging/macosx/osx-app.sh.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master dfe22ab: Get rid of the -sdkroot option; it doesn't affect anything.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dfe22ab861e7f2b618bbe65b0fca32898433216d
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

dfe22ab by Guy Harris (g...@alum.mit.edu):

Get rid of the -sdkroot option; it doesn't affect anything.

Change-Id: I9797eea30594f5e48b21f1c2daede18777e690b1
Reviewed-on: https://code.wireshark.org/review/26036
Reviewed-by: Guy Harris 


Actions performed:

from  316b858   Fix stripping of binaries.
adds  dfe22ab   Get rid of the -sdkroot option; it doesn't affect anything.


Summary of changes:
 packaging/macosx/osx-app.sh.in | 7 +--
 1 file changed, 1 insertion(+), 6 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 86f329a: LTE MAC: check direction and lcid before looking up msg3 table

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=86f329aa940388d981b25c2b3c966313335c2ed9
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

86f329a by Martin Mathieson (martin.r.mathie...@googlemail.com):

LTE MAC: check direction and lcid before looking up msg3 table

Change-Id: I26238e96510e9ccb73ebc4b6c4e8e9e5bc724a91
Reviewed-on: https://code.wireshark.org/review/25991
Petri-Dish: Martin Mathieson 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  1ccfef8   ans: remove unnecessary if (tree) checks
adds  86f329a   LTE MAC: check direction and lcid before looking up msg3 
table


Summary of changes:
 epan/dissectors/packet-mac-lte.c | 20 
 1 file changed, 12 insertions(+), 8 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.4 974bfad: Qt: Another filter expression toolbar layout attempt.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=974bfad357104482fd967bb3df09505ec2604653
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master-2.4
Repository: wireshark

Commits:

974bfad by Gerald Combs (ger...@wireshark.org):

Qt: Another filter expression toolbar layout attempt.

Try hiding and showing the filter expression toolbar in order to update
its layout. This is a bit ham-fisted but seems to be the only way to get
it to work properly after clearing and inserting buttons.

Conflicts:
ui/qt/main_window_slots.cpp

Bug: 14121
Change-Id: Iea851c029c1586abfdb01c639914f6fe97ea29b3
Reviewed-on: https://code.wireshark.org/review/25840
Reviewed-by: Gerald Combs 
Petri-Dish: Gerald Combs 
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke 
(cherry picked from commit 1c5d6881de42d9093933718e7bec6211222fb7d6)
Reviewed-on: https://code.wireshark.org/review/26021


Actions performed:

from  0e48d73   Don't use find to find files to check for dependencies.
adds  974bfad   Qt: Another filter expression toolbar layout attempt.


Summary of changes:
 ui/qt/main_window_slots.cpp | 13 +
 1 file changed, 5 insertions(+), 8 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master e3fcac9: [PFCP] fix UL Gate bits in Gates Status

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e3fcac94b8f3cadc75dc53e08f4c7f7757766a2f
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

e3fcac9 by Joakim Karlsson (oak...@gmail.com):

[PFCP] fix UL Gate bits in Gates Status

Change-Id: Ief03ead2a85233d1b61905d5c39d8fbcf9ab1cb2
Reviewed-on: https://code.wireshark.org/review/26015
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  06bb945   [PFCP] Improve SDF filter - part2
adds  e3fcac9   [PFCP] fix UL Gate bits in Gates Status


Summary of changes:
 epan/dissectors/packet-pfcp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 4031e19: [PFCP] Improve SDF filter

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4031e19e124bef499fab82c9762edbce5085101e
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

4031e19 by Joakim Karlsson (oak...@gmail.com):

[PFCP] Improve SDF filter

Change-Id: Icd045464ab38a33104713e2b99344faed9bd5f5e
Reviewed-on: https://code.wireshark.org/review/26012
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  eb2e910   Remove more cruft.
adds  4031e19   [PFCP] Improve SDF filter


Summary of changes:
 epan/dissectors/packet-pfcp.c | 57 +++
 1 file changed, 36 insertions(+), 21 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 06bb945: [PFCP] Improve SDF filter - part2

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=06bb9450ddd644707c2913c2cf43053867bc5d7e
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

06bb945 by Joakim Karlsson (oak...@gmail.com):

[PFCP] Improve SDF filter - part2

Adding subtrees

Change-Id: I5a9d49af0bc00f26d8d0576c84ae2d4b33b5736f
Reviewed-on: https://code.wireshark.org/review/26013
Reviewed-by: Anders Broman 


Actions performed:

from  4031e19   [PFCP] Improve SDF filter
adds  06bb945   [PFCP] Improve SDF filter - part2


Summary of changes:
 epan/dissectors/packet-pfcp.c | 32 +++-
 1 file changed, 23 insertions(+), 9 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 51cd1db: [PFCP] fixed Unsigned32 in Time Threshold

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=51cd1db521131239af212ac0424eb7b2319cdd5f
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

51cd1db by Joakim Karlsson (oak...@gmail.com):

[PFCP] fixed Unsigned32 in Time Threshold

Change-Id: Ie60038d76faee04585e2b1100afb13301b1d1769
Reviewed-on: https://code.wireshark.org/review/26017
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  3a79b6f   [PFCP] Improve Traffic class field
adds  51cd1db   [PFCP] fixed Unsigned32 in Time Threshold


Summary of changes:
 epan/dissectors/packet-pfcp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 3a79b6f: [PFCP] Improve Traffic class field

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3a79b6f87c806b83932eae15bde6ae1dce983285
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

3a79b6f by Joakim Karlsson (oak...@gmail.com):

[PFCP] Improve Traffic class field

Change-Id: I6e6197f476fce591972e90f9943d7156bfe06921
Reviewed-on: https://code.wireshark.org/review/26016
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  e3fcac9   [PFCP] fix UL Gate bits in Gates Status
adds  3a79b6f   [PFCP] Improve Traffic class field


Summary of changes:
 epan/dissectors/packet-pfcp.c | 18 --
 1 file changed, 8 insertions(+), 10 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 1ccfef8: ans: remove unnecessary if (tree) checks

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1ccfef8b3fca63cbdd7839ebf205bd6d1f7193bb
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

1ccfef8 by Martin Kaiser (wiresh...@kaiser.cx):

ans: remove unnecessary if (tree) checks

Change-Id: I381fbb7d5654c4061ed35db94269f50d49fbeafe
Reviewed-on: https://code.wireshark.org/review/26014
Reviewed-by: Martin Kaiser 
Petri-Dish: Martin Kaiser 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  51cd1db   [PFCP] fixed Unsigned32 in Time Threshold
adds  1ccfef8   ans: remove unnecessary if (tree) checks


Summary of changes:
 epan/dissectors/packet-ans.c | 19 +--
 1 file changed, 9 insertions(+), 10 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 36632a2: More 2.2.13 release note updates.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=36632a20f4865c632049c04b8d36ea96ae920712
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master-2.2
Repository: wireshark

Commits:

36632a2 by Gerald Combs (ger...@zing.org):

More 2.2.13 release note updates.

Change-Id: I2dd667dc6a6f6f949328f1afc7f196dd16d668a6
Reviewed-on: https://code.wireshark.org/review/26027
Reviewed-by: Gerald Combs 


Actions performed:

from  b6048cc   Update the release notes for 2.2.13.
adds  36632a2   More 2.2.13 release note updates.


Summary of changes:
 docbook/release-notes.asciidoc | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.4 deaeaca: More 2.4.5 release note updates.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=deaeaca27cf1bb0519f7e9e6a5c7500f1f35f493
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master-2.4
Repository: wireshark

Commits:

deaeaca by Gerald Combs (ger...@zing.org):

More 2.4.5 release note updates.

Change-Id: I5cace5b0e3d997a27a2e542f6a4ce44123c1e12d
Reviewed-on: https://code.wireshark.org/review/26026
Reviewed-by: Gerald Combs 


Actions performed:

from  e30b6d7   Code-sign extcap binaries.
adds  deaeaca   More 2.4.5 release note updates.


Summary of changes:
 docbook/release-notes.asciidoc | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 1a32fc1: dmp: Allow multiple SecurityCategories again

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1a32fc1ee3ab40bfec1336d856f40c3bb77ea70b
Submitter: Stig Bjørlykke (s...@bjorlykke.org)
Changed: branch: master-2.2
Repository: wireshark

Commits:

1a32fc1 by Stig Bjørlykke (s...@bjorlykke.org):

dmp: Allow multiple SecurityCategories again

A Security Classification in DMP may have multiple Security Categories
so don't restrict this to only one.  Add a arbitrary limit of 255 to
avoid a long dissector loop in malformed packets.

This fixes a bug introduced in g85bbda51.

Bug: 14408
Change-Id: I48e7a61a097c58dfcf21e9c9ed3147cf1573dae6
Reviewed-on: https://code.wireshark.org/review/26011
Petri-Dish: Stig Bjørlykke 
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs 
(cherry picked from commit f14f76d12a3107f0a89884f084640925ba033b28)
Reviewed-on: https://code.wireshark.org/review/26042
Reviewed-by: Stig Bjørlykke 


Actions performed:

from  5e0e2b6   Get rid of the -sdkroot option; it doesn't affect anything.
adds  1a32fc1   dmp: Allow multiple SecurityCategories again


Summary of changes:
 epan/dissectors/packet-dmp.c | 34 --
 1 file changed, 24 insertions(+), 10 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 4d3b399: [PFCP] fixed DL Buffering Duration

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4d3b39938d88c782bd146da59866df89aaf9b80f
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

4d3b399 by Joakim Karlsson (oak...@gmail.com):

[PFCP] fixed DL Buffering Duration

* If stopped there is no time to show
* Default shall be multiple of 1 min

Change-Id: Id9c489688abc30f28a6fb4efbde263409ae92873
Reviewed-on: https://code.wireshark.org/review/26022
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  017167f   Just use tvb_memeql() to check the signature.
adds  4d3b399   [PFCP] fixed DL Buffering Duration


Summary of changes:
 epan/dissectors/packet-pfcp.c | 51 ++-
 1 file changed, 26 insertions(+), 25 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 1248c65: mate: change strcmp in g_strcmp0 that supports NULL (found by clang).

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1248c658d115a4c4908824c9c392ecf6859fd6c3
Submitter: Alexis La Goutte (alexis.lagou...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

1248c65 by Dario Lombardo (lom...@gmail.com):

mate: change strcmp in g_strcmp0 that supports NULL (found by clang).

Change-Id: I66e6183a4f356adfdfd9c55b7b39245a9913857e
Reviewed-on: https://code.wireshark.org/review/25988
Petri-Dish: Dario Lombardo 
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte 


Actions performed:

from  9c11de6   wiretap: zero memory on allocation.
adds  1248c65   mate: change strcmp in g_strcmp0 that supports NULL (found 
by clang).


Summary of changes:
 plugins/epan/mate/mate_util.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 9c11de6: wiretap: zero memory on allocation.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9c11de60de8d3294b1933a710887dd9487fa2ad5
Submitter: Alexis La Goutte (alexis.lagou...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

9c11de6 by Dario Lombardo (lom...@gmail.com):

wiretap: zero memory on allocation.

Change-Id: I0801725e2f6b17a5a3d3985b5039fa362694c7c7
Reviewed-on: https://code.wireshark.org/review/25989
Petri-Dish: Dario Lombardo 
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte 


Actions performed:

from  4d3b399   [PFCP] fixed DL Buffering Duration
adds  9c11de6   wiretap: zero memory on allocation.


Summary of changes:
 wiretap/file_wrappers.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 26cec08: Qt: Another filter expression toolbar layout attempt.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=26cec08f44205fdd8726f6f79598d6ef5bd64251
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master-2.2
Repository: wireshark

Commits:

26cec08 by Gerald Combs (ger...@wireshark.org):

Qt: Another filter expression toolbar layout attempt.

Try hiding and showing the filter expression toolbar in order to update
its layout. This is a bit ham-fisted but seems to be the only way to get
it to work properly after clearing and inserting buttons.

Conflicts:
ui/qt/main_window_slots.cpp

Bug: 14121
Change-Id: Iea851c029c1586abfdb01c639914f6fe97ea29b3
Reviewed-on: https://code.wireshark.org/review/25840
Reviewed-by: Gerald Combs 
Petri-Dish: Gerald Combs 
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke 
(cherry picked from commit 1c5d6881de42d9093933718e7bec6211222fb7d6)
Reviewed-on: https://code.wireshark.org/review/26023


Actions performed:

from  36632a2   More 2.2.13 release note updates.
adds  26cec08   Qt: Another filter expression toolbar layout attempt.


Summary of changes:
 ui/qt/main_window_slots.cpp | 13 +
 1 file changed, 5 insertions(+), 8 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.4 5057322: Fix stripping of binaries.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=505732200fb86c2177d24e571814495649902904
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.4
Repository: wireshark

Commits:

5057322 by Guy Harris (g...@alum.mit.edu):

Fix stripping of binaries.

Instead of using the never-defined $binpath (undefined going back to at
least Wireshark 1.0.0 - is it a leftover from the Inkscape version?),
use $bundle_binary_list, to strip all the executables with strip -ur.

(Not that we want to strip anything - we don't even want the debugging
symbols stripped! - but for cleanliness.)

Change-Id: I9c3520ffb418bf9dc206d3ccb55d347c208f3be2
Reviewed-on: https://code.wireshark.org/review/26033
Reviewed-by: Guy Harris 
(cherry picked from commit 316b858d28092bb1c55ff50cfe68ae51f34425de)
Reviewed-on: https://code.wireshark.org/review/26034


Actions performed:

from  974bfad   Qt: Another filter expression toolbar layout attempt.
adds  5057322   Fix stripping of binaries.


Summary of changes:
 packaging/macosx/osx-app.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master eb2e910: Remove more cruft.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=eb2e9101243fed7f47bf7ade9eacbca0b1ac4c7e
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

eb2e910 by Guy Harris (g...@alum.mit.edu):

Remove more cruft.

There's no Wireshark.app/Contents/Resources/bin directory; remove the
variable containing its path, and the part of an error message that
refers to it.

Change-Id: Id41cc00a2671925c50b2075dd3e9d0f84d5bd921
Reviewed-on: https://code.wireshark.org/review/26039
Reviewed-by: Guy Harris 


Actions performed:

from  dfe22ab   Get rid of the -sdkroot option; it doesn't affect anything.
adds  eb2e910   Remove more cruft.


Summary of changes:
 packaging/macosx/osx-app.sh.in | 4 
 1 file changed, 4 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 01e8f50: TWAMP: Fix packets changing type in wireshark GUI

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=01e8f509d7425dbc5fb4f467087a70b3e8f7f4ea
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

01e8f50 by Valentin Vidic (valentin.vi...@carnet.hr):

TWAMP: Fix packets changing type in wireshark GUI

Since the type detection runs with every click, depending on the order
packets are selected their type can change.  With this change the type
detection is run only once during the first pass through the packet list
and the results are saved for later use.

Change-Id: Ie0b16c4b6e3372fcf72a246987fe7f23bc33fa14
Reviewed-on: https://code.wireshark.org/review/25987
Reviewed-by: Jaap Keuter 
Petri-Dish: Jaap Keuter 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 


Actions performed:

from  e57ecf4   IEEE 802.11: fix build with gcc7
adds  01e8f50   TWAMP: Fix packets changing type in wireshark GUI


Summary of changes:
 epan/dissectors/packet-twamp.c | 141 +
 1 file changed, 71 insertions(+), 70 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe