[Wireshark-commits] master 1619c4c: interface_tree_model.cpp - ensure QObject namespace for tr()

2016-11-06 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1619c4cf4afe792c6c3a987a89c9bc41539fad74
Submitter: Roland Knall (rkn...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

1619c4c by Michael Mann (mman...@netscape.net):

interface_tree_model.cpp - ensure QObject namespace for tr()

Change-Id: I64214b5e2eb8b64ae36e049174d94d10da1e5bc5
Reviewed-on: https://code.wireshark.org/review/18698
Reviewed-by: Michael Mann 
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Roland Knall 


Actions performed:

from  94483fc   gsm_abis_pgsl: Dissect PACCH uplink messages
adds  1619c4c   interface_tree_model.cpp - ensure QObject namespace for tr()


Summary of changes:
 ui/qt/interface_tree_model.cpp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 94483fc: gsm_abis_pgsl: Dissect PACCH uplink messages

2016-11-06 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=94483fc3bc254e4e971a366753ce3449a4addeff
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

94483fc by Harald Welte (lafo...@gnumonks.org):

gsm_abis_pgsl: Dissect PACCH uplink messages

The P-GSL uplink PACCH messages contain information about the decoded
access burst information four consecutive frame numbers.  Each burst
individually carries receive level, access burst type (8/11bit),
validity information and access delay.

Change-Id: I9d874d9b2c6de6a5461591e0f1f037ef2c34c143
Reviewed-on: https://code.wireshark.org/review/18682
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  2d34b19   Include header to declare gsm_a_rr_rxlev_vals_ext.
adds  94483fc   gsm_abis_pgsl: Dissect PACCH uplink messages


Summary of changes:
 epan/dissectors/packet-gsm_abis_pgsl.c |   91 
 1 file changed, 91 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis

2016-11-06 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder Visual Studio Code Analysis 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Visual%20Studio%20Code%20Analysis/builds/17535

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: vs-code-analysis

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 61ed49e69cf0895e041f01fcc0c04b9e0fb2047b
Blamelist: Michael Mann 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 2d34b19: Include header to declare gsm_a_rr_rxlev_vals_ext.

2016-11-06 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2d34b19cb6bdebe835cacd958076de50ce330572
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

2d34b19 by Guy Harris (g...@alum.mit.edu):

Include header to declare gsm_a_rr_rxlev_vals_ext.

Change-Id: Ie3fd593ef5ce90dc07037f44fda869c26616afd9
Reviewed-on: https://code.wireshark.org/review/18697
Reviewed-by: Guy Harris 


Actions performed:

from  43a60c0   Added Dissector for Openflow Experimenter Value field for 
Openflow 1.3 and 1.4
adds  2d34b19   Include header to declare gsm_a_rr_rxlev_vals_ext.


Summary of changes:
 epan/dissectors/packet-gsm_abis_pgsl.c |1 +
 1 file changed, 1 insertion(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86

2016-11-06 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder Windows 8.1 x86 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%208.1%20x86/builds/7910

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-8.1-x86

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 61ed49e69cf0895e041f01fcc0c04b9e0fb2047b
Blamelist: Michael Mann 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64

2016-11-06 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202012%20R2%20x64/builds/2187

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 61ed49e69cf0895e041f01fcc0c04b9e0fb2047b
Blamelist: Michael Mann 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64

2016-11-06 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder OSX 10.6 x64 while building 
wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/OSX%2010.6%20x64/builds/12527

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: osx-10.6-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 61ed49e69cf0895e041f01fcc0c04b9e0fb2047b
Blamelist: Michael Mann 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 16.04 x64

2016-11-06 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder Ubuntu 16.04 x64 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Ubuntu%2016.04%20x64/builds/712

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: ubuntu-16.04-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] 61ed49e69cf0895e041f01fcc0c04b9e0fb2047b
Blamelist: Michael Mann 

BUILD FAILED: failed compile

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 43a60c0: Added Dissector for Openflow Experimenter Value field for Openflow 1.3 and 1.4

2016-11-06 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=43a60c03f63259dd0c759d0effe3a5dfc57d6546
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

43a60c0 by sangodbole (sanket.godb...@spirent.com):

Added Dissector for Openflow Experimenter Value field for Openflow 1.3 and 
1.4

Change-Id: I79d7b9afbde34451b545ac7e67c22b012843d822
Reviewed-on: https://code.wireshark.org/review/18654
Petri-Dish: Alexis La Goutte 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  61ed49e   gsm_abis_pgsl: Decode dissection of codec_rxlev
adds  43a60c0   Added Dissector for Openflow Experimenter Value field for 
Openflow 1.3 and 1.4


Summary of changes:
 epan/dissectors/packet-openflow_v4.c |   10 ++
 epan/dissectors/packet-openflow_v5.c |   10 ++
 2 files changed, 20 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 61ed49e: gsm_abis_pgsl: Decode dissection of codec_rxlev

2016-11-06 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=61ed49e69cf0895e041f01fcc0c04b9e0fb2047b
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

61ed49e by Harald Welte (lafo...@gnumonks.org):

gsm_abis_pgsl: Decode dissection of codec_rxlev

Fix a copy+paste mistake (using the codec_csy string for the
codec_rxlev) and use the existing val_str_ext for decoding the GSM/GPRS
RxLev value into a dBm value range.

Change-Id: Ie19621019977f6a41201cca424de3d44ece309b0
Reviewed-on: https://code.wireshark.org/review/18683
Reviewed-by: Pascal Quantin 
Petri-Dish: Pascal Quantin 
Reviewed-by: Michael Mann 


Actions performed:

from  5ae9af9   Get rid of Boolean "flags" that don't have any bit set.
adds  61ed49e   gsm_abis_pgsl: Decode dissection of codec_rxlev


Summary of changes:
 epan/dissectors/packet-gsm_abis_pgsl.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 7b43bc3: Get rid of Boolean "flags" that don't have any bit set.

2016-11-06 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7b43bc331a039bd0dcf2cea7760eb1e3e66b92b3
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

7b43bc3 by Guy Harris (g...@alum.mit.edu):

Get rid of Boolean "flags" that don't have any bit set.

And tweak the Pidl generator for Wireshark not to generate "flags" like
that.

(The generator also does field name and true/false strings' case
differently, so I didn't use it to regenerate the dissectors; that needs
to be looked at.)

Change-Id: I8554d4fbb9dce38d73db41b00823f54b8243545f
Reviewed-on: https://code.wireshark.org/review/18696
Reviewed-by: Guy Harris 


Actions performed:

from  51651d3   [Automatic update for 2016-11-06]
adds  7b43bc3   Get rid of Boolean "flags" that don't have any bit set.


Summary of changes:
 epan/dissectors/packet-dcerpc-eventlog.c   |8 
 epan/dissectors/packet-dcerpc-witness.c|8 
 tools/pidl/lib/Parse/Pidl/Wireshark/NDR.pm |   29 
 3 files changed, 17 insertions(+), 28 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis

2016-11-06 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder Visual Studio Code Analysis 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Visual%20Studio%20Code%20Analysis/builds/17533

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: vs-code-analysis

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] e3fe33a888529f8305d4ebb7482cb44fce9c435a
Blamelist: Pascal Quantin 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 5ae9af9: Get rid of Boolean "flags" that don't have any bit set.

2016-11-06 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5ae9af9e50c89d8700e5a166a9c345fc46b3a4ca
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

5ae9af9 by Guy Harris (g...@alum.mit.edu):

Get rid of Boolean "flags" that don't have any bit set.

And tweak the Pidl generator for Wireshark not to generate "flags" like
that.

(The generator also does field name and true/false strings' case
differently, so I didn't use it to regenerate the dissectors; that needs
to be looked at.)

Change-Id: Ie1657a782ebdb107e58792cedd29bbaa79b17bd4
Reviewed-on: https://code.wireshark.org/review/18695
Reviewed-by: Guy Harris 


Actions performed:

from  a5a179d   Use guint rather than gsize, to avoid 64-bit-to-32-bit 
shortening warnings.
adds  5ae9af9   Get rid of Boolean "flags" that don't have any bit set.


Summary of changes:
 epan/dissectors/packet-dcerpc-eventlog.c   |8 
 epan/dissectors/packet-dcerpc-witness.c|8 
 tools/pidl/lib/Parse/Pidl/Wireshark/NDR.pm |   29 
 3 files changed, 17 insertions(+), 28 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.2 on Ubuntu 16.04 x64

2016-11-06 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder Ubuntu 16.04 x64 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.2/builders/Ubuntu%2016.04%20x64/builds/237

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.2/

Buildslave for this Build: ubuntu-16.04-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master-2.2] 51651d3e5b9563084fbcbaa61ef5e708410bdf34
Blamelist: Gerald Combs 

BUILD FAILED: failed copy-build

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master a5a179d: Use guint rather than gsize, to avoid 64-bit-to-32-bit shortening warnings.

2016-11-06 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a5a179dd4975b00fbb65c86f8f573d1a73b7ef58
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

a5a179d by Guy Harris (g...@alum.mit.edu):

Use guint rather than gsize, to avoid 64-bit-to-32-bit shortening warnings.

Change-Id: Id907cd8c8ea83730674a0bc9b0636d2408b6546c
Reviewed-on: https://code.wireshark.org/review/18694
Reviewed-by: Guy Harris 


Actions performed:

from  e3fe33a   gsm_abis_pgsl: Fix endianness of frame numbers
adds  a5a179d   Use guint rather than gsize, to avoid 64-bit-to-32-bit 
shortening warnings.


Summary of changes:
 epan/dissectors/packet-gsm_abis_pgsl.c |   26 +-
 1 file changed, 13 insertions(+), 13 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64

2016-11-06 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder OSX 10.6 x64 while building 
wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/OSX%2010.6%20x64/builds/12524

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: osx-10.6-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] e3fe33a888529f8305d4ebb7482cb44fce9c435a
Blamelist: Pascal Quantin 

BUILD FAILED: failed compile_3

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64

2016-11-06 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202012%20R2%20x64/builds/2184

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master] e3fe33a888529f8305d4ebb7482cb44fce9c435a
Blamelist: Pascal Quantin 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master e3fe33a: gsm_abis_pgsl: Fix endianness of frame numbers

2016-11-06 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e3fe33a888529f8305d4ebb7482cb44fce9c435a
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

e3fe33a by Harald Welte (lafo...@gnumonks.org):

gsm_abis_pgsl: Fix endianness of frame numbers

The frame numbers are stored as 24bit value in little endian byte order,
not in big endian (as assumed so far).

Change-Id: Ia58db03749375a025e7b3b6b5805687af7601d9a
Reviewed-on: https://code.wireshark.org/review/18681
Reviewed-by: Pascal Quantin 


Actions performed:

from  94b923c   gsm_abis_pgsl: Hand off into GPRS RLC/MAC dissector
adds  e3fe33a   gsm_abis_pgsl: Fix endianness of frame numbers


Summary of changes:
 epan/dissectors/packet-gsm_abis_pgsl.c |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 94b923c: gsm_abis_pgsl: Hand off into GPRS RLC/MAC dissector

2016-11-06 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=94b923c11b6afc5f2ad7ee5a1f27c7fc514b4540
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

94b923c by Harald Welte (lafo...@gnumonks.org):

gsm_abis_pgsl: Hand off into GPRS RLC/MAC dissector

Rather than displaying the P-GSL data as "data", let's call the
proper GPRS RLC/MAC dissector to get a decode of the payload.

As the RLC/MAC payload of P-GSL is one un-aligned stream of bits
containing the EGPRS header + RLC data blocks, we need to re-aling the
data blocks before calling into the RLC/MAC dissector in case of EGRPS.

Change-Id: Ib081606c1b7af2a15ecf3c5f5b3ff44b5096e865
Reviewed-on: https://code.wireshark.org/review/18483
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Pascal Quantin 


Actions performed:

from  37388fb   gsm_abis_pgsl: Dissect Uplink Channel Mode Information 
Element
adds  94b923c   gsm_abis_pgsl: Hand off into GPRS RLC/MAC dissector


Summary of changes:
 epan/dissectors/packet-gsm_abis_pgsl.c |  229 ++--
 1 file changed, 220 insertions(+), 9 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 37388fb: gsm_abis_pgsl: Dissect Uplink Channel Mode Information Element

2016-11-06 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=37388fb72e1736d88bd5033550cc55425014a72f
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

37388fb by Harald Welte (lafo...@gnumonks.org):

gsm_abis_pgsl: Dissect Uplink Channel Mode Information Element

Change-Id: Ibfd490fbdbdb479f0e557be9c0d3ede6f94c5639
Reviewed-on: https://code.wireshark.org/review/18685
Petri-Dish: Pascal Quantin 
Reviewed-by: Pascal Quantin 


Actions performed:

from  1b6816d   gsm_abis_pgsl: Proper interpretation of "Q bits"
adds  37388fb   gsm_abis_pgsl: Dissect Uplink Channel Mode Information 
Element


Summary of changes:
 epan/dissectors/packet-gsm_abis_pgsl.c |   10 +-
 1 file changed, 9 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 1b6816d: gsm_abis_pgsl: Proper interpretation of "Q bits"

2016-11-06 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1b6816df1c6230403c34128f7f43902da2813886
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

1b6816d by Harald Welte (lafo...@gnumonks.org):

gsm_abis_pgsl: Proper interpretation of "Q bits"

Regarding the EGPRS header, a value of '1' means bads checksum/quality,
and '0' means good quality/checksum.  Let's explicitly state this by
overriding the default True/False boolean labels with Bad/Good.

Change-Id: I2168771d5552345c9c2eb6910f2839013da8210e
Reviewed-on: https://code.wireshark.org/review/18684
Petri-Dish: Pascal Quantin 
Reviewed-by: Pascal Quantin 


Actions performed:

from  991cbe8   [Automatic update for 2016-11-06]
adds  1b6816d   gsm_abis_pgsl: Proper interpretation of "Q bits"


Summary of changes:
 epan/dissectors/packet-gsm_abis_pgsl.c |   11 ---
 1 file changed, 8 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 1f87572: E.212: fix identification of PLMNs with 3 digits MNC ending with a 0

2016-11-06 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1f875721bb0e0eb6c22017b03ebfcc8ecd1399ca
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master-2.0
Repository: wireshark

Commits:

1f87572 by Pascal Quantin (pascal.quan...@gmail.com):

E.212: fix identification of PLMNs with 3 digits MNC ending with a 0

Split PLMNs arrays in 2 so as to clearly konw if the MNC is 2 or 3 digits 
long

Bug: 13092
Change-Id: Ic5f776f3c1e5141f8739bf2137ebd046f7e4a0d6
Reviewed-on: https://code.wireshark.org/review/18679
Reviewed-by: Pascal Quantin 
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 
(cherry picked from commit f894379ea73619d6c31e5c4932d93e307741ffec)
Conflicts:
epan/dissectors/packet-e212.c
epan/dissectors/packet-e212.h
epan/dissectors/packet-eap.c
Reviewed-on: https://code.wireshark.org/review/18690


Actions performed:

from  4a2c689   [Automatic update for 2016-11-06]
adds  1f87572   E.212: fix identification of PLMNs with 3 digits MNC ending 
with a 0


Summary of changes:
 epan/dissectors/packet-e212.c | 2987 ++---
 1 file changed, 1584 insertions(+), 1403 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 4a2c689: [Automatic update for 2016-11-06]

2016-11-06 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4a2c68992c3cd700575f2d727a7bd58724db81e2
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master-2.0
Repository: wireshark

Commits:

4a2c689 by Gerald Combs (ger...@wireshark.org):

[Automatic update for 2016-11-06]

Update manuf, services enterprise-numbers, translations, and other items.

Change-Id: I425576823366396959561bdf6015535d45c6a5ce
Reviewed-on: https://code.wireshark.org/review/18693
Reviewed-by: Gerald Combs 


Actions performed:

from  a6d7c42   RTS_FLAG_NONE is a flags field value, but it's not a flag 
bit.
adds  4a2c689   [Automatic update for 2016-11-06]


Summary of changes:
 epan/dissectors/usb.c   |7 +++
 epan/enterprise-numbers |  150 ---
 epan/sminmpec.c |   34 +++
 manuf   |   49 +++-
 services|3 +
 5 files changed, 234 insertions(+), 9 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 51651d3: [Automatic update for 2016-11-06]

2016-11-06 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=51651d3e5b9563084fbcbaa61ef5e708410bdf34
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master-2.2
Repository: wireshark

Commits:

51651d3 by Gerald Combs (ger...@wireshark.org):

[Automatic update for 2016-11-06]

Update manuf, services enterprise-numbers, translations, and other items.

Change-Id: I9c0694c4ee46b1f2219ed9997cad26c6f647fb83
Reviewed-on: https://code.wireshark.org/review/18692
Reviewed-by: Gerald Combs 


Actions performed:

from  ddbec0a   GVSP: enforce heuristic (get some false positive with STUN)
adds  51651d3   [Automatic update for 2016-11-06]


Summary of changes:
 epan/dissectors/usb.c   |7 +++
 epan/enterprise-numbers |  150 ---
 epan/sminmpec.c |   34 +++
 manuf   |   61 ++-
 services|3 +
 5 files changed, 246 insertions(+), 9 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 991cbe8: [Automatic update for 2016-11-06]

2016-11-06 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=991cbe81c137d73b919a75a6c751f3e402d5acc9
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master
Repository: wireshark

Commits:

991cbe8 by Gerald Combs (ger...@wireshark.org):

[Automatic update for 2016-11-06]

Update manuf, services enterprise-numbers, translations, and other items.

Change-Id: Ia867e3b78363ba806ab99dd8da321f5f48c279cc
Reviewed-on: https://code.wireshark.org/review/18691
Reviewed-by: Gerald Combs 


Actions performed:

from  6862820   TCAP: Use a real dissector table to store dissector handles.
adds  991cbe8   [Automatic update for 2016-11-06]


Summary of changes:
 AUTHORS  |5 ++
 epan/dissectors/usb.c|9 +-
 epan/enterprise-numbers  |  150 +++--
 epan/sminmpec.c  |   34 
 manuf|   61 +-
 services |3 +
 ui/qt/wireshark_de.ts|  205 +-
 ui/qt/wireshark_en.ts|  205 +-
 ui/qt/wireshark_fr.ts|  205 +-
 ui/qt/wireshark_it.ts|  205 +-
 ui/qt/wireshark_ja_JP.ts |  205 +-
 ui/qt/wireshark_pl.ts|  205 +-
 ui/qt/wireshark_zh_CN.ts |  205 +-
 13 files changed, 1022 insertions(+), 675 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.2 on Windows Server 2012 R2 x64

2016-11-06 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.2/builders/Windows%20Server%202012%20R2%20x64/builds/308

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.2/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch master-2.2] ddbec0a1ab41dd67708923f2488d88c8705395a9
Blamelist: Michael Mann 

BUILD FAILED: failed test.sh

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 6862820: TCAP: Use a real dissector table to store dissector handles.

2016-11-06 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=686282083420f26a4e4584053fadbba568ef534f
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

6862820 by Michael Mann (mman...@netscape.net):

TCAP: Use a real dissector table to store dissector handles.

Also cleanup ANSI TCAP dissector that had a commented out attempt at what
was just cleaned up with TCAP.

Change-Id: I347f11e21a493d8d444c2dc528bb7713a227381a
Reviewed-on: https://code.wireshark.org/review/18129
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  d3389fa   Add wlan_radio preference to assume 802.11 preamble is 
short for duration calculations.
adds  6862820   TCAP: Use a real dissector table to store dissector handles.


Summary of changes:
 .../asn1/ansi_tcap/packet-ansi_tcap-template.c |   22 ---
 epan/dissectors/asn1/tcap/packet-tcap-template.c   |   24 -
 epan/dissectors/packet-ansi_tcap.c |   28 +++-
 epan/dissectors/packet-tcap.c  |   24 -
 4 files changed, 27 insertions(+), 71 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master d3389fa: Add wlan_radio preference to assume 802.11 preamble is short for duration calculations.

2016-11-06 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d3389fab94c23c2b4e1c9b9dbf77851379b50eec
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

d3389fa by Simon Barber (simon.bar...@meraki.net):

Add wlan_radio preference to assume 802.11 preamble is short for duration
calculations.

Change-Id: Ie314f7caee067b16da8dcb2a45cb1395ce0cb266
Reviewed-on: https://code.wireshark.org/review/17719
Petri-Dish: Michael Mann 
Reviewed-by: Alexis La Goutte 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  c665926   gsm_abis_pgsl: Fix dissection of PGSL-STATUS-IND
adds  d3389fa   Add wlan_radio preference to assume 802.11 preamble is 
short for duration calculations.


Summary of changes:
 epan/dissectors/packet-ieee80211-radio.c |   16 +++-
 1 file changed, 15 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 ddbec0a: GVSP: enforce heuristic (get some false positive with STUN)

2016-11-06 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ddbec0a1ab41dd67708923f2488d88c8705395a9
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master-2.2
Repository: wireshark

Commits:

ddbec0a by Alexis La Goutte (alexis.lagou...@gmail.com):

GVSP: enforce heuristic (get some false positive with STUN)

Change-Id: Ic1da51a71ee4fa60267751d7bb3f46225ad2f084
Reviewed-on: https://code.wireshark.org/review/16573
Petri-Dish: Alexis La Goutte 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 
(cherry picked from commit 6fbaf9be34e8745b2781294afdcf2822528a6349)
Reviewed-on: https://code.wireshark.org/review/18652
Petri-Dish: Michael Mann 
Reviewed-by: Michael Mann 


Actions performed:

from  c680283   E.212: fix identification of PLMNs with 3 digits MNC ending 
with a 0
adds  ddbec0a   GVSP: enforce heuristic (get some false positive with STUN)


Summary of changes:
 epan/dissectors/packet-gvsp.c |   10 ++
 1 file changed, 10 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 c680283: E.212: fix identification of PLMNs with 3 digits MNC ending with a 0

2016-11-06 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c68028362de3a6311d89dce66775369b3ae8bd79
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master-2.2
Repository: wireshark

Commits:

c680283 by Pascal Quantin (pascal.quan...@gmail.com):

E.212: fix identification of PLMNs with 3 digits MNC ending with a 0

Split PLMNs arrays in 2 so as to clearly konw if the MNC is 2 or 3 digits 
long

Bug: 13092
Change-Id: Ic5f776f3c1e5141f8739bf2137ebd046f7e4a0d6
Reviewed-on: https://code.wireshark.org/review/18679
Reviewed-by: Pascal Quantin 
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 
(cherry picked from commit f894379ea73619d6c31e5c4932d93e307741ffec)
Conflicts:
epan/dissectors/packet-e212.c
epan/dissectors/packet-e212.h
epan/dissectors/packet-eap.c
Reviewed-on: https://code.wireshark.org/review/18688


Actions performed:

from  eabf820   6LoWPAN: Use correct full name
adds  c680283   E.212: fix identification of PLMNs with 3 digits MNC ending 
with a 0


Summary of changes:
 epan/dissectors/packet-e212.c | 2988 ++---
 1 file changed, 1584 insertions(+), 1404 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master c665926: gsm_abis_pgsl: Fix dissection of PGSL-STATUS-IND

2016-11-06 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c665926bab23034e7b231cec4ca7b95c40e2a928
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

c665926 by Harald Welte (lafo...@gnumonks.org):

gsm_abis_pgsl: Fix dissection of PGSL-STATUS-IND

The frame number is (as in all messages) three bytes long, not just one
byte.

Change-Id: I461121d61d2515f51462a3df1086ab988e4afab5
Reviewed-on: https://code.wireshark.org/review/18686
Reviewed-by: Pascal Quantin 


Actions performed:

from  e95519b   lua: Added new integer sizes in TvbRange
adds  c665926   gsm_abis_pgsl: Fix dissection of PGSL-STATUS-IND


Summary of changes:
 epan/dissectors/packet-gsm_abis_pgsl.c |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master e95519b: lua: Added new integer sizes in TvbRange

2016-11-06 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e95519b7f95517780e912df1277f06f707d1176e
Submitter: Alexis La Goutte (alexis.lagou...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

e95519b by Franklin "Snaipe" Mathieu (sna...@diacritic.io):

lua: Added new integer sizes in TvbRange

* Added support for 3-byte integers in :int() and :le_int()
* Added support for 5, 6, and 7-byte integers in :int64() and :le_int64()

Change-Id: If9ab4ea806191bc63effe45a081b9c65693c2367
Signed-off-by: Franklin "Snaipe" Mathieu 
Reviewed-on: https://code.wireshark.org/review/18672
Reviewed-by: Peter Wu 
Petri-Dish: Peter Wu 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Alexis La Goutte 


Actions performed:

from  f894379   E.212: fix identification of PLMNs with 3 digits MNC ending 
with a 0
adds  e95519b   lua: Added new integer sizes in TvbRange


Summary of changes:
 epan/wslua/wslua_tvb.c |   42 --
 test/lua/tvb.lua   |   28 +++-
 2 files changed, 63 insertions(+), 7 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe