[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64

2016-12-02 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202012%20R2%20x64/builds/2329

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master] 
db7c6286169015a727024e86eb270722127125bb
Blamelist: Guy Harris 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master db7c628: Temporarily break up complicated expression into a bunch of separate ifs.

2016-12-02 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=db7c6286169015a727024e86eb270722127125bb
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

db7c628 by Guy Harris (g...@alum.mit.edu):

Temporarily break up complicated expression into a bunch of separate ifs.

Maybe this way we can identify which *particular* test is, according to
Valgrind, looking at uninitialized data; there's nothing obvious that
shows up from inspecting the code, and neither of our static analyzers
seem to have found anything.

Change-Id: I80f6bb8e6fa92decfe195c01766330b97e980821
Reviewed-on: https://code.wireshark.org/review/19049
Reviewed-by: Guy Harris 


Actions performed:

from  2462f9e   packet-rpcrdma: Fix protocol frame pre-detection
adds  db7c628   Temporarily break up complicated expression into a bunch of 
separate ifs.


Summary of changes:
 epan/dissectors/packet-cops.c |   63 +
 1 file changed, 63 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.2 on Ubuntu 16.04 x64

2016-12-02 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder Ubuntu 16.04 x64 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.2/builders/Ubuntu%2016.04%20x64/builds/290

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.2/

Buildslave for this Build: ubuntu-16.04-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master-2.2] 
043e92ab030094036d1188daf728f546e6a5f668
Blamelist: Michael Mann 

BUILD FAILED: failed copy-build

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 043e92a: packet-rpcrdma: Fix protocol frame pre-detection

2016-12-02 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=043e92ab030094036d1188daf728f546e6a5f668
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master-2.2
Repository: wireshark

Commits:

043e92a by Chuck Lever (chuck.le...@oracle.com):

packet-rpcrdma: Fix protocol frame pre-detection

The current mechanism of detecting RPC-over-RDMA is broken because
it treats the Read list as a counted array (it's a list); and treats
the Write list and Reply chunk identically (one is a list, one is
always a single chunk).

While we're here, refactor pre-detection helper functions so they
can be used during frame dissection as well.

Bug: 13196
Change-Id: I76e210c8d2a9464fed00e7199072d37f4ebbebf2
Signed-off-by: Chuck Lever 
Reviewed-on: https://code.wireshark.org/review/19025
Petri-Dish: Michael Mann 
Reviewed-by: Michael Mann 
(cherry picked from commit 2462f9e8103b23c2728cc5aa84995e0b2f363f12)
Reviewed-on: https://code.wireshark.org/review/19044


Actions performed:

from  0798e0a   Include config.h at the very beginning of all Flex scanners.
adds  043e92a   packet-rpcrdma: Fix protocol frame pre-detection


Summary of changes:
 epan/dissectors/packet-rpcrdma.c |  127 +++---
 1 file changed, 90 insertions(+), 37 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 eee5f97: packet-rpcrdma: Fix protocol frame pre-detection

2016-12-02 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=eee5f975d37f195b6a9173e5ebc14cbadf44567c
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master-2.0
Repository: wireshark

Commits:

eee5f97 by Chuck Lever (chuck.le...@oracle.com):

packet-rpcrdma: Fix protocol frame pre-detection

The current mechanism of detecting RPC-over-RDMA is broken because
it treats the Read list as a counted array (it's a list); and treats
the Write list and Reply chunk identically (one is a list, one is
always a single chunk).

While we're here, refactor pre-detection helper functions so they
can be used during frame dissection as well.

Bug: 13196
Change-Id: I76e210c8d2a9464fed00e7199072d37f4ebbebf2
Signed-off-by: Chuck Lever 
Reviewed-on: https://code.wireshark.org/review/19025
Petri-Dish: Michael Mann 
Reviewed-by: Michael Mann 
(cherry picked from commit 2462f9e8103b23c2728cc5aa84995e0b2f363f12)
Reviewed-on: https://code.wireshark.org/review/19045


Actions performed:

from  30c1081   packet-rpcrdma: Dissector should exit when frame is not 
RPC-over-RDMA
adds  eee5f97   packet-rpcrdma: Fix protocol frame pre-detection


Summary of changes:
 epan/dissectors/packet-rpcrdma.c |  127 +++---
 1 file changed, 90 insertions(+), 37 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 2462f9e: packet-rpcrdma: Fix protocol frame pre-detection

2016-12-02 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2462f9e8103b23c2728cc5aa84995e0b2f363f12
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

2462f9e by Chuck Lever (chuck.le...@oracle.com):

packet-rpcrdma: Fix protocol frame pre-detection

The current mechanism of detecting RPC-over-RDMA is broken because
it treats the Read list as a counted array (it's a list); and treats
the Write list and Reply chunk identically (one is a list, one is
always a single chunk).

While we're here, refactor pre-detection helper functions so they
can be used during frame dissection as well.

Bug: 13196
Change-Id: I76e210c8d2a9464fed00e7199072d37f4ebbebf2
Signed-off-by: Chuck Lever 
Reviewed-on: https://code.wireshark.org/review/19025
Petri-Dish: Michael Mann 
Reviewed-by: Michael Mann 


Actions performed:

from  54f48c8   echo: decide on req/resp based on matched port
adds  2462f9e   packet-rpcrdma: Fix protocol frame pre-detection


Summary of changes:
 epan/dissectors/packet-rpcrdma.c |  127 +++---
 1 file changed, 90 insertions(+), 37 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 54f48c8: echo: decide on req/resp based on matched port

2016-12-02 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=54f48c8b92475523a49c15cd549fb5408e96ea8d
Submitter: Peter Wu (pe...@lekensteyn.nl)
Changed: branch: master
Repository: wireshark

Commits:

54f48c8 by Jaap Keuter (jaap.keu...@xs4all.nl):

echo: decide on req/resp based on matched port

Since the use of 'Decode as' can result in another port number than the
default port (7) being the service port, this should be checked against.

Change-Id: I93383613115595fff621e2fb9ab7959cd448c01e
Reviewed-on: https://code.wireshark.org/review/18991
Reviewed-by: Jaap Keuter 
Petri-Dish: Jaap Keuter 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Peter Wu 


Actions performed:

from  14bae88   packet-rpcrdma: Display length and version fields in decimal
adds  54f48c8   echo: decide on req/resp based on matched port


Summary of changes:
 epan/dissectors/packet-echo.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 0798e0a: Include config.h at the very beginning of all Flex scanners.

2016-12-02 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0798e0ac6c3961ca4471335bbfac1691fbeac954
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

0798e0a by Guy Harris (g...@alum.mit.edu):

Include config.h at the very beginning of all Flex scanners.

That way, if we #define anything for large file support, that's done
before we include any system header files that either depend on that
definition or that define it themselves if it's not already defined.

Change-Id: I9b07344151103be337899dead44d6960715d6813
Reviewed-on: https://code.wireshark.org/review/19035
Petri-Dish: Guy Harris 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Guy Harris 
(cherry picked from commit 6f373175396a06b8e1a91acec6031322d91ef9dd)
Reviewed-on: https://code.wireshark.org/review/19043


Actions performed:

from  e0d9408   packet-rpcrdma: Dissector should exit when frame is not 
RPC-over-RDMA
adds  0798e0a   Include config.h at the very beginning of all Flex scanners.


Summary of changes:
 epan/dfilter/scanner.l   |7 +--
 epan/diam_dict.l |7 +--
 epan/dtd_parse.l |7 +--
 epan/dtd_preparse.l  |7 +--
 epan/radius_dict.l   |7 +--
 epan/uat_load.l  |7 +--
 plugins/mate/mate_parser.l   |5 +
 plugins/wimaxasncp/wimaxasncp_dict.l |7 +--
 text2pcap-scanner.l  |5 +
 ui/text_import_scanner.l |7 +--
 wiretap/ascend_scanner.l |7 +--
 wiretap/k12text.l|6 +-
 12 files changed, 60 insertions(+), 19 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 14bae88: packet-rpcrdma: Display length and version fields in decimal

2016-12-02 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=14bae88e0f7827ccf470704a9b997dfd5e665319
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

14bae88 by Chuck Lever (chuck.le...@oracle.com):

packet-rpcrdma: Display length and version fields in decimal

Display length fields in decimal, just as they are displayed by the
RDMA RETH dissector.

Display version fields in decimal, just as they are displayed by the
RPC dissector.

RDMA offset fields are left in hexadecimal since they are
essentially addresses, and at least the Linux RPC-over-RDMA
implementation has debugging messages that display these as
hexadecimal values.

Change-Id: I7206970675ca0ca486b3a2837b6dbb1c4d764091
Signed-off-by: Chuck Lever 
Reviewed-on: https://code.wireshark.org/review/19028
Reviewed-by: Michael Mann 


Actions performed:

from  aecff2f   Include config.h first, for large-file-related #defines.
adds  14bae88   packet-rpcrdma: Display length and version fields in decimal


Summary of changes:
 epan/dissectors/packet-rpcrdma.c |   16 
 1 file changed, 8 insertions(+), 8 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 30c1081: packet-rpcrdma: Dissector should exit when frame is not RPC-over-RDMA

2016-12-02 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=30c1081e6e3bd0878be512867192cbada8c9ba39
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master-2.0
Repository: wireshark

Commits:

30c1081 by Chuck Lever (chuck.le...@oracle.com):

packet-rpcrdma: Dissector should exit when frame is not RPC-over-RDMA

On an RDMA transport, RPC protocol never appears in a frame by
itself. If RPC-over-RDMA is not present, then RPC is by definition
not present as an InfiniBand data payload.

Bug: 13195
Change-Id: Icaea9d4936477af32adc73140c67539e977a7a9a
Signed-off-by: Chuck Lever 
Reviewed-on: https://code.wireshark.org/review/19024
Reviewed-by: Michael Mann 
(cherry picked from commit d5bdf7bac0c829cb00def4abb08444fe96d51e06)
Reviewed-on: https://code.wireshark.org/review/19041
(cherry picked from commit e0d9408b98cf3381b4f8dc554924d5ae4ec12596)
Reviewed-on: https://code.wireshark.org/review/19042


Actions performed:

from  6f64047   Qt: Export object fixups.
adds  30c1081   packet-rpcrdma: Dissector should exit when frame is not 
RPC-over-RDMA


Summary of changes:
 epan/dissectors/packet-rpcrdma.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 e0d9408: packet-rpcrdma: Dissector should exit when frame is not RPC-over-RDMA

2016-12-02 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e0d9408b98cf3381b4f8dc554924d5ae4ec12596
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master-2.2
Repository: wireshark

Commits:

e0d9408 by Chuck Lever (chuck.le...@oracle.com):

packet-rpcrdma: Dissector should exit when frame is not RPC-over-RDMA

On an RDMA transport, RPC protocol never appears in a frame by
itself. If RPC-over-RDMA is not present, then RPC is by definition
not present as an InfiniBand data payload.

Bug: 13195
Change-Id: Icaea9d4936477af32adc73140c67539e977a7a9a
Signed-off-by: Chuck Lever 
Reviewed-on: https://code.wireshark.org/review/19024
Reviewed-by: Michael Mann 
(cherry picked from commit d5bdf7bac0c829cb00def4abb08444fe96d51e06)
Reviewed-on: https://code.wireshark.org/review/19041


Actions performed:

from  84562bc   Include config.h first, for large-file-related #defines.
adds  e0d9408   packet-rpcrdma: Dissector should exit when frame is not 
RPC-over-RDMA


Summary of changes:
 epan/dissectors/packet-rpcrdma.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 84562bc: Include config.h first, for large-file-related #defines.

2016-12-02 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=84562bc3554c785c945d90675aaa4e5fad57698e
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

84562bc by Guy Harris (g...@alum.mit.edu):

Include config.h first, for large-file-related #defines.

Change-Id: Iced77fb65c2db8bc370cefe4c48c972fe1262f92
Reviewed-on: https://code.wireshark.org/review/19039
Reviewed-by: Guy Harris 
(cherry picked from commit aecff2f67995905e58cacd9c4b7e5a7220a26e3b)
Reviewed-on: https://code.wireshark.org/review/19040


Actions performed:

from  beda14c   Include config.h first, for large-file-related #defines.
adds  84562bc   Include config.h first, for large-file-related #defines.


Summary of changes:
 randpkt_core/randpkt_core.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master aecff2f: Include config.h first, for large-file-related #defines.

2016-12-02 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=aecff2f67995905e58cacd9c4b7e5a7220a26e3b
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

aecff2f by Guy Harris (g...@alum.mit.edu):

Include config.h first, for large-file-related #defines.

Change-Id: Iced77fb65c2db8bc370cefe4c48c972fe1262f92
Reviewed-on: https://code.wireshark.org/review/19039
Reviewed-by: Guy Harris 


Actions performed:

from  d5bdf7b   packet-rpcrdma: Dissector should exit when frame is not 
RPC-over-RDMA
adds  aecff2f   Include config.h first, for large-file-related #defines.


Summary of changes:
 randpkt_core/randpkt_core.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64

2016-12-02 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202012%20R2%20x64/builds/2324

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master-2.0] 
6f64047ade14c84caf37c69b55912839a6a15734
Blamelist: Michael Mann 

BUILD FAILED: failed compile_4 compile_6 sign WiX installer

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master d5bdf7b: packet-rpcrdma: Dissector should exit when frame is not RPC-over-RDMA

2016-12-02 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d5bdf7bac0c829cb00def4abb08444fe96d51e06
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

d5bdf7b by Chuck Lever (chuck.le...@oracle.com):

packet-rpcrdma: Dissector should exit when frame is not RPC-over-RDMA

On an RDMA transport, RPC protocol never appears in a frame by
itself. If RPC-over-RDMA is not present, then RPC is by definition
not present as an InfiniBand data payload.

Bug: 13195
Change-Id: Icaea9d4936477af32adc73140c67539e977a7a9a
Signed-off-by: Chuck Lever 
Reviewed-on: https://code.wireshark.org/review/19024
Reviewed-by: Michael Mann 


Actions performed:

from  4dc7873   Include config.h first, for large-file-related #defines.
adds  d5bdf7b   packet-rpcrdma: Dissector should exit when frame is not 
RPC-over-RDMA


Summary of changes:
 epan/dissectors/packet-rpcrdma.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 beda14c: Include config.h first, for large-file-related #defines.

2016-12-02 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=beda14c60e3641df36fba81a09a57f36aeffd0a8
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

beda14c by Guy Harris (g...@alum.mit.edu):

Include config.h first, for large-file-related #defines.

Change-Id: Id71326bc89e1461b100df99b618a1c49256b93af
Reviewed-on: https://code.wireshark.org/review/19037
Reviewed-by: Guy Harris 
(cherry picked from commit 4dc787361202e6ba142672b312e44dd296db8852)
Reviewed-on: https://code.wireshark.org/review/19038


Actions performed:

from  6721868   BOOTP: Fix V-I Vendor-Specific Information Option
adds  beda14c   Include config.h first, for large-file-related #defines.


Summary of changes:
 epan/wslua/wslua_struct.c |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 16.04 x64

2016-12-02 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder Ubuntu 16.04 x64 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Ubuntu%2016.04%20x64/builds/851

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: ubuntu-16.04-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master-2.0] 
6f64047ade14c84caf37c69b55912839a6a15734
Blamelist: Michael Mann 

BUILD FAILED: failed check licenses

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 4dc7873: Include config.h first, for large-file-related #defines.

2016-12-02 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4dc787361202e6ba142672b312e44dd296db8852
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

4dc7873 by Guy Harris (g...@alum.mit.edu):

Include config.h first, for large-file-related #defines.

Change-Id: Id71326bc89e1461b100df99b618a1c49256b93af
Reviewed-on: https://code.wireshark.org/review/19037
Reviewed-by: Guy Harris 


Actions performed:

from  6f37317   Include config.h at the very beginning of all Flex scanners.
adds  4dc7873   Include config.h first, for large-file-related #defines.


Summary of changes:
 epan/wslua/wslua_struct.c |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 6721868: BOOTP: Fix V-I Vendor-Specific Information Option

2016-12-02 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6721868766fd6f0df0859c3cf36777da69a2b3ef
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master-2.2
Repository: wireshark

Commits:

6721868 by Jaap Keuter (jaap.keu...@xs4all.nl):

BOOTP: Fix V-I Vendor-Specific Information Option

Apply the same value checks to the vendor generic suboption dissection
as is done for the Cable lab and ADSL forum ones.
See https://ask.wireshark.org/questions/57695 for an example issue.

Change-Id: I4fe07d07cf0a93f4693e5ff54dd70c008701cf41
Reviewed-on: https://code.wireshark.org/review/18999
Reviewed-by: Jaap Keuter 
Petri-Dish: Jaap Keuter 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 
(cherry picked from commit 9ca313cfbe4993a0a36520d216a3e4282b0b7b99)
Reviewed-on: https://code.wireshark.org/review/19020
Petri-Dish: Michael Mann 


Actions performed:

from  a512ff6   Make sure config.h is included before inet_addr.h.
adds  6721868   BOOTP: Fix V-I Vendor-Specific Information Option


Summary of changes:
 epan/dissectors/packet-bootp.c |   50 +---
 1 file changed, 37 insertions(+), 13 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 6f37317: Include config.h at the very beginning of all Flex scanners.

2016-12-02 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6f373175396a06b8e1a91acec6031322d91ef9dd
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

6f37317 by Guy Harris (g...@alum.mit.edu):

Include config.h at the very beginning of all Flex scanners.

That way, if we #define anything for large file support, that's done
before we include any system header files that either depend on that
definition or that define it themselves if it's not already defined.

Change-Id: I9b07344151103be337899dead44d6960715d6813
Reviewed-on: https://code.wireshark.org/review/19035
Petri-Dish: Guy Harris 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Guy Harris 


Actions performed:

from  2ec9093   Make SMB2 MessageId field a FT_UINT64
adds  6f37317   Include config.h at the very beginning of all Flex scanners.


Summary of changes:
 epan/dfilter/scanner.l   |7 +--
 epan/diam_dict.l |7 +--
 epan/dtd_parse.l |7 +--
 epan/dtd_preparse.l  |7 +--
 epan/radius_dict.l   |7 +--
 epan/uat_load.l  |7 +--
 plugins/mate/mate_parser.l   |5 +
 plugins/wimaxasncp/wimaxasncp_dict.l |7 +--
 text2pcap-scanner.l  |5 +
 ui/text_import_scanner.l |7 +--
 wiretap/ascend_scanner.l |7 +--
 wiretap/k12text.l|6 +-
 12 files changed, 60 insertions(+), 19 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86

2016-12-02 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder Windows 8.1 x86 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%208.1%20x86/builds/8052

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-8.1-x86

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master-2.0] 
6f64047ade14c84caf37c69b55912839a6a15734
Blamelist: Michael Mann 

BUILD FAILED: failed compile_4 compile_6 sign WiX installer

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.0 on Windows 8.1 x86

2016-12-02 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder Windows 8.1 x86 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.0/builders/Windows%208.1%20x86/builds/1096

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.0/

Buildslave for this Build: windows-8.1-x86

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master-2.0] 
6f64047ade14c84caf37c69b55912839a6a15734
Blamelist: Michael Mann 

BUILD FAILED: failed test.sh

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 6f64047: Qt: Export object fixups.

2016-12-02 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6f64047ade14c84caf37c69b55912839a6a15734
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master-2.0
Repository: wireshark

Commits:

6f64047 by Gerald Combs (ger...@wireshark.org):

Qt: Export object fixups.

Add eo_free_entry, which frees an export_object_entry_t.

Create ExportObjectTreeWidgetItem similar to our other custom
TreeWidgetItems. Call eo_free_entry in its destructor. This fixes a
serious memory leak.

Make the columns sortable. Fixup numeric comparisons. Use a convenience
function for file sizes.

Ping-Bug: 13174
Change-Id: Idb4eb5680afe760880ebe7d84216fcac5ccdb250
Reviewed-on: https://code.wireshark.org/review/19010
Petri-Dish: Michael Mann 
Reviewed-by: Gerald Combs 
Reviewed-by: Michael Mann 
(cherry picked from commit e7042d8af3ead1ff43b48d0a3b669c286c970cb5)
Reviewed-on: https://code.wireshark.org/review/19021


Actions performed:

from  5dc08c6   Qt: fix crash when closing RTP player while playing
adds  6f64047   Qt: Export object fixups.


Summary of changes:
 ui/export_object.c |   10 
 ui/export_object.h |1 +
 ui/gtk/export_object_dlg.c |8 +--
 ui/qt/export_object_dialog.cpp |  128 
 ui/qt/export_object_dialog.h   |5 --
 5 files changed, 117 insertions(+), 35 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 2ec9093: Make SMB2 MessageId field a FT_UINT64

2016-12-02 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2ec9093ed8a21737bfad150bc9daa6b3a6bb103b
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

2ec9093 by Michael Mann (mman...@netscape.net):

Make SMB2 MessageId field a FT_UINT64

Also adjust the smb2_info_t structure that handles the value.

Bug: 12915
Change-Id: Ia314b8dc840b9d26d2c1d185f06ef93f242a3a7b
Reviewed-on: https://code.wireshark.org/review/19019
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  d2e2d7c   Put tap-exportobject.h into the release tarball.
adds  2ec9093   Make SMB2 MessageId field a FT_UINT64


Summary of changes:
 epan/dissectors/packet-smb2.c |4 ++--
 epan/dissectors/packet-smb2.h |2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 a512ff6: Make sure config.h is included before inet_addr.h.

2016-12-02 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a512ff643e509d93ab092035395a756db1378623
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

a512ff6 by Guy Harris (g...@alum.mit.edu):

Make sure config.h is included before inet_addr.h.

Otherwise, _FILE_OFFSET_BITS might be defined by a header file included
by inet_addr.h before it gets defined by config.h.

Change-Id: I5987b3f1493b81fd2d427d9792b9606117b255d0
Reviewed-on: https://code.wireshark.org/review/19018
Reviewed-by: Guy Harris 
(cherry picked from commit 6ac40522af625971a6cb7b7e1ab56c7834e335db)
Reviewed-on: https://code.wireshark.org/review/19023


Actions performed:

from  e7042d8   Qt: Export object fixups.
adds  a512ff6   Make sure config.h is included before inet_addr.h.


Summary of changes:
 wsutil/inet_addr.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master d2e2d7c: Put tap-exportobject.h into the release tarball.

2016-12-02 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d2e2d7c1a820fd6612f54ed4bccd1671a720c2a4
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

d2e2d7c by Guy Harris (g...@alum.mit.edu):

Put tap-exportobject.h into the release tarball.

Change-Id: I5c103c5b513c32c5de0ea90956f9049fd6b0edec
Reviewed-on: https://code.wireshark.org/review/19022
Reviewed-by: Guy Harris 


Actions performed:

from  20c57cb   Enable exporting objects with tshark
adds  d2e2d7c   Put tap-exportobject.h into the release tarball.


Summary of changes:
 ui/cli/Makefile.am |1 +
 1 file changed, 1 insertion(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 e7042d8: Qt: Export object fixups.

2016-12-02 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e7042d8af3ead1ff43b48d0a3b669c286c970cb5
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master-2.2
Repository: wireshark

Commits:

e7042d8 by Gerald Combs (ger...@wireshark.org):

Qt: Export object fixups.

Add eo_free_entry, which frees an export_object_entry_t.

Create ExportObjectTreeWidgetItem similar to our other custom
TreeWidgetItems. Call eo_free_entry in its destructor. This fixes a
serious memory leak.

Make the columns sortable. Fixup numeric comparisons. Use a convenience
function for file sizes.

Ping-Bug: 13174
Change-Id: Idb4eb5680afe760880ebe7d84216fcac5ccdb250
Reviewed-on: https://code.wireshark.org/review/19010
Petri-Dish: Michael Mann 
Reviewed-by: Gerald Combs 
Reviewed-by: Michael Mann 


Actions performed:

from  1b6606e   Do *NOT* strip newlines from the standard input of sed.
adds  e7042d8   Qt: Export object fixups.


Summary of changes:
 ui/export_object.c |   10 
 ui/export_object.h |1 +
 ui/gtk/export_object_dlg.c |8 +--
 ui/qt/export_object_dialog.cpp |  128 
 ui/qt/export_object_dialog.h   |5 --
 5 files changed, 117 insertions(+), 35 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 16.04 x64

2016-12-02 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder Ubuntu 16.04 x64 while 
building Wireshark (development). Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Ubuntu%2016.04%20x64/builds/848

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: ubuntu-16.04-x64

Build Reason: A build was forced by 'Guy Harris': Changes aren't triggering 
builds
Build Source Stamp: HEAD
Blamelist: 

BUILD FAILED: failed make distcheck

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 20c57cb: Enable exporting objects with tshark

2016-12-02 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=20c57cb298e4f3b7ac66a22fb7477e4cf424a11b
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

20c57cb by Moshe Kaplan (m...@moshekaplan.com):

Enable exporting objects with tshark

A new "--export-object ," option is added to tshark.

This required refactoring Export Object behavior in all GUIs to give the
export object handling to the dissector, rather than the ui layer.
Included in the refactoring was fixing some serious memory leaks in Qt
Export Object dialog, crash due to memory scope issues in GTK Export
Object dialog, and addition sorting column feature in Qt dialog (set
up by creating a widget to manage the items that were previously
leaking memory)

Bug: 9319
Ping-Bug: 13174
Change-Id: I515d7662fa1f150f672b1476716f347ec27deb9b
Reviewed-on: https://code.wireshark.org/review/18927
Tested-by: Petri Dish Buildbot 
Reviewed-by: Peter Wu 
Tested-by: Michael Mann 
Reviewed-by: Michael Mann 


Actions performed:

from  9ca313c   BOOTP: Fix V-I Vendor-Specific Information Option
adds  20c57cb   Enable exporting objects with tshark


Summary of changes:
 CMakeLists.txt |1 +
 debian/libwireshark0.symbols   |   10 +
 doc/tshark.pod |   13 +
 docbook/release-notes.asciidoc |1 +
 epan/CMakeLists.txt|1 +
 epan/Makefile.am   |2 +
 epan/dissectors/packet-dcm.c   |   35 +-
 epan/dissectors/packet-http.c  |   31 +-
 epan/dissectors/packet-imf.c   |   32 +-
 epan/dissectors/packet-smb.c   |  423 +-
 epan/dissectors/packet-tftp.c  |   91 +++-
 {ui => epan}/export_object.c   |  165 +++
 epan/export_object.h   |  155 +++
 tshark.c   |   16 +
 ui/CMakeLists.txt  |7 +-
 ui/Makefile.am |9 +-
 ui/cli/Makefile.am |2 +
 ui/cli/tap-exportobject.c  |  279 
 frame_tvbuff.h => ui/cli/tap-exportobject.h|   20 +-
 ui/export_object.h |   89 
 ui/export_object_dicom.c   |   78 
 ui/export_object_http.c|   75 
 ui/export_object_imf.c |   75 
 ui/export_object_smb.c |  470 
 ui/export_object_tftp.c|  138 --
 ui/{export_object.c => export_object_ui.c} |   87 +---
 ui/{console.h => export_object_ui.h}   |   28 +-
 ui/gtk/export_object_dlg.c |  115 ++---
 ui/gtk/export_object_dlg.h |8 +-
 ui/gtk/main_menubar.c  |   86 +++-
 ui/qt/CMakeLists.txt   |2 +
 ui/qt/Makefile.am  |2 +
 .../{simple_dialog.h => export_object_action.cpp}  |   47 +-
 ui/qt/{about_dialog.h => export_object_action.h}   |   36 +-
 ui/qt/export_object_dialog.cpp |  209 ++---
 ui/qt/export_object_dialog.h   |   28 +-
 ui/qt/main_window.cpp  |   24 +
 ui/qt/main_window.h|8 +-
 ui/qt/main_window.ui   |   30 --
 ui/qt/main_window_slots.cpp|   36 +-
 40 files changed, 1551 insertions(+), 1413 deletions(-)
 copy {ui => epan}/export_object.c (52%)
 create mode 100644 epan/export_object.h
 create mode 100644 ui/cli/tap-exportobject.c
 copy frame_tvbuff.h => ui/cli/tap-exportobject.h (72%)
 delete mode 100644 ui/export_object.h
 delete mode 100644 ui/export_object_dicom.c
 delete mode 100644 ui/export_object_http.c
 delete mode 100644 ui/export_object_imf.c
 delete mode 100644 ui/export_object_smb.c
 delete mode 100644 ui/export_object_tftp.c
 rename ui/{export_object.c => export_object_ui.c} (52%)
 copy ui/{console.h => export_object_ui.h} (72%)
 copy ui/qt/{simple_dialog.h => export_object_action.cpp} (62%)
 copy ui/qt/{about_dialog.h => export_object_action.h} (67%)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits

[Wireshark-commits] master 9ca313c: BOOTP: Fix V-I Vendor-Specific Information Option

2016-12-02 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9ca313cfbe4993a0a36520d216a3e4282b0b7b99
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

9ca313c by Jaap Keuter (jaap.keu...@xs4all.nl):

BOOTP: Fix V-I Vendor-Specific Information Option

Apply the same value checks to the vendor generic suboption dissection
as is done for the Cable lab and ADSL forum ones.
See https://ask.wireshark.org/questions/57695 for an example issue.

Change-Id: I4fe07d07cf0a93f4693e5ff54dd70c008701cf41
Reviewed-on: https://code.wireshark.org/review/18999
Reviewed-by: Jaap Keuter 
Petri-Dish: Jaap Keuter 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  3b5d5ad   autotools: fix typo.
adds  9ca313c   BOOTP: Fix V-I Vendor-Specific Information Option


Summary of changes:
 epan/dissectors/packet-bootp.c |   50 +---
 1 file changed, 37 insertions(+), 13 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 3b5d5ad: autotools: fix typo.

2016-12-02 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3b5d5adcd3cbd941509485c1ced5d0599f545ed1
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

3b5d5ad by Dario Lombardo (lom...@gmail.com):

autotools: fix typo.

The required executable is rpmbuild and not rpm.

Change-Id: Iba1bff9c7fb6907659451a977ad8ab98efb169da
Reviewed-on: https://code.wireshark.org/review/19015
Reviewed-by: Anders Broman 


Actions performed:

from  74fb68d   simple_dialog(.h): fix parameter 'Type' not found in the 
function declaration [-Wdocumentation]
adds  3b5d5ad   autotools: fix typo.


Summary of changes:
 Makefile.am |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 74fb68d: simple_dialog(.h): fix parameter 'Type' not found in the function declaration [-Wdocumentation]

2016-12-02 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=74fb68d3662881cfa9f11fd29d73144da3d294aa
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

74fb68d by Alexis La Goutte (alexis.lagou...@gmail.com):

simple_dialog(.h): fix parameter 'Type' not found in the function 
declaration [-Wdocumentation]

Change-Id: I3dc476af941221b1d59f31bd6f639a49059e38a9
Reviewed-on: https://code.wireshark.org/review/19014
Petri-Dish: Alexis La Goutte 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Alexis La Goutte 
Reviewed-by: Anders Broman 


Actions performed:

from  6ac4052   Make sure config.h is included before inet_addr.h.
adds  74fb68d   simple_dialog(.h): fix parameter 'Type' not found in the 
function declaration [-Wdocumentation]


Summary of changes:
 ui/simple_dialog.h |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 6ac4052: Make sure config.h is included before inet_addr.h.

2016-12-02 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6ac40522af625971a6cb7b7e1ab56c7834e335db
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

6ac4052 by Guy Harris (g...@alum.mit.edu):

Make sure config.h is included before inet_addr.h.

Otherwise, _FILE_OFFSET_BITS might be defined by a header file included
by inet_addr.h before it gets defined by config.h.

Change-Id: I5987b3f1493b81fd2d427d9792b9606117b255d0
Reviewed-on: https://code.wireshark.org/review/19018
Reviewed-by: Guy Harris 


Actions performed:

from  6e02789   Do *NOT* strip newlines from the standard input of sed.
adds  6ac4052   Make sure config.h is included before inet_addr.h.


Summary of changes:
 wsutil/inet_addr.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 1b6606e: Do *NOT* strip newlines from the standard input of sed.

2016-12-02 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1b6606e913d55a9fbc93029082d64b0e242af67c
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

1b6606e by Guy Harris (g...@alum.mit.edu):

Do *NOT* strip newlines from the standard input of sed.

There is *NO* guarantee that sed will do anything useful with input that
doesn't have a newline and, in fact, the default sed in Solaris 11
doesn't produce *any* output if you hand it input with no newline.

Furthermore, doing xxx=`yyy` will, if the output of yyy has newlines at
the end, strip them; to quote section 2.6.3 "Command Substitution" of
the Single UNIX Specification:

The shell shall expand the command substitution by executing
command in a subshell environment (see Shell Execution
Environment) and replacing the command substitution (the text of
command plus the enclosing "$()" or backquotes) with the
standard output of the command, removing sequences of one or
more  characters at the end of the substitution.

so there's no need to strip the newline.

Change-Id: Ia710f67a42739c1e218eb9fec53a54bde6e010da
Reviewed-on: https://code.wireshark.org/review/19016
Petri-Dish: Guy Harris 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Guy Harris 
(cherry picked from commit 6e0278989c29a401f22485fd295bcc2486160241)
Reviewed-on: https://code.wireshark.org/review/19017


Actions performed:

from  b88f196   The Kerberos dissector include Kerberos header, and needs 
KRB5_CFLAGS.
adds  1b6606e   Do *NOT* strip newlines from the standard input of sed.


Summary of changes:
 acinclude.m4 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 6e02789: Do *NOT* strip newlines from the standard input of sed.

2016-12-02 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6e0278989c29a401f22485fd295bcc2486160241
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

6e02789 by Guy Harris (g...@alum.mit.edu):

Do *NOT* strip newlines from the standard input of sed.

There is *NO* guarantee that sed will do anything useful with input that
doesn't have a newline and, in fact, the default sed in Solaris 11
doesn't produce *any* output if you hand it input with no newline.

Furthermore, doing xxx=`yyy` will, if the output of yyy has newlines at
the end, strip them; to quote section 2.6.3 "Command Substitution" of
the Single UNIX Specification:

The shell shall expand the command substitution by executing
command in a subshell environment (see Shell Execution
Environment) and replacing the command substitution (the text of
command plus the enclosing "$()" or backquotes) with the
standard output of the command, removing sequences of one or
more  characters at the end of the substitution.

so there's no need to strip the newline.

Change-Id: Ia710f67a42739c1e218eb9fec53a54bde6e010da
Reviewed-on: https://code.wireshark.org/review/19016
Petri-Dish: Guy Harris 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Guy Harris 


Actions performed:

from  8d927a9   Qt: Fix QStyledItemDelegate assertions.
adds  6e02789   Do *NOT* strip newlines from the standard input of sed.


Summary of changes:
 acinclude.m4 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe