[Wireshark-commits] master-2.2 b88bb55: Qt: Warn the user about DBAR 1.8 on Windows.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b88bb55779df2b720ed00bd58a82ed1e2e274977
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master-2.2
Repository: wireshark

Commits:

b88bb55 by Gerald Combs (ger...@wireshark.org):

Qt: Warn the user about DBAR 1.8 on Windows.

At startup, dig through the registry looking for shell extensions. If
any of them match known Dell Backup and Recovery DLL names and the DLL
version matches 1.8.*.*, show the user a warning dialog.

This is a bit extreme but I'm not sure what else to do. Dell is a popular
computer manufacturer and bug reports keep trickling in.

Change-Id: I6d1bd6c56850279356570154d231b07facb30cff
Bug: 12036
Ping-bug: 12701
Ping-bug: 13414
Reviewed-on: https://code.wireshark.org/review/16861
Petri-Dish: Gerald Combs 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Alexis La Goutte 
Reviewed-by: Gerald Combs 
(cherry picked from commit a5a8fce06ecb5aff1dfcf101bb2b5455bd776569)
Reviewed-on: https://code.wireshark.org/review/20150
Reviewed-by: Anders Broman 


Actions performed:

from  c3d895f   Qt: Disable pane menu items if not used in layout
adds  b88bb55   Qt: Warn the user about DBAR 1.8 on Windows.


Summary of changes:
 CMakeLists.txt  |1 +
 cmake/modules/UseWinLibs.cmake  |1 +
 ui/qt/wireshark_application.cpp |  128 +++
 ui/qt/wireshark_application.h   |4 ++
 4 files changed, 134 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 48eff6a: Bluetooth: AD: Add dissector for Apple iBeacon

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=48eff6a36bac1526756bbb42a8c9841641792938
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

48eff6a by Michal Labedzki (michal.labed...@tieto.com):

Bluetooth: AD: Add dissector for Apple iBeacon

iBeacon is manufacturer specific (Apple) data in advertising packets.
Based on: 
https://developer.apple.com/ibeacon/Getting-Started-with-iBeacon.pdf

Use DecodeAs on advertise packet using field "BT EIR/AD Manufacturer 
Company ID"
then select this dissector "Apple iBeacon".

Change-Id: Ie3e50a391914054f33144d99734cf59fbda9683e
Reviewed-on: https://code.wireshark.org/review/19970
Petri-Dish: Michal Labedzki 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  16c3ecb   g_slist_free_full requires glib 2.28
adds  48eff6a   Bluetooth: AD: Add dissector for Apple iBeacon


Summary of changes:
 epan/dissectors/packet-bluetooth.c |   74 
 1 file changed, 74 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 16c3ecb: g_slist_free_full requires glib 2.28

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=16c3ecbd4c903815f4797f4f69daff98e9cb8807
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

16c3ecb by AndersBroman (anders.bro...@ericsson.com):

g_slist_free_full requires glib 2.28

Change-Id: I4f9ce7f65da0349b962f6be317635c5acb2daf73
Reviewed-on: https://code.wireshark.org/review/20148
Petri-Dish: Anders Broman 
Reviewed-by: Dario Lombardo 
Reviewed-by: Anders Broman 


Actions performed:

from  14e1912   Qt: Disable pane menu items if not used in layout
adds  16c3ecb   g_slist_free_full requires glib 2.28


Summary of changes:
 epan/proto.c   |5 +
 epan/tap.c |5 +
 extcap/ciscodump.c |5 +
 extcap/sshdump.c   |5 +
 4 files changed, 20 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 c3d895f: Qt: Disable pane menu items if not used in layout

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c3d895fe6e7f0807b7c47a8c09e684f202ae562c
Submitter: Stig Bjørlykke (s...@bjorlykke.org)
Changed: branch: master-2.2
Repository: wireshark

Commits:

c3d895f by Stig Bjørlykke (s...@bjorlykke.org):

Qt: Disable pane menu items if not used in layout

If a pane is not used in the layout it should not be possible to show
and hide this from the menu, as this may give unexpected results.

Change-Id: I335168e66e1dffc89992cad480dd7daaea7e9d59
Reviewed-on: https://code.wireshark.org/review/20140
Petri-Dish: Stig Bjørlykke 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Stig Bjørlykke 
(cherry picked from commit 14e19128dca1b318896ab7768d4527723dbefd17)
Reviewed-on: https://code.wireshark.org/review/20152


Actions performed:

from  419c497   Qt: Preserve pane sizes when layout content changed
adds  c3d895f   Qt: Disable pane menu items if not used in layout


Summary of changes:
 debian/libwireshark8.symbols |1 +
 epan/prefs.c |8 
 epan/prefs.h |5 +
 ui/qt/main_window_slots.cpp  |   10 +++---
 4 files changed, 21 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 419c497: Qt: Preserve pane sizes when layout content changed

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=419c497672219b73b53df9cb6a06695e9a553f97
Submitter: Stig Bjørlykke (s...@bjorlykke.org)
Changed: branch: master-2.2
Repository: wireshark

Commits:

419c497 by Stig Bjørlykke (s...@bjorlykke.org):

Qt: Preserve pane sizes when layout content changed

Preserve pane sizes when rearranging layout content in the
preferences dialog.

Change-Id: I2af2a60424a7bf94f1f92e7c63e6a1823985b60d
Reviewed-on: https://code.wireshark.org/review/20145
Petri-Dish: Stig Bjørlykke 
Reviewed-by: Stig Bjørlykke 
(cherry picked from commit 384c26622b0adc7eda415ba6e2a9fc704cd27794)
Reviewed-on: https://code.wireshark.org/review/20151


Actions performed:

from  7076f9e   Qt: Improved pane size auto detect
adds  419c497   Qt: Preserve pane sizes when layout content changed


Summary of changes:
 ui/qt/main_window_slots.cpp  |4 
 ui/qt/preferences_dialog.cpp |   14 +++---
 2 files changed, 15 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 14e1912: Qt: Disable pane menu items if not used in layout

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=14e19128dca1b318896ab7768d4527723dbefd17
Submitter: Stig Bjørlykke (s...@bjorlykke.org)
Changed: branch: master
Repository: wireshark

Commits:

14e1912 by Stig Bjørlykke (s...@bjorlykke.org):

Qt: Disable pane menu items if not used in layout

If a pane is not used in the layout it should not be possible to show
and hide this from the menu, as this may give unexpected results.

Change-Id: I335168e66e1dffc89992cad480dd7daaea7e9d59
Reviewed-on: https://code.wireshark.org/review/20140
Petri-Dish: Stig Bjørlykke 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Stig Bjørlykke 


Actions performed:

from  384c266   Qt: Preserve pane sizes when layout content changed
adds  14e1912   Qt: Disable pane menu items if not used in layout


Summary of changes:
 debian/libwireshark0.symbols |1 +
 epan/prefs.c |8 
 epan/prefs.h |5 +
 ui/qt/main_window_slots.cpp  |   10 +++---
 4 files changed, 21 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 384c266: Qt: Preserve pane sizes when layout content changed

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=384c26622b0adc7eda415ba6e2a9fc704cd27794
Submitter: Stig Bjørlykke (s...@bjorlykke.org)
Changed: branch: master
Repository: wireshark

Commits:

384c266 by Stig Bjørlykke (s...@bjorlykke.org):

Qt: Preserve pane sizes when layout content changed

Preserve pane sizes when rearranging layout content in the
preferences dialog.

Change-Id: I2af2a60424a7bf94f1f92e7c63e6a1823985b60d
Reviewed-on: https://code.wireshark.org/review/20145
Petri-Dish: Stig Bjørlykke 
Reviewed-by: Stig Bjørlykke 


Actions performed:

from  7e9b7b5   opcua: display abort messages correctly
adds  384c266   Qt: Preserve pane sizes when layout content changed


Summary of changes:
 ui/qt/main_window_slots.cpp  |4 
 ui/qt/preferences_dialog.cpp |   14 +++---
 2 files changed, 15 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 7e9b7b5: opcua: display abort messages correctly

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7e9b7b596728e6d1ab1ab5dc01e6a24a3bfafd6b
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

7e9b7b5 by Hannes Mezger (hannes.mez...@ascolab.com):

opcua: display abort messages correctly

Change-Id: I795fc3a3cf4ca93483f870d229668d7f747bb799
Reviewed-on: https://code.wireshark.org/review/20147
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  a5a8fce   Qt: Warn the user about DBAR 1.8 on Windows.
adds  7e9b7b5   opcua: display abort messages correctly


Summary of changes:
 plugins/opcua/opcua.c |   14 ++
 plugins/opcua/opcua_transport_layer.c |8 
 plugins/opcua/opcua_transport_layer.h |1 +
 3 files changed, 23 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master a5a8fce: Qt: Warn the user about DBAR 1.8 on Windows.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a5a8fce06ecb5aff1dfcf101bb2b5455bd776569
Submitter: Gerald Combs (ger...@wireshark.org)
Changed: branch: master
Repository: wireshark

Commits:

a5a8fce by Gerald Combs (ger...@wireshark.org):

Qt: Warn the user about DBAR 1.8 on Windows.

At startup, dig through the registry looking for shell extensions. If
any of them match known Dell Backup and Recovery DLL names and the DLL
version matches 1.8.*.*, show the user a warning dialog.

This is a bit extreme but I'm not sure what else to do. Dell is a popular
computer manufacturer and bug reports keep trickling in.

Change-Id: I6d1bd6c56850279356570154d231b07facb30cff
Bug: 12036
Ping-bug: 12701
Ping-bug: 13414
Reviewed-on: https://code.wireshark.org/review/16861
Petri-Dish: Gerald Combs 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Alexis La Goutte 
Reviewed-by: Gerald Combs 


Actions performed:

from  815916b   [GTPv2] Add dissection of Node Identifier.
adds  a5a8fce   Qt: Warn the user about DBAR 1.8 on Windows.


Summary of changes:
 CMakeLists.txt  |1 +
 cmake/modules/UseWinLibs.cmake  |1 +
 ui/qt/wireshark_application.cpp |  125 +++
 ui/qt/wireshark_application.h   |4 ++
 4 files changed, 131 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 815916b: [GTPv2] Add dissection of Node Identifier.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=815916b174ce48d65aace9852629f63f45e12704
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

815916b by AndersBroman (anders.bro...@ericsson.com):

[GTPv2] Add dissection of Node Identifier.

Change-Id: Icb2198e4f32ad7e6993bd80c2bf38ed323fb9ba0
Reviewed-on: https://code.wireshark.org/review/20144
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  a467f63   packet-nvme-rdma: Present keep alive timeout in decimal.
adds  815916b   [GTPv2] Add dissection of Node Identifier.


Summary of changes:
 epan/dissectors/packet-gtpv2.c |   44 +++-
 1 file changed, 43 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master a467f63: packet-nvme-rdma: Present keep alive timeout in decimal.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a467f63216a2226eede03491bfda2d2a397659b1
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

a467f63 by Parav Pandit (paravpan...@yahoo.com):

packet-nvme-rdma: Present keep alive timeout in decimal.

This patch presents Keep alive time out value in decimal as its ready to
read time in decimal.
Its adds (msec) string as its unit is in millisecond.

Change-Id: Ia7a1fc6e9cdbba86f8dae14d5fbb07a509d6b30f
Tested-by: paravpan...@yahoo.com
Reviewed-on: https://code.wireshark.org/review/20087
Reviewed-by: Anders Broman 


Actions performed:

from  d33f7b9   [GSM RLCMAC] Use rtlli_vals
adds  a467f63   packet-nvme-rdma: Present keep alive timeout in decimal.


Summary of changes:
 epan/dissectors/packet-nvme-rdma.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master d33f7b9: [GSM RLCMAC] Use rtlli_vals

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d33f7b9fb5589169fda6dfb5ac17e951ea06effb
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

d33f7b9 by Stig Bjørlykke (s...@bjorlykke.org):

[GSM RLCMAC] Use rtlli_vals

Change-Id: I491bdfd3c206971244f26dfc2cfd8172347313c6
Reviewed-on: https://code.wireshark.org/review/20146
Reviewed-by: Anders Broman 


Actions performed:

from  656da8a   ifdef g_list_free_full it requires glib 2.28
adds  d33f7b9   [GSM RLCMAC] Use rtlli_vals


Summary of changes:
 epan/dissectors/packet-gsm_rlcmac.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 656da8a: ifdef g_list_free_full it requires glib 2.28

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=656da8a49838302852b26d2a8289437e42ca9aa9
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

656da8a by AndersBroman (anders.bro...@ericsson.com):

ifdef g_list_free_full it requires glib 2.28

Change-Id: I86292b3d736bb08b21c034bb45f1dcac19196740
Reviewed-on: https://code.wireshark.org/review/20142
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  ba643d6   [GSM RLCMAC] Added parsing of EC-EGPRS DL and UL data 
messages.
adds  656da8a   ifdef g_list_free_full it requires glib 2.28


Summary of changes:
 ui/gtk/dfilter_expr_dlg.c |7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.2 on Windows 8.1 x86

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows 8.1 x86 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.2/builders/Windows%208.1%20x86/builds/451

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.2/

Buildslave for this Build: windows-8.1-x86

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master-2.2] 
7076f9e2d01fd4eb95af9952b5d302a36cb8f2a1
Blamelist: Stig Bjørlykke 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master ba643d6: [GSM RLCMAC] Added parsing of EC-EGPRS DL and UL data messages.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ba643d670b2166279dda57c5c0c0b2fc2e6e37e1
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

ba643d6 by AndersBroman (anders.bro...@ericsson.com):

[GSM RLCMAC] Added parsing of EC-EGPRS DL and UL data messages.

Change-Id: Ia7c74a834d2384642cac7f9a2899313b9bac7c26
Reviewed-on: https://code.wireshark.org/review/20141
Reviewed-by: Anders Broman 


Actions performed:

from  e2cef4c   Qt: Improved pane size auto detect
adds  ba643d6   [GSM RLCMAC] Added parsing of EC-EGPRS DL and UL data 
messages.


Summary of changes:
 epan/dissectors/packet-gsm_rlcmac.c |  279 ++-
 epan/dissectors/packet-gsm_rlcmac.h |   15 ++
 2 files changed, 292 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 7076f9e: Qt: Improved pane size auto detect

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7076f9e2d01fd4eb95af9952b5d302a36cb8f2a1
Submitter: Stig Bjørlykke (s...@bjorlykke.org)
Changed: branch: master-2.2
Repository: wireshark

Commits:

7076f9e by Stig Bjørlykke (s...@bjorlykke.org):

Qt: Improved pane size auto detect

Split panes in exactly equal sizes.

Change-Id: I4b984931e860160791497a299011489aa26ad4ef
Reviewed-on: https://code.wireshark.org/review/20139
Petri-Dish: Stig Bjørlykke 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Stig Bjørlykke 
(cherry picked from commit e2cef4cbbd8afe64b446f16443e1e80478117327)
Reviewed-on: https://code.wireshark.org/review/20143


Actions performed:

from  26c3ebc   Updated URL for STANAG 4607 documentation.
adds  7076f9e   Qt: Improved pane size auto detect


Summary of changes:
 ui/qt/main_window_slots.cpp |   15 +--
 1 file changed, 9 insertions(+), 6 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master e2cef4c: Qt: Improved pane size auto detect

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e2cef4cbbd8afe64b446f16443e1e80478117327
Submitter: Stig Bjørlykke (s...@bjorlykke.org)
Changed: branch: master
Repository: wireshark

Commits:

e2cef4c by Stig Bjørlykke (s...@bjorlykke.org):

Qt: Improved pane size auto detect

Split panes in exactly equal sizes.

Change-Id: I4b984931e860160791497a299011489aa26ad4ef
Reviewed-on: https://code.wireshark.org/review/20139
Petri-Dish: Stig Bjørlykke 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Stig Bjørlykke 


Actions performed:

from  6efc0f4   Updated URL for STANAG 4607 documentation.
adds  e2cef4c   Qt: Improved pane size auto detect


Summary of changes:
 ui/qt/main_window_slots.cpp |   15 +--
 1 file changed, 9 insertions(+), 6 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.0 on Windows 8.1 x86

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows 8.1 x86 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.0/builders/Windows%208.1%20x86/builds/1167

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.0/

Buildslave for this Build: windows-8.1-x86

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master-2.0] 
38b428a31736cb08563442e3c97564951f7f6601
Blamelist: Guy Harris 

BUILD FAILED: failed test.sh

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.2 on Ubuntu 16.04 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Ubuntu 16.04 x64 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.2/builders/Ubuntu%2016.04%20x64/builds/400

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.2/

Buildslave for this Build: ubuntu-16.04-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master-2.2] 
83aa52d9ba654928d32923cf7aebb1d7a755d23f
Blamelist: Guy Harris 

BUILD FAILED: failed copy-build

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 a1f72e1: Updated URL for STANAG 4607 documentation.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a1f72e1c1ec3be317ef6ac232c35fb426b147dfe
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

a1f72e1 by Guy Harris (g...@alum.mit.edu):

Updated URL for STANAG 4607 documentation.

Change-Id: Ib25ab0ba5b9d613d55fc54c0f3ef84cb7698754f
Reviewed-on: https://code.wireshark.org/review/20136
Reviewed-by: Guy Harris 
(cherry picked from commit 6efc0f4ea62b22e289fa22e6f1735f2e89302165)
Reviewed-on: https://code.wireshark.org/review/20138


Actions performed:

from  38b428a   Report an error for too-short packets.
adds  a1f72e1   Updated URL for STANAG 4607 documentation.


Summary of changes:
 wiretap/stanag4607.c |4 
 1 file changed, 4 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 26c3ebc: Updated URL for STANAG 4607 documentation.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=26c3ebc727c3ff335858a658cd8d6649c8cae803
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

26c3ebc by Guy Harris (g...@alum.mit.edu):

Updated URL for STANAG 4607 documentation.

Change-Id: Ib25ab0ba5b9d613d55fc54c0f3ef84cb7698754f
Reviewed-on: https://code.wireshark.org/review/20136
Reviewed-by: Guy Harris 
(cherry picked from commit 6efc0f4ea62b22e289fa22e6f1735f2e89302165)
Reviewed-on: https://code.wireshark.org/review/20137


Actions performed:

from  83aa52d   Report an error for too-short packets.
adds  26c3ebc   Updated URL for STANAG 4607 documentation.


Summary of changes:
 wiretap/stanag4607.c |4 
 1 file changed, 4 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 6efc0f4: Updated URL for STANAG 4607 documentation.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6efc0f4ea62b22e289fa22e6f1735f2e89302165
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

6efc0f4 by Guy Harris (g...@alum.mit.edu):

Updated URL for STANAG 4607 documentation.

Change-Id: Ib25ab0ba5b9d613d55fc54c0f3ef84cb7698754f
Reviewed-on: https://code.wireshark.org/review/20136
Reviewed-by: Guy Harris 


Actions performed:

from  c7042be   Report an error for too-short packets.
adds  6efc0f4   Updated URL for STANAG 4607 documentation.


Summary of changes:
 wiretap/stanag4607.c |4 
 1 file changed, 4 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 38b428a: Report an error for too-short packets.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=38b428a31736cb08563442e3c97564951f7f6601
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

38b428a by Guy Harris (g...@alum.mit.edu):

Report an error for too-short packets.

The packet length field gives the length of the *entire* packet, so, by
definition, it must not be zero.  Make sure it's at least big enough for
the packet header itself plus one segment header.

Bug: 13416
Change-Id: I625bd5c0ce75ab1200b3becf12fc1c819fefcd63
Reviewed-on: https://code.wireshark.org/review/20133
Reviewed-by: Guy Harris 
(cherry picked from commit c7042bedbb3b12c5f4e19e59e52da370d4ffe62f)
Reviewed-on: https://code.wireshark.org/review/20135


Actions performed:

from  768b279   "NULL" is not what you use for a null pointer.
adds  38b428a   Report an error for too-short packets.


Summary of changes:
 wiretap/stanag4607.c |   15 ++-
 1 file changed, 14 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 83aa52d: Report an error for too-short packets.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=83aa52d9ba654928d32923cf7aebb1d7a755d23f
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

83aa52d by Guy Harris (g...@alum.mit.edu):

Report an error for too-short packets.

The packet length field gives the length of the *entire* packet, so, by
definition, it must not be zero.  Make sure it's at least big enough for
the packet header itself plus one segment header.

Bug: 13416
Change-Id: I625bd5c0ce75ab1200b3becf12fc1c819fefcd63
Reviewed-on: https://code.wireshark.org/review/20133
Reviewed-by: Guy Harris 
(cherry picked from commit c7042bedbb3b12c5f4e19e59e52da370d4ffe62f)
Reviewed-on: https://code.wireshark.org/review/20134


Actions performed:

from  5609829   Qt: Use correct wsApp signal for RecentFilesRead
adds  83aa52d   Report an error for too-short packets.


Summary of changes:
 wiretap/stanag4607.c |   15 ++-
 1 file changed, 14 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master c7042be: Report an error for too-short packets.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c7042bedbb3b12c5f4e19e59e52da370d4ffe62f
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

c7042be by Guy Harris (g...@alum.mit.edu):

Report an error for too-short packets.

The packet length field gives the length of the *entire* packet, so, by
definition, it must not be zero.  Make sure it's at least big enough for
the packet header itself plus one segment header.

Bug: 13416
Change-Id: I625bd5c0ce75ab1200b3becf12fc1c819fefcd63
Reviewed-on: https://code.wireshark.org/review/20133
Reviewed-by: Guy Harris 


Actions performed:

from  bc2b135   Add follow "types" by protocol short name, not filter name
adds  c7042be   Report an error for too-short packets.


Summary of changes:
 wiretap/stanag4607.c |   15 ++-
 1 file changed, 14 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows 8.1 x86 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%208.1%20x86/builds/8626

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-8.1-x86

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master] 
1077e9afcc72d312e194169c2598319be38b7f29
Blamelist: Guy Harris 

BUILD FAILED: failed test.sh

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.2 on Windows Server 2012 R2 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.2/builders/Windows%20Server%202012%20R2%20x64/builds/464

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.2/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master-2.2] 
8a4d259e7ba2b10960c5598ad3276797fae9dfbc
Blamelist: Stig Bjørlykke 

BUILD FAILED: failed test.sh

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe