[Wireshark-commits] buildbot failure in Wireshark 2.2 on Ubuntu 16.04 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Ubuntu 16.04 x64 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.2/builders/Ubuntu%2016.04%20x64/builds/418

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.2/

Buildslave for this Build: ubuntu-16.04-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master-2.2] 
8a168ed1b3b7af79b31e2cc2c746dae395dd8847
Blamelist: Michal Labedzki 

BUILD FAILED: failed compile

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 8a168ed: androiddump: Use nonblocking connect

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8a168ed1b3b7af79b31e2cc2c746dae395dd8847
Submitter: Michal Labedzki (michal.tomasz.labed...@gmail.com)
Changed: branch: master-2.2
Repository: wireshark

Commits:

8a168ed by Michal Labedzki (michal.labed...@tieto.com):

androiddump: Use nonblocking connect

Release as version 1.0.3 [backport]:
All connects to ADB are now non-blocking.
Try to connect up to 10 times with 1ms delays,
so in worst-case it takes ~10ms (for example 14ms)

Use non-blocking socket for a while on Windows.

Bug: 13104
Change-Id: I791909c9c951b62195b48acd82490e1b9ebf2be0
Reviewed-on: https://code.wireshark.org/review/19968
Petri-Dish: Michal Labedzki 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michal Labedzki 
Tested-by: Michal Labedzki 
Reviewed-on: https://code.wireshark.org/review/20263


Actions performed:

from  991f1b5   Return correct filter for get_hostlist_filter()
adds  8a168ed   androiddump: Use nonblocking connect


Summary of changes:
 extcap/androiddump.c |   77 --
 1 file changed, 68 insertions(+), 9 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202012%20R2%20x64/builds/2981

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master] 
17dd9d0544b5d28eb28f5010918b52b96bce6da4
Blamelist: Guy Harris 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 17dd9d0: radius: remove unused rule, add clarifying comment

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=17dd9d0544b5d28eb28f5010918b52b96bce6da4
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

17dd9d0 by Peter Wu (pe...@lekensteyn.nl):

radius: remove unused rule, add clarifying comment

Since commit fdb5257f7cc8e19e6f8bcd35edee225cf44438a2 the ATTR_W_VENDOR
symbol was never matched, so remove it.

Change-Id: I5a56f48ce1995c23f9eca518308d3543a15ad049
Reviewed-on: https://code.wireshark.org/review/20313
Petri-Dish: Guy Harris 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Guy Harris 


Actions performed:

from  82b2d8b   Expand a comment.
adds  17dd9d0   radius: remove unused rule, add clarifying comment


Summary of changes:
 epan/radius_dict.l |   15 ++-
 1 file changed, 6 insertions(+), 9 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202012%20R2%20x64/builds/2979

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master] 
82b2d8b4e53878f03e469869abd6cfa82b6f7bf8
Blamelist: Guy Harris 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 82b2d8b: Expand a comment.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=82b2d8b4e53878f03e469869abd6cfa82b6f7bf8
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

82b2d8b by Guy Harris (g...@alum.mit.edu):

Expand a comment.

Change-Id: I4b040665582ec1fd3f97b915b3819ff2d8850a6f
Reviewed-on: https://code.wireshark.org/review/20315
Reviewed-by: Guy Harris 


Actions performed:

from  3c6900f   radius: fix use-after-free after recent memleak fixes
adds  82b2d8b   Expand a comment.


Summary of changes:
 epan/radius_dict.l |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 3c6900f: radius: fix use-after-free after recent memleak fixes

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3c6900f31fcfed080d165b581ccef8f022109491
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

3c6900f by Peter Wu (pe...@lekensteyn.nl):

radius: fix use-after-free after recent memleak fixes

The same data is referenced by the ID-to-name and name-to-ID mapping, so
be make sure that the ID mapping is responsible (as the name mapping is
just used for duplicate detection and while parsing dictionary files).

Still to be done is fixing duplicate attribute numbers (by adding
support for OIDs and changing TLV attribute type IDs to OIDs) and fixing
duplicate attribute names (by prefixing the Vendor Names to them).
Also not handled is fixing Value memleaks.

Reproducers of the crash under ASAN:

tshark -G fields >/dev/null
tshark -r radius-ms-mppe-etrl-bug.cap   (from bug 796)

Change-Id: Ifa4055901072bc830e19fe06937af67ce524a3be
Fixes: v2.3.0rc0-2536-gd4cf57100c ("Free radius dissector memory on 
shutdown")
Reviewed-on: https://code.wireshark.org/review/20307
Reviewed-by: Peter Wu 
Petri-Dish: Peter Wu 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  87b7242   radius: fix memleaks of value_string
adds  3c6900f   radius: fix use-after-free after recent memleak fixes


Summary of changes:
 epan/dissectors/packet-radius.c |   19 ---
 epan/dissectors/packet-radius.h |   12 ++--
 epan/radius_dict.l  |6 +++---
 3 files changed, 25 insertions(+), 12 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 87b7242: radius: fix memleaks of value_string

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=87b7242e69845db13daf570101903521e17cfd50
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

87b7242 by Peter Wu (pe...@lekensteyn.nl):

radius: fix memleaks of value_string

The value_string was taken from the GArray and added to
radius_attr_info_t, but these were not properly freed.

Change-Id: I8de2b84760887c41229a57881ff46cedcef1d22f
Reviewed-on: https://code.wireshark.org/review/20311
Reviewed-by: Michael Mann 


Actions performed:

from  77d309c   radius: fix final memleak due to malformed dictionary
adds  87b7242   radius: fix memleaks of value_string


Summary of changes:
 epan/dissectors/packet-radius.c |   10 +-
 epan/radius_dict.l  |   22 ++
 2 files changed, 19 insertions(+), 13 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 77d309c: radius: fix final memleak due to malformed dictionary

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=77d309c92fdd3e7826c12301d3d4ab3a56251b1b
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

77d309c by Peter Wu (pe...@lekensteyn.nl):

radius: fix final memleak due to malformed dictionary

The VENDOR line did not have a proper ID, so scanning the full line
failed and the "yyextra->vendor_name" was not freed. Import the current
version from FreeRadius to fix this problem.

(Since the attributes are now grouped by the vendor, the conflict
comment no longer applies.)

Change-Id: Id6020c0a5f34c624aedbb0acebe70dc643402e41
Reviewed-on: https://code.wireshark.org/review/20312
Reviewed-by: Michael Mann 


Actions performed:

from  146b6b8   text2pcap: free memory on exit.
adds  77d309c   radius: fix final memleak due to malformed dictionary


Summary of changes:
 radius/dictionary.zyxel |   14 +++---
 1 file changed, 7 insertions(+), 7 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 146b6b8: text2pcap: free memory on exit.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=146b6b824da171f457198797def5083d2fa90a0c
Submitter: Dario Lombardo (lom...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

146b6b8 by Dario Lombardo (lom...@gmail.com):

text2pcap: free memory on exit.

Make also text2pcap_lex_destroy() public to be called from main.

Change-Id: I360c3dd3991d027afe6e4542ea5f9680e92f92cf
Reviewed-on: https://code.wireshark.org/review/20226
Reviewed-by: Michael Mann 
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Dario Lombardo 


Actions performed:

from  26e62df   Qt: Fix -Wshorten-64-to-32 warnings
adds  146b6b8   text2pcap: free memory on exit.


Summary of changes:
 text2pcap.c |9 +
 text2pcap.h |2 ++
 2 files changed, 7 insertions(+), 4 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 26e62df: Qt: Fix -Wshorten-64-to-32 warnings

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=26e62dfad07a02efc03e4c08c3c6b08e5c5d2076
Submitter: Stig Bj?rlykke (s...@bjorlykke.org)
Changed: branch: master
Repository: wireshark

Commits:

26e62df by Stig Bjørlykke (s...@bjorlykke.org):

Qt: Fix -Wshorten-64-to-32 warnings

Fix some warnings when building with -Wshorten-64-to-32 flag for
C++ code.

Fixes for warnings from QList, QTimer and QVector has been pushed
upstream, so some time we may be able to enable this flag for C++.

Change-Id: Iae7457f9afc469c63f3edbe23dbf272b5c6c9e5e
Reviewed-on: https://code.wireshark.org/review/20310
Petri-Dish: Stig Bjørlykke 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Stig Bjørlykke 


Actions performed:

from  311b1ee   IEEE 802.11: Handle Atheros padding
adds  26e62df   Qt: Fix -Wshorten-64-to-32 warnings


Summary of changes:
 ui/qt/byte_view_text.cpp   |2 +-
 ui/qt/file_set_dialog.cpp  |4 ++--
 ui/qt/iax2_analysis_dialog.cpp |   12 ++--
 ui/qt/import_text_dialog.cpp   |2 +-
 ui/qt/io_graph_dialog.cpp  |2 +-
 ui/qt/qcustomplot.cpp  |2 +-
 ui/qt/qt_ui_utils.cpp  |2 +-
 ui/qt/rtp_analysis_dialog.cpp  |4 ++--
 ui/qt/tcp_stream_dialog.cpp|2 +-
 9 files changed, 16 insertions(+), 16 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe