[Wireshark-commits] master-2.0 5b9790d: One of the new routines is static; declare it.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5b9790d0bf004fe0acc543675a826be800da4d70
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

5b9790d by Guy Harris (g...@alum.mit.edu):

One of the new routines is static; declare it.

Change-Id: I0737a342652ebf0f64071d8e485910a843ed8a44
Reviewed-on: https://code.wireshark.org/review/20832
Reviewed-by: Guy Harris 


Actions performed:

from  5057c8f   Fix some dissection errors.
adds  5b9790d   One of the new routines is static; declare it.


Summary of changes:
 epan/osi-utils.c |2 ++
 1 file changed, 2 insertions(+)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.0 on Windows Server 2012 R2 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.0/builders/Windows%20Server%202012%20R2%20x64/builds/573

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.0/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master-2.0] 
5057c8f31c654d3010c907a3b9dd174792a5dac4
Blamelist: Guy Harris 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.2 on Windows 8.1 x86

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows 8.1 x86 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.2/builders/Windows%208.1%20x86/builds/521

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.2/

Buildslave for this Build: windows-8.1-x86

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master-2.2] 
545e6483dd0ca3125ee5fe620cfbe32415c7766d
Blamelist: Guy Harris 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.0 on Windows 8.1 x86

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows 8.1 x86 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.0/builders/Windows%208.1%20x86/builds/1219

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.0/

Buildslave for this Build: windows-8.1-x86

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master-2.0] 
5057c8f31c654d3010c907a3b9dd174792a5dac4
Blamelist: Guy Harris 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.0 on OSX 10.7 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder OSX 10.7 x64 while building 
wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.0/builders/OSX%2010.7%20x64/builds/1233

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.0/

Buildslave for this Build: osx-10.7-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master-2.0] 
5057c8f31c654d3010c907a3b9dd174792a5dac4
Blamelist: Guy Harris 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.2 on Ubuntu 16.04 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Ubuntu 16.04 x64 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.2/builders/Ubuntu%2016.04%20x64/builds/470

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.2/

Buildslave for this Build: ubuntu-16.04-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master-2.2] 
545e6483dd0ca3125ee5fe620cfbe32415c7766d
Blamelist: Guy Harris 

BUILD FAILED: failed compile

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.0 on Ubuntu 16.04 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Ubuntu 16.04 x64 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.0/builders/Ubuntu%2016.04%20x64/builds/289

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.0/

Buildslave for this Build: ubuntu-16.04-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master-2.0] 
5057c8f31c654d3010c907a3b9dd174792a5dac4
Blamelist: Guy Harris 

BUILD FAILED: failed compile

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.2 on OSX 10.7 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder OSX 10.7 x64 while building 
wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.2/builders/OSX%2010.7%20x64/builds/518

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.2/

Buildslave for this Build: osx-10.7-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master-2.2] 
545e6483dd0ca3125ee5fe620cfbe32415c7766d
Blamelist: Guy Harris 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.0 on OSX 10.6 x86

[buildbot-no-reply]

The Buildbot has detected a new failure on builder OSX 10.6 x86 while building 
wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.0/builders/OSX%2010.6%20x86/builds/1226

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.0/

Buildslave for this Build: osx-10.6-x86

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master-2.0] 
5057c8f31c654d3010c907a3b9dd174792a5dac4
Blamelist: Guy Harris 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 5057c8f: Fix some dissection errors.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5057c8f31c654d3010c907a3b9dd174792a5dac4
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

5057c8f by Guy Harris (g...@alum.mit.edu):

Fix some dissection errors.

"XXX supported" for a metric type is a Boolean, not an int; add it as
such.

Add the value of the item without the extra bits.

The length of an address prefix is in semi-octets (nibbles/hex digits),
not in octets.

Change-Id: I642f0dab5030f7609e89f45cf2cff15cd74dfbda
Reviewed-on: https://code.wireshark.org/review/20819
Reviewed-by: Guy Harris 
(cherry picked from commit 02f74e47ed3e542f4aff9fc6a7a9c44e29be5c7b)
Reviewed-on: https://code.wireshark.org/review/20831


Actions performed:

from  b4feea7   This is now an FT_STRING elsewhere, so make it one here.
adds  5057c8f   Fix some dissection errors.


Summary of changes:
 epan/dissectors/packet-isis-lsp.c |   17 -
 epan/osi-utils.c  |   51 +
 epan/osi-utils.h  |1 +
 3 files changed, 51 insertions(+), 18 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 545e648: Fix some dissection errors.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=545e6483dd0ca3125ee5fe620cfbe32415c7766d
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

545e648 by Guy Harris (g...@alum.mit.edu):

Fix some dissection errors.

"XXX supported" for a metric type is a Boolean, not an int; add it as
such.

Add the value of the item without the extra bits.

The length of an address prefix is in semi-octets (nibbles/hex digits),
not in octets.

Change-Id: I642f0dab5030f7609e89f45cf2cff15cd74dfbda
Reviewed-on: https://code.wireshark.org/review/20819
Reviewed-by: Guy Harris 
(cherry picked from commit 02f74e47ed3e542f4aff9fc6a7a9c44e29be5c7b)
Reviewed-on: https://code.wireshark.org/review/20830


Actions performed:

from  879d976   You can't get a string value from an FT_NONE string.
adds  545e648   Fix some dissection errors.


Summary of changes:
 epan/dissectors/packet-isis-lsp.c |   17 -
 epan/osi-utils.c  |   51 +
 epan/osi-utils.h  |1 +
 3 files changed, 51 insertions(+), 18 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 b4feea7: This is now an FT_STRING elsewhere, so make it one here.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b4feea73f26ba8510f570846f8a6bb50801cb927
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

b4feea7 by Guy Harris (g...@alum.mit.edu):

This is now an FT_STRING elsewhere, so make it one here.

FT_NONE is wrong for string-valued fields.

Change-Id: I2a44c4542c79daa486382bd5b28f6c37c9c46111
Reviewed-on: https://code.wireshark.org/review/20827
Reviewed-by: Guy Harris 
(cherry picked from commit aa82f522c28134463b223bc1eaa5d1fd6cd9d9cd)
Reviewed-on: https://code.wireshark.org/review/20829


Actions performed:

from  0a30922   Provide better error messages for field type mismatches.
adds  b4feea7   This is now an FT_STRING elsewhere, so make it one here.


Summary of changes:
 epan/dissectors/packet-btavrcp.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 879d976: You can't get a string value from an FT_NONE string.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=879d976b98111daf54fe3b35b23cf3fa5e69f49a
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

879d976 by Guy Harris (g...@alum.mit.edu):

You can't get a string value from an FT_NONE string.

Make it an FT_STRING.

Change-Id: I2a44c4542c79daa486382bd5b28f6c37c9c46111
Reviewed-on: https://code.wireshark.org/review/20827
Reviewed-by: Guy Harris 
(cherry picked from commit aa82f522c28134463b223bc1eaa5d1fd6cd9d9cd)
Reviewed-on: https://code.wireshark.org/review/20828


Actions performed:

from  7fa6f59   Provide better error messages for field type mismatches.
adds  879d976   You can't get a string value from an FT_NONE string.


Summary of changes:
 epan/dissectors/packet-btavrcp.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master aa82f52: You can't get a string value from an FT_NONE string.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=aa82f522c28134463b223bc1eaa5d1fd6cd9d9cd
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

aa82f52 by Guy Harris (g...@alum.mit.edu):

You can't get a string value from an FT_NONE string.

Make it an FT_STRING.

Change-Id: I2a44c4542c79daa486382bd5b28f6c37c9c46111
Reviewed-on: https://code.wireshark.org/review/20827
Reviewed-by: Guy Harris 


Actions performed:

from  19bb1b1   Provide better error messages for field type mismatches.
adds  aa82f52   You can't get a string value from an FT_NONE string.


Summary of changes:
 epan/dissectors/packet-btavrcp.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.2 on Windows Server 2012 R2 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.2/builders/Windows%20Server%202012%20R2%20x64/builds/536

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.2/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master-2.2] 
14f5f90bb90eea6f0fda392c89c2bd79854f2282
Blamelist: Michael Mann 

BUILD FAILED: failed test.sh

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 0a30922: Provide better error messages for field type mismatches.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0a309226153d8806cba8b18f476ce2bfb2eede84
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

0a30922 by Guy Harris (g...@alum.mit.edu):

Provide better error messages for field type mismatches.

Don't just report an assertion failure with a line in proto.c; give the
name of the field with the wrong type, and a list of the types that are
valid for the routine in question.

Change-Id: Id3ed7c376fdc72bf6cff69c647833946cfa99ee6
Reviewed-on: https://code.wireshark.org/review/20824
Reviewed-by: Guy Harris 
(cherry picked from commit 19bb1b128b0e8fdbff0959a00ea062a34fbadfb4)
Reviewed-on: https://code.wireshark.org/review/20826


Actions performed:

from  4732ebb   Fix endpoints statistics optional filter parsing
adds  0a30922   Provide better error messages for field type mismatches.


Summary of changes:
 epan/proto.c |   20 +++-
 1 file changed, 15 insertions(+), 5 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 7fa6f59: Provide better error messages for field type mismatches.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7fa6f59f840b5dd6644205a3efba8b7a8a280233
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

7fa6f59 by Guy Harris (g...@alum.mit.edu):

Provide better error messages for field type mismatches.

Don't just report an assertion failure with a line in proto.c; give the
name of the field with the wrong type, and a list of the types that are
valid for the routine in question.

Change-Id: Id3ed7c376fdc72bf6cff69c647833946cfa99ee6
Reviewed-on: https://code.wireshark.org/review/20824
Reviewed-by: Guy Harris 
(cherry picked from commit 19bb1b128b0e8fdbff0959a00ea062a34fbadfb4)
Reviewed-on: https://code.wireshark.org/review/20825


Actions performed:

from  14f5f90   packet-ieee802154.c: Bugfix handling Auxilary Security 
Header for v2003
adds  7fa6f59   Provide better error messages for field type mismatches.


Summary of changes:
 epan/proto.c |   24 ++--
 1 file changed, 18 insertions(+), 6 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 19bb1b1: Provide better error messages for field type mismatches.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=19bb1b128b0e8fdbff0959a00ea062a34fbadfb4
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

19bb1b1 by Guy Harris (g...@alum.mit.edu):

Provide better error messages for field type mismatches.

Don't just report an assertion failure with a line in proto.c; give the
name of the field with the wrong type, and a list of the types that are
valid for the routine in question.

Change-Id: Id3ed7c376fdc72bf6cff69c647833946cfa99ee6
Reviewed-on: https://code.wireshark.org/review/20824
Reviewed-by: Guy Harris 


Actions performed:

from  d967d71   FT_CHAR is an integral type, so list it in the diagnostic 
message.
adds  19bb1b1   Provide better error messages for field type mismatches.


Summary of changes:
 epan/proto.c |   24 ++--
 1 file changed, 18 insertions(+), 6 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master d967d71: FT_CHAR is an integral type, so list it in the diagnostic message.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d967d71d98f20dbd107594e7605b13ea28cfe982
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

d967d71 by Guy Harris (g...@alum.mit.edu):

FT_CHAR is an integral type, so list it in the diagnostic message.

Change-Id: I8d095a2424033bee5b3569c906327ac15de33890
Reviewed-on: https://code.wireshark.org/review/20823
Reviewed-by: Guy Harris 


Actions performed:

from  6a67209   ieee80211: Fix parsing of supported operating classes IE
adds  d967d71   FT_CHAR is an integral type, so list it in the diagnostic 
message.


Summary of changes:
 epan/proto.h |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 6a67209: ieee80211: Fix parsing of supported operating classes IE

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6a67209bff51c6e75e959bee27b29c0ebdd7882b
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

6a67209 by Mikael Kanstrup (mikael.kanst...@gmail.com):

ieee80211: Fix parsing of supported operating classes IE

Fix parsing of Supported Operating Classes information element

- Fix min tag length check message (min length is 2 not 3)
- Fix max tag length check (no max defined)
- Fix malformed packet exception on frames with min tag length
- Handle OneHundredAndThirty and Zero field delimiters
- Use same base (dec) for both current and alternate op classes

Bug: 13534
Change-Id: I05b2238eb07f65fde0a33479e9459d2a99911a50
Reviewed-on: https://code.wireshark.org/review/20784
Reviewed-by: Peter Wu 
Petri-Dish: Peter Wu 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  d57f03c   Add citrix mep dissectors
adds  6a67209   ieee80211: Fix parsing of supported operating classes IE


Summary of changes:
 epan/dissectors/packet-ieee80211.c |   42 
 1 file changed, 24 insertions(+), 18 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master d57f03c: Add citrix mep dissectors

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d57f03ce0f747f251dd34f2bbe70e45667aa8a09
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

d57f03c by Priyanka Mondal (priyanka02...@gmail.com):

Add citrix mep dissectors

Change-Id: Id574fc20e17333646d615cab415b2d40b4487375
Reviewed-on: https://code.wireshark.org/review/20333
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  7aed334   Don't add an FT_UINT32 with proto_tree_add_none_format().
adds  d57f03c   Add citrix mep dissectors


Summary of changes:
 docbook/release-notes.asciidoc  |3 +
 epan/dissectors/CMakeLists.txt  |3 +
 epan/dissectors/Makefile.am |3 +
 epan/dissectors/packet-ns-ha.c  |  314 ++
 epan/dissectors/packet-ns-mep.c |  905 
 epan/dissectors/packet-ns-rpc.c | 1243 +++
 6 files changed, 2471 insertions(+)
 create mode 100644 epan/dissectors/packet-ns-ha.c
 create mode 100644 epan/dissectors/packet-ns-mep.c
 create mode 100644 epan/dissectors/packet-ns-rpc.c
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 14f5f90: packet-ieee802154.c: Bugfix handling Auxilary Security Header for v2003

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=14f5f90bb90eea6f0fda392c89c2bd79854f2282
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master-2.2
Repository: wireshark

Commits:

14f5f90 by Michael Mann (mman...@netscape.net):

packet-ieee802154.c: Bugfix handling Auxilary Security Header for v2003

Bug: 4912
Change-Id: Ifc4922fecb1320d7992f8250a0fb2fa18723a514
Reviewed-on: https://code.wireshark.org/review/20659
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 
(cherry picked from commit 015217ac62698a539631323aa5551fd4b4ef9673)
Reviewed-on: https://code.wireshark.org/review/20667
Reviewed-by: Michael Mann 


Actions performed:

from  2258a45   Fix endpoints statistics optional filter parsing
adds  14f5f90   packet-ieee802154.c: Bugfix handling Auxilary Security 
Header for v2003


Summary of changes:
 epan/dissectors/packet-ieee802154.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 7aed334: Don't add an FT_UINT32 with proto_tree_add_none_format().

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7aed334856820b1a1676b81313076e086a893587
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

7aed334 by Guy Harris (g...@alum.mit.edu):

Don't add an FT_UINT32 with proto_tree_add_none_format().

Make it an FT_NONE.

Change-Id: I83339d84b88c7decffa6e6a48d12acc4b063a4ad
Reviewed-on: https://code.wireshark.org/review/20822
Reviewed-by: Guy Harris 


Actions performed:

from  01ec229   Don't use proto_tree_add_uint() to add an FT_BOOLEAN field.
adds  7aed334   Don't add an FT_UINT32 with proto_tree_add_none_format().


Summary of changes:
 epan/dissectors/packet-wbxml.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 01ec229: Don't use proto_tree_add_uint() to add an FT_BOOLEAN field.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=01ec22994affe82633bb673da6f78d87986411cd
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

01ec229 by Guy Harris (g...@alum.mit.edu):

Don't use proto_tree_add_uint() to add an FT_BOOLEAN field.

We don't allow that.  Use proto_tree_add_boolean() instead.

Change-Id: I59ed0f0dc731b1ce4b5d921cd4e85b1c101cb2a8
Reviewed-on: https://code.wireshark.org/review/20821
Reviewed-by: Guy Harris 


Actions performed:

from  62d7819   Add packet capture support for Darwin USB
adds  01ec229   Don't use proto_tree_add_uint() to add an FT_BOOLEAN field.


Summary of changes:
 plugins/profinet/packet-pn-rt.c |   16 
 1 file changed, 8 insertions(+), 8 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 62d7819: Add packet capture support for Darwin USB

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=62d78199eee5d239b826442c6edd95aeeef1540b
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

62d7819 by Scott Deandrea (sdeand...@apple.com):

Add packet capture support for Darwin USB

Change-Id: Iec9e4ac2362cf8e88a3cf6ae3483cefe938967e5
Reviewed-on: https://code.wireshark.org/review/20814
Petri-Dish: Alexis La Goutte 
Petri-Dish: Guy Harris 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Guy Harris 


Actions performed:

from  02f74e4   Fix some dissection errors.
adds  62d7819   Add packet capture support for Darwin USB


Summary of changes:
 epan/dissectors/packet-usb.c |  360 ++
 epan/dissectors/packet-usb.h |3 +-
 wiretap/pcap-common.c|3 +
 wiretap/wtap.c   |3 +
 wiretap/wtap.h   |1 +
 5 files changed, 369 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202012%20R2%20x64/builds/3231

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master] 
7dc065397a5a18715dd1cf70dc4cfbccb550fa90
Blamelist: Guy Harris 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 02f74e4: Fix some dissection errors.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=02f74e47ed3e542f4aff9fc6a7a9c44e29be5c7b
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

02f74e4 by Guy Harris (g...@alum.mit.edu):

Fix some dissection errors.

"XXX supported" for a metric type is a Boolean, not an int; add it as
such.

Add the value of the item without the extra bits.

The length of an address prefix is in semi-octets (nibbles/hex digits),
not in octets.

Change-Id: I642f0dab5030f7609e89f45cf2cff15cd74dfbda
Reviewed-on: https://code.wireshark.org/review/20819
Reviewed-by: Guy Harris 


Actions performed:

from  7dc0653   Optimize frame_data layout.
adds  02f74e4   Fix some dissection errors.


Summary of changes:
 epan/dissectors/packet-isis-lsp.c |   17 +++-
 epan/osi-utils.c  |   52 +
 epan/osi-utils.h  |1 +
 3 files changed, 52 insertions(+), 18 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 16.04 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Ubuntu 16.04 x64 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Ubuntu%2016.04%20x64/builds/1775

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: ubuntu-16.04-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master] 
7dc065397a5a18715dd1cf70dc4cfbccb550fa90
Blamelist: Guy Harris 

BUILD FAILED: failed test.sh

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 7dc0653: Optimize frame_data layout.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7dc065397a5a18715dd1cf70dc4cfbccb550fa90
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

7dc0653 by Jakub Zawadzki (darkjames...@darkjames.pl):

Optimize frame_data layout.

Move tsprec to remove padding. It saves 8 bytes on amd64,
shrink size of frame_data structure from 96 to 88 bytes.

Change-Id: Ib69687b2e5b7d65b5c15eda7d5834100a02c059e
Reviewed-on: https://code.wireshark.org/review/20807
Petri-Dish: Jakub Zawadzki 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Alexis La Goutte 
Reviewed-by: Guy Harris 


Actions performed:

from  a8ce98f   Fix endpoints statistics optional filter parsing
adds  7dc0653   Optimize frame_data layout.


Summary of changes:
 epan/frame_data.h |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 4732ebb: Fix endpoints statistics optional filter parsing

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4732ebb48d9e06c1a1d411d266400aed0c76618b
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master-2.0
Repository: wireshark

Commits:

4732ebb by Pascal Quantin (pascal.quan...@gmail.com):

Fix endpoints statistics optional filter parsing

Bug: 13538
Change-Id: I4cd66d2dffc976610d41126c50b5722bc06a72f8
Reviewed-on: https://code.wireshark.org/review/20818
Reviewed-by: Pascal Quantin 


Actions performed:

from  654be43   Print signed values with %d, not %u.
adds  4732ebb   Fix endpoints statistics optional filter parsing


Summary of changes:
 epan/conversation_table.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 2258a45: Fix endpoints statistics optional filter parsing

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2258a4566c293234afbd77b0bc155b78d3b235cc
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master-2.2
Repository: wireshark

Commits:

2258a45 by Pascal Quantin (pascal.quan...@gmail.com):

Fix endpoints statistics optional filter parsing

Bug: 13538
Change-Id: I4cd66d2dffc976610d41126c50b5722bc06a72f8
Reviewed-on: https://code.wireshark.org/review/20810
Reviewed-by: Pascal Quantin 
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Christopher Maynard 
(cherry picked from commit a8ce98fc255482938b70142707e8fd40b134595e)
Reviewed-on: https://code.wireshark.org/review/20817


Actions performed:

from  959bc4c   Fix the build when a different version of Qt is in PATH
adds  2258a45   Fix endpoints statistics optional filter parsing


Summary of changes:
 epan/conversation_table.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master a8ce98f: Fix endpoints statistics optional filter parsing

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a8ce98fc255482938b70142707e8fd40b134595e
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

a8ce98f by Pascal Quantin (pascal.quan...@gmail.com):

Fix endpoints statistics optional filter parsing

Bug: 13538
Change-Id: I4cd66d2dffc976610d41126c50b5722bc06a72f8
Reviewed-on: https://code.wireshark.org/review/20810
Reviewed-by: Pascal Quantin 
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Christopher Maynard 


Actions performed:

from  c5d7183   Fix comments.
adds  a8ce98f   Fix endpoints statistics optional filter parsing


Summary of changes:
 epan/conversation_table.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202012%20R2%20x64/builds/3228

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master] 
c5d7183a32d138004517ab3699caa3239623f1b5
Blamelist: Guy Harris 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master c5d7183: Fix comments.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c5d7183a32d138004517ab3699caa3239623f1b5
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

c5d7183 by Guy Harris (g...@alum.mit.edu):

Fix comments.

Change-Id: Iac768dd2f06ce081a7b82c58c225f2674f3f1174
Reviewed-on: https://code.wireshark.org/review/20815
Reviewed-by: Guy Harris 


Actions performed:

from  e767f42   AMQP: fix field amqp.value is not of type FT_NONE
adds  c5d7183   Fix comments.


Summary of changes:
 epan/osi-utils.h |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 959bc4c: Fix the build when a different version of Qt is in PATH

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=959bc4cf9a3da9dbcc9155fd72fbd5f189869025
Submitter: Graham Bloice (graham.blo...@trihedral.com)
Changed: branch: master-2.2
Repository: wireshark

Commits:

959bc4c by Роман Донченко (d...@corrigendum.ru):

Fix the build when a different version of Qt is in PATH

When we add our Qt to PATH, prepend it so that it will be found first.

Change-Id: I405496d6a08d676b5a2e0d9bd792de7ba9abe7f9
Reviewed-on: https://code.wireshark.org/review/18988
Petri-Dish: Graham Bloice 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Graham Bloice 
(cherry picked from commit 4ace7ce80dc11010f78202ab742f749f85cbdd6b)
Reviewed-on: https://code.wireshark.org/review/20809


Actions performed:

from  6a05b59   Qt: do not expand collapsed trees when switching packets
adds  959bc4c   Fix the build when a different version of Qt is in PATH


Summary of changes:
 CMakeLists.txt|2 +-
 packaging/nsis/CMakeLists.txt |2 +-
 packaging/wix/CMakeLists.txt  |2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.2 on Windows Server 2012 R2 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.2/builders/Windows%20Server%202012%20R2%20x64/builds/532

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.2/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master-2.2] 
17a3730146e56b7aee0f15dbcc6b6106a7bc4e82
Blamelist: Peter Wu 

BUILD FAILED: failed test.sh

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master e767f42: AMQP: fix field amqp.value is not of type FT_NONE

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e767f42a242fa640feaee7df70c668ee16114f2d
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
Repository: wireshark

Commits:

e767f42 by Alexis La Goutte (alexis.lagou...@gmail.com):

AMQP: fix field amqp.value is not of type FT_NONE

Bug: 13435
Change-Id: Ib61404fc3a8c461593d2a8a60224463ef2b9c4b6
Reviewed-on: https://code.wireshark.org/review/20309
Petri-Dish: Alexis La Goutte 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michael Mann 


Actions performed:

from  fff930d   Qt: do not expand collapsed trees when switching packets
adds  e767f42   AMQP: fix field amqp.value is not of type FT_NONE


Summary of changes:
 epan/dissectors/packet-amqp.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 6a05b59: Qt: do not expand collapsed trees when switching packets

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6a05b597c0a8e1d5d5a05c6eb1293b63d338d4d0
Submitter: Peter Wu (pe...@lekensteyn.nl)
Changed: branch: master-2.2
Repository: wireshark

Commits:

6a05b59 by Peter Wu (pe...@lekensteyn.nl):

Qt: do not expand collapsed trees when switching packets

Scenario: user selects a field, collapsed tha parent tree and selects
the next packet. Before this patch, the tree would be expanded again,
selecting the child. After this patch, the tree will not be expanded,
instead selecting the tree node that got collapsed.

Change-Id: I7968fca1056a937cf3b399afb6f3089c2d199067
Reviewed-on: https://code.wireshark.org/review/20801
Petri-Dish: Peter Wu 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Graham Bloice 
Reviewed-by: Peter Wu 
(cherry picked from commit fff930d3939c21a1ed988ef9014c32f75739ea7c)
Reviewed-on: https://code.wireshark.org/review/20806


Actions performed:

from  17a3730   dns: prevent repeatedly overwriting resolved entries
adds  6a05b59   Qt: do not expand collapsed trees when switching packets


Summary of changes:
 ui/qt/proto_tree.cpp |   11 +--
 1 file changed, 9 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master fff930d: Qt: do not expand collapsed trees when switching packets

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fff930d3939c21a1ed988ef9014c32f75739ea7c
Submitter: Peter Wu (pe...@lekensteyn.nl)
Changed: branch: master
Repository: wireshark

Commits:

fff930d by Peter Wu (pe...@lekensteyn.nl):

Qt: do not expand collapsed trees when switching packets

Scenario: user selects a field, collapsed tha parent tree and selects
the next packet. Before this patch, the tree would be expanded again,
selecting the child. After this patch, the tree will not be expanded,
instead selecting the tree node that got collapsed.

Change-Id: I7968fca1056a937cf3b399afb6f3089c2d199067
Reviewed-on: https://code.wireshark.org/review/20801
Petri-Dish: Peter Wu 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Graham Bloice 
Reviewed-by: Peter Wu 


Actions performed:

from  641a48e   checkAPIs: improve trailing item suggestion for XXX_string
adds  fff930d   Qt: do not expand collapsed trees when switching packets


Summary of changes:
 ui/qt/proto_tree.cpp |   11 +--
 1 file changed, 9 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 641a48e: checkAPIs: improve trailing item suggestion for XXX_string

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=641a48ec68778a5eaed82e436c09642e9ef1f911
Submitter: Peter Wu (pe...@lekensteyn.nl)
Changed: branch: master
Repository: wireshark

Commits:

641a48e by Peter Wu (pe...@lekensteyn.nl):

checkAPIs: improve trailing item suggestion for XXX_string

Tighten the check (do not just check for "0,NULL}};" but also
"{0,NULL}};" in case someone decides to use "{0x10,NULL}};" as trailing
item. Improve the suggestion, "{NULL,NULL}" is better for string_string
than "{0,NULL}".

For now treat 0 the same as NULL since files like packet-fix.h would
need editing otherwise. Accept octal notation for value_string since
packet-nfs.c uses this in nfs2_mode_names.

Change-Id: Ic507dbd8b07f3ae062b3f0310aa3398115d54273
Reviewed-on: https://code.wireshark.org/review/20796
Petri-Dish: Alexis La Goutte 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Alexis La Goutte 
Reviewed-by: Peter Wu 


Actions performed:

from  0896352   Fix typo.
adds  641a48e   checkAPIs: improve trailing item suggestion for XXX_string


Summary of changes:
 tools/checkAPIs.pl |   29 +
 1 file changed, 25 insertions(+), 4 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 17a3730: dns: prevent repeatedly overwriting resolved entries

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=17a3730146e56b7aee0f15dbcc6b6106a7bc4e82
Submitter: Peter Wu (pe...@lekensteyn.nl)
Changed: branch: master-2.2
Repository: wireshark

Commits:

17a3730 by Peter Wu (pe...@lekensteyn.nl):

dns: prevent repeatedly overwriting resolved entries

When a packet contains multiple conflicting names for the same address,
it would result in modification of the resolved name every time this DNS
packet is selected. In Qt, this causes a periodic (one second)
redissection of the current (DNS!) packet which interferes with user
interaction. To avoid this, only add the address on the first visit.

Bug: 13533
Change-Id: Ic71515131da4d666bfd589df9ff90a866a30778c
Reviewed-on: https://code.wireshark.org/review/20800
Petri-Dish: Peter Wu 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 
(cherry picked from commit 93cf5909ec0aabb84b96c518ad61e082d52600b6)
Reviewed-on: https://code.wireshark.org/review/20805
Reviewed-by: Peter Wu 


Actions performed:

from  c9beee0   Print signed values with %d, not %u.
adds  17a3730   dns: prevent repeatedly overwriting resolved entries


Summary of changes:
 epan/dissectors/packet-dns.c |6 --
 1 file changed, 4 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64

[buildbot-no-reply]

The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202012%20R2%20x64/builds/3223

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master] 
08963526bc618cb827f7e1eddb547c3bea0d2017
Blamelist: Guy Harris 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 0896352: Fix typo.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=08963526bc618cb827f7e1eddb547c3bea0d2017
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

0896352 by Guy Harris (g...@alum.mit.edu):

Fix typo.

Change-Id: I55137590280024dd383c0d005a2d9d79f9b7d38a
Reviewed-on: https://code.wireshark.org/review/20804
Reviewed-by: Guy Harris 


Actions performed:

from  9a3f177   Fix incorrect NSAP AFI values.
adds  0896352   Fix typo.


Summary of changes:
 epan/proto.h |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 9a3f177: Fix incorrect NSAP AFI values.

[Wireshark code review]

URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9a3f177c22cc9f02511913be51927aab5309ab11
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

9a3f177 by Guy Harris (g...@alum.mit.edu):

Fix incorrect NSAP AFI values.

Change-Id: I302041f5a08973229317455d8df8690256557e76
Reviewed-on: https://code.wireshark.org/review/20803
Reviewed-by: Guy Harris 


Actions performed:

from  93cf590   dns: prevent repeatedly overwriting resolved entries
adds  9a3f177   Fix incorrect NSAP AFI values.


Summary of changes:
 epan/dissectors/packet-arp.c  |6 +++---
 epan/dissectors/packet-isup.c |4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe