[Wireshark-commits] master 280f2fe: RPC-over-RDMA: protect against a variable overflow

2017-04-05 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=280f2feeaf95fcf50f028162b49be1bf6866c918
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

280f2fe by Pascal Quantin (pascal.quan...@gmail.com):

RPC-over-RDMA: protect against a variable overflow

Bug: 13558
Change-Id: I0cb379df1a6c40a3c4a84f18c631d9239550c3ab
Reviewed-on: https://code.wireshark.org/review/20941
Reviewed-by: Pascal Quantin 
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  0bd1190   BGP: fix a variable underflow
adds  280f2fe   RPC-over-RDMA: protect against a variable overflow


Summary of changes:
 epan/dissectors/packet-rpcrdma.c |   14 +-
 1 file changed, 9 insertions(+), 5 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 0bd1190: BGP: fix a variable underflow

2017-04-05 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0bd11903938e7fbcc876888178ed9c1f085fdffc
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

0bd1190 by Pascal Quantin (pascal.quan...@gmail.com):

BGP: fix a variable underflow

Bug: 13557
Change-Id: I882c8a7161ff233e289a413579ed51c3b8f43c36
Reviewed-on: https://code.wireshark.org/review/20940
Reviewed-by: Pascal Quantin 
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  899f989   WASSP: replace a DISSECTOR_ASSERT() by an expert info
adds  0bd1190   BGP: fix a variable underflow


Summary of changes:
 epan/dissectors/packet-bgp.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.0 on Windows Server 2012 R2 x64

2017-04-05 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.0/builders/Windows%20Server%202012%20R2%20x64/builds/585

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.0/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master-2.0] 
2edee293c47789ccdafbd3b745c8a2e89e415594
Blamelist: Guy Harris 

BUILD FAILED: failed test.sh

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 899f989: WASSP: replace a DISSECTOR_ASSERT() by an expert info

2017-04-05 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=899f98911365c22434c61df91fd0a6df576be276
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

899f989 by Pascal Quantin (pascal.quan...@gmail.com):

WASSP: replace a DISSECTOR_ASSERT() by an expert info

Bug: 13555
Change-Id: I052600eee1e0bf0f036e419bc9df7ff228941883
Reviewed-on: https://code.wireshark.org/review/20937
Reviewed-by: Pascal Quantin 
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  462fba9   LAPSat: remove a useless assert
adds  899f989   WASSP: replace a DISSECTOR_ASSERT() by an expert info


Summary of changes:
 epan/dissectors/packet-wassp.c |   28 +---
 1 file changed, 21 insertions(+), 7 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 462fba9: LAPSat: remove a useless assert

2017-04-05 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=462fba965a2ba5e15add24ef02bc4b9b95567ba5
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

462fba9 by Pascal Quantin (pascal.quan...@gmail.com):

LAPSat: remove a useless assert

If the length is bigger than the captured length, an excpetion will be 
thrown anyway

Bug: 13554
Change-Id: Icf0f2b049847ec945efdf42815b49c4e6040e19d
Reviewed-on: https://code.wireshark.org/review/20936
Reviewed-by: Pascal Quantin 
Petri-Dish: Pascal Quantin 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  f5f   BGP: Update BGP Path Attributes with latest IANA assignment.
adds  462fba9   LAPSat: remove a useless assert


Summary of changes:
 epan/dissectors/packet-lapsat.c |2 --
 1 file changed, 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.0 on Windows 8.1 x86

2017-04-05 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder Windows 8.1 x86 while 
building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.0/builders/Windows%208.1%20x86/builds/1230

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.0/

Buildslave for this Build: windows-8.1-x86

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master-2.0] 
2edee293c47789ccdafbd3b745c8a2e89e415594
Blamelist: Guy Harris 

BUILD FAILED: failed test.sh

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master f53333f: BGP: Update BGP Path Attributes with latest IANA assignment.

2017-04-05 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f5f43398bd09321b372c1f46085381ea4ab8
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

f5f by Simon Zhong (szhong.j...@gmail.com):

BGP: Update BGP Path Attributes with latest IANA assignment.

Change-Id: I6f66a5d51677db6cfea279c322ef9f976452de90
Reviewed-on: https://code.wireshark.org/review/20930
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  a00b971   TAPA: replace DISSECTOR_ASSERT() calls by expert info
adds  f5f   BGP: Update BGP Path Attributes with latest IANA assignment.


Summary of changes:
 epan/dissectors/packet-bgp.c |   72 --
 1 file changed, 49 insertions(+), 23 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.0 2edee29: TAPA: replace DISSECTOR_ASSERT() calls by expert info

2017-04-05 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2edee293c47789ccdafbd3b745c8a2e89e415594
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.0
Repository: wireshark

Commits:

2edee29 by Pascal Quantin (pascal.quan...@gmail.com):

TAPA: replace DISSECTOR_ASSERT() calls by expert info

Bug: 13553
Change-Id: I01d35c7e68bfee6d30da63cb804dd9913bb5a7a2
Reviewed-on: https://code.wireshark.org/review/20932
Reviewed-by: Pascal Quantin 
Petri-Dish: Pascal Quantin 
Reviewed-by: Guy Harris 
(cherry picked from commit a00b971b0712cb8a68d2d0cf3f2b9a4edafe62c0)
Reviewed-on: https://code.wireshark.org/review/20939


Actions performed:

from  0096f90   White space and style cleanups.
adds  2edee29   TAPA: replace DISSECTOR_ASSERT() calls by expert info


Summary of changes:
 epan/dissectors/packet-tapa.c |   58 +++--
 1 file changed, 39 insertions(+), 19 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 4a8ef7e: TAPA: replace DISSECTOR_ASSERT() calls by expert info

2017-04-05 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4a8ef7e9d323e63f6414fcea4c891551259b5785
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master-2.2
Repository: wireshark

Commits:

4a8ef7e by Pascal Quantin (pascal.quan...@gmail.com):

TAPA: replace DISSECTOR_ASSERT() calls by expert info

Bug: 13553
Change-Id: I01d35c7e68bfee6d30da63cb804dd9913bb5a7a2
Reviewed-on: https://code.wireshark.org/review/20932
Reviewed-by: Pascal Quantin 
Petri-Dish: Pascal Quantin 
Reviewed-by: Guy Harris 
(cherry picked from commit a00b971b0712cb8a68d2d0cf3f2b9a4edafe62c0)
Reviewed-on: https://code.wireshark.org/review/20938


Actions performed:

from  c94b1f5   Qt: fix tracer and selection of packet in IO Graph
adds  4a8ef7e   TAPA: replace DISSECTOR_ASSERT() calls by expert info


Summary of changes:
 epan/dissectors/packet-tapa.c |   58 +++--
 1 file changed, 39 insertions(+), 19 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master a00b971: TAPA: replace DISSECTOR_ASSERT() calls by expert info

2017-04-05 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a00b971b0712cb8a68d2d0cf3f2b9a4edafe62c0
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

a00b971 by Pascal Quantin (pascal.quan...@gmail.com):

TAPA: replace DISSECTOR_ASSERT() calls by expert info

Bug: 13553
Change-Id: I01d35c7e68bfee6d30da63cb804dd9913bb5a7a2
Reviewed-on: https://code.wireshark.org/review/20932
Reviewed-by: Pascal Quantin 
Petri-Dish: Pascal Quantin 
Reviewed-by: Guy Harris 


Actions performed:

from  9737754   More OS name cleanups.
adds  a00b971   TAPA: replace DISSECTOR_ASSERT() calls by expert info


Summary of changes:
 epan/dissectors/packet-tapa.c |   58 +++--
 1 file changed, 39 insertions(+), 19 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 9737754: More OS name cleanups.

2017-04-05 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=97377547a7cdd7fd51e252729ad916bee5f47967
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

9737754 by Guy Harris (g...@alum.mit.edu):

More OS name cleanups.

Use macOS when not referring to a particular release; use the
appropriate name when referring to a particular release.

Change-Id: I9293d4db7c91d7c859d7c067c0f0b3c9c482fcc5
Reviewed-on: https://code.wireshark.org/review/20935
Reviewed-by: Guy Harris 


Actions performed:

from  3dd45f5   Remove trailing whitespace.
adds  9737754   More OS name cleanups.


Summary of changes:
 packaging/macosx/Read_me_first.rtf |2 +-
 .../macosx/Wireshark_package.pmdoc/index.xml.in|2 +-
 packaging/macosx/dmg_set_style.scpt|  Bin 7078 -> 7968 bytes
 3 files changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 3dd45f5: Remove trailing whitespace.

2017-04-05 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3dd45f53d68b13db080e18c88f6855031db7d5fb
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

3dd45f5 by Guy Harris (g...@alum.mit.edu):

Remove trailing whitespace.

Change-Id: If044e0df526cfba0061ab3e5beec5a56dfe1e870
Reviewed-on: https://code.wireshark.org/review/20934
Reviewed-by: Guy Harris 


Actions performed:

from  357cfd3   A bunch of "{Mac} OS X" -> "macOS" changes.
adds  3dd45f5   Remove trailing whitespace.


Summary of changes:
 README.macos |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 357cfd3: A bunch of "{Mac} OS X" -> "macOS" changes.

2017-04-05 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=357cfd3b035d1ba6438e82cc1cbec105874206b6
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

357cfd3 by Guy Harris (g...@alum.mit.edu):

A bunch of "{Mac} OS X" -> "macOS" changes.

Avoid anachronisms, however; there was no "macOS 10.0" or even "OS X
10.0", for example.  It was "Mac OS X" until 10.8 (although 10.7 was
sometimes called "OS X" and sometimes called "Mac OS X"), and it was "OS
X" from 10.8 to 10.11.

Change-Id: Ie4a848997dcc6c45c2245c1fb84ec526032375c3
Reviewed-on: https://code.wireshark.org/review/20933
Reviewed-by: Guy Harris 


Actions performed:

from  1f94d34   Update comments.
adds  357cfd3   A bunch of "{Mac} OS X" -> "macOS" changes.


Summary of changes:
 CMakeLists.txt  |   30 ++-
 CMakeOptions.txt|4 ++--
 Makefile.am |6 +++---
 README  |2 +-
 README.cmake|   12 +--
 README.macos|   23 ++--
 caputils/capture-pcap-util-unix.c   |4 ++--
 caputils/capture-pcap-util.c|4 ++--
 caputils/iface_monitor.c|2 +-
 caputils/iface_monitor.h|2 +-
 cmake/modules/FindM.cmake   |2 +-
 cmake/modules/FindOS_X_FRAMEWORKS.cmake |8 +++
 cmake/modules/FindPCAP.cmake|2 +-
 cmakeconfig.h.in|4 ++--
 doc/README.plugins  |4 ++--
 doc/README.vagrant  |4 ++--
 dumpcap.c   |6 +++---
 epan/addr_resolv.c  |2 +-
 epan/aftypes.h  |2 +-
 epan/dissectors/packet-corosync-totemsrp.c  |2 +-
 epan/dissectors/packet-ieee80211-radiotap.c |2 +-
 epan/dissectors/packet-rpc.c|6 +++---
 epan/dissectors/packet-smb2.c   |2 +-
 epan/prefs.c|4 ++--
 help/faq.py |8 +++
 image/README.image  |4 ++--
 m4/ws_osx.m4|4 +---
 macosx-support-lib-patches/qt-fix-pc-files  |2 +-
 packaging/macosx/ChmodBPF/ChmodBPF  |4 ++--
 packaging/macosx/Info.plist.in  |2 +-
 packaging/macosx/osx-app.sh |   10 -
 test/run_and_catch_crashes  |2 +-
 test/suite-capture.sh   |2 +-
 tfshark.c   |4 ++--
 tools/checkAPIs.pl  |2 +-
 tools/test-common.sh|   10 -
 tshark.c|4 ++--
 ui/commandline.c|2 +-
 ui/console.c|2 +-
 ui/gtk/file_dlg.c   |6 +++---
 ui/gtk/main.c   |2 +-
 ui/gtk/main_menubar.c   |2 +-
 ui/gtk/prefs_gui.c  |4 ++--
 ui/gtk/rlc_lte_graph.c  |2 +-
 ui/gtk/tcp_graph.c  |2 +-
 ui/gtk/webbrowser.c |6 +++---
 ui/qt/capture_file_dialog.h |2 +-
 ui/qt/capture_filter_syntax_worker.cpp  |2 +-
 ui/qt/export_object_dialog.cpp  |2 +-
 ui/qt/geometry_state_dialog.h   |6 +++---
 ui/qt/interface_tree_model.cpp  |2 +-
 ui/qt/io_graph_dialog.cpp   |2 +-
 ui/qt/main_welcome.cpp  |2 +-
 ui/qt/main_welcome.h|2 +-
 ui/qt/main_window.cpp   |8 +++
 ui/qt/main_window_slots.cpp |   14 ++---
 ui/qt/manage_interfaces_dialog.cpp  |2 +-
 ui/qt/overlay_scroll_bar.cpp|2 +-
 ui/qt/packet_list.cpp   |4 ++--
 ui/qt/profile_dialog.cpp|2 +-
 ui/qt/progress_frame.cpp|2 +-
 ui/qt/protocol_preferences_menu.cpp |2 +-
 ui/qt/rtp_audio_stream.cpp  |2 +-
 ui/qt/sctp_chunk_statistics_dialog.cpp  |2 +-
 ui/qt/stock_icon.cpp|2 +-
 ui/qt/stock_icon_tool_button.cpp|4 ++--
 ui/qt/wireshark_application.cpp |   14 ++---
 ui/qt/wireshark_application.h   |2 +-
 wireshark-mime-package.xml  |2 +-
 wiretap/file_access.c   |   10 -
 wiretap/pcapng.c|2 +-
 ws_diag_control.h   |6

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64

2017-04-05 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202012%20R2%20x64/builds/3277

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master] 
71905a34b70857a8398840dc01b9df5ae59a652c
Blamelist: Guy Harris 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 1f94d34: Update comments.

2017-04-05 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1f94d34f43055ea47fc9426e1720bdb4b7397dd9
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

1f94d34 by Guy Harris (g...@alum.mit.edu):

Update comments.

The OS is now called macOS.

In newer versions of macOS, tar can uncompress xz'ed tarballs, but older
versions don't support that.

Change-Id: Ife8ac7fc7da69586ad6b718def4a52588740686b
Reviewed-on: https://code.wireshark.org/review/20931
Reviewed-by: Guy Harris 


Actions performed:

from  71905a3   Follow HTTP redirects when fetching tarballs in 
macosx-setup.sh
adds  1f94d34   Update comments.


Summary of changes:
 macosx-setup.sh |   30 +++---
 1 file changed, 15 insertions(+), 15 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 71905a3: Follow HTTP redirects when fetching tarballs in macosx-setup.sh

2017-04-05 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=71905a34b70857a8398840dc01b9df5ae59a652c
Submitter: Guy Harris (g...@alum.mit.edu)
Changed: branch: master
Repository: wireshark

Commits:

71905a3 by Ahmad Fatoum (ah...@a3f.at):

Follow HTTP redirects when fetching tarballs in macosx-setup.sh

xz now hosts older releases on SourceForge and does a 302 redirect
to SourceForge, which cURL without -L won't follow.
The default value of 50 redirects before giving up is left unchanged.

Change-Id: I2d73301f025737ad84438d01a445fe6f257ba9d5
Reviewed-on: https://code.wireshark.org/review/20926
Reviewed-by: Guy Harris 


Actions performed:

from  2eca457   Display numeric fields in their base display type for 
columns.
adds  71905a3   Follow HTTP redirects when fetching tarballs in 
macosx-setup.sh


Summary of changes:
 macosx-setup.sh |   30 +++---
 1 file changed, 15 insertions(+), 15 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark 2.2 on Ubuntu 16.04 x64

2017-04-05 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder Ubuntu 16.04 x64 while 
building Wireshark 2.2. Full details are available at:

http://buildbot.wireshark.org/wireshark-2.2/builders/Ubuntu%2016.04%20x64/builds/491

Buildbot URL: http://buildbot.wireshark.org/wireshark-2.2/

Buildslave for this Build: ubuntu-16.04-x64

Build Reason: A build was forced by 'Gerald': force build
Build Source Stamp: HEAD
Blamelist: 

BUILD FAILED: failed shell_4

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 16.04 x64

2017-04-05 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder Ubuntu 16.04 x64 while 
building Wireshark (development). Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Ubuntu%2016.04%20x64/builds/1831

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: ubuntu-16.04-x64

Build Reason: A build was forced by 'Gerald': force build
Build Source Stamp: HEAD
Blamelist: 

BUILD FAILED: failed

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 c94b1f5: Qt: fix tracer and selection of packet in IO Graph

2017-04-05 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c94b1f5cce521378cbbd3301d078b6b8f79f093d
Submitter: Peter Wu (pe...@lekensteyn.nl)
Changed: branch: master-2.2
Repository: wireshark

Commits:

c94b1f5 by Peter Wu (pe...@lekensteyn.nl):

Qt: fix tracer and selection of packet in IO Graph

Do not assume first graph in the list, pick the first visible graph.
This (1) fixes the tracer which would otherwise show a marker at an
non-obvious position that is not located on the graph and (2) fixes the
GoToPacket action when clicking on the graph.

Bug: 13537
Change-Id: I49d750102ad25c8539aa2e44fe1583cd535dd471
Reviewed-on: https://code.wireshark.org/review/20768
Petri-Dish: Peter Wu 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Peter Wu 
(cherry picked from commit a5f9b4e06dffa34e795f3abb1e44d4e7ec7cdfa9)
 [Conflicts resolved by replacing use of VariantPointer -- PeterWu]
Reviewed-on: https://code.wireshark.org/review/20925


Actions performed:

from  c5adb50   Bluetooth: HCI_CMD: Fix wrong field name
adds  c94b1f5   Qt: fix tracer and selection of packet in IO Graph


Summary of changes:
 ui/qt/io_graph_dialog.cpp |   40 +++-
 ui/qt/io_graph_dialog.h   |1 +
 2 files changed, 32 insertions(+), 9 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64

2017-04-05 Thread buildbot-no-reply 
The Buildbot has detected a new failure on builder Windows Server 2012 R2 x64 
while building wireshark. Full details are available at:

http://buildbot.wireshark.org/wireshark-master/builders/Windows%20Server%202012%20R2%20x64/builds/3275

Buildbot URL: http://buildbot.wireshark.org/wireshark-master/

Buildslave for this Build: windows-2012r2-x64

Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this 
build
Build Source Stamp: [branch refs/heads/master] 
2eca457d52eba25a70d82b796d147a764367f679
Blamelist: Anders Broman 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot



___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 c5adb50: Bluetooth: HCI_CMD: Fix wrong field name

2017-04-05 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c5adb50ed679bd689fde607f1d69a91c05d8716d
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master-2.2
Repository: wireshark

Commits:

c5adb50 by Michal Labedzki (michal.labed...@tieto.com):

Bluetooth: HCI_CMD: Fix wrong field name

Interval -> Window

Change-Id: Ic40811a87fd301a07e2a9af60b152feeab395ead
Reviewed-on: https://code.wireshark.org/review/20893
Petri-Dish: Michal Labedzki 
Reviewed-by: Michael Mann 
(cherry picked from commit 4543d339e35173523e5d3a7b21248a0c335d7348)
Reviewed-on: https://code.wireshark.org/review/20920


Actions performed:

from  29af115   Bluetooth: HFP: Fix expert info for reserved field in +BRSFs
adds  c5adb50   Bluetooth: HCI_CMD: Fix wrong field name


Summary of changes:
 epan/dissectors/packet-bthci_cmd.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 29af115: Bluetooth: HFP: Fix expert info for reserved field in +BRSFs

2017-04-05 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=29af1151f4f2b282c882f90c8927df57f8307dc2
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master-2.2
Repository: wireshark

Commits:

29af115 by Michal Labedzki (michal.labed...@tieto.com):

Bluetooth: HFP: Fix expert info for reserved field in +BRSFs

It seems to be issue introduced while implementing
features from new specification - add new bits in bitmask field
without correcting expert info condition.

Change-Id: I5a4fb4147971f565cfb5dd1abf4e5616ce9da4c5
Reviewed-on: https://code.wireshark.org/review/20895
Petri-Dish: Michal Labedzki 
Reviewed-by: Michael Mann 
(cherry picked from commit ae7ac4441e2a46b2d34e00e94fcc72e25152644c)
Reviewed-on: https://code.wireshark.org/review/20921


Actions performed:

from  70b92bf   Bluetooth: PBAP: Fix two Application Parameters fields
adds  29af115   Bluetooth: HFP: Fix expert info for reserved field in +BRSFs


Summary of changes:
 epan/dissectors/packet-bthfp.c |8 
 1 file changed, 4 insertions(+), 4 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master-2.2 70b92bf: Bluetooth: PBAP: Fix two Application Parameters fields

2017-04-05 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=70b92bf28665639f12a2e7e7968781342a6b669b
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master-2.2
Repository: wireshark

Commits:

70b92bf by Michal Labedzki (michal.labed...@tieto.com):

Bluetooth: PBAP: Fix two Application Parameters fields

Application Parameters:
  vCard Selector
  Data Filter

Both are splitted to two 4-bytes subfield, so there is a need to
move offset for second field.

Change-Id: I66c106f5455bff8789f25c683301276b1e484e65
Reviewed-on: https://code.wireshark.org/review/20892
Petri-Dish: Michal Labedzki 
Reviewed-by: Michael Mann 
(cherry picked from commit 889752a294291d2168989ec5ff1efcda0c967bcf)
Reviewed-on: https://code.wireshark.org/review/20922


Actions performed:

from  1d5fe35   White space and style cleanups.
adds  70b92bf   Bluetooth: PBAP: Fix two Application Parameters fields


Summary of changes:
 epan/dissectors/packet-obex.c |8 
 1 file changed, 4 insertions(+), 4 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 2eca457: Display numeric fields in their base display type for columns.

2017-04-05 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2eca457d52eba25a70d82b796d147a764367f679
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

2eca457 by Michael Mann (mman...@netscape.net):

Display numeric fields in their base display type for columns.

Don't force display of BASE_DEC

Change-Id: Id6f115c074f0d4b1bd277dcbf6c523ffaa295edb
Reviewed-on: https://code.wireshark.org/review/20918
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  c018405   Bluetooth: HCI_CMD: Implement all remaining commands
adds  2eca457   Display numeric fields in their base display type for 
columns.


Summary of changes:
 epan/proto.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master c018405: Bluetooth: HCI_CMD: Implement all remaining commands

2017-04-05 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c0184059d1fd48cfe2fd80302d1928088f7e0524
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

c018405 by Michal Labedzki (michal.labed...@tieto.com):

Bluetooth: HCI_CMD: Implement all remaining commands

Commands:
  Set Connectionless Slave Broadcast Data
  Read Synchronization Train Parameters
  Write Synchronization Train Parameters
  Read Secure Connections Host Support
  Write Secure Connections Host Support
  Read Authenticated Payload Timeout
  Write Authenticated Payload Timeout
  Read Local OOB Extended Data
  Read Extended Page Timeout
  Write Extended Page Timeout
  Read Extended Inquiry Length
  Write Extended Inquiry Length

Change-Id: If6d7a7b5405c9b9bd708553d56c6bd372b0b293b
Reviewed-on: https://code.wireshark.org/review/20891
Petri-Dish: Michael Mann 
Petri-Dish: Michal Labedzki 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Anders Broman 


Actions performed:

from  023cf32   Qt: support selecting the min/max packet from IO Graph
adds  c018405   Bluetooth: HCI_CMD: Implement all remaining commands


Summary of changes:
 epan/dissectors/packet-bthci_cmd.c |  122 +---
 1 file changed, 112 insertions(+), 10 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 023cf32: Qt: support selecting the min/max packet from IO Graph

2017-04-05 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=023cf320ebc2ce467aec07136c74a32254cf733c
Submitter: Peter Wu (pe...@lekensteyn.nl)
Changed: branch: master
Repository: wireshark

Commits:

023cf32 by Peter Wu (pe...@lekensteyn.nl):

Qt: support selecting the min/max packet from IO Graph

GTK+ supports selecting the first packet (via the "left mouse button")
and the last packet (via the "right mouse button") in an interval, and
Qt supports selecting the last packet of an interval. This patch enables
picking the packet matching the extreme value in Qt.

Bug: 12401
Change-Id: If0b7f2f1bf8c384ea0d68b5f5fae2d1e8b4b0ac2
Reviewed-on: https://code.wireshark.org/review/20769
Petri-Dish: Peter Wu 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Peter Wu 


Actions performed:

from  a5f9b4e   Qt: fix tracer and selection of packet in IO Graph
adds  023cf32   Qt: support selecting the min/max packet from IO Graph


Summary of changes:
 ui/io_graph_item.h|   44 
 ui/qt/io_graph_dialog.cpp |8 +++-
 2 files changed, 51 insertions(+), 1 deletion(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master a5f9b4e: Qt: fix tracer and selection of packet in IO Graph

2017-04-05 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a5f9b4e06dffa34e795f3abb1e44d4e7ec7cdfa9
Submitter: Peter Wu (pe...@lekensteyn.nl)
Changed: branch: master
Repository: wireshark

Commits:

a5f9b4e by Peter Wu (pe...@lekensteyn.nl):

Qt: fix tracer and selection of packet in IO Graph

Do not assume first graph in the list, pick the first visible graph.
This (1) fixes the tracer which would otherwise show a marker at an
non-obvious position that is not located on the graph and (2) fixes the
GoToPacket action when clicking on the graph.

Bug: 13537
Change-Id: I49d750102ad25c8539aa2e44fe1583cd535dd471
Reviewed-on: https://code.wireshark.org/review/20768
Petri-Dish: Peter Wu 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Peter Wu 


Actions performed:

from  48a614d   LTE RRC: add description of FGI 42 bit
adds  a5f9b4e   Qt: fix tracer and selection of packet in IO Graph


Summary of changes:
 ui/qt/io_graph_dialog.cpp |   40 +++-
 ui/qt/io_graph_dialog.h   |1 +
 2 files changed, 32 insertions(+), 9 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 48a614d: LTE RRC: add description of FGI 42 bit

2017-04-05 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=48a614da2eae8b1f54cdfa9c7d0d2c22275a9e07
Submitter: Pascal Quantin (pascal.quan...@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

48a614d by Pascal Quantin (pascal.quan...@gmail.com):

LTE RRC: add description of FGI 42 bit

Change-Id: Ie72e82c26eddef9ca99b7da801cc85e54ba5158e
Reviewed-on: https://code.wireshark.org/review/20924
Reviewed-by: Pascal Quantin 


Actions performed:

from  3053d7c   Qt: Remove unused argument in Size string
adds  48a614d   LTE RRC: add description of FGI 42 bit


Summary of changes:
 .../asn1/lte-rrc/packet-lte-rrc-template.c |4 ++--
 epan/dissectors/packet-lte-rrc.c   |4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 3053d7c: Qt: Remove unused argument in Size string

2017-04-05 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3053d7c0c14515fa8ab46a5b01e45678bd19f314
Submitter: Stig Bjørlykke (s...@bjorlykke.org)
Changed: branch: master
Repository: wireshark

Commits:

3053d7c by Stig Bjørlykke (s...@bjorlykke.org):

Qt: Remove unused argument in Size string

Change-Id: I4c09092aba986c4fe224a46cac23d70bc5915aa6
Reviewed-on: https://code.wireshark.org/review/20923
Petri-Dish: Stig Bjørlykke 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Stig Bjørlykke 


Actions performed:

from  9f71c86   A few more BASE_UNIT_STRING cases.
adds  3053d7c   Qt: Remove unused argument in Size string


Summary of changes:
 ui/qt/capture_file_dialog.cpp |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 9f71c86: A few more BASE_UNIT_STRING cases.

2017-04-05 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9f71c86880cb5c3eab65c82e6fb3d32e603f3709
Submitter: Jaap Keuter (jaap.keu...@xs4all.nl)
Changed: branch: master
Repository: wireshark

Commits:

9f71c86 by Michael Mann (mman...@netscape.net):

A few more BASE_UNIT_STRING cases.

Change-Id: Ic443f773d19e63aad59292bfb540f58bda565241
Reviewed-on: https://code.wireshark.org/review/20917
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Jaap Keuter 


Actions performed:

from  70eeeff   packet-etch.c: Optimize proto_item_append_text use
adds  9f71c86   A few more BASE_UNIT_STRING cases.


Summary of changes:
 epan/dissectors/packet-ancp.c |4 ++--
 epan/dissectors/packet-bfd.c  |6 ++
 epan/dissectors/packet-ieee1722.c |3 +--
 3 files changed, 5 insertions(+), 8 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 70eeeff: packet-etch.c: Optimize proto_item_append_text use

2017-04-05 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=70eeeff25ce9aab6f4725d325e13aac690f48f00
Submitter: Jaap Keuter (jaap.keu...@xs4all.nl)
Changed: branch: master
Repository: wireshark

Commits:

70eeeff by Michael Mann (mman...@netscape.net):

packet-etch.c: Optimize proto_item_append_text use

Change-Id: I0272b7160fa2207fd4bba40d9d4b59ab920c6298
Reviewed-on: https://code.wireshark.org/review/20916
Reviewed-by: Alexis La Goutte 
Petri-Dish: Alexis La Goutte 
Reviewed-by: Anders Broman 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Jaap Keuter 


Actions performed:

from  76edea1   Bluetooth: HCI_CMD: Fix master-slave role
adds  70eeeff   packet-etch.c: Optimize proto_item_append_text use


Summary of changes:
 epan/dissectors/packet-etch.c |4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe

[Wireshark-commits] master 76edea1: Bluetooth: HCI_CMD: Fix master-slave role

2017-04-05 Thread Wireshark code review 
URL: 
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=76edea174f808785cca55033cb3c2ebfbf149e6a
Submitter: Michal Labedzki (michal.labed...@wireshark.org)
Changed: branch: master
Repository: wireshark

Commits:

76edea1 by Michal Labedzki (michal.labed...@tieto.com):

Bluetooth: HCI_CMD: Fix master-slave role

Initiator is always master. Only Role switch event may change it.
Improve "Accept Connection Request" to avoid users confusion
by using new specification description:
0x00 Become the Master for this connection. The LM will perform the role 
switch.
0x01 Remain the Slave for this connection. The LM will NOT perform the role 
switch.

Field "Role" is now splitted from: "bthci_cmd.role"
and it name is "bthci_cmd.acr.role".

Change-Id: I98e3641b9ba9d2fd6c97808e4772beb4265018fd
Reviewed-on: https://code.wireshark.org/review/20894
Petri-Dish: Michal Labedzki 
Tested-by: Petri Dish Buildbot 
Reviewed-by: Michal Labedzki 


Actions performed:

from  cf54564   packet-geneve.c: Convert print_flags to 
proto_tree_add_bitmask
adds  76edea1   Bluetooth: HCI_CMD: Fix master-slave role


Summary of changes:
 epan/dissectors/packet-bthci_cmd.c |   23 ++-
 1 file changed, 14 insertions(+), 9 deletions(-)
___
Sent via:Wireshark-commits mailing list 
Archives:https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
 mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe