[Wireshark-commits] master f91e653: lldp: show the Protocol Identity as bytes, not a text string.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f91e6535c2aa17466a06bcaf62f4019df5b2ee68 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: f91e653 by Guy Harris (ghar...@sonic.net): lldp: show the Protocol Identity as bytes, not a text string. Section D.2.4.3 "protocol identity" of IEEE 802.1Q-2018 says: The protocol identity field shall contain the first n octets of the protocol after the layer 2 addresses (i.e., for example, starting with the EtherType field) that the sender would like to advertise. Show it as FT_BYTES, not FT_STRINGZ. Add a comment explaining that, and expand a comment to indicate what specifications there are for LLDP and some Organizationally Specific TLVs. Change-Id: I8c41026379731d1c05134d6e7ad563227f9fbfde Reviewed-on: https://code.wireshark.org/review/38229 Petri-Dish: Guy Harris Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris Actions performed: from 82a4968 plugin_if: add plugin_if_get_frame_data() and plugin_if_get_capture_file() add f91e653 lldp: show the Protocol Identity as bytes, not a text string. Summary of changes: epan/dissectors/packet-lldp.c | 34 -- 1 file changed, 32 insertions(+), 2 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 82a4968: plugin_if: add plugin_if_get_frame_data() and plugin_if_get_capture_file()
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=82a4968bc31b8fa85a3f45a583d8f7f71bd6737f Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 82a4968 by Tomas Kukosa (kuk...@herman.cz): plugin_if: add plugin_if_get_frame_data() and plugin_if_get_capture_file() Change-Id: I7505d4185f18d13d6836c9c9bb8f400d12f2a524 Reviewed-on: https://code.wireshark.org/review/38217 Petri-Dish: Tomáš Kukosa Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall Actions performed: from 7e46db8 gnutella: add a comment about the character encoding. add 82a4968 plugin_if: add plugin_if_get_frame_data() and plugin_if_get_capture_file() Summary of changes: debian/libwireshark0.symbols | 2 ++ epan/plugin_if.c | 34 +++ epan/plugin_if.h | 14 ++ plugins/epan/pluginifdemo/pluginifdemo.c | 23 ++-- ui/qt/main_window.cpp| 46 5 files changed, 117 insertions(+), 2 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 7e46db8: gnutella: add a comment about the character encoding.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7e46db8f866abae189f0d4cf616d4c4f733f2239 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: 7e46db8 by Guy Harris (ghar...@sonic.net): gnutella: add a comment about the character encoding. Change-Id: I9daf9a5de2e49c5d6e16780254db045b673999f5 Reviewed-on: https://code.wireshark.org/review/38228 Reviewed-by: Guy Harris Actions performed: from ae9f431 wmem_strbuf: add comments asking whether some checks are necessary. add 7e46db8 gnutella: add a comment about the character encoding. Summary of changes: epan/dissectors/packet-gnutella.c | 16 1 file changed, 16 insertions(+) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master ae9f431: wmem_strbuf: add comments asking whether some checks are necessary.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ae9f431c0973b106012bdce483bc59970d85877a Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: ae9f431 by Guy Harris (ghar...@sonic.net): wmem_strbuf: add comments asking whether some checks are necessary. Change-Id: I5a918eba4301aea64c58a8ada89b4daa49fb8c87 Reviewed-on: https://code.wireshark.org/review/38226 Reviewed-by: Guy Harris Actions performed: from c542e24 tds: update URLs. add ae9f431 wmem_strbuf: add comments asking whether some checks are necessary. Summary of changes: epan/wmem/wmem_strbuf.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master c542e24: tds: update URLs.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c542e2476c19142a5e50dcdb006bfd64084fef02 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: c542e24 by Guy Harris (ghar...@sonic.net): tds: update URLs. Fix some Wayback Machine URLs that no longer work because the wayback.archive.org domain name no longer works. Update some Microsoft URLs that used to go through the Wayback Machine to point to the current versions at docs.microsoft.com. Update a comment to reflect the disappearance of a Network Associates document and its absence from the Wayback Machine. Change-Id: I27a5b19fa7747a8f601fd9e6c0bf75aba0a3528e Reviewed-on: https://code.wireshark.org/review/38225 Reviewed-by: Guy Harris Actions performed: from cc84e6a mysql: add more URLs. add c542e24 tds: update URLs. Summary of changes: epan/dissectors/packet-tds.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master cc84e6a: mysql: add more URLs.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cc84e6a4e59eaf1c436c4ffc022c979226aa96e3 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: cc84e6a by Guy Harris (ghar...@sonic.net): mysql: add more URLs. Add URLs from newer versions of the protocol documentation. Change-Id: I03d6b4d34ce7f7b831a4eda3075b65b026f96526 Reviewed-on: https://code.wireshark.org/review/38224 Reviewed-by: Guy Harris Actions performed: from 0815888 hiqnet: update URL, use HTTPS One More Place. add cc84e6a mysql: add more URLs. Summary of changes: epan/dissectors/packet-mysql.c | 3 +++ 1 file changed, 3 insertions(+) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 0815888: hiqnet: update URL, use HTTPS One More Place.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=08158882afa2b4d2befc66eedb8c33aea741f483 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: 0815888 by Guy Harris (ghar...@sonic.net): hiqnet: update URL, use HTTPS One More Place. Update one URL to a newer location and newer version of the document; change the other one to use HTTPS. Change-Id: I18bb2a14722c4e340a3e5f1afe0198def9d4fceb Reviewed-on: https://code.wireshark.org/review/38223 Reviewed-by: Guy Harris Actions performed: from 0580dc7 dmp: add the Wayback Machine version of a URL. add 0815888 hiqnet: update URL, use HTTPS One More Place. Summary of changes: epan/dissectors/packet-hiqnet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 0580dc7: dmp: add the Wayback Machine version of a URL.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0580dc7677db9c2f9564182286c11f202f90debe Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: 0580dc7 by Guy Harris (ghar...@sonic.net): dmp: add the Wayback Machine version of a URL. The original document no longer appears to be available; point to the Wayback Machine version. Change-Id: I9f0b0742339cc7a982e638cbae5155e9ac6c1d20 Reviewed-on: https://code.wireshark.org/review/38222 Reviewed-by: Guy Harris Actions performed: from be8315e GBCS: Add alert clock not adjusted outside tolerance add 0580dc7 dmp: add the Wayback Machine version of a URL. Summary of changes: epan/dissectors/packet-dmp.c | 1 + 1 file changed, 1 insertion(+) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master be8315e: GBCS: Add alert clock not adjusted outside tolerance
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=be8315eeac7e6def5191bb75232d21f8a908eff7 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: be8315e by Kenneth Soerensen (knnthsr...@gmail.com): GBCS: Add alert clock not adjusted outside tolerance Change-Id: Id41647e359c582aa287b605dba077ef9cfd4d7fc Reviewed-on: https://code.wireshark.org/review/38219 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman Actions performed: from f436253 indigocare-netrix: use a string encoding for all tvb_get_string_enc() calls. add be8315e GBCS: Add alert clock not adjusted outside tolerance Summary of changes: epan/dissectors/packet-gbcs.c | 1 + 1 file changed, 1 insertion(+) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master f436253: indigocare-netrix: use a string encoding for all tvb_get_string_enc() calls.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f43625386a7a58d47f0dc313f9980962cd8444bc Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: f436253 by Guy Harris (ghar...@sonic.net): indigocare-netrix: use a string encoding for all tvb_get_string_enc() calls. Don't just pass ENC_NA, pass ENC_ASCII|ENC_NA, to mark all string fetches with the encoding to use. Change-Id: Icbe533b8e36d6df25841049950512cecd4c247a1 Reviewed-on: https://code.wireshark.org/review/38221 Reviewed-by: Guy Harris Actions performed: from 5dec9f9 indigocare-icall: use a string encoding for all tvb_get_string_enc() calls. add f436253 indigocare-netrix: use a string encoding for all tvb_get_string_enc() calls. Summary of changes: epan/dissectors/packet-indigocare-netrix.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 5dec9f9: indigocare-icall: use a string encoding for all tvb_get_string_enc() calls.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5dec9f91fcd3ab246cf54d9bc26b91c88a3913ea Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: 5dec9f9 by Guy Harris (ghar...@sonic.net): indigocare-icall: use a string encoding for all tvb_get_string_enc() calls. Don't just pass ENC_NA, pass ENC_ASCII|ENC_NA, to mark all string fetches with the encoding to use. Change-Id: If834f216a49787ff09b3b714d755d9467848e5a5 Reviewed-on: https://code.wireshark.org/review/38220 Reviewed-by: Guy Harris Actions performed: from 421db8b proxy: add AWS TLV (VPCE) add 5dec9f9 indigocare-icall: use a string encoding for all tvb_get_string_enc() calls. Summary of changes: epan/dissectors/packet-indigocare-icall.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 421db8b: proxy: add AWS TLV (VPCE)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=421db8b0198e8b81565dfed57ef3a0ae848902d8 Submitter: "Jaap Keuter " Changed: branch: master Repository: wireshark Commits: 421db8b by Alexis La Goutte (alexis.lagou...@gmail.com): proxy: add AWS TLV (VPCE) Change-Id: I1a0d8fd3dd9c5a0fc3b414c1dff40340df0afc73 Reviewed-on: https://code.wireshark.org/review/29709 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Jaap Keuter Actions performed: from 6dc6d26 SMB2: Add TC reserved flags field add 421db8b proxy: add AWS TLV (VPCE) Summary of changes: epan/dissectors/packet-proxy.c | 2 ++ 1 file changed, 2 insertions(+) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 6dc6d26: SMB2: Add TC reserved flags field
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6dc6d26768a08a9ad23970782a242219dd911e97 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 6dc6d26 by Alexis La Goutte (alexis.lagou...@gmail.com): SMB2: Add TC reserved flags field Change-Id: Idc23fcc876f3e5e8bd83118ff6c5708c55e422f0 Reviewed-on: https://code.wireshark.org/review/38216 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: ronnie sahlberg Actions performed: from 81651fa SMB2: use tfs set_notset add 6dc6d26 SMB2: Add TC reserved flags field Summary of changes: epan/dissectors/packet-smb2.c | 7 +++ 1 file changed, 7 insertions(+) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master 81651fa: SMB2: use tfs set_notset
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=81651fa34fefcd35b191d94966c1efc0098653d5 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 81651fa by Alexis La Goutte (alexis.lagou...@gmail.com): SMB2: use tfs set_notset Change-Id: I1287d449b1f20a4da625d2629226573cc5497db3 Reviewed-on: https://code.wireshark.org/review/38215 Reviewed-by: ronnie sahlberg Actions performed: from fa6f268 gearman: expand a comment. add 81651fa SMB2: use tfs set_notset Summary of changes: epan/dissectors/packet-smb2.c | 21 +++-- 1 file changed, 3 insertions(+), 18 deletions(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master fa6f268: gearman: expand a comment.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fa6f2681e38378685e75c2fc7fe15ad8226e68ad Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: fa6f268 by Guy Harris (ghar...@sonic.net): gearman: expand a comment. Change-Id: I886f8a6b55e908f2c55f2a45f90dc7e6411467e5 Reviewed-on: https://code.wireshark.org/review/38218 Reviewed-by: Guy Harris Actions performed: from 132d6ec gsmtap: Add support for E1/T1 traces add fa6f268 gearman: expand a comment. Summary of changes: epan/dissectors/packet-gearman.c | 4 1 file changed, 4 insertions(+) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
[Wireshark-commits] master-3.2 f4db9ac: dicom: Handle frames with segments from different reassemblies
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f4db9acd5f4df2bdad43401b1df9f3c259598519 Submitter: "Anders Broman " Changed: branch: master-3.2 Repository: wireshark Commits: f4db9ac by John Thacker (johnthac...@gmail.com): dicom: Handle frames with segments from different reassemblies There can be multiple PDV segments in the same frame that belong to different reassemblies. Change the reassembly_id used for the reassembly tables so that it is not identical for all segments in the same presentation context (but still unique for a given reassembly), so that that case can be handled properly. Otherwise fragment_add_seq_next will retrieve the wrong reassembly for one of the segments (especially on the second pass.) Bug: 13110 Change-Id: Ib967fc7f6b7b591b9e3494d81d3b5d4ecc43cac1 Reviewed-on: https://code.wireshark.org/review/38200 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman (cherry picked from commit df69e61cb6bc3910975d864175a1f64476fcd25c) Reviewed-on: https://code.wireshark.org/review/38207 Reviewed-by: Jaap Keuter Petri-Dish: Jaap Keuter Actions performed: from f404b09 PROFINET: DHCP suboption undefined bytes add f4db9ac dicom: Handle frames with segments from different reassemblies Summary of changes: epan/dissectors/packet-dcm.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) ___ Sent via:Wireshark-commits mailing list Archives:https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
