[Wireshark-commits] master-3.2 16a85d5: GSM-SMS: add missing increment of offset.

2020-05-16 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=16a85d5ee0bf6a5c21fbccc47edcb3b312b557f3 Submitter: "Guy Harris " Changed: branch: master-3.2 Repository: wireshark Commits: 16a85d5 by Martin Mathieson (martin.r.mathie...@googlemail.com): GSM-SMS: add missing

[Wireshark-commits] master-3.2 888ea63: More PVS-Studio issues flagged by Valerii Zapodovnikov.

2020-05-16 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=888ea633cfce81ddda2577a1765d7d1dda6a57fe Submitter: "Guy Harris " Changed: branch: master-3.2 Repository: wireshark Commits: 888ea63 by Martin Mathieson (martin.mathie...@keysight.com): More PVS-Studio issues flagged

[Wireshark-commits] master e34f760: isobus-vt: update with information from the spec.

2020-05-16 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e34f760f285b13d1267c721ae11882241a6a3f3b Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: e34f760 by Guy Harris (ghar...@sonic.net): isobus-vt: update with information from the spec.

[Wireshark-commits] master e837ad5: PFCP: fix wrong names of some IEs

2020-05-16 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e837ad57d9f55f4eaab2da8ea41b75f329817139 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: e837ad5 by Yoshiyuki Kurauchi (ahochauwaa...@gmail.com): PFCP: fix wrong names of some IEs

[Wireshark-commits] master a9b0db1: PFCP: fix Trace Information IE

2020-05-16 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a9b0db19c03a923705aa5ff17e97139e0108 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: a9b0db1 by Yoshiyuki Kurauchi (ahochauwaa...@gmail.com): PFCP: fix Trace Information IE

[Wireshark-commits] master bd1724a: PFCP: fix Ethertype IE

2020-05-16 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bd1724aa3876e849ecd4c046984e5c06b11869b4 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: bd1724a by Yoshiyuki Kurauchi (ahochauwaa...@gmail.com): PFCP: fix Ethertype IE Fix

[Wireshark-commits] master cf340fa: USB: fix redundant assignments or tests flagged by PVS-Studio

2020-05-16 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cf340fa0ec458e9a0fd97f4e6a6bd427217fd441 Submitter: "Martin Mathieson " Changed: branch: master Repository: wireshark Commits: cf340fa by Martin Mathieson (martin.mathie...@keysight.com): USB: fix redundant

[Wireshark-commits] master 7794527: rlcmac: Improve COL_INFO for (E)GPRS packets

2020-05-15 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7794527604e27e6da88d4871ba27aa48ec89abd1 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 7794527 by Pau Espin Pedrol (pes...@sysmocom.de): rlcmac: Improve COL_INFO for (E)GPRS

[Wireshark-commits] master 1ddd993: gprscdr: Update to 3GPP TS 32.298 V16.4.1

2020-05-15 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1ddd9932d881e0399c07f3524c0fe72ba661686d Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 1ddd993 by Joakim Karlsson (oak...@gmail.com): gprscdr: Update to 3GPP TS 32.298 V16.4.1

[Wireshark-commits] master cbb12e0: pfcp: Update to 3GPP TS 29.244 V16.3.1

2020-05-15 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cbb12e04bf0de7e78ecd1c9b46e2ceab95a8 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: cbb12e0 by Joakim Karlsson (oak...@gmail.com): pfcp: Update to 3GPP TS 29.244 V16.3.1

[Wireshark-commits] master 454d974: tls: PSK is named "Pre-Shared Key"

2020-05-15 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=454d974fe58d0829a8a41fabcee7914599e95102 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 454d974 by Stig Bjørlykke (s...@bjorlykke.org): tls: PSK is named "Pre-Shared Key"

[Wireshark-commits] master f331b62: NSH MD Type 2 Context TLV definition updated to conform with RFC8300.

2020-05-15 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f331b6243663ee466fadfff6da6db15205ad2b17 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: f331b62 by Vanson Lim (v...@cisco.com): NSH MD Type 2 Context TLV definition updated to

[Wireshark-commits] master-2.6 75a6906: Radius: Fix NULL pointer call

2020-05-15 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=75a6906892de89869c068d28268d83c7f2db32dd Submitter: "Pascal Quantin " Changed: branch: master-2.6 Repository: wireshark Commits: 75a6906 by Uli Heilmeier (u...@heilmeier.eu): Radius: Fix NULL pointer call

[Wireshark-commits] master-3.0 b36232d: Radius: Fix NULL pointer call

2020-05-15 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b36232d5856eef1db533d23b14440c9afda624b5 Submitter: "Pascal Quantin " Changed: branch: master-3.0 Repository: wireshark Commits: b36232d by Uli Heilmeier (u...@heilmeier.eu): Radius: Fix NULL pointer call

[Wireshark-commits] master-3.2 3c67e08: Radius: Fix NULL pointer call

2020-05-15 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3c67e08b4ff27e0c7bc9a44e6498773071567d42 Submitter: "Pascal Quantin " Changed: branch: master-3.2 Repository: wireshark Commits: 3c67e08 by Uli Heilmeier (u...@heilmeier.eu): Radius: Fix NULL pointer call

[Wireshark-commits] master b5dc967: Radius: Fix NULL pointer call

2020-05-15 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b5dc967c7924a3bd4326099c2939f3bb068a1c35 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: b5dc967 by Uli Heilmeier (u...@heilmeier.eu): Radius: Fix NULL pointer call Check

[Wireshark-commits] master 6078965: smb2: add dissector for App_Instance_Version structure in SMB2 Create Context.

2020-05-15 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6078965ebe5ba2c9956651d97a6b0b451ab3a191 Submitter: "Alexis La Goutte " Changed: branch: master Repository: wireshark Commits: 6078965 by Andy Zhao (jinh...@gmail.com): smb2: add dissector for App_Instance_Version

[Wireshark-commits] master 2342872: ENIP: TCP/IP Object Updates

2020-05-14 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2342872ed4fd135a625d5f6e455a8004229d9ec8 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 2342872 by Dylan Ulis (daul...@gmail.com): ENIP: TCP/IP Object Updates 1. Status

[Wireshark-commits] master 536f5b4: sharkd_session.c: fix a warning reported by gcc 10

2020-05-14 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=536f5b466bfe5b88cafaa1b04f3052a155376afb Submitter: "Alexis La Goutte " Changed: branch: master Repository: wireshark Commits: 536f5b4 by Pascal Quantin (pas...@wireshark.org): sharkd_session.c: fix a warning reported

[Wireshark-commits] master 4b67b72: SBcAP: fix update of info column

2020-05-14 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4b67b72d2a5724f650cf59f912faa96f999e2eca Submitter: "Pascal Quantin " Changed: branch: master Repository: wireshark Commits: 4b67b72 by Pascal Quantin (pas...@wireshark.org): SBcAP: fix update of info column

[Wireshark-commits] master d2812de: Fix some more broken web links in dissector code

2020-05-14 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d2812de8e7eba334ba5c33994afc0c2254938b86 Submitter: "Martin Mathieson " Changed: branch: master Repository: wireshark Commits: d2812de by Martin Mathieson (martin.mathie...@keysight.com): Fix some more broken web

[Wireshark-commits] master 84e0f45: Add radiotap.vendor dissector table for vendor namespace

2020-05-14 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=84e0f456401d73c8e88c8393d1572383485960bc Submitter: "Alexis La Goutte " Changed: branch: master Repository: wireshark Commits: 84e0f45 by Tomas Kukosa (tke...@gmail.com): Add radiotap.vendor dissector table for vendor

[Wireshark-commits] master 5ed4f53: Fix a few broken web links from dissectors

2020-05-13 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5ed4f53e2bbabef638855cc12af57713aff28d15 Submitter: "Martin Mathieson " Changed: branch: master Repository: wireshark Commits: 5ed4f53 by Martin Mathieson (martin.mathie...@keysight.com): Fix a few broken web links

[Wireshark-commits] master 90d1a9d: scylla: fix tree sizes and offsets

2020-05-13 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=90d1a9de4392992544c44923d7ba0247a582aacb Submitter: "Martin Mathieson " Changed: branch: master Repository: wireshark Commits: 90d1a9d by Piotr Sarna (sa...@scylladb.com): scylla: fix tree sizes and offsets

[Wireshark-commits] master 256cc1a: RTPS: updated submessage parsing to match protocol spec

2020-05-13 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=256cc1a85cef3df99958ae9d825b0b0901b1521c Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 256cc1a by Adam Mitz (mi...@objectcomputing.com): RTPS: updated submessage parsing to match

[Wireshark-commits] master da8c28d: CIP Motion: Connection Configuration Data

2020-05-13 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=da8c28dc67ac3d319fa8f97a6f74682043eaf0f2 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: da8c28d by Dylan Ulis (daul...@gmail.com): CIP Motion: Connection Configuration Data

[Wireshark-commits] master e8c9b6c: DoxyGen: Add Wireshark icon to output

2020-05-13 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e8c9b6c0dd6603f9f1b4e02ee128bcf0d3befd85 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: e8c9b6c by Jaap Keuter (jaap.keu...@xs4all.nl): DoxyGen: Add Wireshark icon to output

[Wireshark-commits] master 91a4950: DoxyGen: Remove build dir from input

2020-05-13 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=91a4950926ef3bec493af8fad61e32b1184402c1 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 91a4950 by Jaap Keuter (jaap.keu...@xs4all.nl): DoxyGen: Remove build dir from input

[Wireshark-commits] master 17c9a2a: scylla: link requests with responses

2020-05-12 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=17c9a2a2a4b85d54fbfe133808079235f8b8ea4a Submitter: "Martin Mathieson " Changed: branch: master Repository: wireshark Commits: 17c9a2a by Piotr Sarna (sa...@scylladb.com): scylla: link requests with responses

[Wireshark-commits] master 82fb2d1: scylla: fill the list of packets that do not expect responses

2020-05-12 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=82fb2d1f29c7fdd32e3a0601d02235cd87d696d0 Submitter: "Martin Mathieson " Changed: branch: master Repository: wireshark Commits: 82fb2d1 by Piotr Sarna (sa...@scylladb.com): scylla: fill the list of packets that do not

[Wireshark-commits] master 24a2d77: DLEP: Additional data items

2020-05-11 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=24a2d77ac439470fcf11ba4ab5cee13c0cd21454 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 24a2d77 by Uli Heilmeier (u...@heilmeier.eu): DLEP: Additional data items Added

[Wireshark-commits] master fc1929e: scylla: add PAXOS_PRUNE verb

2020-05-11 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fc1929e9aec25287269546f1d863eda63b7ae373 Submitter: "Martin Mathieson " Changed: branch: master Repository: wireshark Commits: fc1929e by Piotr Sarna (sa...@scylladb.com): scylla: add PAXOS_PRUNE verb The

[Wireshark-commits] master-3.2 f6e8731: RTSP/SDP: Fix parsing error for H264:sprop-parameter-sets

2020-05-11 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f6e8731eb0aea079b765dd660286bc575a70a1c0 Submitter: "Anders Broman " Changed: branch: master-3.2 Repository: wireshark Commits: f6e8731 by Sergey Bogdanov (sergey.bogda...@astrosoft.ru): RTSP/SDP: Fix parsing error

[Wireshark-commits] master-2.6 bc87100: [Automatic update for 2020-05-10]

2020-05-10 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bc87100db8dbb140d9c979a074c5d554ac32d511 Submitter: "Gerald Combs " Changed: branch: master-2.6 Repository: wireshark Commits: bc87100 by Gerald Combs (ger...@wireshark.org): [Automatic update for 2020-05-10]

[Wireshark-commits] master-3.0 71307c3: [Automatic update for 2020-05-10]

2020-05-10 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=71307c3f854baccaf6ed86ed7fac144463950057 Submitter: "Gerald Combs " Changed: branch: master-3.0 Repository: wireshark Commits: 71307c3 by Gerald Combs (ger...@wireshark.org): [Automatic update for 2020-05-10]

[Wireshark-commits] master-3.2 303aa26: [Automatic update for 2020-05-10]

2020-05-10 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=303aa2601f43243c03aa5b2cc3b15cdd88a0b7ee Submitter: "Gerald Combs " Changed: branch: master-3.2 Repository: wireshark Commits: 303aa26 by Gerald Combs (ger...@wireshark.org): [Automatic update for 2020-05-10]

[Wireshark-commits] master a941457: [Automatic update for 2020-05-10]

2020-05-10 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a941457d91dcb8cbb37e3a0ad6b0c1410a171f7b Submitter: "Gerald Combs " Changed: branch: master Repository: wireshark Commits: a941457 by Gerald Combs (ger...@wireshark.org): [Automatic update for 2020-05-10]

[Wireshark-commits] master a32298b: GSM-SMS: add missing increment of offset.

2020-05-09 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a32298b7f6dd0e411b4774334f32ede775e402b4 Submitter: "Pascal Quantin " Changed: branch: master Repository: wireshark Commits: a32298b by Martin Mathieson (martin.r.mathie...@googlemail.com): GSM-SMS: add missing

[Wireshark-commits] master 366415b: ARP: expand the set of ARPHRD_ definitions from both IANA and Linxu.

2020-05-09 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=366415bcc352f18fabc9a7fc17a34139c526c617 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: 366415b by Guy Harris (g...@alum.mit.edu): ARP: expand the set of ARPHRD_ definitions from both

[Wireshark-commits] master 569f3bd: More PVS-Studio issues flagged by Valerii Zapodovnikov.

2020-05-09 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=569f3bd6111cfebe2fcd62484d854a053b5c9636 Submitter: "Martin Mathieson " Changed: branch: master Repository: wireshark Commits: 569f3bd by Martin Mathieson (martin.mathie...@keysight.com): More PVS-Studio issues

[Wireshark-commits] master d795711: sll: se the value_string table for ARP hardware types.

2020-05-09 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d795711a49184da6761fedbd91515cdc432d3ac7 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: d795711 by Guy Harris (g...@alum.mit.edu): sll: se the value_string table for ARP hardware

[Wireshark-commits] master 7e7db3e: sll: add support for LINKTYPE_LINUX_SLL2.

2020-05-08 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7e7db3e91ce50f1f3ba35f88aff83c66b5f9bf97 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: 7e7db3e by Guy Harris (g...@alum.mit.edu): sll: add support for LINKTYPE_LINUX_SLL2.

[Wireshark-commits] master 2480d9b: Add an encapsulation table entry for WTAP_ENCAP_MP4.

2020-05-08 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2480d9b69a9f416a6a3836def1479c66fec8d7b9 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: 2480d9b by Guy Harris (g...@alum.mit.edu): Add an encapsulation table entry for WTAP_ENCAP_MP4.

[Wireshark-commits] master-3.2 7ebd540: Qt: Respect user preference to hide packet list

2020-05-08 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7ebd5405f14f1e18e45624304ab2c4a3e7f94850 Submitter: "Stig Bjørlykke " Changed: branch: master-3.2 Repository: wireshark Commits: 7ebd540 by Tomasz Moń (deso...@gmail.com): Qt: Respect user preference to hide packet

[Wireshark-commits] master c0a4b8b: ENIP: Code Cleanup

2020-05-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c0a4b8b30f332c432504e424ec42bbd055ee9a27 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: c0a4b8b by Dylan Ulis (daul...@gmail.com): ENIP: Code Cleanup No real functional

[Wireshark-commits] master 63a8ac5: Qt: Respect user preference to hide packet list

2020-05-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=63a8ac5210f1935c684b74170278b177d2e01561 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 63a8ac5 by Tomasz Moń (deso...@gmail.com): Qt: Respect user preference to hide packet list

[Wireshark-commits] master fd7895d: Replace instances of wmem_alloc with wmem_new

2020-05-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fd7895d37c2410f81231efdfd8b0640c15887a70 Submitter: "Pascal Quantin " Changed: branch: master Repository: wireshark Commits: fd7895d by Moshe Kaplan (m...@moshekaplan.com): Replace instances of wmem_alloc with

[Wireshark-commits] master 87f320e: IEEE802.11: HS2.0 ANQP Friendly Name Subtree Fix

2020-05-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=87f320ec25a27f06e90f68a200ab7702a5b7c850 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 87f320e by Matthew Weant (mswe...@gmail.com): IEEE802.11: HS2.0 ANQP Friendly Name Subtree

[Wireshark-commits] master 9279be0: IEEE802.11: Fixed HS2.0 Cap List Dissection

2020-05-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9279be0394e8e05df08cf9c57a621de68cb2593f Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 9279be0 by Matthew Weant (mswe...@gmail.com): IEEE802.11: Fixed HS2.0 Cap List Dissection

[Wireshark-commits] master ef67994: TCP: Add expert info for SYN-ACK that accepts TFO data

2020-05-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ef67994c904c9270268d9901450ebd7a545497a2 Submitter: "Alexis La Goutte " Changed: branch: master Repository: wireshark Commits: ef67994 by Peter Wu (pe...@lekensteyn.nl): TCP: Add expert info for SYN-ACK that accepts

[Wireshark-commits] master 3a82774: CIP: Various Updates

2020-05-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3a82774b32a0ec71235bdf516d77add7785df47b Submitter: "Alexis La Goutte " Changed: branch: master Repository: wireshark Commits: 3a82774 by Dylan Ulis (daul...@gmail.com): CIP: Various Updates 1. Electronic Key

[Wireshark-commits] master ceb45a1: QUIC: append Stream ID to more frame types

2020-05-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ceb45a186c2e45af888ed730e9642f06b97e698a Submitter: "Alexis La Goutte " Changed: branch: master Repository: wireshark Commits: ceb45a1 by Peter Wu (pe...@lekensteyn.nl): QUIC: append Stream ID to more frame types

[Wireshark-commits] master 5d3eea1: ConversationDialog: fix a TCP graph race condition

2020-05-06 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5d3eea14a376d402594ae290ed9292fe57a680b5 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 5d3eea1 by Martin Kaiser (wiresh...@kaiser.cx): ConversationDialog: fix a TCP graph race

[Wireshark-commits] master b869452: packet-dof.c: Remove fprintf

2020-05-06 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b869452ba34f64f398e4a8974e2f0c3cb043e372 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: b869452 by Moshe Kaplan (m...@moshekaplan.com): packet-dof.c: Remove fprintf

[Wireshark-commits] master a5703f2: More changes arising from PVS-Studio output.

2020-05-06 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a5703f22cb723c46d5700cf3fffc8a9b40dd47d3 Submitter: "Martin Mathieson " Changed: branch: master Repository: wireshark Commits: a5703f2 by Martin Mathieson (martin.r.mathie...@googlemail.com): More changes arising from

[Wireshark-commits] master-3.2 5ce52f7: Qt: Stretch last packet list header section

2020-05-06 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5ce52f748553b9bf5d3ef1882af6ceb9cdb0f50a Submitter: "Anders Broman " Changed: branch: master-3.2 Repository: wireshark Commits: 5ce52f7 by Tomasz Moń (deso...@gmail.com): Qt: Stretch last packet list header section

[Wireshark-commits] master f399d13: IDL: Clean up IDL based dissector generation

2020-05-05 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f399d135e0d1bd00d3ff8dc3ee052fe31866e3a2 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: f399d13 by Jaap Keuter (jaap.keu...@xs4all.nl): IDL: Clean up IDL based dissector generation

[Wireshark-commits] master 1d0b233: Qt: Stretch last packet list header section

2020-05-05 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1d0b233f12e937f6278fc38775fca530e2be2661 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 1d0b233 by Tomasz Moń (deso...@gmail.com): Qt: Stretch last packet list header section

[Wireshark-commits] master 5e4379f: IDL: make code generation reproducible

2020-05-05 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5e4379f5b5fbf40151d58e6aab28b072e39fde17 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 5e4379f by Jaap Keuter (jaap.keu...@xs4all.nl): IDL: make code generation reproducible

[Wireshark-commits] master ddc5a49: EAP: AT_NOTIFICATION Dissection

2020-05-05 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ddc5a49ca471b2740917337ae2ef749868e097ac Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: ddc5a49 by Matthew Weant (mswe...@gmail.com): EAP: AT_NOTIFICATION Dissection Added

[Wireshark-commits] master 5dabd51: Windows: upgrade Npcap to 0.9991

2020-05-05 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5dabd51742ac5064cab00e56d075c114c7f9157c Submitter: "Pascal Quantin " Changed: branch: master Repository: wireshark Commits: 5dabd51 by Pascal Quantin (pas...@wireshark.org): Windows: upgrade Npcap to 0.9991

[Wireshark-commits] master 1408dd3: Last batch of changes from PVS-Studio scan.

2020-05-05 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1408dd3b5022cf5b4f7545440cd5839c784a4764 Submitter: "Martin Mathieson " Changed: branch: master Repository: wireshark Commits: 1408dd3 by Martin Mathieson (martin.mathie...@keysight.com): Last batch of changes from

[Wireshark-commits] master-3.2 64f9812: SOMEIP: Bugfix for SOME/IP-SD Collision of Unique ID

2020-05-05 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=64f981271c4187e2ee06852cf78231a9a3353b33 Submitter: "Gerald Combs " Changed: branch: master-3.2 Repository: wireshark Commits: 64f9812 by Dr. Lars Völker (lars.voel...@technica-engineering.de): SOMEIP: Bugfix for

[Wireshark-commits] master-3.2 62bd075: SOMEIP: removing warnings due to guint64 (%lx vs %llx)

2020-05-05 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=62bd0752f8ee26433bcb067be1d72f82fb05eacf Submitter: "Gerald Combs " Changed: branch: master-3.2 Repository: wireshark Commits: 62bd075 by Dr. Lars Völker (lars.voel...@technica-engineering.de): SOMEIP: removing

[Wireshark-commits] master f263df0: SOMEIP: removing warnings due to guint64 (%lx vs %llx)

2020-05-05 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f263df0a4542c47d90798bd30fe2c4cd9d252820 Submitter: "Gerald Combs " Changed: branch: master Repository: wireshark Commits: f263df0 by Dr. Lars Völker (lars.voel...@technica-engineering.de): SOMEIP: removing warnings

[Wireshark-commits] master dba3081: EAP: Unknown Data at end of EAP Identities

2020-05-05 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dba3081f4d6d4288b37df4437d6af0b55bb98e2f Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: dba3081 by Matthew Weant (mswe...@gmail.com): EAP: Unknown Data at end of EAP Identities

[Wireshark-commits] master 6ada430: SOMEIP: Bugfix for SOME/IP-SD Collision of Unique ID

2020-05-05 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6ada4302b545d28a2bf2b8711382051f50363b6d Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 6ada430 by Dr. Lars Völker (lars.voel...@technica-engineering.de): SOMEIP: Bugfix for

[Wireshark-commits] master-2.6 50ceaef: Infiniband: skip past the undissected vendor header.

2020-05-04 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=50ceaefd5628f275860e8c2bbc5d0bfd62b341a0 Submitter: "Guy Harris " Changed: branch: master-2.6 Repository: wireshark Commits: 50ceaef by Guy Harris (g...@alum.mit.edu): Infiniband: skip past the undissected vendor

[Wireshark-commits] master-3.0 51260d3: Infiniband: skip past the undissected vendor header.

2020-05-04 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=51260d32dc1011f2cd7693eca4a3f5b6a3604e25 Submitter: "Guy Harris " Changed: branch: master-3.0 Repository: wireshark Commits: 51260d3 by Guy Harris (g...@alum.mit.edu): Infiniband: skip past the undissected vendor

[Wireshark-commits] master-3.2 9ccd6b0: Infiniband: skip past the undissected vendor header.

2020-05-04 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9ccd6b0520d311c3ec627d81dfd3843c2bfe0e97 Submitter: "Guy Harris " Changed: branch: master-3.2 Repository: wireshark Commits: 9ccd6b0 by Guy Harris (g...@alum.mit.edu): Infiniband: skip past the undissected vendor

[Wireshark-commits] master c521570: Infiniband: skip past the undissected vendor header.

2020-05-04 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c5215707d47082c1de2459dc9d1e4be7ad2d974e Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: c521570 by Guy Harris (g...@alum.mit.edu): Infiniband: skip past the undissected vendor header.

[Wireshark-commits] master-2.6 bec65cb: pcapng (dissector): don't assume the endianness doesn't change.

2020-05-04 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bec65cb3c34684b010c35839924cd0471d4d4c11 Submitter: "Guy Harris " Changed: branch: master-2.6 Repository: wireshark Commits: bec65cb by Guy Harris (g...@alum.mit.edu): pcapng (dissector): don't assume the endianness

[Wireshark-commits] master-3.0 c38d416: pcapng (dissector): don't assume the endianness doesn't change.

2020-05-04 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c38d416101ff25845a9354cb9c490ed11f1b14e1 Submitter: "Guy Harris " Changed: branch: master-3.0 Repository: wireshark Commits: c38d416 by Guy Harris (g...@alum.mit.edu): pcapng (dissector): don't assume the endianness

[Wireshark-commits] master-3.2 8d2600d: pcapng (dissector): don't assume the endianness doesn't change.

2020-05-04 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8d2600d8c526e84055ef201e90c3f50d5ea24d25 Submitter: "Guy Harris " Changed: branch: master-3.2 Repository: wireshark Commits: 8d2600d by Guy Harris (g...@alum.mit.edu): pcapng (dissector): don't assume the endianness

[Wireshark-commits] master b99a0c9: pcapng (dissector): don't assume the endianness doesn't change.

2020-05-04 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b99a0c95d8c3fec834da0b7be27b2fc385054646 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: b99a0c9 by Guy Harris (g...@alum.mit.edu): pcapng (dissector): don't assume the endianness

[Wireshark-commits] master-2.6 36805f2: Fix calculation of fractional part of time stamps.

2020-05-04 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=36805f25f868387936c99529effd078bf0b615a6 Submitter: "Guy Harris " Changed: branch: master-2.6 Repository: wireshark Commits: 36805f2 by Guy Harris (g...@alum.mit.edu): Fix calculation of fractional part of time

[Wireshark-commits] master-3.2 26da8c7: Fix calculation of fractional part of time stamps.

2020-05-04 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=26da8c7c0b1adbe5105560bedc0296be25942f67 Submitter: "Guy Harris " Changed: branch: master-3.2 Repository: wireshark Commits: 26da8c7 by Guy Harris (g...@alum.mit.edu): Fix calculation of fractional part of time

[Wireshark-commits] master-3.0 1c1f9b3: Fix calculation of fractional part of time stamps.

2020-05-04 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1c1f9b3caeb06a03a042b07bb179b82f1f133627 Submitter: "Guy Harris " Changed: branch: master-3.0 Repository: wireshark Commits: 1c1f9b3 by Guy Harris (g...@alum.mit.edu): Fix calculation of fractional part of time

[Wireshark-commits] master 432cb20: Fix calculation of fractional part of time stamps.

2020-05-04 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=432cb2070718cd5d3aa2e485a91d8a8d32485e10 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: 432cb20 by Guy Harris (g...@alum.mit.edu): Fix calculation of fractional part of time stamps.

[Wireshark-commits] master-3.2 cae1c56: NAS 5GS: fix highlighting of the QOs flow description elements

2020-05-04 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cae1c562d7e1f38e6d5d0f5400c45f5647a77437 Submitter: "Pascal Quantin " Changed: branch: master-3.2 Repository: wireshark Commits: cae1c56 by Pascal Quantin (pas...@wireshark.org): NAS 5GS: fix highlighting of the QOs

[Wireshark-commits] master 274ec6a: NAS 5GS: fix highlighting of the QOs flow description elements

2020-05-04 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=274ec6adc4983008fc0b500aa28594d99649e474 Submitter: "Pascal Quantin " Changed: branch: master Repository: wireshark Commits: 274ec6a by Pascal Quantin (pas...@wireshark.org): NAS 5GS: fix highlighting of the QOs flow

[Wireshark-commits] master-3.0 28281a7: pcapng: fix build in older releases.

2020-05-04 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=28281a7bd9f05b300ef0da2712da0efd3948aaf3 Submitter: "Guy Harris " Changed: branch: master-3.0 Repository: wireshark Commits: 28281a7 by Guy Harris (g...@alum.mit.edu): pcapng: fix build in older releases. The

[Wireshark-commits] master-2.6 8b88051: pcapng: fix build in older releases.

2020-05-04 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8b88051e69a7c230c46ac57bdf67081fda6c8b0b Submitter: "Guy Harris " Changed: branch: master-2.6 Repository: wireshark Commits: 8b88051 by Guy Harris (g...@alum.mit.edu): pcapng: fix build in older releases. The

[Wireshark-commits] master-3.0 2febe85: MIME/pcapng: use snap length to get SPB data length

2020-05-04 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2febe85b33730ac3974d2592b9360492a1fe1f53 Submitter: "Guy Harris " Changed: branch: master-3.0 Repository: wireshark Commits: 2febe85 by David Perry (boolean...@protonmail.com): MIME/pcapng: use snap length to get SPB

[Wireshark-commits] master-2.6 ebce737: MIME/pcapng: use snap length to get SPB data length

2020-05-04 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ebce737a513ede3ddf8cb6ac33fcca2230761734 Submitter: "Guy Harris " Changed: branch: master-2.6 Repository: wireshark Commits: ebce737 by David Perry (boolean...@protonmail.com): MIME/pcapng: use snap length to get SPB

[Wireshark-commits] master-3.2 95c6c44: MIME/pcapng: use snap length to get SPB data length

2020-05-04 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=95c6c4431799867ec10ea5e34500a1e0858cf8ba Submitter: "Guy Harris " Changed: branch: master-3.2 Repository: wireshark Commits: 95c6c44 by David Perry (boolean...@protonmail.com): MIME/pcapng: use snap length to get SPB

[Wireshark-commits] master-2.6 49f13e6: MIME/pcapng: reset interface array on new SHB

2020-05-04 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=49f13e6044ca9b26f5014c52be6e067da40351ef Submitter: "Guy Harris " Changed: branch: master-2.6 Repository: wireshark Commits: 49f13e6 by David Perry (boolean...@protonmail.com): MIME/pcapng: reset interface array on

[Wireshark-commits] master-3.0 8fa068d: MIME/pcapng: reset interface array on new SHB

2020-05-04 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8fa068d7fb4ad05f25c295560666fe2bae9273a4 Submitter: "Guy Harris " Changed: branch: master-3.0 Repository: wireshark Commits: 8fa068d by David Perry (boolean...@protonmail.com): MIME/pcapng: reset interface array on

[Wireshark-commits] master-3.2 d309f25: MIME/pcapng: reset interface array on new SHB

2020-05-04 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d309f25dd4d409ea7441a10887c851b58383c1f3 Submitter: "Guy Harris " Changed: branch: master-3.2 Repository: wireshark Commits: d309f25 by David Perry (boolean...@protonmail.com): MIME/pcapng: reset interface array on

[Wireshark-commits] master-2.6 58e8049: pcapng: pull the interface ID handling into a single routine.

2020-05-04 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=58e8049a732d11134fb062a55fa02721597362d3 Submitter: "Guy Harris " Changed: branch: master-2.6 Repository: wireshark Commits: 58e8049 by Guy Harris (g...@alum.mit.edu): pcapng: pull the interface ID handling into a

[Wireshark-commits] master-2.6 f806b00: Add additional checks, clean up some stuff.

2020-05-04 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f806b006fcf226e3e3d77d7b2de64844c9a89397 Submitter: "Guy Harris " Changed: branch: master-2.6 Repository: wireshark Commits: f806b00 by Guy Harris (g...@alum.mit.edu): Add additional checks, clean up some stuff.

[Wireshark-commits] master-3.0 e898ee7: Add additional checks, clean up some stuff.

2020-05-04 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e898ee70ce4f8721fce0afb1bf9ab8d25f642b54 Submitter: "Guy Harris " Changed: branch: master-3.0 Repository: wireshark Commits: e898ee7 by Guy Harris (g...@alum.mit.edu): Add additional checks, clean up some stuff.

[Wireshark-commits] master-3.2 012ec01: Add additional checks, clean up some stuff.

2020-05-04 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=012ec01729f844319e92f8710791495e3366e38c Submitter: "Guy Harris " Changed: branch: master-3.2 Repository: wireshark Commits: 012ec01 by Guy Harris (g...@alum.mit.edu): Add additional checks, clean up some stuff.

[Wireshark-commits] master-3.0 250fc9f: Remove space that snuck in during editing.

2020-05-04 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=250fc9f14b0fe05f33faf365f6ed4fa73ae70ded Submitter: "Guy Harris " Changed: branch: master-3.0 Repository: wireshark Commits: 250fc9f by Guy Harris (g...@alum.mit.edu): Remove space that snuck in during editing.

[Wireshark-commits] master-3.2 4a68e5c: Remove space that snuck in during editing.

2020-05-04 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4a68e5cabdfefd09b7c545950aa48de95265c4e8 Submitter: "Guy Harris " Changed: branch: master-3.2 Repository: wireshark Commits: 4a68e5c by Guy Harris (g...@alum.mit.edu): Remove space that snuck in during editing.

[Wireshark-commits] master-2.6 d7f219c: Remove space that snuck in during editing.

2020-05-04 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d7f219cd0f32c26572326cb750a5544e8cd25f06 Submitter: "Guy Harris " Changed: branch: master-2.6 Repository: wireshark Commits: d7f219c by Guy Harris (g...@alum.mit.edu): Remove space that snuck in during editing.

[Wireshark-commits] master-3.2 435e4dd: Add support for IDB option 15 - if_hardware, for hardware description.

2020-05-04 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=435e4dd56bcb6369b998d52dbf8f87a4ccf4f1d1 Submitter: "Guy Harris " Changed: branch: master-3.2 Repository: wireshark Commits: 435e4dd by Guy Harris (g...@alum.mit.edu): Add support for IDB option 15 - if_hardware, for

[Wireshark-commits] master-2.6 5280739: Add support for IDB option 15 - if_hardware, for hardware description.

2020-05-04 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5280739e63bdd4bc2d3eb595bce06b59367debd5 Submitter: "Guy Harris " Changed: branch: master-2.6 Repository: wireshark Commits: 5280739 by Guy Harris (g...@alum.mit.edu): Add support for IDB option 15 - if_hardware, for

[Wireshark-commits] master-3.0 9cc2661: Add support for IDB option 15 - if_hardware, for hardware description.

2020-05-04 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9cc26618b350ad08aa275ce787dfee040039cb3d Submitter: "Guy Harris " Changed: branch: master-3.0 Repository: wireshark Commits: 9cc2661 by Guy Harris (g...@alum.mit.edu): Add support for IDB option 15 - if_hardware, for

[Wireshark-commits] master-3.0 746a249: pcapng: pull the interface ID handling into a single routine.

2020-05-04 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=746a249380bb24c5d7eab04a28b25241a10bf473 Submitter: "Guy Harris " Changed: branch: master-3.0 Repository: wireshark Commits: 746a249 by Guy Harris (g...@alum.mit.edu): pcapng: pull the interface ID handling into a

<    5   6   7   8   9   10   11   12   13   14   >