[Wireshark-commits] master 7dd7a05: [NAS-5GS] Dissect more IEs

2018-03-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7dd7a05d480226736696aed4a6530b0e84526aea Submitter: Anders Broman (a.broma...@gmail.com) Changed: branch: master Repository: wireshark Commits: 7dd7a05 by AndersBroman (anders.bro...@ericsson.com): [NAS-5GS] Dissect

[Wireshark-commits] master e1790da: Hack to fix ABI checking.

2018-03-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e1790da88cb02dcc0764e58cc8b67afe9d8543a1 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: e1790da by Guy Harris (g...@alum.mit.edu): Hack to fix ABI checking.

[Wireshark-commits] master 1592587: LWAPP: define a recursion depth limit

2018-03-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1592587e6f9fd8c8aa8fc7f67989690d0c6882c4 Submitter: Anders Broman (a.broma...@gmail.com) Changed: branch: master Repository: wireshark Commits: 1592587 by Pascal Quantin (pascal.quan...@gmail.com): LWAPP: define a

[Wireshark-commits] master 3132a50: Autotools: Build rawshark.

2018-03-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3132a504489944b41522125f8e7aaba8ae50a66f Submitter: Gerald Combs (ger...@wireshark.org) Changed: branch: master Repository: wireshark Commits: 3132a50 by Gerald Combs (ger...@wireshark.org): Autotools: Build rawshark.

[Wireshark-commits] master a3e1967: Debian: Fixup some symbols.

2018-03-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a3e1967d8e6e3825c341cd39c48f31a5bc8cbe24 Submitter: Gerald Combs (ger...@wireshark.org) Changed: branch: master Repository: wireshark Commits: a3e1967 by Gerald Combs (ger...@wireshark.org): Debian: Fixup some

[Wireshark-commits] master fbb0423: IEEE 802.15.4: support vendor specific commands; small cleanups

2018-03-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fbb042336af42635eedabd7f1bb2eb5c6bd35d5f Submitter: Anders Broman (a.broma...@gmail.com) Changed: branch: master Repository: wireshark Commits: fbb0423 by Robert Sauter (sau...@locoslab.com): IEEE 802.15.4: support

[Wireshark-commits] master 39a6599: CMake: Exclude test targets from the default build.

2018-03-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=39a65995ccaa45322b7ee870fe21a0daa6157242 Submitter: Gerald Combs (ger...@wireshark.org) Changed: branch: master Repository: wireshark Commits: 39a6599 by Gerald Combs (ger...@wireshark.org): CMake: Exclude test

[Wireshark-commits] master-2.4 13270b1: LWAPP: define a recursion depth limit

2018-03-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=13270b1bc0a29f9c31358ae1461c8eb9253cc08e Submitter: Pascal Quantin (pascal.quan...@gmail.com) Changed: branch: master-2.4 Repository: wireshark Commits: 13270b1 by Pascal Quantin (pascal.quan...@gmail.com): LWAPP:

[Wireshark-commits] master cc45082: Gryphon Protocol dissector fixes and updates.

2018-03-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cc45082635c9cfed0112727b1b10a0f863bce13c Submitter: Anders Broman (a.broma...@gmail.com) Changed: branch: master Repository: wireshark Commits: cc45082 by ciechanowski (markciechanow...@gmail.com): Gryphon Protocol

[Wireshark-commits] master eefa76a: address_types: fix returned length of eui64_addr_to_str

2018-03-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=eefa76a7c810bd74d95d571362f0ad5fda691e70 Submitter: Roland Knall (rkn...@gmail.com) Changed: branch: master Repository: wireshark Commits: eefa76a by Robert Sauter (sau...@locoslab.com): address_types: fix returned

[Wireshark-commits] master-2.2 dac48f1: LWAPP: define a recursion depth limit

2018-03-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dac48f148538c706c446e5105d84ebcb54587528 Submitter: Anders Broman (a.broma...@gmail.com) Changed: branch: master-2.2 Repository: wireshark Commits: dac48f1 by Pascal Quantin (pascal.quan...@gmail.com): LWAPP: define a

[Wireshark-commits] master e7cf995: Squelch some casting-away-const warnings.

2018-03-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e7cf995b1e0a9b434782adf0e2ee40bfb721aac2 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: e7cf995 by Guy Harris (g...@alum.mit.edu): Squelch some casting-away-const

[Wireshark-commits] master 8a67735: The routines that implement a codec don't need to be public.

2018-03-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8a677354bd14eb1cff01c01bc9a303c502074d56 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: 8a67735 by Guy Harris (g...@alum.mit.edu): The routines that implement a codec

[Wireshark-commits] master e5cc633: Constify an argument that doesn't need to be non-const.

2018-03-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e5cc633ee49823ac56350fd57fea3e54717d85f7 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: e5cc633 by Guy Harris (g...@alum.mit.edu): Constify an argument that doesn't

[Wireshark-commits] master 695fbb9: Squelch some casting-away-constness warnings.

2018-03-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=695fbb9be0122e280755c11b9e0b89e9e256875b Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: 695fbb9 by Guy Harris (g...@alum.mit.edu): Squelch some casting-away-constness

[Wireshark-commits] master 241b274: Don't cast away constness.

2018-03-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=241b274b5f8e6f7e3ea22f7598a271f48ccd3191 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: 241b274 by Guy Harris (g...@alum.mit.edu): Don't cast away constness.

[Wireshark-commits] master 957845f: CMake: Don't bother compiling zlibstatic.

2018-03-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=957845f5a4ed8919164dfd469890732b65b40831 Submitter: Gerald Combs (ger...@wireshark.org) Changed: branch: master Repository: wireshark Commits: 957845f by Gerald Combs (ger...@wireshark.org): CMake: Don't bother

[Wireshark-commits] master 692cef8: dissectors: more SPDX license convertions.

2018-03-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=692cef88c7f68af53e9487e3e2264de8d98b230b Submitter: Jaap Keuter (jaap.keu...@xs4all.nl) Changed: branch: master Repository: wireshark Commits: 692cef8 by Dario Lombardo (lom...@gmail.com): dissectors: more SPDX

[Wireshark-commits] master-2.4 c69d710: SMB2: use file scope to avoid leaking memory

2018-03-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c69d710d2bf39fe633800db65efddf55701131b6 Submitter: Anders Broman (a.broma...@gmail.com) Changed: branch: master-2.4 Repository: wireshark Commits: c69d710 by Pascal Quantin (pascal.quan...@gmail.com): SMB2: use file

[Wireshark-commits] master f789736: Qt: Handle UAT editor dialogs explicitly.

2018-03-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f7897365213111fa86fa940ddea6c3e191b0b429 Submitter: Roland Knall (rkn...@gmail.com) Changed: branch: master Repository: wireshark Commits: f789736 by Michael Mann (mman...@netscape.net): Qt: Handle UAT editor dialogs

[Wireshark-commits] master 830adb2: Qt: rework routine in module_preferences_scroll_area.

2018-03-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=830adb2a02c3ef5209bf79c933879b49b12b7902 Submitter: Dario Lombardo (lom...@gmail.com) Changed: branch: master Repository: wireshark Commits: 830adb2 by Dario Lombardo (lom...@gmail.com): Qt: rework routine in

[Wireshark-commits] master-2.4 2e58b82: print: free memory if not used (found by clang).

2018-03-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2e58b825cd1aea05728ee454fa78a74ca3bf0df7 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master-2.4 Repository: wireshark Commits: 2e58b82 by Dario Lombardo (lom...@gmail.com): print: free memory if not

[Wireshark-commits] master-2.2 5b02289: multipart: use packet scope memory to avoid leaking in case an exception is triggered by subdissectors

2018-03-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5b0228945dc74ee82d2ab4a4e7af2bdfe7b75910 Submitter: Pascal Quantin (pascal.quan...@gmail.com) Changed: branch: master-2.2 Repository: wireshark Commits: 5b02289 by Pascal Quantin (pascal.quan...@gmail.com): multipart:

[Wireshark-commits] master 6db59af: print: free memory if not used (found by clang).

2018-03-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6db59affd9c9b20f2ce725cd2ce7a88c71982a07 Submitter: Anders Broman (a.broma...@gmail.com) Changed: branch: master Repository: wireshark Commits: 6db59af by Dario Lombardo (lom...@gmail.com): print: free memory if not

[Wireshark-commits] master 3772396: WIP:ieee80211: HotSpot 2.0 fixes.

2018-03-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=37723968d2b37c52f5809398b85adffdc815ce9d Submitter: ronnie sahlberg (ronniesahlb...@gmail.com) Changed: branch: master Repository: wireshark Commits: 3772396 by Richard Sharpe (realrichardsha...@gmail.com):

[Wireshark-commits] master 3a54fd1: bluetooth: Update Assigned Numbers

2018-03-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3a54fd1d7d5d0ee1635e7100635ad3cad0ffbcd1 Submitter: Stig Bjørlykke (s...@bjorlykke.org) Changed: branch: master Repository: wireshark Commits: 3a54fd1 by Stig Bjørlykke (s...@bjorlykke.org): bluetooth: Update Assigned

[Wireshark-commits] master-2.4 03e55eb: bluetooth: Update Assigned Numbers

2018-03-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=03e55eb8459d3885952275c696c4e7463fe714f4 Submitter: Stig Bjørlykke (s...@bjorlykke.org) Changed: branch: master-2.4 Repository: wireshark Commits: 03e55eb by Stig Bjørlykke (s...@bjorlykke.org): bluetooth: Update

[Wireshark-commits] master-2.4 0e7ac7d: Fix another leak, which happens with -E occurrence=l.

2018-03-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0e7ac7d051ac40bec44f41ea9b94d91593dfcb39 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master-2.4 Repository: wireshark Commits: 0e7ac7d by Guy Harris (g...@alum.mit.edu): Fix another leak, which happens

[Wireshark-commits] master 9a5217b: Fix another leak, which happens with -E occurrence=l.

2018-03-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9a5217bdd4680e36f2e92838348bd4ea010d28a0 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: 9a5217b by Guy Harris (g...@alum.mit.edu): Fix another leak, which happens with

[Wireshark-commits] master-2.2 976be71: Fix another leak, which happens with -E occurrence=l.

2018-03-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=976be718e3ca27fd14c7139732501a67eefedab8 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master-2.2 Repository: wireshark Commits: 976be71 by Guy Harris (g...@alum.mit.edu): Fix another leak, which happens

[Wireshark-commits] master 8a5385b: More licenses converted to SPDX.

2018-03-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8a5385b9c9ec4ccfd692263eb7c59b09f9bc1a15 Submitter: Anders Broman (a.broma...@gmail.com) Changed: branch: master Repository: wireshark Commits: 8a5385b by Dario Lombardo (lom...@gmail.com): More licenses converted to

[Wireshark-commits] master 71f3637: licensecheck: add BSD licenses.

2018-03-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=71f36379aef2ff9fcf092619011f02f68ce9d3b2 Submitter: Anders Broman (a.broma...@gmail.com) Changed: branch: master Repository: wireshark Commits: 71f3637 by Dario Lombardo (lom...@gmail.com): licensecheck: add BSD

[Wireshark-commits] master 8a5cd7a: ieee802154: fix 'wpan.tsch.timeslot' exists multiple times with NOT compatible types: FT_UINT16 and FT_NONE

2018-03-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8a5cd7a5c67cdca5eed91ec6a36ba310772e795f Submitter: Anders Broman (a.broma...@gmail.com) Changed: branch: master Repository: wireshark Commits: 8a5cd7a by Alexis La Goutte (alexis.lagou...@gmail.com): ieee802154: fix

[Wireshark-commits] master 99a3298: nas_5gs: fix duplicate entry

2018-03-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=99a329891dca9e1e033313aad2a8445e2d5206af Submitter: Anders Broman (a.broma...@gmail.com) Changed: branch: master Repository: wireshark Commits: 99a3298 by Alexis La Goutte (alexis.lagou...@gmail.com): nas_5gs: fix

[Wireshark-commits] master-2.2 c2e5d02: print: free memory if not used (found by clang).

2018-03-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c2e5d02cab0512731a528a20ca0f09393a22ce6f Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master-2.2 Repository: wireshark Commits: c2e5d02 by Dario Lombardo (lom...@gmail.com): print: free memory if not

[Wireshark-commits] master-2.2 e19aba3: GIOP: use wmem packet scope for get_modname_from_repoid()

2018-03-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e19aba33026212cbe000ece633adf14d109489fa Submitter: Pascal Quantin (pascal.quan...@gmail.com) Changed: branch: master-2.2 Repository: wireshark Commits: e19aba3 by Pascal Quantin (pascal.quan...@gmail.com): GIOP: use

[Wireshark-commits] master 4f36a28: Qt: remove leak from protocol_preferences_menu (found by clang).

2018-03-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4f36a28acbc06781740cf4105375ae7759b6606b Submitter: Roland Knall (rkn...@gmail.com) Changed: branch: master Repository: wireshark Commits: 4f36a28 by Dario Lombardo (lom...@gmail.com): Qt: remove leak from

[Wireshark-commits] master 5375283: Qt: remove leak in simple_statistics_dialog (found by clang).

2018-03-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5375283f9294d444fcda14df74fed77160bf1d1d Submitter: Anders Broman (a.broma...@gmail.com) Changed: branch: master Repository: wireshark Commits: 5375283 by Dario Lombardo (lom...@gmail.com): Qt: remove leak in

[Wireshark-commits] master fe71e26: spdx: more licenses converted.

2018-03-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fe71e26af27a01173f3029a7d848b9ba65a0defb Submitter: Anders Broman (a.broma...@gmail.com) Changed: branch: master Repository: wireshark Commits: fe71e26 by Dario Lombardo (lom...@gmail.com): spdx: more licenses