URL:
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=553e119672a27b068ec14073dbc1456df06d0ec3
Submitter: Peter Wu (pe...@lekensteyn.nl)
Changed: branch: master
Repository: wireshark
Commits:
553e119 by Mirko Parthey (mirko.part...@web.de):
ISAKMP: Reduce code duplication
Equalize attribute dissecting functions:
* Convert all attribute type names to range_string.
Add "Unassigned" and "Private use" ranges while we are at it.
* Swap the order of format and type fields for config attributes.
Move common code into the new function dissect_attribute_header().
Try to keep the parameter list short:
* Group the hfindex values for attribute details into a struct.
* Merge attribute subtree types.
Add a colon in the main attribute item label for visual separation.
Skip dissection of config attributes for unknown IKE versions.
Change-Id: I6e6286f3d4cf16f3cd16a23aca540c4af72f3442
Reviewed-on: https://code.wireshark.org/review/17663
Petri-Dish: Peter Wu <pe...@lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-re...@wireshark.org>
Reviewed-by: Peter Wu <pe...@lekensteyn.nl>
Actions performed:
from ca2a969 Qt: allow file dialogs to mark an UAT as dirty
adds 553e119 ISAKMP: Reduce code duplication
Summary of changes:
epan/dissectors/packet-isakmp.c | 469 ++++++++++++++++++---------------------
1 file changed, 221 insertions(+), 248 deletions(-)
___________________________________________________________________________
Sent via: Wireshark-commits mailing list <wireshark-commits@wireshark.org>
Archives: https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
