Re: [Wireshark-dev] [Wireshark-commits] rev 21705: /trunk/ /trunk/plugins/asn1/: asn1.h packet-asn1.c /trunk/epan/dissectors/: packet-MAP_DialoguePDU.c packet-acp133.c packet-acse.c packet-ansi_map.c

2007-05-07 Thread Kukosa, Tomas
Hello Anders, I had not checked X.690 (BER) specification before I defined PER external structures in asn1_ctx_t. I expected BER uses encoding based on X.680 definition. I think we could merge most of PER and BER items in external structure. I will move PER items one layer upper and you can

Re: [Wireshark-dev] [Wireshark-commits] rev 21705: /trunk//trunk/plugins/asn1/: asn1.h packet-asn1.c/trunk/epan/dissectors/: packet-MAP_DialoguePDU.cpacket-acp133.c packet-acse.c packet-ansi_map.c pac

2007-05-07 Thread Anders Broman \(AL/EAB\)
Hi, I thought as much but there is still a lot of work to get the actx into all the BER dissecors. I'm taking it a step At the time. Regards Anders -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Kukosa, Tomas Sent: den 7 maj 2007 07:58 To:

Re: [Wireshark-dev] [Wireshark-commits] rev 21705:/trunk//trunk/plugins/asn1/: asn1.hpacket-asn1.c/trunk/epan/dissectors/:packet-MAP_DialoguePDU.cpacket-acp133.c packet-acse.cpacket-ansi_map.c packet-

2007-05-07 Thread Kukosa, Tomas
Hi, BTW when you are making such large changes do not you think about changing of packet-ber from field oriented to type oriented? I.e. replacing field_function() { type_function(hf_field); } sequence_structure[] = { {..., field_function}, } with code sequence_structure[] = {

Re: [Wireshark-dev] [Wireshark-commits] rev21705:/trunk//trunk/plugins/asn1/:asn1.hpacket-asn1.c/trunk/epan/dissectors/:packet-MAP_DialoguePDU.cpacket-acp133.cpacket-acse.cpacket-ansi_map.c packet-ber

2007-05-07 Thread Anders Broman \(AL/EAB\)
Hi, Could you do the asn2wrs changes and send me the file then I could do some experiments and see how much work is involved? At least you have taken care of T38 then there is Kerberos and some gsm stuff so it might not be to difficult. Regards Anders Från:

Re: [Wireshark-dev] [Wireshark-commits] rev21705:/trunk//trunk/plugins/asn1/:asn1.hpacket-asn1.c/trunk/epan/dissectors/:packet-MAP_DialoguePDU.cpacket-acp133.cpacket-acse.cpacket-ansi_map.c packet-ber

2007-05-07 Thread ronnie sahlberg
Is it really worth it to asn2wsr'ify the kerberos dissector? First, the dissector currently handles two different versions of kerberos, both the standard 1510 ASN but also the slightly different ASN used by packetcable. Second, the dissector as it is today is almost complete and dissects

Re: [Wireshark-dev] [Wireshark-commits]rev21705:/trunk//trunk/plugins/asn1/:asn1.hpacket-asn1.c/trunk/epan/dissectors/:packet-MAP_DialoguePDU.cpacket-acp133.cpacket-acse.cpacket-ansi_map.cpacket-ber.c

2007-05-07 Thread Anders Broman \(AL/EAB\)
Hi, You are probably right. As with other stuff where hand made BER/PER code is used I have made dummy files to let asn2wrs create the code to cut-and-paste to where needed Should we check that type of code in some where and if so where? /asn1/helpers/ /ros

Re: [Wireshark-dev] OpcUa update

2007-05-07 Thread Gerhard Gappmeier
Hi, A fuzzed Sample.cap file (attached) crashed TShark and took a *very* long time (2 mins) to load in WS. it loads the file imediately on my computer without any delay. I tried the fuzzy file also with tshark. I called tshark -r sample.cap, is this right? Because it didn't crash for me. I

Re: [Wireshark-dev] [Wireshark-commits]rev21705:/trunk//trunk/plugins/asn1/:asn1.hpacket-asn1.c/trunk/epan/dissectors/:packet-MAP_DialoguePDU.cpacket-acp133.cpacket-acse.cpacket-ansi_map.cpacket-ber.c

2007-05-07 Thread Anders Broman \(AL/EAB\)
Hi, Thanks, I'll check if I have any traces and send them privatly. Regards Anders From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Kukosa, Tomas Sent: den 7 maj 2007 13:19 To: Developer support list for Wireshark Subject: Re: [Wireshark-dev]

Re: [Wireshark-dev] OpcUa update

2007-05-07 Thread Gerald Combs
Gerhard Gappmeier wrote: Hi, A fuzzed Sample.cap file (attached) crashed TShark and took a *very* long time (2 mins) to load in WS. it loads the file imediately on my computer without any delay. I tried the fuzzy file also with tshark. I called tshark -r sample.cap, is this right?

Re: [Wireshark-dev] OpcUa update

2007-05-07 Thread Ulf Lamping
Gerhard Gappmeier wrote: it loads the file imediately on my computer without any delay. I tried the fuzzy file also with tshark. I called tshark -r sample.cap, is this right? Because it didn't crash for me. I tried it several times. Any ideas why it behaves different for you? I'm currently