[Wireshark-dev] Bugfix for plugins/profinet

2007-07-23 Thread HPfrommer
Hi, I've fixed a bug in the Profinet-Dissector (plugins/profinet/packet-dcerpc-pn-io.c). In PROFINET IO DCE RPC write-requests, only the first IR frame dataset in PDIRFrameData was dissected. I've fixed the problem, now all IR frame datasets are dissected into individual sub-trees. svn

[Wireshark-dev] What is the process to submit patches for my new DLT support code?

2007-07-23 Thread Fulko Hew
a)What is the proper procedure to get my code/support for my new DLT type incorporated into the official release of PCAP? b) See Note 1 for a second question. The changes amount to: 1/ gencode.c: Add a 'case DLT_SITA'. 2/ pcap-bpf.h: Add '#define DLT_SITA 196'. 3/ pcap.c: Add

Re: [Wireshark-dev] What is the process to submit patches for my new DLT support code?

2007-07-23 Thread Guy Harris
Fulko Hew wrote: a)What is the proper procedure to get my code/support for my new DLT type incorporated into the official release of PCAP? Send a patch to [EMAIL PROTECTED] b) See Note 1 for a second question. The changes amount to: 1/ gencode.c: Add a 'case DLT_SITA'. 2/

Re: [Wireshark-dev] [PATCH] draft-ietf-behave-rfc3489bis-07

2007-07-23 Thread Jeff Morriss
Marc Petit-Huguenin wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Morriss wrote: Marc Petit-Huguenin wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, This is an update to the STUN2 dissector using the last draft, draft-ietf-behave-rfc3489bis-07. It doesn't compile

Re: [Wireshark-dev] Bugfix for plugins/profinet

2007-07-23 Thread Ulf Lamping
[EMAIL PROTECTED] schrieb: Hi, I’ve fixed a bug in the Profinet-Dissector (plugins/profinet/packet-dcerpc-pn-io.c). In PROFINET IO DCE RPC write-requests, only the first IR frame dataset in PDIRFrameData was dissected. I’ve fixed the problem, now all IR frame datasets are dissected

Re: [Wireshark-dev] [PATCH] draft-ietf-behave-rfc3489bis-07

2007-07-23 Thread Marc Petit-Huguenin
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Morriss wrote: Marc Petit-Huguenin wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, This is an update to the STUN2 dissector using the last draft, draft-ietf-behave-rfc3489bis-07. It doesn't compile as is: gcc

Re: [Wireshark-dev] New dissector: TNEF

2007-07-23 Thread Stig Bjørlykke
Den 15. jul. 2007 kl. 13.10 skrev Graeme Lunt: Stig - can you check what I've checked in still decodes your X.400 encoded TNEF? Works perfect for my X.400 captures. But the multipart dissector is trying to decode as TNEF if the Remove base64 encoding from body is turned off, which

Re: [Wireshark-dev] [PATCH] draft-ietf-behave-rfc3489bis-07

2007-07-23 Thread Marc Petit-Huguenin
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Morriss wrote: Marc Petit-Huguenin wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Please find attached a new version of the patch. Checked in (rev 22383), thanks! BTW, this dissector really should be broken up into multiple

[Wireshark-dev] [PATCH] DMP - Fix for long SICs

2007-07-23 Thread BRUMBY, Ian
Problem: The DMP dissector fails to correctly decode 4 character and longer SICs. First reason: There is a 32 bit overflow in the following code: p = (gint) pow (multiplier, no_char - 1 - i); Multiplier is either 36.0 or 74.0, and no_char can be as high as 8. Second reason: An