Re: [Wireshark-dev] New packet list - small fixes

2009-07-12 Thread Anders Broman
Hi, Checked in, together with some changes towards only storing the actually used columns. I haven't figured out where packet_list_get_value():s column value comes from yet. I get the same crash :-( Regards Anders -Ursprungligt meddelande- Från: wireshark-dev-boun...@wireshark.org

Re: [Wireshark-dev] New packet list - small fixes

2009-07-12 Thread Jakub Zawadzki
On Sun, Jul 12, 2009 at 11:08:59AM +0200, Anders Broman wrote: Checked in Thanks :) together with some changes towards only storing the actually used columns. It crash at startup (newrecord-col_text[] not allocated), in attachment fix to restore old newrecord-col_text. Cheers. diff --git

[Wireshark-dev] buildbot failure in Wireshark (development) on Ubuntu-7.10-x86-64

2009-07-12 Thread buildbot-no-reply
The Buildbot has detected a new failure of Ubuntu-7.10-x86-64 on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/Ubuntu-7.10-x86-64/builds/1240 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: ubuntu-7.10-x86

[Wireshark-dev] buildbot failure in Wireshark (development) on Windows-XP-x86

2009-07-12 Thread buildbot-no-reply
The Buildbot has detected a new failure of Windows-XP-x86 on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/Windows-XP-x86/builds/6514 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: windows-xp-x86 Build

Re: [Wireshark-dev] New packet list - small fixes

2009-07-12 Thread Jakub Zawadzki
On Sun, Jul 12, 2009 at 11:08:59AM +0200, Anders Broman wrote: I haven't figured out where packet_list_get_value():s column value comes from yet. It's set by gtk_tree_view_column_add_attribute(..., text, X) call Doc:

[Wireshark-dev] buildbot failure in Wireshark (development) on Windows-XP-Win64

2009-07-12 Thread buildbot-no-reply
The Buildbot has detected a new failure of Windows-XP-Win64 on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/Windows-XP-Win64/builds/910 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: windows-xp-win64 Build

Re: [Wireshark-dev] New packet list - small fixes

2009-07-12 Thread Anders Broman
Thanks, I've now changed it so that the column index is also used in the tree view. Regards Anders -Ursprungligt meddelande- Från: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-boun...@wireshark.org] För Jakub Zawadzki Skickat: den 12 juli 2009 20:15 Till: Developer support

[Wireshark-dev] New packet list: Optimize memory usage

2009-07-12 Thread Jakub Zawadzki
Hi, This patch (Proof of Concept) removes allocating memory for columns data, and makes them 'dynamic' (packets redissected when column data needed) Getting column data is done in packet_list_record_get_column() I'd be grateful if someone could give some hints how it could be optimized. (Anyway

Re: [Wireshark-dev] New packet list: Optimize memory usage

2009-07-12 Thread Jakub Zawadzki
Once again, against r29075 :) diff --git file.c file.c index 71ac4d1..181c32f 100644 --- file.c +++ file.c @@ -1046,7 +1046,7 @@ add_packet_to_packet_list(frame_data *fdata, capture_file *cf, evaluated. */ if ((dfcode != NULL refilter) || color_filters_used() ||

Re: [Wireshark-dev] New packet list: Optimize memory usage

2009-07-12 Thread Guy Harris
On Jul 12, 2009, at 12:48 PM, Jakub Zawadzki wrote: This patch (Proof of Concept) removes allocating memory for columns data, and makes them 'dynamic' (packets redissected when column data needed) That should make changing the time format, for example, *extremely* fast - it should just

Re: [Wireshark-dev] New packet list: Optimize memory usage

2009-07-12 Thread Anders Broman
On Jul 12, 2009, at 12:48 PM, Jakub Zawadzki wrote: This patch (Proof of Concept) removes allocating memory for columns data, and makes them 'dynamic' (packets redissected when column data needed) That should make changing the time format, for example, *extremely* fast - it should just

Re: [Wireshark-dev] New packet list: Optimize memory usage

2009-07-12 Thread Guy Harris
On Jul 12, 2009, at 3:15 PM, Anders Broman wrote: (That doesn't say this is the wrong thing to do - I've been advocating this for a while, and made a version of the GTK 1.2[.x] GtkCList with dynamic column data and prototyped the same thing - it says we need to make random access to

Re: [Wireshark-dev] New packet list: Optimize memory usage

2009-07-12 Thread Guy Harris
On Jul 12, 2009, at 3:46 PM, Guy Harris wrote: In bzip2 format, the stream is a sequence of blocks, and, at least as I understand it, each block can be decompressed independently, so seeking to a particular offset in the decompressed version of a bzip2'ed stream involves seeking to the

Re: [Wireshark-dev] New packet list: Optimize memory usage

2009-07-12 Thread Stephen Fisher
On Sun, Jul 12, 2009 at 09:48:14PM +0200, Jakub Zawadzki wrote: This patch (Proof of Concept) removes allocating memory for columns data, and makes them 'dynamic' (packets redissected when column data needed) I haven't seen any visible lags while scrolling, CPU usage is higher but for