[Wireshark-dev] Request for Review_for_checkin : Bug 5589 - DIS update to enable radio voice comms jitter analysis

2011-02-10 Thread Kristofek, Chuck (IS)
Hi, I have submitted a patch for the Telephony tools to enable DIS voice analysis. Please review the code for checkin and provide comments. Thanks in advance. Regards, Chuck ___ Sent via:Wireshark-dev mailing list

[Wireshark-dev] New DVB_CI dissector: Discussion as to approach

2011-02-10 Thread Bill Meier
(Extracts of comments on Bug #5654 copied to wireshark-dev for further discussion) (From Martin Kaiser) I would like to submit a dissector for the DVB Common Interface. It's a protocol between a PCMCIA module and a DVB receiver that is implemented in the vast majority of DVB-compliant devices

Re: [Wireshark-dev] New DVB_CI dissector: Discussion as to approach

2011-02-10 Thread Bill Meier
Do you know of a better way to encode the direction in a pcap file or should I keep the direction byte? (If we go for pcap files and a new DLT, we should agree on this before I can apply for a DLT value). .. --To use a pcap format file to contain your captured DVBCI info: 1. As you note:

Re: [Wireshark-dev] New DVB_CI dissector: Discussion as to approach

2011-02-10 Thread Bill Meier
On 2/10/2011 2:38 PM, Bill Meier wrote: 1. libpcap processes the pseudo-header and fills in a dissector-specific Clarification: libpcap above means the Wireshark libpcap.c (not the libpcap library). ___ Sent via:

Re: [Wireshark-dev] New DVB_CI dissector: Discussion as to approach

2011-02-10 Thread Guy Harris
On Feb 10, 2011, at 11:38 AM, Bill Meier wrote: There are two approaches to processing the pseudo-header: 1. libpcap processes the pseudo-header and fills in a dissector-specific structure which is eventually passed to the DVBCI dissector (pinfo-pseudo_header) along with the actual data.

[Wireshark-dev] tshark run during build with plugins gives register_subtree_array error

2011-02-10 Thread Turner, Jay
Platform: Windows XP Pro SP3, MS VS 2008, Wireshark 1.4.3. I built Wireshark with three plugins. All compiled successfully. Wireshark was built. At the line in the build: wireshark-gtk2\tshark.exe -G | perl doc\dfilter2pod.pl doc\wireshark-filter.pod.template doc\wireshark-filter.pod a GUI

Re: [Wireshark-dev] tshark run during build with plugins gives register_subtree_array error

2011-02-10 Thread Guy Harris
On Feb 10, 2011, at 12:16 PM, Turner, Jay wrote: Platform: Windows XP Pro SP3, MS VS 2008, Wireshark 1.4.3. I built Wireshark with three plugins. I.e., with three plugins that you (or somebody else) wrote (as opposed to plugins that are part of the Wireshark distribution)? All compiled

Re: [Wireshark-dev] tshark run during build with plugins gives register_subtree_array error

2011-02-10 Thread Turner, Jay
Removing the plugins prevented the error. Therefore my plugins must have been starting and they did something wrong. What significantly changed between 1.0.3 plugin initialization and 1.4.3 plugin initialization? I'll isolate the plugin and start cutting things out until it starts up okay.

Re: [Wireshark-dev] tshark run during build with plugins gives register_subtree_array error

2011-02-10 Thread Bill Meier
On 2/10/2011 3:16 PM, Turner, Jay wrote: wireshark-gtk2\tshark.exe -G | perl doc\dfilter2pod.pl doc\wireshark-filter.pod.template doc\wireshark-filter.pod a GUI Error dialog appeared saying: ** ERROR **: register_subtree_array: subtree item type (ett_...) not -1 ! This is a development error:

Re: [Wireshark-dev] tshark run during build with plugins gives register_subtree_array error

2011-02-10 Thread Guy Harris
On Feb 10, 2011, at 12:38 PM, Turner, Jay wrote: Removing the plugins prevented the error. Therefore my plugins must have been starting and they did something wrong. What significantly changed between 1.0.3 plugin initialization and 1.4.3 plugin initialization? What significantly changed

Re: [Wireshark-dev] tshark run during build with plugins gives register_subtree_array error

2011-02-10 Thread Turner, Jay
Well, just read the message, dummy. 8^) Previously I had initialized everything with zeroes. So the pointers all pointed to zeroes. Setting them to -1 worked. I didn't recognize the ett reference or the significance of the -1 in the error message until I went and looked at the method header.

[Wireshark-dev] Is there a Wireshark call for gethostbyname?

2011-02-10 Thread Turner, Jay
I have to link with ws2_32.lib on Windows to get the gethostbyname call and the getservbyname call. I'm just wanting to display a human-name if one is in my DNS cache when I dissect. Does Wireshark have preferred calls in libwireshark.lib so that I don't have to include winsock2.h and the

Re: [Wireshark-dev] Is there a Wireshark call for gethostbyname?

2011-02-10 Thread Jaap Keuter
Hi, Have a look at epan/addr_resolv.[ch] Thanks, Jaap On 02/10/2011 10:47 PM, Turner, Jay wrote: I have to link with ws2_32.lib on Windows to get the gethostbyname call and the getservbyname call. I’m just wanting to display a human-name if one is in my DNS cache when I dissect. Does

[Wireshark-dev] libwireshark.lib is missing some proto_registrar_* methods

2011-02-10 Thread Turner, Jay
I noticed that libwireshark.lib didn't have proto_registrar_get_name and proto_registrar_get_length (maybe even proto_registrar_get_abbrev, but I may have overwritten it and readded it). I added them to libwireshark.def and my code linked where it got LNK2019 errors before. Were these omitted

Re: [Wireshark-dev] libwireshark.lib is missing some proto_registrar_* methods

2011-02-10 Thread Guy Harris
On Feb 10, 2011, at 1:55 PM, Turner, Jay wrote: I noticed that libwireshark.lib didn’t have proto_registrar_get_name and proto_registrar_get_length (maybe even proto_registrar_get_abbrev, but I may have overwritten it and readded it). I added them to libwireshark.def and my code linked

Re: [Wireshark-dev] libwireshark.lib is missing some proto_registrar_* methods

2011-02-10 Thread Andreas
Am 11.02.2011 00:06, schrieb Guy Harris: They weren't omitted on purpose. They were probably omitted because they were added by a UN*X user; by default, UN*X dynamic shared libraries export every non-static symbol, unlike Windows DLLs. I think this is a strong argument to move away from the