Re: [Wireshark-dev] [Wireshark-commits] rev 45212: /trunk/ui/gtk/ /trunk/ui/gtk/: gui_utils.c

2012-09-30 Thread Jeff Morriss
On Sun, Sep 30, 2012 at 4:13 AM, Maynard, Chris christopher.mayn...@gtech.com wrote: ... but since I'm not entirely sure what is needed here, I'll leave it to you (or someone else) to make an appropriate change. I just wanted the builds to succeed again so I could continue with some other

Re: [Wireshark-dev] [Wireshark-commits] rev 45212: /trunk/ui/gtk/ /trunk/ui/gtk/: gui_utils.c

2012-09-30 Thread Evan Huus
On Sat, Sep 29, 2012 at 10:13 PM, Maynard, Chris christopher.mayn...@gtech.com wrote: Apologies, I meant to write: if (!result || avail 0 || !result1 || childstatus != STILL_ACTIVE) { I think I am too accustomed to *nix return values where 0 typically means success, and so I read the

Re: [Wireshark-dev] [Wireshark-commits] rev 45189: /trunk/ /trunk/: cfile.h file.c

2012-09-30 Thread Maynard, Chris
So should r45182 and r45189 be scheduled for backport to fix bug 6208? - Chris From: wireshark-commits-boun...@wireshark.org [wireshark-commits-boun...@wireshark.org] On Behalf Of darkja...@wireshark.org [darkja...@wireshark.org] Sent: Friday, September

Re: [Wireshark-dev] [Wireshark-commits] rev 45189: /trunk/ /trunk/: cfile.h file.c

2012-09-30 Thread Jakub Zawadzki
On Sun, Sep 30, 2012 at 12:01:01PM -0400, Maynard, Chris wrote: So should r45182 and r45189 be scheduled for backport to fix bug 6208? I think r45189 is buggy, if wireshark is refiltering, and you get new packets, some packets might have wrong relative timestamps (displayed, captured), and wrong

Re: [Wireshark-dev] [Wireshark-commits] rev 45227: /trunk/ui/gtk/ /trunk/ui/gtk/: main_statusbar.c

2012-09-30 Thread Maynard, Chris
Capture comments can be added/removed through the summary dialog as well. - Chris From: wireshark-commits-boun...@wireshark.org [wireshark-commits-boun...@wireshark.org] On Behalf Of mart...@wireshark.org [mart...@wireshark.org] Sent: Sunday, September

[Wireshark-dev] New dissector parameter

2012-09-30 Thread David Aggeler
As a positive surprise I noticed the API change for the dissector calls. Where can I find the documentation describing the change best? Any plans to change the true/false return from heuristic dissectors and replace it in favor of the 0, 0, 0 approach used in new_dissector_t? As far as I

Re: [Wireshark-dev] Compilation failure - privileges.c: In function 'relinquish_special_privs_perm' - ignoring return value of 'setresgid', declared with attribute warn_unused_result [-Werror=unused-r

2012-09-30 Thread Bill Meier
On 9/29/2012 5:49 PM, Evan Huus wrote: On Sat, Sep 29, 2012 at 4:05 PM, Bill Meier wme...@newsguy.com wrote: My inclination: test the return value of the various set*id calls and if fail, do g_error(). Thoughts ? I'd be tempted to make it a g_warning() since Wireshark will *probably* keep

Re: [Wireshark-dev] [Wireshark-commits] rev 45212: /trunk/ui/gtk/ /trunk/ui/gtk/: gui_utils.c

2012-09-30 Thread Maynard, Chris
Should similar changes be made here as well? capture_sync.c:1948:if (GetExitCodeProcess((HANDLE) capture_opts-fork_child, childstatus) tshark.c:1962:result1 = GetExitCodeProcess((HANDLE)*(pipe_input_p-child_process), - Chris From:

[Wireshark-dev] Transmission Latency Calculation

2012-09-30 Thread Herb Falk h...@sisconet.com
I am creating a dissector that needs to be able to calculate the transmission latency of a packet. The protocol being dissected has the timestamp of the transmission, I need to be able to gain access to the time of capture of wireshark in order to calculate the difference. Anybody know an

Re: [Wireshark-dev] Transmission Latency Calculation

2012-09-30 Thread Christopher Maynard
Herb Falk herb@... Herb@... writes: I am creating a dissector that needs to be able to calculate the transmission latency of a packet.   The protocol being dissected has the timestamp of the “transmission”, I need to be able to gain access to the time of capture of wireshark in order to