[Wireshark-dev] Wireshark Dissector

2013-06-25 Thread suraj mukade
Hi, How to call your own dissector based on type field in Ethernet? After getting Type value from Ethernet frame,I want to dissect the custom Ethernet frame with some added fields and then proceed the normal dissection. I could write the dissector which can dissect packets on specified UDP/TCP

Re: [Wireshark-dev] Proposed Gerrit workflow (was: Re: Notes from Sharkfest '13)

2013-06-25 Thread Bálint Réczey
Hi Michael, 2013/6/24 Michael Tuexen michael.tue...@lurchi.franken.de: ... The current process puts responsibility on the core developer who commits a change. Personally, I don't think it is bad if this breaks the build on some buildbot, I only this it is bad if the committer doesn't care.

Re: [Wireshark-dev] OSX 32-bit build on 10.5.x (Leopard) no longer supported?

2013-06-25 Thread Michael Tuexen
On Jun 25, 2013, at 3:14 AM, Guy Harris g...@alum.mit.edu wrote: On Jun 24, 2013, at 2:48 PM, David Ameiss netsh...@ameissnet.com wrote: On my Leopard 10.5.8 system (yes, it's ancient - but needed to build 32-bit plugins) the last version of Wireshark that works is 1.8.6. When I try

Re: [Wireshark-dev] using C++, was: Notes from Sharkfest '13

2013-06-25 Thread Jeff Morriss
On 06/21/13 02:08, Dirk Jagdmann wrote: C++. It snuck in with Qt. Should we allow C++ in the rest of the code or at least use C++ compilation everywhere? Another advantage would be that we can use real C++ exceptions. What would be the advantage of using C++ exceptions? (I sort of like the

Re: [Wireshark-dev] Notes from Sharkfest '13

2013-06-25 Thread Jeff Morriss
On 06/20/13 19:56, Evan Huus wrote: On Thu, Jun 20, 2013 at 4:43 PM, Guy Harris g...@alum.mit.edu wrote: On Jun 20, 2013, at 2:17 PM, Gerald Combs ger...@wireshark.org wrote: Qt. We need to coordinate work (e.g. so that we don't inadvertently interfere with Thomas' GSoC effort). It would be

Re: [Wireshark-dev] OSX 32-bit build on 10.5.x (Leopard) no longer supported?

2013-06-25 Thread Wireshark
Sorry, I forgot to mention I'm running on an Intel machine (MacBook Pro), and running the Intel packages. -- David Ameiss netsh...@ameissnet.com On Jun 25, 2013, at 11:05 AM, Michael Tuexen michael.tue...@lurchi.franken.de wrote: On Jun 25, 2013, at 3:14 AM, Guy Harris g...@alum.mit.edu

Re: [Wireshark-dev] OSX 32-bit build on 10.5.x (Leopard) no longer supported?

2013-06-25 Thread Michael Tuexen
On Jun 25, 2013, at 7:53 PM, David Ameiss netsh...@ameissnet.com wrote: Interestingly, the 1.8.8 32-bit Wireshark package built on this machine installs and runs with no problem. So it would appear that something changed on the build machine? The 32-bit buildbot machine was updated from

Re: [Wireshark-dev] OSX 32-bit build on 10.5.x (Leopard) no longer supported?

2013-06-25 Thread Guy Harris
On Jun 25, 2013, at 11:39 AM, Michael Tuexen michael.tue...@lurchi.franken.de wrote: The 32-bit buildbot machine was updated from 10.5 to 10.6 for allowing QT builds. The default build target on 10.6 is 10.6-and-later. If we're going to run 10.6 on the buildbot that builds

Re: [Wireshark-dev] OSX 32-bit build on 10.5.x (Leopard) no longer supported?

2013-06-25 Thread Michael Tuexen
On Jun 25, 2013, at 9:01 PM, Guy Harris g...@alum.mit.edu wrote: On Jun 25, 2013, at 11:39 AM, Michael Tuexen michael.tue...@lurchi.franken.de wrote: The 32-bit buildbot machine was updated from 10.5 to 10.6 for allowing QT builds. The default build target on 10.6 is 10.6-and-later.

Re: [Wireshark-dev] [Wireshark-commits] rev 50141: / /trunk/echld/: CMakeLists.txt echld_parent.c /trunk/: Makefile.am configure.ac echld_test.c

2013-06-25 Thread Joerg Mayer
Some notes about echld: On Tue, Jun 25, 2013 at 05:43:53PM +, l...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=50141 User: lego Date: 2013/06/25 10:43 AM Log: This should get cmake to ignore echld... Directory: /trunk/echld/ Changes

[Wireshark-dev] packet_win.c still broken

2013-06-25 Thread Joerg Mayer
Hello Guy, your change to the buffer handling broke packet_win.c when being built with WANT_PACKET_EDITOR. As I asked about this problem before, maybe this bug isn't worth fixing, but then we should remove WANT_PACKET_EDITOR. Ciao Jörg [ 82%] Building C object

Re: [Wireshark-dev] CMake for Windows

2013-06-25 Thread Joerg Mayer
Hello Graham, On Thu, Jun 20, 2013 at 04:55:01PM -0700, Graham Bloice wrote: As the starter for some planned major improvements|changes to the win32 build, I'd like to get CMake working for building Wireshark on Windows. I know what I'm doing with the nmake builds, and have once built

Re: [Wireshark-dev] Fileshark (AKA Dissecting Files with Wireshark)

2013-06-25 Thread Joerg Mayer
On Thu, Jun 20, 2013 at 11:54:37AM -0700, Evan Huus wrote: This topic has come up a couple of times already on the list, and people have has submitted several patches to dissect files but there has been some worry about scope creep and the potential architectural differences between file and

Re: [Wireshark-dev] using C++, was: Notes from Sharkfest '13

2013-06-25 Thread Evan Huus
On Tue, Jun 25, 2013 at 12:13 PM, Jeff Morriss jeff.morriss...@gmail.com wrote: On 06/21/13 02:08, Dirk Jagdmann wrote: C++. It snuck in with Qt. Should we allow C++ in the rest of the code or at least use C++ compilation everywhere? Another advantage would be that we can use real C++

Re: [Wireshark-dev] OSX 32-bit build on 10.5.x (Leopard) no longer supported?

2013-06-25 Thread David Ameiss
I would have no problem with not supporting 10.5. For me, the 10.5 machine's only purpose is to build 32-bit plugins. If I can do that on 10.6, I'm cool with that. On 06/25/2013 02:23 PM, Michael Tuexen wrote: On Jun 25, 2013, at 9:01 PM, Guy Harris g...@alum.mit.edu wrote: On Jun 25,

Re: [Wireshark-dev] packet_win.c still broken

2013-06-25 Thread Guy Harris
On Jun 25, 2013, at 12:57 PM, Guy Harris g...@alum.mit.edu wrote: Once I file my next clang bug, I'll look at fixing that one. OK, it now builds. (I tried building it with a 1.10 tree, but haven't yet figured out how I can actually edit a field; I can get it to pop up the edit dialog, but it

[Wireshark-dev] make rpm-package fails if uic isn't installed.

2013-06-25 Thread Christopher Maynard
I'm trying to build a customized RHEL6 wireshark rpm based on 1.10.0, but it fails because uic isn't installed. I have tried to set --with-qt=no, but this has no effect. The error follows: make[1]: Entering directory `/path/to/wireshark/1.10.0/ui/qt' uic capture_preferences_frame.ui -o

Re: [Wireshark-dev] make rpm-package fails if uic isn't installed.

2013-06-25 Thread Jeff Morriss
On 06/25/13 17:47, Christopher Maynard wrote: I'm trying to build a customized RHEL6 wireshark rpm based on 1.10.0, but it fails because uic isn't installed. I have tried to set --with-qt=no, but this has no effect. The error follows: make[1]: Entering directory

Re: [Wireshark-dev] packet_win.c still broken

2013-06-25 Thread Christopher Maynard
Guy Harris guy@... writes: (I tried building it with a 1.10 tree, but haven't yet figured out how I can actually edit a field; I can get it to pop up the edit dialog, but it doesn't seem to let me type anywhere) I used this before and thought it was possible to edit the hex bytes within

Re: [Wireshark-dev] [Wireshark-commits] rev 50154: /trunk/ /trunk/ui/cli/: tap-afpstat.c tap-camelsrt.c tap-comparestat.c tap-diameter-avp.c tap-funnel.c tap-h225rassrt.c tap-megacostat.c tap-mgcpstat

2013-06-25 Thread Guy Harris
On Jun 25, 2013, at 3:02 PM, morr...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=50154 User: morriss Date: 2013/06/25 03:02 PM Log: Move a couple of time-related modules into wsutil. timestats.c is more than just time-related, it's also

Re: [Wireshark-dev] [Wireshark-commits] rev 50154: /trunk/ /trunk/ui/cli/: tap-afpstat.c tap-camelsrt.c tap-comparestat.c tap-diameter-avp.c tap-funnel.c tap-h225rassrt.c tap-megacostat.c tap-mgcpstat

2013-06-25 Thread Jeff Morriss
On 06/25/2013 07:48 PM, Guy Harris wrote: On Jun 25, 2013, at 3:02 PM, morr...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=50154 User: morriss Date: 2013/06/25 03:02 PM Log: Move a couple of time-related modules into wsutil. timestats.c is more

Re: [Wireshark-dev] Wireshark Dissector

2013-06-25 Thread Guy Harris
On Jun 25, 2013, at 12:31 AM, suraj mukade surajmuk...@gmail.com wrote: How to call your own dissector based on type field in Ethernet? After getting Type value from Ethernet frame,I want to dissect the custom Ethernet frame with some added fields and then proceed the normal dissection.

Re: [Wireshark-dev] Wireshark Dissector

2013-06-25 Thread suraj mukade
Hi Harris, Thanks for the precise answer. I understood thing dissector_add_uint(); But I am not clear with dissector table concept. Let me explain, My Ethernet frame will have some Ethernet type value (for example ABCD)which wireshark doesn’t understand. So if the frame with Ethernet type