Re: [Wireshark-dev] Recent changes in composite TVB (extra changes beside move)

2013-08-01 Thread Graham Bloice
On 31 July 2013 22:42, Jakub Zawadzki darkjames...@darkjames.pl wrote: SNIP --- 9d519b5659aa8c0c4aa984bc6169909eb31be7d6_2.c2013-07-31 22:50:46.144101741 +0200 +++ 9d519b5659aa8c0c4aa984bc6169909eb31be7d6_1.c2013-07-31 22:50:36.800818660 +0200 Totally off-topic rant, but

Re: [Wireshark-dev] Recent changes in composite TVB (extra changes beside move)

2013-08-01 Thread Bálint Réczey
2013/8/1 Graham Bloice graham.blo...@trihedral.com: On 31 July 2013 22:42, Jakub Zawadzki darkjames...@darkjames.pl wrote: SNIP --- 9d519b5659aa8c0c4aa984bc6169909eb31be7d6_2.c2013-07-31 22:50:46.144101741 +0200 +++ 9d519b5659aa8c0c4aa984bc6169909eb31be7d6_1.c2013-07-31

Re: [Wireshark-dev] Problems building installer on Windows 8

2013-08-01 Thread John OSullivan
Hi, The problem appears to be with NSIS version 3.0a1, there are no problems with version NSIS 2.46. The problem is also evident on earlier versions of the wireshark source if NSIS 3.0a1 is used. I will try and confirm if this is also the case on non-windows 8 builds. I have been building the 32

[Wireshark-dev] Subject: The field called Command Sequence Number in the SMB2 dissector is actually the Message ID

2013-08-01 Thread Turney, Cal
Hi Richard, That confusion has probably caused one of the WAN Accelerator companies to break SMB2 Signing by mishandling that field. Not sure which one it is, since the customer hasn't told me whose WAN Accelerator they use. (Hint, it is possible for those numbers to be out of order in a TCP

Re: [Wireshark-dev] The field called Command Sequence Number in the SMB2 dissector is actually the Message ID

2013-08-01 Thread Jeff Morriss
I took a half-educated whack at fixing those in r51080. Thanks for pointing it out (and feel free to point out any mistakes I may have made). On 07/31/13 17:08, Dirk Jagdmann wrote: while you are renaming the displayed name of this variable, the rest of the SMB2 dissector is using the term