[Wireshark-dev] Performance degradation in trunk

2013-09-12 Thread Anders Broman
Hi, I recently supplied some people with an internal build from recent trunk and got complaints on performance. Switching back To the default Wireshark on the Ubuntu 13.04 system 1.8.2 reading of a 400M trace file with SIP Diameter etc traffic is more than twice as fast. Regards Anders

Re: [Wireshark-dev] Performance degradation in trunk

2013-09-12 Thread Bálint Réczey
Could they analyze perf results or run git bisect to find the point when the degradation started? Cheers, Balint 2013/9/12 Anders Broman anders.bro...@ericsson.com: Hi, I recently supplied some people with an internal build from recent trunk and got complaints on performance. Switching back

Re: [Wireshark-dev] Performance degradation in trunk

2013-09-12 Thread Evan Huus
On 2013-09-12, at 5:40 AM, Bálint Réczey bal...@balintreczey.hu wrote: Could they analyze perf results or run git bisect to find the point when the degradation started? Since this is on Ubuntu (which can run valgrind) just use the -p option to tools/valgrind-wireshark.sh and it will produce a

Re: [Wireshark-dev] Performance degradation in trunk

2013-09-12 Thread Martin Mathieson
PS I suspect some new heuristic dissector has been introduced, since none of the other changes from 1.8 to trunk are likely to have such a significant performance impact. I haven't checked to see when it was last changed, but I noticed a while back that SIP and HTTP were both pretty

Re: [Wireshark-dev] Performance degradation in trunk

2013-09-12 Thread Martin Mathieson
You load it into kcachegrind. I found a compiled windows version on sourceforge (I think http://sourceforge.net/projects/precompiledbin/). Martin On Thu, Sep 12, 2013 at 1:54 PM, Anders Broman anders.bro...@ericsson.comwrote: -Original Message- From:

[Wireshark-dev] OID list usage

2013-09-12 Thread Bart J. Smit
Hi, I am working on a FOSS project (http://github.com/bartsmit/bedtime) and I would like to incorporate information from your OID list. Currently the relevant script (re)populates a database table by parsing the list on demand by the end user. I had a look for subscription/publication

[Wireshark-dev] custom plugin (*.dll) is not working at plugin configured path %WIRESHARK%\plugins\version

2013-09-12 Thread Hardik Patel
Hello guys, I have created simple plugin in windows environment which just label Name on perticular TCP port number. After building with make i get .dll in same folder where source code exist. nmake -f Makefile.nmake all when i copy in following folder then launch wireshark.exe from

Re: [Wireshark-dev] Performance degradation in trunk

2013-09-12 Thread Evan Huus
Alright, so there isn't a clear culprit, but there's a good chance it's the heuristics for STUN - after 1.8 a conversation lookup was added (r44068), and that uses a g_hash_table. The only major difference between the two profiles that I found was a significant increase in calls to

Re: [Wireshark-dev] custom plugin (*.dll) is not working at plugin configured path %WIRESHARK%\plugins\version

2013-09-12 Thread Evan Huus
The API/ABI has changed between 1.10 and 1.11 (and tends to change in every major version). You will have to rebuild your plugin against the 1.10 source in order to use it with a 1.10 binary. Evan On Thu, Sep 12, 2013 at 7:44 AM, Hardik Patel hardik.pa...@gmail.comwrote: Hello guys, I have

Re: [Wireshark-dev] Performance degradation in trunk

2013-09-12 Thread Evan Huus
P.P.S. The 1.8 profile didn't include debug symbols for Wireshark, so it wasn't as useful as I'd hoped. If my guess isn't correct and you generate a new profile for 1.8, please install the -dev and -dbg packages for wireshark, libwireshark etc so that the profile contains human-readable symbols.

[Wireshark-dev] Question regarding emem - wmem conversion

2013-09-12 Thread Joerg Mayer
I just looked at packet-tacacs.c. The conversion looked straight forward, the em_alloc was easy to convert. Then I noticed calls to ep_address_to_str, which is done in epan/ep_address_to_str.c Is it OK to leave that and only convert the other strings, i.e. is it OK if some of the memory is handled

Re: [Wireshark-dev] Question regarding emem - wmem conversion

2013-09-12 Thread Evan Huus
On Thu, Sep 12, 2013 at 11:12 AM, Joerg Mayer jma...@loplof.de wrote: I just looked at packet-tacacs.c. The conversion looked straight forward, the em_alloc was easy to convert. Then I noticed calls to ep_address_to_str, which is done in epan/ep_address_to_str.c Is it OK to leave that and

Re: [Wireshark-dev] Question regarding emem - wmem conversion

2013-09-12 Thread Joerg Mayer
Evan, On Thu, Sep 12, 2013 at 11:23:33AM -0400, Evan Huus wrote: The only other thing to be aware of when doing conversions is that user table callbacks (UATs) sometimes use ep_ memory, but can be called from the preferences page when no packet is being dissected, so if you convert these to

Re: [Wireshark-dev] Question regarding emem - wmem conversion

2013-09-12 Thread Dario Lombardo
On Thu, Sep 12, 2013 at 5:36 PM, Joerg Mayer jma...@loplof.de wrote: So if we could split this between a few people at least the trivial part could be done quickly. Can you please show us what should be done? I could get a part of it if it's clear what to do. Dario.

Re: [Wireshark-dev] [Wireshark-commits] rev 51972: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-tds.c packet-telnet.c packet-tipc.c packet-tpncp.c packet-tr.c

2013-09-12 Thread Evan Huus
The changes to packet-tpncp.c are unfortunately not valid (thus the recent buildbot test failures). The old code called ep_alloc when no packet was in scope in the init function, which emem shouldn't have been allowing in the first place. This is one of the non-trivial cases you referred to - it

Re: [Wireshark-dev] [Wireshark-commits] rev 51978: /trunk/epan/ /trunk/epan/: proto.c

2013-09-12 Thread Evan Huus
I think it should be a cast to time_t, since that is the actual type in question? On 2013-09-12, at 8:07 PM, jma...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=51978 User: jmayer Date: 2013/09/12 01:07 PM Log: Make proto.c compile on my system

[Wireshark-dev] wireshark crashing

2013-09-12 Thread Ed Beroset
In working through the tutorial for ns3 (see http://www.nsnam.org/docs/release/3.14/tutorial/singlehtml/index.html ) I've created two simple pcap files. When I try to look at them using wireshark, I get a signal 11 (segmentation fault). I've done a backtrace and the last function call is

Re: [Wireshark-dev] Question regarding emem - wmem conversion

2013-09-12 Thread Evan Huus
On Thu, Sep 12, 2013 at 11:36 AM, Joerg Mayer jma...@loplof.de wrote: Evan, On Thu, Sep 12, 2013 at 11:23:33AM -0400, Evan Huus wrote: The only other thing to be aware of when doing conversions is that user table callbacks (UATs) sometimes use ep_ memory, but can be called from the

Re: [Wireshark-dev] [Wireshark-commits] rev 51978: /trunk/epan/ /trunk/epan/: proto.c

2013-09-12 Thread Guy Harris
On Sep 12, 2013, at 1:21 PM, Evan Huus eapa...@gmail.com wrote: I think it should be a cast to time_t, since that is the actual type in question? Yes. I've checked that in (along with a change to proto.h to add comments to the ENC_TIME_ encodings to indicate what they are).

Re: [Wireshark-dev] Question regarding emem - wmem conversion

2013-09-12 Thread kaushik varanasi
Dear Joerg and Evan, Can any of you brief me about what should be done. I would like to get involved and learn. thanks :) sincerely, Kaushik. On Thu, Sep 12, 2013 at 10:08 PM, Evan Huus eapa...@gmail.com wrote: On Thu, Sep 12, 2013 at 11:36 AM, Joerg Mayer jma...@loplof.de wrote: Evan,

Re: [Wireshark-dev] Question regarding emem - wmem conversion

2013-09-12 Thread Joerg Mayer
Hello Kauschik, On Fri, Sep 13, 2013 at 02:53:50AM +0530, kaushik varanasi wrote: Can any of you brief me about what should be done. I would like to get involved and learn. Here is what I do (now) - I'm on Linux: - cd epan/dissectors/ - Pick a letter from the alphabet. - grep emem.h

Re: [Wireshark-dev] OID list usage

2013-09-12 Thread ronnie sahlberg
Which oid list are you referring to exactly ? On Thu, Sep 12, 2013 at 12:18 AM, Bart J. Smit b...@smits.co.uk wrote: Hi, I am working on a FOSS project (http://github.com/bartsmit/bedtime) and I would like to incorporate information from your OID list. Currently the relevant script