Re: [Wireshark-dev] [Wireshark-commits] rev 53135: /trunk/ui/gtk/ /trunk/ui/gtk/: main_menubar.c

2013-11-07 Thread Guy Harris
On Nov 6, 2013, at 11:43 PM, alagou...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=53135 User: alagoutte Date: 2013/11/07 07:43 AM Log: Add Edit Packet in Right Click Directory: /trunk/ui/gtk/ ChangesPath Action +18 -2

Re: [Wireshark-dev] [Wireshark-commits] rev 53135: /trunk/ui/gtk/ /trunk/ui/gtk/: main_menubar.c

2013-11-07 Thread Anders Broman
-Original Message- From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Guy Harris Sent: den 7 november 2013 09:35 To: wireshark-dev@wireshark.org Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 53135: /trunk/ui/gtk/ /trunk/ui/gtk/:

Re: [Wireshark-dev] [Wireshark-commits] rev 53135: /trunk/ui/gtk/ /trunk/ui/gtk/: main_menubar.c

2013-11-07 Thread Alexis La Goutte
Hi, On Thu, Nov 7, 2013 at 10:01 AM, Anders Broman anders.bro...@ericsson.comwrote: On Nov 6, 2013, at 11:43 PM, alagou...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=5313 5 User: alagoutte Date: 2013/11/07 07:43 AM Log: Add Edit

Re: [Wireshark-dev] [Wireshark-commits] rev 53135: /trunk/ui/gtk/ /trunk/ui/gtk/: main_menubar.c

2013-11-07 Thread Anders Broman
From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Alexis La Goutte Sent: den 7 november 2013 10:05 To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 53135: /trunk/ui/gtk/ /trunk/ui/gtk/:

[Wireshark-dev] Build wireshark-qt with Clang : -fPIC or -fPIE

2013-11-07 Thread Alexis La Goutte
Hi, When i try to build wireshark-qt with clang (and autotools) i have the following error message : dev:~/wireshark-clang/ui/qt$ make CXX accordion_frame.o In file included from /usr/include/qt5/QtGui/qwindowdefs.h:45:0, from /usr/include/qt5/QtWidgets/qwidget.h:45,

Re: [Wireshark-dev] Build wireshark-qt with Clang : -fPIC or -fPIE

2013-11-07 Thread Evan Huus
On Thu, Nov 7, 2013 at 8:34 AM, Alexis La Goutte alexis.lagou...@gmail.com wrote: Hi, When i try to build wireshark-qt with clang (and autotools) i have the following error message : dev:~/wireshark-clang/ui/qt$ make CXX accordion_frame.o In file included from

[Wireshark-dev] Heuristic dissector priority

2013-11-07 Thread Roland Knall
Hi I am currently implementing a generic dissector, which takes a predefined script and dissect payload. Pretty much in a way wsgd (wsgd.fr) does, but some features where lacking for me, and the integration into wireshark did not work for me either. One of the features of my solution is the

Re: [Wireshark-dev] adding IRIG time and time of day

2013-11-07 Thread John Dill
Message: 1 Date: Wed, 6 Nov 2013 13:12:04 -0800 From: Guy Harris g...@alum.mit.edu To: Developer support list for Wireshark wireshark-dev@wireshark.org Subject: Re: [Wireshark-dev] adding IRIG time and time of day Message-ID: a4378249-6d30-404f-8123-2fe8b845c...@alum.mit.edu Content-Type:

[Wireshark-dev] Add data parameter to tcp_dissect_pdus?

2013-11-07 Thread mmann78
Should tcp_dissect_pdus() add a data parameter to allow private data that was passed to a dissector running over TCP to be used by the dissector itself? I debated this when removing the pinfo-private data used to pass struct tcpinfo data in r53036. The only current dissector that uses

Re: [Wireshark-dev] Add data parameter to tcp_dissect_pdus?

2013-11-07 Thread Evan Huus
On Thu, Nov 7, 2013 at 12:33 PM, mman...@netscape.net wrote: Should tcp_dissect_pdus() add a data parameter to allow private data that was passed to a dissector running over TCP to be used by the dissector itself? I debated this when removing the pinfo-private data used to pass struct

Re: [Wireshark-dev] Add data parameter to tcp_dissect_pdus?

2013-11-07 Thread Guy Harris
On Nov 7, 2013, at 10:28 AM, Evan Huus eapa...@gmail.com wrote: I think it makes sense to add a data parameter to tcp_dissect_pdus. I certainly can't see why it would cause problems. +1 ___ Sent via:Wireshark-dev

Re: [Wireshark-dev] [Wireshark-commits] rev 53146: /trunk/epan/ /trunk/epan/dissectors/: packet-2dparityfec.c packet-acap.c packet-bitcoin.c packet-data.c packet-daytime.c packet-dbus.c packet-fcdns.c

2013-11-07 Thread Evan Huus
On Nov 7, 2013, at 3:14 PM, darkja...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=53146 User: darkjames Date: 2013/11/07 08:14 PM Log: Add infrastructure for section-initializing protocol hfis (without array). Looks cool. How is this going to

Re: [Wireshark-dev] [Wireshark-commits] rev 53146: /trunk/epan/ /trunk/epan/dissectors/: packet-2dparityfec.c packet-acap.c packet-bitcoin.c packet-data.c packet-daytime.c packet-dbus.c packet-fcdns.c

2013-11-07 Thread Joerg Mayer
On Thu, Nov 07, 2013 at 08:14:20PM +, darkja...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=53146 User: darkjames Date: 2013/11/07 08:14 PM Log: Add infrastructure for section-initializing protocol hfis (without array). Nice! configure

[Wireshark-dev] Git mirror issues

2013-11-07 Thread Gerald Combs
A while back Erwin Rol noticed that tags weren't showing up in the git mirror[1]. I finally had a chance to look into the issue in detail and as it turns out some transactions were failing due to a stale lock file. After cleaning up the lock file and running 'git fsck' the missing tags have

Re: [Wireshark-dev] [Wireshark-commits] rev 53146: /trunk/epan/ /trunk/epan/dissectors/: packet-2dparityfec.c packet-acap.c packet-bitcoin.c packet-data.c packet-daytime.c packet-dbus.c packet-fcdns.c

2013-11-07 Thread Jakub Zawadzki
On Thu, Nov 07, 2013 at 10:43:26PM +0100, Jakub Zawadzki wrote: On Thu, Nov 07, 2013 at 09:52:19PM +0100, Joerg Mayer wrote: On Thu, Nov 07, 2013 at 08:14:20PM +, darkja...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=53146 User: darkjames

Re: [Wireshark-dev] [Wireshark-commits] rev 53146: /trunk/epan/ /trunk/epan/dissectors/: packet-2dparityfec.c packet-acap.c packet-bitcoin.c packet-data.c packet-daytime.c packet-dbus.c packet-fcdns.c

2013-11-07 Thread Joerg Mayer
On Fri, Nov 08, 2013 at 01:03:47AM +0100, Jakub Zawadzki wrote: After r53150 it works with GCC, at least on my Linux ;-) And after another commit it also works on my system (32-bit Linux with GCC 4.8.2), so I decided to make it easier to play with this. Turns out my mint dissector had an unused

Re: [Wireshark-dev] [Wireshark-commits] rev 53146: /trunk/epan/ /trunk/epan/dissectors/: packet-2dparityfec.c packet-acap.c packet-bitcoin.c packet-data.c packet-daytime.c packet-dbus.c packet-fcdns.c

2013-11-07 Thread Jakub Zawadzki
On Fri, Nov 08, 2013 at 01:27:40AM +0100, Joerg Mayer wrote: On Fri, Nov 08, 2013 at 01:03:47AM +0100, Jakub Zawadzki wrote: After r53150 it works with GCC, at least on my Linux ;-) And after another commit it also works on my system (32-bit Linux with GCC 4.8.2), so I decided to make it