On Sun, Jul 6, 2014 at 12:59 PM, Alexis La Goutte <alexis.lagou...@gmail.com > wrote:
> On Sat, Jul 5, 2014 at 11:49 PM, Evan Huus <eapa...@gmail.com> wrote: > > On Sat, Jul 5, 2014 at 2:46 PM, Wireshark code review > > <code-review-do-not-re...@wireshark.org> wrote: > >> > >> URL: > >> > https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=599b880e4c53613c243b0a39548968f34cdce0e3 > >> Submitter: Guy Harris (g...@alum.mit.edu) > >> Changed: branch: master > >> Repository: wireshark > >> > >> Commits: > >> > >> 599b880 by Guy Harris (g...@alum.mit.edu): > >> > >> Handle the UTC timestamps in NetMon 2.3 files. > >> > >> This addresses part of, but not all of, the issues in bug ten > >> thousand, > >> one hundred, and ninety: > >> > >> https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10190 > >> > >> (I'm spelling it out to make sure Gerrit doesn't think this change > >> *does* address all the issues in that bug, and mark it as RESOLVED > >> FIXED; I feel like I have to treat Gerrit as a dog or small child > from > >> whom I'm trying to keep a secret - "honey, I'm taking the dog to the > >> vee eee tee".) > > > > > > It would be nice to have different tags for Refs-Bug and Fixes-Bug, and > have > > the bugzilla integration do The Right Thing for changes that refer to > but do > > not fix a bug. Gerald, how easy is this? I believe OpenStack has a set of > > tags they use which we might look to for inspiration? > +1 > I like OpenStack tags : > > Closes-Bug: #1234567 -- use 'Closes-Bug' if the commit is intended to > fully fix and close the bug being referenced. > Partial-Bug: #1234567 -- use 'Partial-Bug' if the commit is only a > partial fix and more work is needed. > Related-Bug: #1234567 -- use 'Related-Bug' if the commit is merely > related to the referenced bug. > > > > https://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references > On a related note, Gerrit has stopped commenting when a new patchset is uploaded referencing a bug (I assume because it wasn't super-useful and was causing noise). It would still be useful though, I think, if it add a comment for new changes (just not for new patchsets within each change) if that is possible. Evan > > > >> > >> Change-Id: Ic234130c1ea84cfaf47901485dca775e168f71d0 > >> Reviewed-on: https://code.wireshark.org/review/2859 > >> Reviewed-by: Guy Harris <g...@alum.mit.edu> > >> > >> > >> Actions performed: > >> > >> from 3686713 Update libnghttp2 to latest master (add support for > >> draft-13) > >> adds 599b880 Handle the UTC timestamps in NetMon 2.3 files. > >> > >> > >> Summary of changes: > >> wiretap/netmon.c | 270 > >> ++++++++++++++++++++++++++++++------------------------ > >> 1 file changed, 148 insertions(+), 122 deletions(-) > >> > >> > ___________________________________________________________________________ > >> Sent via: Wireshark-commits mailing list > >> <wireshark-comm...@wireshark.org> > >> Archives: http://www.wireshark.org/lists/wireshark-commits > >> Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits > >> > >> mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe > > > > > > > > > ___________________________________________________________________________ > > Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> > > Archives: http://www.wireshark.org/lists/wireshark-dev > > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > > mailto:wireshark-dev-requ...@wireshark.org > ?subject=unsubscribe > ___________________________________________________________________________ > Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> > Archives: http://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org > ?subject=unsubscribe >
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
