Re: [Wireshark-dev] [Wireshark-commits] master 7f3d97c: Include the gnm dissector.

2014-08-01 Thread Anders Broman
Den 1 aug 2014 01:23 skrev Guy Harris g...@alum.mit.edu: On Jul 31, 2014, at 3:21 PM, Jeff Morriss jeff.morriss...@gmail.com wrote: The commit message there says it was removed because it was never used. Never used in what sense? Nobody ever read a capture file that used it? I created

Re: [Wireshark-dev] [Wireshark-commits] master 43a81b6: Add some information on running from the build directory.

2014-08-01 Thread Peter Wu
On Thursday 31 July 2014 16:40:53 Guy Harris wrote: On Jul 31, 2014, at 3:11 PM, Peter Wu pe...@lekensteyn.nl wrote: [..] Oh my, that filesystem.c code is really ugly and relying on a lot of assumptions. Why does it need to distinguish build dirs from other dirs in the first place? So

Re: [Wireshark-dev] [Wireshark-commits] master 43a81b6: Add some information on running from the build directory.

2014-08-01 Thread Peter Wu
On Thursday 31 July 2014 20:04:52 Evan Huus wrote: FWIW this issue also makes it impossible to run parts of the test suite from an out-of-tree build, which can be problematic. Which part exactly? I can run most of the test-suite with an OOT build using: WS_BIN_PATH=/tmp/wsbuild/run ./test.sh

Re: [Wireshark-dev] [Wireshark-announce] Wireshark 1.12.0rc3 is now available

2014-08-01 Thread Graham Bloice
The x86 CMake build now completes :-) The x64 build is failing due to the lack of an acceptable Python and some dumpcap link errors. On 1 August 2014 00:28, Gerald Combs ger...@wireshark.org wrote: On 7/31/14 2:19 PM, Graham Bloice wrote: On 31 July 2014 22:14, Graham Bloice

Re: [Wireshark-dev] [Wireshark-commits] master 43a81b6: Add some information on running from the build directory.

2014-08-01 Thread Evan Huus
On Aug 1, 2014, at 5:12, Peter Wu pe...@lekensteyn.nl wrote: On Thursday 31 July 2014 20:04:52 Evan Huus wrote: FWIW this issue also makes it impossible to run parts of the test suite from an out-of-tree build, which can be problematic. Which part exactly? I can run most of the

Re: [Wireshark-dev] [Wireshark-commits] master 43a81b6: Add some information on running from the build directory.

2014-08-01 Thread Guy Harris
On Aug 1, 2014, at 2:00 AM, Peter Wu pe...@lekensteyn.nl wrote: On Thursday 31 July 2014 16:40:53 Guy Harris wrote: On Jul 31, 2014, at 3:11 PM, Peter Wu pe...@lekensteyn.nl wrote: [..] Oh my, that filesystem.c code is really ugly and relying on a lot of assumptions. Why does it need to

Re: [Wireshark-dev] [Wireshark-commits] master 43a81b6: Add some information on running from the build directory.

2014-08-01 Thread Jeff Morriss
On 08/01/14 13:54, Guy Harris wrote: On Aug 1, 2014, at 2:00 AM, Peter Wu pe...@lekensteyn.nl wrote: On Thursday 31 July 2014 16:40:53 Guy Harris wrote: On Jul 31, 2014, at 3:11 PM, Peter Wu pe...@lekensteyn.nl wrote: [..] Oh my, that filesystem.c code is really ugly and relying on a lot

Re: [Wireshark-dev] [Wireshark-commits] master 43a81b6: Add some information on running from the build directory.

2014-08-01 Thread Evan Huus
On Fri, Aug 1, 2014 at 1:58 PM, Jeff Morriss jeff.morriss...@gmail.com wrote: On 08/01/14 13:54, Guy Harris wrote: On Aug 1, 2014, at 2:00 AM, Peter Wu pe...@lekensteyn.nl wrote: On Thursday 31 July 2014 16:40:53 Guy Harris wrote: On Jul 31, 2014, at 3:11 PM, Peter Wu pe...@lekensteyn.nl

Re: [Wireshark-dev] [Wireshark-commits] master 43a81b6: Add some information on running from the build directory.

2014-08-01 Thread Jeff Morriss
On 08/01/14 14:04, Evan Huus wrote: On Fri, Aug 1, 2014 at 1:58 PM, Jeff Morriss jeff.morriss...@gmail.com mailto:jeff.morriss...@gmail.com wrote: On 08/01/14 13:54, Guy Harris wrote: On Aug 1, 2014, at 2:00 AM, Peter Wu pe...@lekensteyn.nl mailto:pe...@lekensteyn.nl

Re: [Wireshark-dev] Ping-Bug?

2014-08-01 Thread Gerald Combs
On 8/1/14 9:08 AM, Jeff Morriss wrote: On 07/13/14 14:05, Alexis La Goutte wrote: On Fri, Jul 11, 2014 at 10:06 PM, Evan Huus eapa...@gmail.com wrote: On Fri, Jul 11, 2014 at 4:03 PM, Gerald Combs ger...@wireshark.org wrote: On 7/7/14 9:10 PM, Evan Huus wrote: On Sun, Jul 6, 2014 at 12:59

Re: [Wireshark-dev] Ping-Bug?

2014-08-01 Thread Evan Huus
On Fri, Aug 1, 2014 at 6:52 PM, Gerald Combs ger...@wireshark.org wrote: On 8/1/14 9:08 AM, Jeff Morriss wrote: On 07/13/14 14:05, Alexis La Goutte wrote: On Fri, Jul 11, 2014 at 10:06 PM, Evan Huus eapa...@gmail.com wrote: On Fri, Jul 11, 2014 at 4:03 PM, Gerald Combs ger...@wireshark.org

Re: [Wireshark-dev] Ping-Bug?

2014-08-01 Thread Gerald Combs
On 8/1/14 3:58 PM, Evan Huus wrote: On Fri, Aug 1, 2014 at 6:52 PM, Gerald Combs ger...@wireshark.org mailto:ger...@wireshark.org wrote: On 8/1/14 9:08 AM, Jeff Morriss wrote: On 07/13/14 14:05, Alexis La Goutte wrote: On Fri, Jul 11, 2014 at 10:06 PM, Evan Huus

Re: [Wireshark-dev] Ping-Bug?

2014-08-01 Thread Evan Huus
On Fri, Aug 1, 2014 at 7:03 PM, Gerald Combs ger...@wireshark.org wrote: On 8/1/14 3:58 PM, Evan Huus wrote: On Fri, Aug 1, 2014 at 6:52 PM, Gerald Combs ger...@wireshark.org mailto:ger...@wireshark.org wrote: On 8/1/14 9:08 AM, Jeff Morriss wrote: On 07/13/14 14:05, Alexis La

Re: [Wireshark-dev] Ping-Bug?

2014-08-01 Thread Gerald Combs
On 8/1/14 4:06 PM, Evan Huus wrote: On Fri, Aug 1, 2014 at 7:03 PM, Gerald Combs ger...@wireshark.org mailto:ger...@wireshark.org wrote: On 8/1/14 3:58 PM, Evan Huus wrote: On Fri, Aug 1, 2014 at 6:52 PM, Gerald Combs ger...@wireshark.org mailto:ger...@wireshark.org

Re: [Wireshark-dev] Ping-Bug?

2014-08-01 Thread Jeff Morriss
On 08/01/2014 06:52 PM, Gerald Combs wrote: Until a few minutes ago any time bug followed by a number appeared in the commit message Gerrit would add a comment and close it. The specific JavaScript RE was \b[Bb]ug:?\s*#?(\d+)\b. Ah, OK, I could have sworn I had seen it working before. Maybe I

Re: [Wireshark-dev] [Wireshark-commits] master 6b11cd9: Make Lua taps work in out-of-source-tree builds.

2014-08-01 Thread Evan Huus
Thanks Jeff, this gets me farther however lua out-of-tree is still failing for me, and it's actually because it can't find init.lua this time :) The error I am getting is: attempt to call global 'typeof' (a nil value) typeof is a function defined in init.lua (which is in ${BUILD_DIR}/epan/ for

Re: [Wireshark-dev] [Wireshark-commits] master 6b11cd9: Make Lua taps work in out-of-source-tree builds.

2014-08-01 Thread Jeff Morriss
Ahhh... The problem is cmake puts the generated files in the wrong directory (epan/ instead of epan/wslua/). /* load system's init.lua */ if (running_in_build_directory()) { /* Running from build directory, load generated file */ filename = g_strdup_printf(%s