Re: [Wireshark-dev] Adding a new dissector - beginners guide

2014-08-22 Thread Thomas Wiens
On 22 August 2014 00:03, Graham Bloice wrote: Create a batch file containing something like: REM Environment setup for Wireshark using VS2010 set CYGWIN=nodosfilewarning set WIRESHARK_BASE_DIR=E:\Wireshark set WIRESHARK_TARGET_PLATFORM=win32 set

Re: [Wireshark-dev] Adding a new dissector - beginners guide

2014-08-22 Thread Graham Bloice
On 22 August 2014 10:18, Thomas Wiens th.wi...@gmx.de wrote: On 22 August 2014 00:03, Graham Bloice wrote: Create a batch file containing something like: REM Environment setup for Wireshark using VS2010 set CYGWIN=nodosfilewarning set WIRESHARK_BASE_DIR=E:\Wireshark set

Re: [Wireshark-dev] Trunk Windows CMake builds are broken

2014-08-22 Thread Graham Bloice
On 21 August 2014 13:24, Gisle Vanem gva...@yahoo.no wrote: Guy Harris g...@alum.mit.edu wrote: Presumably autotools can be convinced to generate ws_config.h rather than config.h. I'm not a user of auto* tools, but I guess it's done with: - AC_CONFIG_HEADERS(config.h)

Re: [Wireshark-dev] Adding a new dissector - beginners guide

2014-08-22 Thread Bill Meier
On 8/22/2014 5:22 AM, Graham Bloice wrote: On 22 August 2014 10:18, Thomas Wiens th.wi...@gmx.de mailto:th.wi...@gmx.de wrote: I've got another question to working on the comments in the review system: Is it good style to push every fixed comment as a single commit, or should

Re: [Wireshark-dev] Adding a new dissector - beginners guide

2014-08-22 Thread Graham Bloice
On 22 August 2014 14:51, Thomas Wiens th.wi...@gmx.de wrote: Hi, I've just commited a fixed version. I think I did something wrong. In the review system it is shown as a new version. I used: git commit -a git review As I noted on the review, I think you must have removed the Change-ID:

Re: [Wireshark-dev] Adding a new dissector - beginners guide

2014-08-22 Thread Jeff Morriss
On 08/22/14 09:51, Thomas Wiens wrote: Hi, I've just commited a fixed version. I think I did something wrong. In the review system it is shown as a new version. I used: git commit -a git review If you were on the same branch as your original commit (or if you re-downloaded your change with

Re: [Wireshark-dev] Adding a new dissector - beginners guide

2014-08-22 Thread Bill Meier
On 8/22/2014 10:15 AM, Thomas Wiens wrote: On 22 August 2014 16:05, wrote Graham Bloice: As I noted on the review, I think you must have removed the Change-ID: line from the commit message that Gerrit uses to track a new patch set for an existing change. You should have used `git commit