Re: [Wireshark-dev] Failing to push to gerrit

2014-09-11 Thread Graham Bloice
On 7 September 2014 23:51, Martin Mathieson martin.r.mathie...@googlemail.com wrote: I hadn't updated git-review since I first installed it, but running $ pip install -U git-review Requirement already up-to-date: git-review in c:\python27\lib\site-packages Cleaning up... showed that I was

Re: [Wireshark-dev] Valgrind profiling results gone bad

2014-09-11 Thread Anders Broman
The culprit seems to be proto_tre_add_item() does any one know what changed? and why? Hi, Looking further into it I think the regression is introduced in commit 5460d7fa0cd13f84ff567c96ee89d07b37cd4b62

Re: [Wireshark-dev] Failing to push to gerrit

2014-09-11 Thread Martin Mathieson
Hi Graham, I am running git inside a Cygwin shell. I didn't notice any issues wth line-endings. I cannot run git-review even to print the version. I did manually delete the entries for git-review in the scripts and lib folders and reinstalled, but still see the following error: $ git-review

Re: [Wireshark-dev] Failing to push to gerrit

2014-09-11 Thread Graham Bloice
On 11 September 2014 18:11, Martin Mathieson martin.r.mathie...@googlemail.com wrote: Hi Graham, I am running git inside a Cygwin shell. I didn't notice any issues wth line-endings. So are you using Cygwin git or Windows git? I cannot run git-review even to print the version. I did

Re: [Wireshark-dev] Failing to push to gerrit

2014-09-11 Thread Martin Mathieson
On Thu, Sep 11, 2014 at 6:31 PM, Graham Bloice graham.blo...@trihedral.com wrote: On 11 September 2014 18:11, Martin Mathieson martin.r.mathie...@googlemail.com wrote: Hi Graham, I am running git inside a Cygwin shell. I didn't notice any issues wth line-endings. So are you using