Re: [Wireshark-dev] --without-gtk3 doesn't imply --with-qt

2014-11-26 Thread Jeff Morriss
On 11/25/14 22:46, Guy Harris wrote: On Nov 25, 2014, at 7:09 PM, Jeff Morriss jeff.morriss...@gmail.com wrote: On 11/25/2014 06:09 PM, Stephen Fisher wrote: I decided to stop building my local Wireshark with GTK3 support by adding --without-gtk3 (or --with-gtk3=no) assuming that this would

Re: [Wireshark-dev] Removal of pinfo-private_data

2014-11-26 Thread Jeff Morriss
On 11/25/14 11:43, mman...@netscape.net wrote: necessary and how many were copy/paste imitators. Some also copy/pasted the same comment that was (paraphrasing) Don't let exceptions thrown by subdissectors get in our way of continuing to dissect. I've always thought of TRY/CATCH blocks as a

Re: [Wireshark-dev] --without-gtk3 doesn't imply --with-qt

2014-11-26 Thread Stephen Fisher
Is there any reason a user would have both GTK3 and GTK2 installed and not want to use GTK3 for wireshark-gtk builds? We could simplify it to be --with-gtk/--without-gtk and --with-qt/--without-qt and just use the latest version of GTK on the system (3.x, if available, otherwise 2.x) when

Re: [Wireshark-dev] --without-gtk3 doesn't imply --with-qt

2014-11-26 Thread Jeff Morriss
On 11/26/14 13:01, Stephen Fisher wrote: Is there any reason a user would have both GTK3 and GTK2 installed and not want to use GTK3 for wireshark-gtk builds? We could simplify it to be --with-gtk/--without-gtk and --with-qt/--without-qt and just use the latest version of GTK on the system

Re: [Wireshark-dev] --without-gtk3 doesn't imply --with-qt

2014-11-26 Thread Guy Harris
On Nov 26, 2014, at 10:01 AM, Stephen Fisher sfis...@sdf.org wrote: Is there any reason a user would have both GTK3 and GTK2 installed and not want to use GTK3 for wireshark-gtk builds? They're a developer and want to either 1) make sure that a change they're doing won't break GTK 2

Re: [Wireshark-dev] --without-gtk3 doesn't imply --with-qt

2014-11-26 Thread Stephen Fisher
On Wed, Nov 26, 2014 at 01:26:51PM -0500, Jeff Morriss wrote: I have both Gtk3 and Gtk2 installed but build with Gtk2. The Gtk3 UI just looks horrible to me (and, no, I'm not one who really cares about how things look but, well, I have a choice). I was hoping it was just me that had that

[Wireshark-dev] Custom link layer type for logging additional data

2014-11-26 Thread Anil
Hi, During packet capture, I want to log additional data other than what's in the ethernet packet and the per packet pcap header. So, I have created a custom header and am logging additional information into this. I have modified pcap_to_wtap_map[] to add another mapping to add another link

Re: [Wireshark-dev] Custom link layer type for logging additional data

2014-11-26 Thread Guy Harris
On Nov 26, 2014, at 8:18 PM, Anil anilkumar...@gmail.com wrote: Hi, During packet capture, I want to log additional data other than what's in the ethernet packet and the per packet pcap header. So, I have created a custom header and am logging additional information into this. I have

Re: [Wireshark-dev] Custom link layer type for logging additional data

2014-11-26 Thread Anil
Guy, Thanks for your reply. I will follow the procedure when I have to checkin the code (I have not done that as of now). My question is more about, 'is it right to use another link type to log additional information about the packet ?' . The additional information is not 'really' another link

Re: [Wireshark-dev] Custom link layer type for logging additional data

2014-11-26 Thread Guy Harris
On Nov 26, 2014, at 11:34 PM, Anil anilkumar...@gmail.com wrote: Thanks for your reply. I will follow the procedure when I have to checkin the code (I have not done that as of now). My question is more about, 'is it right to use another link type to log additional information about the

Re: [Wireshark-dev] Custom link layer type for logging additional data

2014-11-26 Thread Michal Labedzki
How about use LINKTYPE/DLT WIRESHARK_UPPER_PDU? With this one (+extcap) wiretap is complete replacement of libpcap (Wiretap is a library that is being developed as a future replacement for libpcap - wiretap/README). On 27 November 2014 at 08:34, Anil anilkumar...@gmail.com wrote: Guy, Thanks

Re: [Wireshark-dev] Custom link layer type for logging additional data

2014-11-26 Thread Guy Harris
On Nov 26, 2014, at 11:43 PM, Michal Labedzki michal.labed...@tieto.com wrote: How about use LINKTYPE/DLT WIRESHARK_UPPER_PDU? With this one (+extcap) wiretap is complete replacement of libpcap (Wiretap is a library that is being developed as a future replacement for libpcap -