Re: [Wireshark-dev] Console output from dissectors

2016-06-29 Thread Alexis La Goutte
Hi Dario, it is "False positive" because printf is part of #ifdef DEBUG... (and no DEBUG enable) but you can look packet-mysql.c, there is the same "case" ( #ifdef CTDEBUG) and i have change to use proto_tree_add_debug_* functions Cheers On Wed, Jun 29, 2016 at 9:47 AM, Dario Lombardo

Re: [Wireshark-dev] Console output from dissectors

2016-06-29 Thread Jaap Keuter
Hi, No, the console output is strictly for debug purposes only, either via printf of g_log. These printf() statements are all wrapped in DEBUG for conditional compilation, so should not result in code when compiled for production. Thanks, Jaap > On 29 Jun 2016, at 09:47, Dario Lombardo

[Wireshark-dev] Console output from dissectors

2016-06-29 Thread Dario Lombardo
Hello Running checkAPI against the dissectors, I get warnings like Warning: Found termoutput APIs in packet-wtp.c: printf Are the dissector expected to produce console output? If yes, which function should they use? g_log()? Thanks Dario.