Re: [Wireshark-dev] Actualize kafka dissector

On Tue, Nov 15, 2016 at 5:05 PM, Dmitry Lazurkin wrote: > Hello. > >> - attaching per-packet kafka info and looking it up all over the place? > How to working with per-packet data? Which functions i should use for it? > I don't think we should use per-packet info to remember

Re: [Wireshark-dev] Actualize kafka dissector

> On 15 Nov 2016, at 18:05, Dmitry Lazurkin wrote: > > > How to test kafka dissector? Catch real kafka session? Randpkt? Unit-tests? > Test by collecting real kafka sessions and work with fuzz-test.sh Thanks, Jaap

Re: [Wireshark-dev] Actualize kafka dissector

Hello. > - attaching per-packet kafka info and looking it up all over the place? How to working with per-packet data? Which functions i should use for it? > I don't remember how big the protocol changes are, but I > wonder how much longer it would take to support api_version 2 than to > warn

Re: [Wireshark-dev] Actualize kafka dissector

Hi, coming to this discussion late.. I added support for api_version 1 a few months ago when I needed to see the decode of those messages. I haven't yet needed to work with api_version 2, but as I remember it also changes several of the formats, including the 'kafka message' headers themselves -