Re: [Wireshark-dev] Getting values into version_extra, VCSVERSION and VCSBRANCH in a RPM

2017-01-10 Thread Richard Sharpe
On Tue, Jan 10, 2017 at 5:44 PM, Jeff Morriss wrote: > On 01/10/2017 07:53 PM, Richard Sharpe wrote: >> >> Now that my dissector generator is working well enough to handle the >> vagaries of the ten or so XDR files we have I am working on getting >> RPMs generated. >>

Re: [Wireshark-dev] Getting values into version_extra, VCSVERSION and VCSBRANCH in a RPM

2017-01-10 Thread Jeff Morriss
On 01/10/2017 07:53 PM, Richard Sharpe wrote: Now that my dissector generator is working well enough to handle the vagaries of the ten or so XDR files we have I am working on getting RPMs generated. I want the version info returned by get_ws_vcs_version_info to: 1. Return some additional info

[Wireshark-dev] Getting values into version_extra, VCSVERSION and VCSBRANCH in a RPM

2017-01-10 Thread Richard Sharpe
Now that my dissector generator is working well enough to handle the vagaries of the ten or so XDR files we have I am working on getting RPMs generated. I want the version info returned by get_ws_vcs_version_info to: 1. Return some additional info in the version string, like 2.3.0-SOMEHASH where

Re: [Wireshark-dev] What is different in compilation/linking of tshark and wireshark?

2017-01-10 Thread Jirka Novak
Hi Guy, > If you're trying to include some of the RTP player's functionality in TShark, > then you will have to split that functionality into "the parts that will work > in a command-line program as well as in a GUI program" and "the parts that > work only in a GUI program", and only link the

Re: [Wireshark-dev] Overview of MPLS PW bugs

2017-01-10 Thread Francesco Fondelli
Hi Guy, https://code.wireshark.org/review/#/c/19599/ change 19599 is an attempt to improve the situation. It is a work in progress. - The code that takes into consideration padding can be done better for IPv4 (line 497). - I suspect the IPv6 case (line 510) is wrong because the ip6len is not