Re: [Wireshark-dev] Change in wireshark[master]: Add support for BASE_VALS_NO_UNKNOWN

2017-04-18 Thread Guy Harris
On Apr 10, 2017, at 3:19 PM, Guy Harris wrote: > Would a more descriptive name for it be something such as BASE_SPECIAL_VALS? OK, I've changed the name to BASE_SPECIAL_VALS. ___ Sent via:Wireshark-dev

Re: [Wireshark-dev] The build broke on the recent X11 changes

2017-04-18 Thread Michael Mann
https://code.wireshark.org/review/21199 -Original Message- From: Jaap Keuter To: alexis.lagoutte ; Developer support list for Wireshark Sent: Tue, Apr 18, 2017 1:48 pm Subject: Re: [Wireshark-dev] The

Re: [Wireshark-dev] The build broke on the recent X11 changes

2017-04-18 Thread Jaap Keuter
Hi, Indeed: gcc version 6.3.0 20170406 (Debian 6.3.0-12) Looking at the code it indeed seems wrong not to have braces there. Thanks, Jaap On 18-04-17 18:49, Alexis La Goutte wrote: > Hi Jaap, > > What release of gcc do you are using ? (i think a recent release...) > > On Tue, Apr 18, 2017

Re: [Wireshark-dev] The build broke on the recent X11 changes

2017-04-18 Thread Alexis La Goutte
Hi Jaap, What release of gcc do you are using ? (i think a recent release...) On Tue, Apr 18, 2017 at 6:34 PM, Jaap Keuter wrote: > Hi, > > I get this building Wireshark: > > make[6]: Entering directory '/home/jaap/src/wireshark/ > master/epan/dissectors' > CC

[Wireshark-dev] The build broke on the recent X11 changes

2017-04-18 Thread Jaap Keuter
Hi, I get this building Wireshark: make[6]: Entering directory '/home/jaap/src/wireshark/master/epan/dissectors' CC packet-x11.lo packet-x11.c: In function ‘dissect_x11_request’: packet-x11.c:3753:13: error: this ‘if’ clause does not guard... [-Werror=misleading-indentation]

[Wireshark-dev] Pref values in GUI windows

2017-04-18 Thread John Dunlop
Hi, Wondering if someone could help me out on an inconsistency I am seeing in pref value settings via the GUI. Basically if I set values from a right-click on my own protocol I can set and view the preferences correctly. However, if I set the preferences for my own protocol from the