Re: [Wireshark-dev] QCustomPlot 2.0.0

Qt Charts look nice (and it look available from Qt 5.6...) Not really time for the moment to try to finish the port to qcustomsplot and we have already try to push some patch on upstream but it is very long ! On Sat, Feb 10, 2018 at 3:03 PM, Roland Knall wrote: > ;-) My

Re: [Wireshark-dev] QCustomPlot 2.0.0

;-) My main concern though will be performance. We have to figure out, if QCustomPlot or Qt Charts is better in regards to performance, some initial tests do not show a clear winner, but all in due time. My main concern is just, that we cannot integrate QCustomPlot 2.0 without modifications.

Re: [Wireshark-dev] QCustomPlot 2.0.0

Given how good the Qt Charts screenshots look, and how unimportant the change to control the ticks on my axis is to me, I will leave this. Martin On Sat, Feb 10, 2018 at 10:42 AM, Roland Knall wrote: > I've tried to port Alexis patch to the current master and use QCustomPlot >

Re: [Wireshark-dev] QCustomPlot 2.0.0

I've tried to port Alexis patch to the current master and use QCustomPlot 2.0.0 final with it. Ran into quite a few issues, mostly virtual methods not properly marked for override. This leads to a compilation dropout with -Werror. So, the question I am having is, is it worth implementing

Re: [Wireshark-dev] QCustomPlot 2.0.0

Thanks Alexis, I had not seen your earlier draft.. Nor had I diffed the earlier QCustomPlot release against what we were using to realise that we were patching it. Can already see one place where I did things differently to you :) Martin On Sat, Feb 10, 2018 at 9:02 AM, Alexis La Goutte

Re: [Wireshark-dev] QCustomPlot 2.0.0

Hi, I have already try on 2016 (when there is qcustomplot 2.0 beta) (published my old draft > https://code.wireshark.org/review/#/c/17980/ ) But there is some issue (some change on function and need to reapply some wireshark patch if i remenber..) But qcustomsplot 2.0 is compatible with Qt 4.8