Re: [Wireshark-dev] Lua dissector: How to set sub-field bit widths using preferences?

2018-09-06 Thread Maynard, Chris
> From: Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of > David Aldrich > Sent: Thursday, September 6, 2018 8:38 AM > To: wireshark-dev@wireshark.org > Subject: Re: [Wireshark-dev] Lua dissector: How to set sub-field bit widths > using preferences? > > Hi Chris > > Thank

Re: [Wireshark-dev] Lua dissector: How to set sub-field bit widths using preferences?

2018-09-06 Thread David Aldrich
Hi Chris Thank you very much. It's working very nicely now. Sorry to have questioned your solution! Best regards David ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev

Re: [Wireshark-dev] Lua dissector: How to set sub-field bit widths using preferences?

2018-09-06 Thread Maynard, Chris
Small correction. > -Original Message- > > 2) What does this line do? > > > > table.insert(t, (bit.band(bit.rshift(val, i), 1) == 1 and '1') or '0') > > This shifts val right i number of bits, where i is a value between 16 and 1, > and > then tests that bit to see if it's set or not.

Re: [Wireshark-dev] Lua dissector: How to set sub-field bit widths using preferences?

2018-09-06 Thread Maynard, Chris
> From: Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of > David Aldrich > Sent: Thursday, September 6, 2018 7:01 AM > To: wireshark-dev@wireshark.org > Subject: Re: [Wireshark-dev] Lua dissector: How to set sub-field bit widths > using preferences? > > Hi Chris >  >

Re: [Wireshark-dev] Lua dissector: How to set sub-field bit widths using preferences?

2018-09-06 Thread David Aldrich
Hi Chris Thanks very much for your reply and suggested code. I have a couple of questions: 1) I need to declare RuPortId_F somehow. Previously I had: RuPortId_F = ProtoField.uint16("my_protocol.RuPortId", "RU Port ID", base.HEX, NULL, 0x000F) but now the masking is done in your

Re: [Wireshark-dev] Cannot push patch to Gerrit - Found WIP commit

2018-09-06 Thread Pascal Quantin
Hi Dario, Le jeu. 6 sept. 2018 à 09:08, Dario Lombardo a écrit : > Maybe this is not related, but shouldn't it be refs/for/master/ ? > The topic is optional. BR, Pascal. > On Wed, Sep 5, 2018 at 5:39 PM Andrii Vladyka wrote: > >> I am trying to push a patch (single commit on top of the

Re: [Wireshark-dev] Cannot push patch to Gerrit - Found WIP commit

2018-09-06 Thread Dario Lombardo
Maybe this is not related, but shouldn't it be refs/for/master/ ? On Wed, Sep 5, 2018 at 5:39 PM Andrii Vladyka wrote: > I am trying to push a patch (single commit on top of the latest master > branch) with the following syntax: > > git push ssh://usern...@code.wireshark.org:29418/wireshark >